14 Jan, 2018
1 commit
-
This driver has no business including , it is a
driver so include .Signed-off-by: Linus Walleij
16 Feb, 2016
1 commit
-
By the time request_region is called in the AMD 8111 GPIO driver, a
corresponding device structure has already been allocated. The
devm_request_region function should be used to help simplify the cleanup
code and reduce the possible points of failure.Signed-off-by: William Breathitt Gray
Reviewed-by: Alexandre Courbot
Signed-off-by: Linus Walleij
05 Jan, 2016
1 commit
-
This makes the driver use the data pointer added to the gpio_chip
to store a pointer to the state container instead of relying on
container_of().Cc: Dmitry Eremin-Solenikov
Signed-off-by: Linus Walleij
19 Nov, 2015
1 commit
-
The name .dev in a struct is normally reserved for a struct device
that is let us say a superclass to the thing described by the struct.
struct gpio_chip stands out by confusingly using a struct device *dev
to point to the parent device (such as a platform_device) that
represents the hardware. As we want to give gpio_chip:s real devices,
this is not working. We need to rename this member to parent.This was done by two coccinelle scripts, I guess it is possible to
combine them into one, but I don't know such stuff. They look like
this:@@
struct gpio_chip *var;
@@
-var->dev
+var->parentand:
@@
struct gpio_chip var;
@@
-var.dev
+var.parentand:
@@
struct bgpio_chip *var;
@@
-var->gc.dev
+var->gc.parentPlus a few instances of bgpio that I couldn't figure out how
to teach Coccinelle to rewrite.This patch hits all over the place, but I *strongly* prefer this
solution to any piecemal approaches that just exercise patch
mechanics all over the place. It mainly hits drivers/gpio and
drivers/pinctrl which is my own backyard anyway.Cc: Haavard Skinnemoen
Cc: Rafał Miłecki
Cc: Richard Purdie
Cc: Mauro Carvalho Chehab
Cc: Alek Du
Cc: Jaroslav Kysela
Cc: Takashi Iwai
Acked-by: Dmitry Torokhov
Acked-by: Greg Kroah-Hartman
Acked-by: Lee Jones
Acked-by: Jiri Kosina
Acked-by: Hans-Christian Egtvedt
Acked-by: Jacek Anaszewski
Signed-off-by: Linus Walleij
19 Jan, 2015
1 commit
-
Commit ffe4770b9b3483f74 ("gpio-amd8111: check ioport_map return value")
adds the error check on ioport_map(). It doesnt release the requested region.On failure this patch release the region that has requested before.
Signed-off-by: Varka Bhadram
Reported-by: Alexandre Courbot
Signed-off-by: Linus Walleij
16 Jan, 2015
1 commit
-
ioport_map() may fail. Its safe to check the return value.
Signed-off-by: Varka Bhadram
Signed-off-by: Linus Walleij
27 Oct, 2014
1 commit
-
This change unmaps ioport when gpiochip_add fails
Signed-off-by: Pramod Gurav
Reviewed-by: Alexandre Courbot
Signed-off-by: Linus Walleij
22 Jul, 2014
1 commit
-
Signed-off-by: abdoulaye berthe
Signed-off-by: Linus Walleij
03 Dec, 2013
1 commit
-
Don't use DEFINE_PCI_DEVICE_TABLE macro, because this macro
is not preferred.Signed-off-by: Jingoo Han
Signed-off-by: Linus Walleij
12 Jul, 2012
1 commit
-
Add a driver to use GPIO pins available on several AMD south bridges
(currently only AMD 8111 is supported).Signed-off-by: Dmitry Eremin-Solenikov
Signed-off-by: Linus Walleij