Eric Lee / smarc-fsl-linux-kernel

06 Jul, 2020

4 commits

  • 981b1261b   mfd: si476x-cmd: Add missing documentation for si476x_cmd_fm_rds_status()'s arg 'report' ... Browse Code »

    Kerneldoc syntax is used, but not complete.

    Descriptions are required for all arguments.

    Fixes the following W=1 build warning:

    drivers/mfd/si476x-cmd.c:907: warning: Function parameter or member 'report' not described in 'si476x_core_cmd_fm_rds_status'

    Cc: Andrey Smirnov
    Signed-off-by: Lee Jones

    Lee Jones
     
  • 748160e77   mfd: si476x-cmd: Update si476x_cmd_am_rsq_status()'s kerneldoc ... Browse Code »

    4 of the old arguments were grouped and moved into a struct which
    is now passed as a pointer instead of the arguments themselves.
    However, whoever carried out this work forgot to update the
    function's kerneldoc header.

    Fixes the following W=1 warnings:

    drivers/mfd/si476x-cmd.c:746: warning: Function parameter or member 'rsqargs' not described in 'si476x_core_cmd_am_rsq_s
    drivers/mfd/si476x-cmd.c:746: warning: Excess function parameter 'rsqack' description in 'si476x_core_cmd_am_rsq_status'
    drivers/mfd/si476x-cmd.c:746: warning: Excess function parameter 'attune' description in 'si476x_core_cmd_am_rsq_status'
    drivers/mfd/si476x-cmd.c:746: warning: Excess function parameter 'cancel' description in 'si476x_core_cmd_am_rsq_status'
    drivers/mfd/si476x-cmd.c:746: warning: Excess function parameter 'stcack' description in 'si476x_core_cmd_am_rsq_status'

    Cc: Andrey Smirnov
    Signed-off-by: Lee Jones

    Lee Jones
     
  • 9745ef7dc   mfd: si476x-cmd: Add missing colon(s) for all documented kerneldoc arguments ... Browse Code »

    Kerneldoc validation gets confused if syntax isn't "@.*: ".

    Adding the missing colons squashes the following W=1 warnings:

    drivers/mfd/si476x-cmd.c:525: warning: Function parameter or member 'dout' not described in 'si476x_core_cmd_dig_audio_pin_c
    drivers/mfd/si476x-cmd.c:525: warning: Function parameter or member 'xout' not described in 'si476x_core_cmd_dig_audio_pin_c
    drivers/mfd/si476x-cmd.c:574: warning: Function parameter or member 'core' not described in 'si476x_core_cmd_zif_pin_cfg'
    drivers/mfd/si476x-cmd.c:574: warning: Function parameter or member 'iqclk' not described in 'si476x_core_cmd_zif_pin_cfg'
    drivers/mfd/si476x-cmd.c:574: warning: Function parameter or member 'iqfs' not described in 'si476x_core_cmd_zif_pin_cfg'
    drivers/mfd/si476x-cmd.c:574: warning: Function parameter or member 'iout' not described in 'si476x_core_cmd_zif_pin_cfg'
    drivers/mfd/si476x-cmd.c:574: warning: Function parameter or member 'qout' not described in 'si476x_core_cmd_zif_pin_cfg'
    drivers/mfd/si476x-i2c.c:550: warning: Function parameter or member 'func' not described in 'si476x_core_fwver_to_revision'
    drivers/mfd/si476x-cmd.c:631: warning: Function parameter or member 'core' not described in 'si476x_core_cmd_ic_link_gpo_ctl
    drivers/mfd/si476x-cmd.c:631: warning: Function parameter or member 'icin' not described in 'si476x_core_cmd_ic_link_gpo_ctl
    drivers/mfd/si476x-cmd.c:631: warning: Function parameter or member 'icip' not described in 'si476x_core_cmd_ic_link_gpo_ctl
    drivers/mfd/si476x-cmd.c:631: warning: Function parameter or member 'icon' not described in 'si476x_core_cmd_ic_link_gpo_ctl
    drivers/mfd/si476x-cmd.c:631: warning: Function parameter or member 'icop' not described in 'si476x_core_cmd_ic_link_gpo_ctl
    drivers/mfd/si476x-cmd.c:662: warning: Function parameter or member 'core' not described in 'si476x_core_cmd_ana_audio_pin_c
    drivers/mfd/si476x-cmd.c:662: warning: Function parameter or member 'lrout' not described in 'si476x_core_cmd_ana_audio_pin_
    drivers/mfd/si476x-cmd.c:697: warning: Function parameter or member 'core' not described in 'si476x_core_cmd_intb_pin_cfg_a1
    drivers/mfd/si476x-cmd.c:697: warning: Function parameter or member 'intb' not described in 'si476x_core_cmd_intb_pin_cfg_a1
    drivers/mfd/si476x-cmd.c:697: warning: Function parameter or member 'a1' not described in 'si476x_core_cmd_intb_pin_cfg_a10'
    drivers/mfd/si476x-cmd.c:746: warning: Function parameter or member 'core' not described in 'si476x_core_cmd_am_rsq_status'
    drivers/mfd/si476x-cmd.c:746: warning: Function parameter or member 'rsqargs' not described in 'si476x_core_cmd_am_rsq_statu
    drivers/mfd/si476x-cmd.c:746: warning: Function parameter or member 'report' not described in 'si476x_core_cmd_am_rsq_status
    drivers/mfd/si476x-cmd.c:878: warning: Function parameter or member 'core' not described in 'si476x_core_cmd_fm_seek_start'
    drivers/mfd/si476x-cmd.c:878: warning: Function parameter or member 'seekup' not described in 'si476x_core_cmd_fm_seek_start
    drivers/mfd/si476x-cmd.c:878: warning: Function parameter or member 'wrap' not described in 'si476x_core_cmd_fm_seek_start'
    drivers/mfd/si476x-cmd.c:907: warning: Function parameter or member 'core' not described in 'si476x_core_cmd_fm_rds_status'
    drivers/mfd/si476x-cmd.c:907: warning: Function parameter or member 'status_only' not described in 'si476x_core_cmd_fm_rds_s
    drivers/mfd/si476x-cmd.c:907: warning: Function parameter or member 'mtfifo' not described in 'si476x_core_cmd_fm_rds_status
    drivers/mfd/si476x-cmd.c:907: warning: Function parameter or member 'intack' not described in 'si476x_core_cmd_fm_rds_status
    drivers/mfd/si476x-cmd.c:907: warning: Function parameter or member 'report' not described in 'si476x_core_cmd_fm_rds_status
    drivers/mfd/si476x-cmd.c:1052: warning: Function parameter or member 'core' not described in 'si476x_core_cmd_am_seek_start'
    drivers/mfd/si476x-cmd.c:1052: warning: Function parameter or member 'seekup' not described in 'si476x_core_cmd_am_seek_star
    drivers/mfd/si476x-cmd.c:1052: warning: Function parameter or member 'wrap' not described in 'si476x_core_cmd_am_seek_start'

    Cc: Andrey Smirnov
    Signed-off-by: Lee Jones

    Lee Jones
     
  • 3c719388f   mfd: si476x-cmd: Repair wrongly described function argument 's/response/resp' ... Browse Code »

    si476x_core_send_command()'s 5th argument has never been called response.

    This change must have occurred prior to the driver being Mainlined.

    We're also taking the opportunity to bring the first description back
    into line, making my OCD happy!

    This fixes the following W=1 warning(s):

    drivers/mfd/si476x-cmd.c:264: warning: Function parameter or member 'resp' not described in 'si476x_core_send_command
    drivers/mfd/si476x-cmd.c:264: warning: Excess function parameter 'response' description in 'si476x_core_send_command'

    Cc: Andrey Smirnov
    Signed-off-by: Lee Jones

    Lee Jones
     

05 Jun, 2019

1 commit

  • 8e8e69d67   treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 285 ... Browse Code »

    Based on 1 normalized pattern(s):

    this program is free software you can redistribute it and or modify
    it under the terms of the gnu general public license as published by
    the free software foundation version 2 of the license this program
    is distributed in the hope that it will be useful but without any
    warranty without even the implied warranty of merchantability or
    fitness for a particular purpose see the gnu general public license
    for more details

    extracted by the scancode license scanner the SPDX license identifier

    GPL-2.0-only

    has been chosen to replace the boilerplate/reference in 100 file(s).

    Signed-off-by: Thomas Gleixner
    Reviewed-by: Alexios Zavras
    Reviewed-by: Allison Randal
    Cc: linux-spdx@vger.kernel.org
    Link: https://lkml.kernel.org/r/20190529141900.918357685@linutronix.de
    Signed-off-by: Greg Kroah-Hartman

    Thomas Gleixner
     

25 Jul, 2014

1 commit

  • d69d4212b   mfd: si476x-cmd: Remedy checkpatch style complains ... Browse Code »

    This is part of an effort to clean-up the MFD subsystem.

    WARNING: line over 80 characters
    + struct si476x_rsq_status_args *rsqargs,

    WARNING: line over 80 characters
    + struct si476x_rsq_status_report *report)

    WARNING: Unnecessary space before function pointer arguments
    + int (*power_up) (struct si476x_core *,

    WARNING: Unnecessary space before function pointer arguments
    + int (*power_down) (struct si476x_core *,

    total: 0 errors, 4 warnings, 1555 lines checked

    Signed-off-by: Lee Jones

    Lee Jones
     

17 May, 2013

2 commits

  • 151978bf6   mfd: si476x: Use get_unaligned_be16() for unaligned be16 loads ... Browse Code »

    Loading be16 values from byte buffers may cause unaligned accesses, so use
    get_unaligned_be16() to avoid problems on architectures that do not support
    these.

    Signed-off-by: Geert Uytterhoeven
    Acked-by: Andrey Smirnov
    Signed-off-by: Samuel Ortiz

    Geert Uytterhoeven
     
  • b0222afa5   mfd: si476x: Do not use binary constants ... Browse Code »

    Gcc < 4.3 doesn't understand binary constanrs (0b*):

    drivers/mfd/si476x-cmd.c:153:22: error: invalid suffix "b11111" on integer constant
    drivers/mfd/si476x-cmd.c:775:20: error: invalid suffix "b00001000" on integer constant
    drivers/mfd/si476x-cmd.c:776:20: error: invalid suffix "b00000100" on integer constant
    drivers/mfd/si476x-cmd.c:777:21: error: invalid suffix "b00000010" on integer constant
    drivers/mfd/si476x-cmd.c:778:21: error: invalid suffix "b00000001" on integer constant
    drivers/mfd/si476x-cmd.c:780:17: error: invalid suffix "b10000000" on integer constant
    drivers/mfd/si476x-cmd.c:781:22: error: invalid suffix "b00100000" on integer constant
    ...

    Hence use hexadecimal constants (0x*) instead.

    Signed-off-by: Geert Uytterhoeven
    Acked-by: Andrey Smirnov
    Signed-off-by: Samuel Ortiz

    Geert Uytterhoeven
     

20 Apr, 2013

1 commit