Eric Lee / smarc-fsl-linux-kernel

06 Jul, 2020

1 commit

  • afb718a87   mfd: wm8350-core: Supply description wm8350_reg_{un}lock args ... Browse Code »

    Kerneldoc syntax is used, but not complete. Descriptions required.

    Prevents warnings like:

    drivers/mfd/wm8350-core.c:136: warning: Function parameter or member 'wm8350' not described in 'wm8350_reg_lock'
    drivers/mfd/wm8350-core.c:165: warning: Function parameter or member 'wm8350' not described in 'wm8350_reg_unlock'

    Cc: patches@opensource.cirrus.com
    Signed-off-by: Lee Jones

    Lee Jones
     

31 May, 2019

1 commit

  • 2874c5fd2   treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152 ... Browse Code »

    Based on 1 normalized pattern(s):

    this program is free software you can redistribute it and or modify
    it under the terms of the gnu general public license as published by
    the free software foundation either version 2 of the license or at
    your option any later version

    extracted by the scancode license scanner the SPDX license identifier

    GPL-2.0-or-later

    has been chosen to replace the boilerplate/reference in 3029 file(s).

    Signed-off-by: Thomas Gleixner
    Reviewed-by: Allison Randal
    Cc: linux-spdx@vger.kernel.org
    Link: https://lkml.kernel.org/r/20190527070032.746973796@linutronix.de
    Signed-off-by: Greg Kroah-Hartman

    Thomas Gleixner
     

01 Feb, 2019

1 commit

  • 0db88688e   mfd: wm8350-core: Drop unused module infrastructure from non-modular code ... Browse Code »

    The Kconfig currently controlling compilation of this code is:

    drivers/mfd/Kconfig:config MFD_WM8350
    drivers/mfd/Kconfig: bool

    ...meaning that it currently is not being built as a module by anyone.

    Lets remove the couple traces of modular infrastructure use, so that
    when reading the driver there is no doubt it is builtin-only.

    We delete the MODULE_LICENSE tag etc. since all that information
    is already contained at the top of the file in the comments.

    We replace module.h with init.h and export.h ; the latter since the
    file does export some symbols.

    Previous demodularizaion work has made wm8350_device_exit() no longer
    used, so it is also removed from the 8350 core code.

    Signed-off-by: Paul Gortmaker
    Acked-by: Charles Keepax
    Signed-off-by: Lee Jones

    Paul Gortmaker
     

22 Jun, 2015

1 commit

  • b3c8c82b4   mfd: wm8350-core: Pass the IRQF_ONESHOT flag ... Browse Code »

    Since commit 1c6c69525b40eb76de8adf039409722015927dc3 ("genirq: Reject
    bogus threaded irq requests") threaded IRQs without a primary handler
    need to be requested with IRQF_ONESHOT, otherwise the request will fail.

    So pass the IRQF_ONESHOT flag in this case.

    The semantic patch that makes this change is available
    in scripts/coccinelle/misc/irqf_oneshot.cocci.

    Signed-off-by: Fabio Estevam
    Signed-off-by: Lee Jones

    Fabio Estevam
     

26 Nov, 2014

1 commit

19 Mar, 2014

1 commit

09 Jul, 2012

2 commits

  • 19d57ed5a   mfd: Remove custom wm8350 cache implementation ... Browse Code »

    Since none of the users now reference the cache directly we can happily
    remove the custom cache code and rely on the regmap cache.

    For simplicity we don't bother with the register defaults tables but
    instead read the defaults from the device - regmap is capable of doing
    this, unlike our old cache infrastructure. This saves a lot of code and
    allows us to cache the device revision information too.

    Signed-off-by: Mark Brown
    Signed-off-by: Samuel Ortiz

    Mark Brown
     
  • 52b461b86   mfd: Add regmap cache support for wm8350 ... Browse Code »

    Use the most simple possible transformation on the existing code so keep
    the table sitting around, further patches in this series will delete the
    existing cache code - the main purpose of this patch is to ensure that
    we always have a cache for bisection.

    Signed-off-by: Mark Brown
    Signed-off-by: Samuel Ortiz

    Mark Brown
     

07 May, 2012

1 commit

09 Jan, 2012

1 commit

12 Aug, 2010

1 commit

  • 8c46cf30f   mfd: Fix wrong wm8350-core kfree in error path ... Browse Code »

    This patch includes below fixes:
    1. fix wm8350_create_cache error path
    make sure wm8350->reg_cache is freed in error path.
    2. fix wm8350_device_init error path
    no need to kfree(wm8350->reg_cache) in the case of goto out.

    Signed-off-by: Axel Lin
    Acked-by: Mark Brown
    Signed-off-by: Samuel Ortiz

    Axel Lin
     

13 May, 2010

1 commit

  • 5051d411e   mfd: Clean up after WM83xx AUXADC interrupt if it arrives late ... Browse Code »

    In certain circumstances, especially under heavy load, the AUXADC
    completion interrupt may be detected after we've timed out waiting for
    it. That conversion would still succeed but the next conversion will
    see the completion that was signalled by the interrupt for the previous
    conversion and therefore not wait for the AUXADC conversion to run,
    causing it to report failure.

    Provide a simple, non-invasive cleanup by using try_wait_for_completion()
    to ensure that the completion is not signalled before we wait. Since
    the AUXADC is run within a mutex we know there can only have been at
    most one AUXADC interrupt outstanding. A more involved change should
    follow for the next merge window.

    Signed-off-by: Mark Brown
    Signed-off-by: Samuel Ortiz

    Mark Brown
     

30 Mar, 2010

1 commit

  • 5a0e3ad6a   include cleanup: Update gfp.h and slab.h includes to prepare for breaking implic… ... Browse Code »

    …it slab.h inclusion from percpu.h

    percpu.h is included by sched.h and module.h and thus ends up being
    included when building most .c files. percpu.h includes slab.h which
    in turn includes gfp.h making everything defined by the two files
    universally available and complicating inclusion dependencies.

    percpu.h -> slab.h dependency is about to be removed. Prepare for
    this change by updating users of gfp and slab facilities include those
    headers directly instead of assuming availability. As this conversion
    needs to touch large number of source files, the following script is
    used as the basis of conversion.

    http://userweb.kernel.org/~tj/misc/slabh-sweep.py

    The script does the followings.

    * Scan files for gfp and slab usages and update includes such that
    only the necessary includes are there. ie. if only gfp is used,
    gfp.h, if slab is used, slab.h.

    * When the script inserts a new include, it looks at the include
    blocks and try to put the new include such that its order conforms
    to its surrounding. It's put in the include block which contains
    core kernel includes, in the same order that the rest are ordered -
    alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
    doesn't seem to be any matching order.

    * If the script can't find a place to put a new include (mostly
    because the file doesn't have fitting include block), it prints out
    an error message indicating which .h file needs to be added to the
    file.

    The conversion was done in the following steps.

    1. The initial automatic conversion of all .c files updated slightly
    over 4000 files, deleting around 700 includes and adding ~480 gfp.h
    and ~3000 slab.h inclusions. The script emitted errors for ~400
    files.

    2. Each error was manually checked. Some didn't need the inclusion,
    some needed manual addition while adding it to implementation .h or
    embedding .c file was more appropriate for others. This step added
    inclusions to around 150 files.

    3. The script was run again and the output was compared to the edits
    from #2 to make sure no file was left behind.

    4. Several build tests were done and a couple of problems were fixed.
    e.g. lib/decompress_*.c used malloc/free() wrappers around slab
    APIs requiring slab.h to be added manually.

    5. The script was run on all .h files but without automatically
    editing them as sprinkling gfp.h and slab.h inclusions around .h
    files could easily lead to inclusion dependency hell. Most gfp.h
    inclusion directives were ignored as stuff from gfp.h was usually
    wildly available and often used in preprocessor macros. Each
    slab.h inclusion directive was examined and added manually as
    necessary.

    6. percpu.h was updated not to include slab.h.

    7. Build test were done on the following configurations and failures
    were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my
    distributed build env didn't work with gcov compiles) and a few
    more options had to be turned off depending on archs to make things
    build (like ipr on powerpc/64 which failed due to missing writeq).

    * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
    * powerpc and powerpc64 SMP allmodconfig
    * sparc and sparc64 SMP allmodconfig
    * ia64 SMP allmodconfig
    * s390 SMP allmodconfig
    * alpha SMP allmodconfig
    * um on x86_64 SMP allmodconfig

    8. percpu.h modifications were reverted so that it could be applied as
    a separate patch and serve as bisection point.

    Given the fact that I had only a couple of failures from tests on step
    6, I'm fairly confident about the coverage of this conversion patch.
    If there is a breakage, it's likely to be something in one of the arch
    headers which should be easily discoverable easily on most builds of
    the specific arch.

    Signed-off-by: Tejun Heo <tj@kernel.org>
    Guess-its-ok-by: Christoph Lameter <cl@linux-foundation.org>
    Cc: Ingo Molnar <mingo@redhat.com>
    Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>

    Tejun Heo
     

08 Mar, 2010

1 commit

  • d19663ac6   mfd: Use completion interrupt for WM835x AUXADC ... Browse Code »

    Use the completion interrupt generated by the device rather than
    polling for conversions to complete. As a backup we still check
    the state of the AUXADC if we don't get a completion, mostly for
    systems that don't have the WM8350 interrupt infrastructure hooked
    up.

    Signed-off-by: Mark Brown
    Signed-off-by: Samuel Ortiz

    Mark Brown
     

18 Jan, 2010

1 commit

14 Dec, 2009

2 commits

17 Sep, 2009

2 commits

20 May, 2009

1 commit

  • b126d1134   mfd: Keep a cache of WM8350 volatile values ... Browse Code »

    Due to the way that the WM8350 audio driver handles CODEC_ENA many of
    the WM8350 audio registers are marked as volatile when they aren't
    actually so. Allow the audio driver to see a cache of these values for
    inspection during interrupt context.

    To do this we need to stop satisfying any bits from volatile registers
    from cache - there's no real benefit from doing so anyway, we did the
    read already.

    Signed-off-by: Mark Brown
    Signed-off-by: Samuel Ortiz

    Mark Brown
     

05 Apr, 2009

3 commits

13 Mar, 2009

1 commit

17 Feb, 2009

4 commits

08 Jan, 2009

1 commit

  • 0081e8020   leds: Add WM8350 LED driver ... Browse Code »

    The voltage and current regulators on the WM8350 AudioPlus PMIC can be
    used in concert to provide a power efficient LED driver. This driver
    implements support for this within the standard LED class.

    Platform initialisation code should configure the LED hardware in the
    init callback provided by the WM8350 core driver. The callback should
    use wm8350_isink_set_flash(), wm8350_dcdc25_set_mode() and
    wm8350_dcdc_set_slot() to configure the operating parameters of the
    regulators for their hardware and then then use wm8350_register_led() to
    instantiate the LED driver.

    This driver was originally written by Liam Girdwood, though it has been
    extensively modified since then.

    Signed-off-by: Mark Brown
    Signed-off-by: Richard Purdie

    Mark Brown
     

04 Jan, 2009

10 commits

22 Oct, 2008

1 commit