01 Sep, 2019
1 commit
-
Issue:
- # hwclock -w
hwclock: RTC_SET_TIME: Invalid argumentWhy:
- Relative commit: 8b9f9d4dc511 ("regmap: verify if register is
writeable before writing operations"), this patch
will always check for unwritable registers, it will compare reg
with max_register in regmap_writeable.- The pcf85363/pcf85263 has the capability of address wrapping
which means if you access an address outside the allowed range
(0x00-0x2f) hardware actually wraps the access to a lower address.
The rtc-pcf85363 driver will use this feature to configure the time
and execute 2 actions in the same i2c write operation (stopping the
clock and configure the time). However the driver has also
configured the `regmap maxregister` protection mechanism that will
block accessing addresses outside valid range (0x00-0x2f).How:
- Split of writing regs to two parts, first part writes control
registers about stop_enable and resets, second part writes
RTC time and date registers.Signed-off-by: Biwen Li
Link: https://lore.kernel.org/r/20190829021418.4607-1-biwen.li@nxp.com
Signed-off-by: Alexandre Belloni
11 Apr, 2019
5 commits
-
Use SPDX-License-Identifier instead of a verbose license text.
Signed-off-by: Alexandre Belloni
-
It is not necessary to forward declare pcf85363_driver as it is not used
before being declared.Signed-off-by: Alexandre Belloni
-
regmap is abstracting the i2c functionalities the best it can, there is no
need to check.Signed-off-by: Alexandre Belloni
-
This is a standard BCD RTC that will fail in 2100.
Signed-off-by: Alexandre Belloni
-
pcf85363->dev is unused, remove it.
Signed-off-by: Alexandre Belloni
11 Dec, 2018
1 commit
-
Add support for NXP pcf85263 real-time clock. pcf85263 rtc is compatible
with pcf85363,except that pcf85363 has additional 64 bytes of RAM.1 byte of nvmem is supported and exposed in sysfs (# is the instance
number,starting with 0): /sys/bus/nvmem/devices/pcf85x63-#/nvmemSigned-off-by: Biju Das
Signed-off-by: Alexandre Belloni
17 Mar, 2018
3 commits
-
As per 8.2.6 Setting and reading the time in RTC mode, first stop the clok,
then reset it before setting the date and time registers. Finally, start
the clock.This uses register address wrap around from 0x2f to 0x00 for efficiency.
This allows to set the clock with a millisecond accuracy (drift is not
corrected in this example):RTC System
1325388767 1325388767.000029180
1325388768 1325388768.000018362
1325388769 1325388769.000006544
1325388770 1325388769.999992725
1325388771 1325388770.999974544Signed-off-by: Alexandre Belloni
-
Handle alarms, currently only on INTA
Signed-off-by: Alexandre Belloni
-
This helps debugging as it allows reading registers from debugfs.
Signed-off-by: Alexandre Belloni
01 Mar, 2018
2 commits
-
Avoid allocating memory for struct nvmem_config.
Signed-off-by: Alexandre Belloni
-
Call rtc_nvmem_register instead of letting the core do it and stop using
the nvmem_config member of struct rtc_device.Signed-off-by: Alexandre Belloni
08 Nov, 2017
1 commit
-
Note that alarms are not currently implemented.
64 bytes of nvmem is supported and exposed in
sysfs (# is the instance number, starting with 0):/sys/bus/nvmem/devices/pcf85363-#/nvmem
Signed-off-by: Eric Nelson
Reviewed-by: Fabio Estevam
Tested-by: Alexandre Belloni
Acked-by: Rob Herring
Signed-off-by: Alexandre Belloni
