Eric Lee / smarc-fsl-linux-kernel

14 Jul, 2019

1 commit

  • f0162d21c   rtc: wm831x: Add IRQF_ONESHOT flag ... Browse Code »

    fix below issue reported by coccicheck
    drivers/rtc/rtc-wm831x.c:436:7-32: ERROR: Threaded IRQ with no primary
    handler requested without IRQF_ONESHOT

    Signed-off-by: Hariprasad Kelam
    Acked-by: Charles Keepax
    Link: https://lore.kernel.org/r/20190711175615.GA13651@hari-Inspiron-1545
    Signed-off-by: Alexandre Belloni

    Hariprasad Kelam
     

29 Apr, 2019

2 commits

04 Apr, 2019

4 commits

01 Mar, 2018

1 commit

04 Jul, 2013

1 commit

30 Apr, 2013

1 commit

22 Feb, 2013

1 commit

04 Jan, 2013

1 commit

  • 5a167f454   Drivers: rtc: remove __dev* attributes. ... Browse Code »

    CONFIG_HOTPLUG is going away as an option. As a result, the __dev*
    markings need to be removed.

    This change removes the use of __devinit, __devexit_p, __devinitdata,
    __devinitconst, and __devexit from these drivers.

    Based on patches originally written by Bill Pemberton, but redone by me
    in order to handle some of the coding style issues better, by hand.

    Cc: Bill Pemberton
    Cc: Alessandro Zummo
    Cc: Srinidhi Kasagar
    Cc: Linus Walleij
    Cc: Mike Frysinger
    Cc: Wan ZongShun
    Cc: Guan Xuetao
    Cc: Mark Brown
    Signed-off-by: Greg Kroah-Hartman

    Greg Kroah-Hartman
     

19 Jul, 2012

1 commit

  • 9dccf55f4   rtc: wm831x: Feed the write counter into device_add_randomness() ... Browse Code »

    The tamper evident features of the RTC include the "write counter" which
    is a pseudo-random number regenerated whenever we set the RTC. Since this
    value is unpredictable it should provide some useful seeding to the random
    number generator.

    Only do this on boot since the goal is to seed the pool rather than add
    useful entropy.

    Signed-off-by: Mark Brown
    Signed-off-by: Theodore Ts'o
    Cc: stable@vger.kernel.org

    Mark Brown
     

20 May, 2012

1 commit

  • cd99758ba   mfd: Convert wm831x to irq_domain ... Browse Code »

    The modern idiom is to use irq_domain to allocate interrupts. This is
    useful partly to allow further infrastructure to be based on the domains
    and partly because it makes it much easier to allocate virtual interrupts
    to devices as we don't need to allocate a contiguous range of interrupt
    numbers.

    Convert the wm831x driver over to this infrastructure, using a legacy
    IRQ mapping if an irq_base is specified in platform data and otherwise
    using a linear mapping, always registering the interrupts even if they
    won't ever be used. Only boards which need to use the GPIOs as
    interrupts should need to use an irq_base.

    This means that we can't use the MFD irq_base management since the
    unless we're using an explicit irq_base from platform data we can't rely
    on a linear mapping of interrupts. Instead we need to map things via
    the irq_domain - provide a conveniencem function wm831x_irq() to save a
    small amount of typing when doing so. Looking at this I couldn't clearly
    see anything the MFD core could do to make this nicer.

    Since we're not supporting device tree yet there's no meaningful
    advantage if we don't do this conversion in one, the fact that the
    interrupt resources are used for repeated IP blocks makes accessor
    functions for the irq_domain more trouble to do than they're worth.

    Signed-off-by: Mark Brown
    Signed-off-by: Samuel Ortiz

    Mark Brown
     

11 Jan, 2012

3 commits

  • 0c4eae665   rtc: convert drivers/rtc/* to use module_platform_driver() ... Browse Code »

    This patch converts the drivers in drivers/rtc/* to use the
    module_platform_driver() macro which makes the code smaller and a bit
    simpler.

    Signed-off-by: Axel Lin
    Acked-by: Mark Brown
    Acked-by: Mike Frysinger
    Acked-by: Guan Xuetao
    Acked-by: Linus Walleij
    Acked-by: Haojian Zhuang
    Cc: Alessandro Zummo
    Cc: Srinidhi Kasagar
    Cc: Lars-Peter Clausen
    Cc: Ben Dooks
    Cc: John Stultz
    Acked-by: Jean-Christophe PLAGNIOL-VILLARD
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Axel Lin
     
  • 5f85d20d0   drivers/rtc/rtc-wm831x.c: convert to devm_kzalloc() ... Browse Code »

    Marginally less code and eliminate the possibility of memory leaks.

    Signed-off-by: Mark Brown
    Acked-by: Jean-Christophe PLAGNIOL-VILLARD
    Cc: Alessandro Zummo
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Mark Brown
     
  • 2d65943e5   drivers/rtc/rtc-wm831x.c: remove unused period IRQ handler ... Browse Code »

    Due to changes in the RTC core the period interrupt is now unused so
    delete the code managing it.

    Signed-off-by: Mark Brown
    Cc: Alessandro Zummo
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Mark Brown
     

10 Mar, 2011

1 commit

  • 51ba60c5b   RTC: Cleanup rtc_class_ops->update_irq_enable() ... Browse Code »

    Now that the generic code handles UIE mode irqs via periodic
    alarm interrupts, no one calls the
    rtc_class_ops->update_irq_enable() method anymore.

    This patch removes the driver hooks and implementations of
    update_irq_enable if no one else is calling it.

    CC: Thomas Gleixner
    CC: Alessandro Zummo
    CC: Marcelo Roberto Jimenez
    CC: rtc-linux@googlegroups.com
    Signed-off-by: John Stultz

    John Stultz
     

25 May, 2010

1 commit

  • 5815e5d36   rtc: use genirq directly in rtc-wm831x ... Browse Code »

    Now that the WM831x core uses genirq for the IRQ controller there is no
    need to use the WM831x-specific wrappers to request interrupts so convert
    to use genirq directly.

    Also use more meaningful strings to make /proc/interrupts more readily
    legible.

    Signed-off-by: Mark Brown
    Cc: Alessandro Zummo
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Mark Brown
     

30 Mar, 2010

1 commit

  • 5a0e3ad6a   include cleanup: Update gfp.h and slab.h includes to prepare for breaking implic… ... Browse Code »

    …it slab.h inclusion from percpu.h

    percpu.h is included by sched.h and module.h and thus ends up being
    included when building most .c files. percpu.h includes slab.h which
    in turn includes gfp.h making everything defined by the two files
    universally available and complicating inclusion dependencies.

    percpu.h -> slab.h dependency is about to be removed. Prepare for
    this change by updating users of gfp and slab facilities include those
    headers directly instead of assuming availability. As this conversion
    needs to touch large number of source files, the following script is
    used as the basis of conversion.

    http://userweb.kernel.org/~tj/misc/slabh-sweep.py

    The script does the followings.

    * Scan files for gfp and slab usages and update includes such that
    only the necessary includes are there. ie. if only gfp is used,
    gfp.h, if slab is used, slab.h.

    * When the script inserts a new include, it looks at the include
    blocks and try to put the new include such that its order conforms
    to its surrounding. It's put in the include block which contains
    core kernel includes, in the same order that the rest are ordered -
    alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
    doesn't seem to be any matching order.

    * If the script can't find a place to put a new include (mostly
    because the file doesn't have fitting include block), it prints out
    an error message indicating which .h file needs to be added to the
    file.

    The conversion was done in the following steps.

    1. The initial automatic conversion of all .c files updated slightly
    over 4000 files, deleting around 700 includes and adding ~480 gfp.h
    and ~3000 slab.h inclusions. The script emitted errors for ~400
    files.

    2. Each error was manually checked. Some didn't need the inclusion,
    some needed manual addition while adding it to implementation .h or
    embedding .c file was more appropriate for others. This step added
    inclusions to around 150 files.

    3. The script was run again and the output was compared to the edits
    from #2 to make sure no file was left behind.

    4. Several build tests were done and a couple of problems were fixed.
    e.g. lib/decompress_*.c used malloc/free() wrappers around slab
    APIs requiring slab.h to be added manually.

    5. The script was run on all .h files but without automatically
    editing them as sprinkling gfp.h and slab.h inclusions around .h
    files could easily lead to inclusion dependency hell. Most gfp.h
    inclusion directives were ignored as stuff from gfp.h was usually
    wildly available and often used in preprocessor macros. Each
    slab.h inclusion directive was examined and added manually as
    necessary.

    6. percpu.h was updated not to include slab.h.

    7. Build test were done on the following configurations and failures
    were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my
    distributed build env didn't work with gcov compiles) and a few
    more options had to be turned off depending on archs to make things
    build (like ipr on powerpc/64 which failed due to missing writeq).

    * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
    * powerpc and powerpc64 SMP allmodconfig
    * sparc and sparc64 SMP allmodconfig
    * ia64 SMP allmodconfig
    * s390 SMP allmodconfig
    * alpha SMP allmodconfig
    * um on x86_64 SMP allmodconfig

    8. percpu.h modifications were reverted so that it could be applied as
    a separate patch and serve as bisection point.

    Given the fact that I had only a couple of failures from tests on step
    6, I'm fairly confident about the coverage of this conversion patch.
    If there is a breakage, it's likely to be something in one of the arch
    headers which should be easily discoverable easily on most builds of
    the specific arch.

    Signed-off-by: Tejun Heo <tj@kernel.org>
    Guess-its-ok-by: Christoph Lameter <cl@linux-foundation.org>
    Cc: Ingo Molnar <mingo@redhat.com>
    Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>

    Tejun Heo
     

16 Dec, 2009

1 commit

17 Sep, 2009

1 commit

  • 35c86bf66   rtc: Add support for RTCs on Wolfson WM831x devices ... Browse Code »

    The WM831x series of PMICs contain RTC functionality. The hardware
    provides a 32 bit counter incrementing at 1Hz together with a per
    tick interrupt and an alarm value. For simplicity the driver chooses
    to define the epoch for the counter as the Unix epoch - if required
    platform data can be used in future to customise this.

    When powered on from a completely cold state the RTC reports that it
    has not been configured - when this happens an error is returned
    when attempting to read the RTC in order to avoid use of values we
    know to be invalid.

    The hardware also provides security features which mean that it can
    ignore attempts to set the RTC time in certain circumstances, most
    notably if the RTC is written to too often. These errors are detected
    by verifying the written RTC value.

    Signed-off-by: Mark Brown
    Acked-by: Alessandro Zummo
    Signed-off-by: Samuel Ortiz

    Mark Brown