14 Jun, 2020

1 commit

  • Since commit 84af7a6194e4 ("checkpatch: kconfig: prefer 'help' over
    '---help---'"), the number of '---help---' has been gradually
    decreasing, but there are still more than 2400 instances.

    This commit finishes the conversion. While I touched the lines,
    I also fixed the indentation.

    There are a variety of indentation styles found.

    a) 4 spaces + '---help---'
    b) 7 spaces + '---help---'
    c) 8 spaces + '---help---'
    d) 1 space + 1 tab + '---help---'
    e) 1 tab + '---help---' (correct indentation)
    f) 1 tab + 1 space + '---help---'
    g) 1 tab + 2 spaces + '---help---'

    In order to convert all of them to 1 tab + 'help', I ran the
    following commend:

    $ find . -name 'Kconfig*' | xargs sed -i 's/^[[:space:]]*---help---/\thelp/'

    Signed-off-by: Masahiro Yamada

    Masahiro Yamada
     

21 May, 2019

1 commit


31 Oct, 2018

1 commit

  • Move remaining definitions and declarations from include/linux/bootmem.h
    into include/linux/memblock.h and remove the redundant header.

    The includes were replaced with the semantic patch below and then
    semi-automated removal of duplicated '#include

    @@
    @@
    - #include
    + #include

    [sfr@canb.auug.org.au: dma-direct: fix up for the removal of linux/bootmem.h]
    Link: http://lkml.kernel.org/r/20181002185342.133d1680@canb.auug.org.au
    [sfr@canb.auug.org.au: powerpc: fix up for removal of linux/bootmem.h]
    Link: http://lkml.kernel.org/r/20181005161406.73ef8727@canb.auug.org.au
    [sfr@canb.auug.org.au: x86/kaslr, ACPI/NUMA: fix for linux/bootmem.h removal]
    Link: http://lkml.kernel.org/r/20181008190341.5e396491@canb.auug.org.au
    Link: http://lkml.kernel.org/r/1536927045-23536-30-git-send-email-rppt@linux.vnet.ibm.com
    Signed-off-by: Mike Rapoport
    Signed-off-by: Stephen Rothwell
    Acked-by: Michal Hocko
    Cc: Catalin Marinas
    Cc: Chris Zankel
    Cc: "David S. Miller"
    Cc: Geert Uytterhoeven
    Cc: Greentime Hu
    Cc: Greg Kroah-Hartman
    Cc: Guan Xuetao
    Cc: Ingo Molnar
    Cc: "James E.J. Bottomley"
    Cc: Jonas Bonn
    Cc: Jonathan Corbet
    Cc: Ley Foon Tan
    Cc: Mark Salter
    Cc: Martin Schwidefsky
    Cc: Matt Turner
    Cc: Michael Ellerman
    Cc: Michal Simek
    Cc: Palmer Dabbelt
    Cc: Paul Burton
    Cc: Richard Kuo
    Cc: Richard Weinberger
    Cc: Rich Felker
    Cc: Russell King
    Cc: Serge Semin
    Cc: Thomas Gleixner
    Cc: Tony Luck
    Cc: Vineet Gupta
    Cc: Yoshinori Sato
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Mike Rapoport
     

20 Jul, 2017

1 commit

  • The following commit:

    5997efb96756 ("x86/boot: Use memremap() to map the MPF and MPC data")

    causes new build failures on certain randconfigs:

    drivers/sfi/sfi_core.c: In function ‘sfi_map_memory’:
    drivers/sfi/sfi_core.c:104:10: error: implicit declaration of function ‘memremap’ [-Werror=implicit-function-declaration]
    drivers/sfi/sfi_core.c:104:31: error: ‘MEMREMAP_WB’ undeclared (first use in this function)

    This is a case of parasitic header dependencies: the sfi_core.c file indirectly
    includes for typical - but not all configs.

    Including explicitly solves the build failure.

    Cc: Linus Torvalds
    Cc: Peter Zijlstra
    Cc: Thomas Gleixner
    Cc: arnd@arndb.de
    Cc: aryabinin@virtuozzo.com
    Cc: bp@alien8.de
    Cc: bp@suse.de
    Cc: brijesh.singh@amd.com
    Cc: corbet@lwn.net
    Cc: dvyukov@google.com
    Cc: dyoung@redhat.com
    Cc: glider@google.com
    Cc: konrad.wilk@oracle.com
    Cc: linux-tip-commits@vger.kernel.org
    Cc: luto@kernel.org
    Cc: lwoodman@redhat.com
    Cc: matt@codeblueprint.co.uk
    Cc: mst@redhat.com
    Cc: pbonzini@redhat.com
    Cc: riel@redhat.com
    Cc: rkrcmar@redhat.com
    Cc: thomas.lendacky@amd.com
    Cc: toshi.kani@hpe.com
    Link: http://lkml.kernel.org/r/20170720092307.6xslahuaclmsiffe@gmail.com
    Signed-off-by: Ingo Molnar

    Ingo Molnar
     

18 Jul, 2017

1 commit

  • The ioremap() function is intended for mapping MMIO. For RAM, the
    memremap() function should be used. Convert calls from ioremap() to
    memremap() when re-mapping RAM.

    This will be used later by SME to control how the encryption mask is
    applied to memory mappings, with certain memory locations being mapped
    decrypted vs encrypted.

    Signed-off-by: Tom Lendacky
    Reviewed-by: Thomas Gleixner
    Reviewed-by: Borislav Petkov
    Cc: Alexander Potapenko
    Cc: Andrey Ryabinin
    Cc: Andy Lutomirski
    Cc: Arnd Bergmann
    Cc: Borislav Petkov
    Cc: Brijesh Singh
    Cc: Dave Young
    Cc: Dmitry Vyukov
    Cc: Jonathan Corbet
    Cc: Konrad Rzeszutek Wilk
    Cc: Larry Woodman
    Cc: Linus Torvalds
    Cc: Matt Fleming
    Cc: Michael S. Tsirkin
    Cc: Paolo Bonzini
    Cc: Peter Zijlstra
    Cc: Radim Krčmář
    Cc: Rik van Riel
    Cc: Toshimitsu Kani
    Cc: kasan-dev@googlegroups.com
    Cc: kvm@vger.kernel.org
    Cc: linux-arch@vger.kernel.org
    Cc: linux-doc@vger.kernel.org
    Cc: linux-efi@vger.kernel.org
    Cc: linux-mm@kvack.org
    Link: http://lkml.kernel.org/r/b13fccb9abbd547a7eef7b1fdfc223431b211c88.1500319216.git.thomas.lendacky@amd.com
    Signed-off-by: Ingo Molnar

    Tom Lendacky
     

04 Dec, 2014

1 commit

  • drivers/sfi/sfi_core.c:164:26: warning: no previous prototype for ‘sfi_map_table’ [-Wmissing-prototypes]
    drivers/sfi/sfi_core.c:192:6: warning: no previous prototype for ‘sfi_unmap_table’ [-Wmissing-prototypes]

    Signed-off-by: Andy Shevchenko
    Signed-off-by: Len Brown

    Andy Shevchenko
     

07 Dec, 2013

2 commits

  • The following warnings can be seen in W=1 builds, because the original
    sfi_acpi.[ch] header inclusions are incorrect:

    include/linux/sfi_acpi.h:72:2: error: implicit declaration of function 'acpi_table_parse' [-Werror=implicit-function-declaration]
    drivers/sfi/sfi_acpi.c:154:5: warning: no previous prototype for 'sfi_acpi_table_parse' [-Wmissing-prototypes]

    Fix linux/sfi_acpi.h and modify drivers/sfi/sfi_acpi.c accordingly.

    Reported-by: Andy Shevchenko
    Signed-off-by: Lv Zheng
    [rjw: Subject and changelog]
    Signed-off-by: Rafael J. Wysocki

    Lv Zheng
     
  • Replace direct inclusions of , and
    , which are incorrect, with
    inclusions and remove some inclusions of those files that aren't
    necessary.

    First of all, , and
    should not be included directly from any files that are built for
    CONFIG_ACPI unset, because that generally leads to build warnings about
    undefined symbols in !CONFIG_ACPI builds. For CONFIG_ACPI set,
    includes those files and for CONFIG_ACPI unset it
    provides stub ACPI symbols to be used in that case.

    Second, there are ordering dependencies between those files that always
    have to be met. Namely, it is required that be included
    prior to so that the acpi_pci_root declarations the
    latter depends on are always there. And which provides
    basic ACPICA type declarations should always be included prior to any other
    ACPI headers in CONFIG_ACPI builds. That also is taken care of including
    as appropriate.

    Signed-off-by: Lv Zheng
    Cc: Greg Kroah-Hartman
    Cc: Matthew Garrett
    Cc: Tony Luck
    Cc: "H. Peter Anvin"
    Acked-by: Bjorn Helgaas (drivers/pci stuff)
    Acked-by: Konrad Rzeszutek Wilk (Xen stuff)
    Signed-off-by: Rafael J. Wysocki

    Lv Zheng
     

01 Nov, 2011

1 commit

  • sfi_acpi.c needs to include linux/sysfs.h for data types.

    drivers/sfi/sfi_core.h:66: error: field 'attr' has incomplete type
    drivers/sfi/sfi_acpi.c:179: warning: 'struct kobject' declared inside parameter list
    drivers/sfi/sfi_acpi.c:179: warning: its scope is only this definition or declaration, which is probably not what you want
    drivers/sfi/sfi_acpi.c:182: warning: type defaults to 'int' in declaration of '__mptr'
    drivers/sfi/sfi_acpi.c:182: warning: initialization from incompatible pointer type

    Signed-off-by: Randy Dunlap
    Signed-off-by: Paul Gortmaker

    Randy Dunlap
     

31 Mar, 2011

1 commit


12 Jan, 2011

1 commit


02 Jun, 2010

1 commit


28 May, 2010

1 commit

  • Analogous to ACPI's /sys/firmware/acpi/tables/...

    create /sys/firmware/sfi/tables/

    The tables are primariy for the kernel,
    but sometimes it is useful for user-space to be
    able to read them.

    Signed-off-by: Feng Tang
    Signed-off-by: Len Brown

    Feng Tang
     

25 May, 2010

1 commit

  • There are 2 major changes from v0.81 to v0.7:
    1. Consolidating the SPIB/I2CB tables into a new DEVS table,
    which is more expandable and can support other bus types
    than spi/i2c.
    2. Creating a new GPIO table, which list all the GPIO pins
    used in the platform.

    However, to avoid breaking current platforms who use SFI v0.7
    version firmware, the definitions for SPIB/I2CB will still
    be kept for a while

    Signed-off-by: Feng Tang
    Signed-off-by: Len Brown

    Feng Tang
     

03 Oct, 2009

2 commits

  • sfi_verify_table() is called at runtime, and thus cannot be __init

    Signed-off-by: Arjan van de Ven
    Signed-off-by: Len Brown

    Arjan van de Ven
     
  • The function sfi_map_memory/sfi_unmap_memory uses
    early_ioremap/early_iounmap respectively, which refers to a __init
    function. And function sfi_check_table also refers to a __init function
    sfi_verify_table. Since the references are valid, so use __ref to get rid
    of the warnings.

    We were warned by the following warnings:

    LD vmlinux.o
    MODPOST vmlinux.o
    WARNING: vmlinux.o(.text+0xb6ba3a): Section mismatch in reference from
    the function sfi_map_memory() to the function
    .init.text:early_ioremap()
    The function sfi_map_memory() references
    the function __init early_ioremap().
    This is often because sfi_map_memory lacks a __init
    annotation or the annotation of early_ioremap is wrong.

    WARNING: vmlinux.o(.text+0xb6bab6): Section mismatch in reference from
    the function sfi_unmap_memory() to the function
    .init.text:early_iounmap()
    The function sfi_unmap_memory() references
    the function __init early_iounmap().
    This is often because sfi_unmap_memory lacks a __init
    annotation or the annotation of early_iounmap is wrong.

    WARNING: vmlinux.o(.text+0xb6be30): Section mismatch in reference from
    the function sfi_check_table() to the function
    .init.text:sfi_verify_table()
    The function sfi_check_table() references
    the function __init sfi_verify_table().
    This is often because sfi_check_table lacks a __init
    annotation or the annotation of sfi_verify_table is wrong.

    Signed-off-by: Rakib Mullick
    Signed-off-by: Andrew Morton
    Signed-off-by: Len Brown

    Rakib Mullick
     

16 Sep, 2009

1 commit


29 Aug, 2009

3 commits

  • Extend SFI to access standard ACPI tables.
    (eg. the PCI MCFG) using sfi_acpi_table_parse().

    Note that this is _not_ a hybrid ACPI + SFI mode.
    The platform boots in either ACPI mode or SFI mode.

    SFI runs only with acpi_disabled=1, which can be set
    at build-time via CONFIG_ACPI=n, or at boot time by
    the failure to find ACPI platform support.

    So this extension simply allows SFI-platforms to
    re-use existing standard table formats that happen to
    be defined to live in ACPI envelopes.

    Signed-off-by: Feng Tang
    Signed-off-by: Len Brown

    Feng Tang
     
  • drivers/sfi/sfi_core.c contains the generic SFI implementation.
    It has a private header, sfi_core.h, for its own use and the
    private use of future files in drivers/sfi/

    Signed-off-by: Feng Tang
    Signed-off-by: Len Brown

    Feng Tang
     
  • CONFIG_SFI=y enables the kernel to boot and run optimally
    on platforms that support the Simple Firmware Interface.

    Thanks to Jacob Pan for prototyping the initial Linux SFI support,
    and to Feng Tang for Linux bring-up and debug both in emulation
    and on Moorestown hardware.

    See http://simplefirmware.org for more information on SFI.

    Signed-off-by: Len Brown

    Len Brown