15 Jan, 2020

1 commit

  • This patch corrects the SPDX License Identifier style in
    header file related to Eckelmann SIOX driver.
    For C header files Documentation/process/license-rules.rst
    mandates C-like comments (opposed to C source files where
    C++ style should be used).

    Changes made by using a script provided by Joe Perches here:
    https://lkml.org/lkml/2019/2/7/46.

    Suggested-by: Joe Perches
    Signed-off-by: Nishad Kamdar
    Acked-by: Uwe Kleine-König
    Acked-by: Thorsten Scherer
    Link: https://lore.kernel.org/r/20200101131418.GA3110@nishad
    Signed-off-by: Greg Kroah-Hartman

    Nishad Kamdar
     

21 May, 2019

1 commit


07 Jul, 2018

3 commits

  • At over 4000 #includes, is the 9th most
    #included header file in the Linux kernel. It does not need
    , so drop that header and explicitly add
    to source files that need it.

    4146 #include

    After this patch, there are 225 files that use ,
    for a reduction of around 3900 times that
    does not have to be read & parsed.

    225 #include

    This patch was build-tested on 20 different arch-es.

    It also makes these drivers SubmitChecklist#1 compliant.

    Signed-off-by: Randy Dunlap
    Reported-by: kbuild test robot # drivers/media/platform/vimc/
    Reported-by: kbuild test robot # drivers/pinctrl/pinctrl-u300.c
    Signed-off-by: Greg Kroah-Hartman

    Randy Dunlap
     
  • When a siox master device is registered a kthread is created that is
    only started when triggered by userspace. So this thread might be in
    TASK_UNINTERRUPTIBLE state for long and trigger a warning

    [ 241.130465] INFO: task siox-0:626 blocked for more than 120 seconds.

    with the respective debug settings enabled. It might be right to put an
    unstarted thread to TASK_IDLE (in kernel/kthread.c:kthread()) instead,
    but independant of this discussion it is cleaner for
    siox_master_register() to start the thread immediately. The effect is
    that it enters its own waiting state and then stays in state TASK_IDLE
    which doesn't trigger the above warning.

    As siox_poll_thread() uses some variables of the device the
    initialisation of these is moved before thread creation.

    Acked-by: Peter Zijlstra (Intel)
    Signed-off-by: Uwe Kleine-König
    Acked-by: Gavin Schenk
    Signed-off-by: Greg Kroah-Hartman

    Uwe Kleine-König
     
  • The type bits are part of the per-device status word. So it's natural to
    consider an error in the type bits as a status error instead of only
    resulting in an unsynced state.

    Signed-off-by: Uwe Kleine-König
    Acked-by: Gavin Schenk
    Signed-off-by: Greg Kroah-Hartman

    Uwe Kleine-König
     

16 Mar, 2018

1 commit

  • Width 20 given in format string is larger than destination
    buffer 'type[20]', use %19s to prevent overflowing it.

    Fixes: bbecb07fa0af ("siox: new driver framework for eckelmann SIOX")
    Cc: stable
    Reported-by: David Binderman
    Signed-off-by: Gavin Schenk
    Reviewed-by: Uwe Kleine-König
    Signed-off-by: Greg Kroah-Hartman

    Gavin Schenk
     

19 Dec, 2017

3 commits

  • This bus driver uses GPIOs to control the four SIOX bus lines.

    Acked-by: Gavin Schenk
    Signed-off-by: Uwe Kleine-König
    Signed-off-by: Greg Kroah-Hartman

    Uwe Kleine-König
     
  • Implement tracing for SIOX. There are events for the data that is
    written to the bus and for data being read from it.

    Acked-by: Gavin Schenk
    Signed-off-by: Uwe Kleine-König
    Signed-off-by: Greg Kroah-Hartman

    Uwe Kleine-König
     
  • SIOX is a bus system invented at Eckelmann AG to control their building
    management and refrigeration systems. Traditionally the bus was
    implemented on custom microcontrollers, today Linux based machines are
    in use, too.

    The topology on a SIOX bus looks as follows:

    ,------->--DCLK-->---------------+----------------------.
    ^ v v
    ,--------. ,----------------------. ,------
    | | | ,--------------. | |
    | |--->--DOUT-->---|->-|shift register|->-|--->---|
    | | | `--------------' | |
    | master | | device | | device
    | | | ,--------------. | |
    | |---
    Signed-off-by: Uwe Kleine-König
    Signed-off-by: Greg Kroah-Hartman

    Uwe Kleine-König