25 Sep, 2020
2 commits
-
Let the controller logic decide when to enter into clock pause mode!
Entering in to pause mode during unregistration does not really make
sense as the controller is totally going down at that point in time.Fixes: 4b14e62ad3c9e ("slimbus: Add support for 'clock-pause' feature")
Signed-off-by: Srinivas Kandagatla
Link: https://lore.kernel.org/r/20200925095520.27316-3-srinivas.kandagatla@linaro.org
Signed-off-by: Greg Kroah-Hartman -
logical address can be either assigned by the SLIMBus controller or the core.
Core uses IDA in cases where get_addr callback is not provided by the
controller.
Core already has this check while allocating IDR, however during absence
reporting this is not checked. This patch fixes this issue.Fixes: 46a2bb5a7f7e ("slimbus: core: Add slim controllers support")
Signed-off-by: Srinivas Kandagatla
Link: https://lore.kernel.org/r/20200925095520.27316-2-srinivas.kandagatla@linaro.org
Signed-off-by: Greg Kroah-Hartman
15 May, 2020
2 commits
-
Adding missing corresponding of_node_put
Fixes: 7588a511bdb4 ("slimbus: core: add support to device tree helper")
Signed-off-by: Saravana Kannan
[Srini: added fixes tag, removed NULL check and updated log]
Signed-off-by: Srinivas Kandagatla
Link: https://lore.kernel.org/r/20200511151334.362-3-srinivas.kandagatla@linaro.org
Signed-off-by: Greg Kroah-Hartman -
When setting the of_node for a newly created device, also set the
fwnode. This allows fw_devlink feature to work for slimbus devices.Also, remove some unnecessary NULL checks. The functions in question
already do NULL checks.Signed-off-by: Saravana Kannan
[Srini: removed unnecessary NULL check from other patch]
Signed-off-by: Srinivas Kandagatla
Link: https://lore.kernel.org/r/20200511151334.362-2-srinivas.kandagatla@linaro.org
Signed-off-by: Greg Kroah-Hartman
20 Jun, 2019
1 commit
-
Rely on MODULE_ALIAS() for automatic kernel module loading, rather than
basing it on the OF compatible. This ensures that drivers without
of_device_id table, such as wcd9335, will be automatically loaded.Signed-off-by: Srinivas Kandagatla
[bjorn: Added commit message]
Signed-off-by: Bjorn Andersson
Signed-off-by: Greg Kroah-Hartman
22 Jan, 2019
4 commits
-
Add missing spin lock intialization this also fixes the spinlock bad magic
warning.Signed-off-by: Srinivas Kandagatla
Signed-off-by: Greg Kroah-Hartman -
use slim_device_update_status() instead of directly calling
the device_status() callback. Move slim_device_update_status() before
probe to avoid forward declaration too.Signed-off-by: Srinivas Kandagatla
Signed-off-by: Greg Kroah-Hartman -
Calling device_status callback under a lock would prevent drivers
to do any slimbus trasactions which would invoke this lock like
get_laddr(). Remove this unnecessary lock!Signed-off-by: Srinivas Kandagatla
Signed-off-by: Greg Kroah-Hartman -
match full slim device id instead of just product and manufacture code,
this will allow drivers to be much more specific to that device.Signed-off-by: Srinivas Kandagatla
Signed-off-by: Greg Kroah-Hartman
26 Sep, 2018
3 commits
-
This patch adds support to uevent to help automatic module loading.
Signed-off-by: Srinivas Kandagatla
Signed-off-by: Greg Kroah-Hartman -
device status update can be racy with probe in some cases, so make sure
it take lock during the probe. Also after probe the device is expected
to be ready for communications, so make sure that a logical address
can be assigned to it after probe. If it fails to do so then probe
defer such instances.Signed-off-by: Srinivas Kandagatla
Signed-off-by: Greg Kroah-Hartman -
device_id for device tree based devices come from dt compatible string,
such drivers need not provide non dt style device id table.Match those device using compatible strings.
Signed-off-by: Srinivas Kandagatla
Signed-off-by: Greg Kroah-Hartman
07 Jul, 2018
2 commits
-
This patch adds support to SLIMbus stream apis for slimbus device.
SLIMbus streaming involves adding support to Data Channel Management and
channel Reconfiguration Messages to slim core plus few stream apis.
>From slim device side the apis are very simple mostly inline with other
stream apis.Currently it only supports Isochronous and Push/Pull transport protocols,
which are sufficient for audio use cases.Signed-off-by: Srinivas Kandagatla
Signed-off-by: Greg Kroah-Hartman -
On SLIMBus controllers like Qcom NGD(non ported device), controller
can request logical address once the remote side is powered, having a
helper function like this to explicitly enumerate the bus is helpful.
Also codec drivers which are taking to interface device would need
such a helper too.Signed-off-by: Srinivas Kandagatla
Signed-off-by: Greg Kroah-Hartman
16 Mar, 2018
1 commit
-
Never directly free @dev after calling device_register(), even
if it returned an error! Always use put_device() to give up the
reference initialized.Signed-off-by: Arvind Yadav
Signed-off-by: Srinivas Kandagatla
Signed-off-by: Greg Kroah-Hartman
19 Dec, 2017
4 commits
-
Per SLIMbus specification, a reconfiguration sequence known as
'clock pause' needs to be broadcast over the bus while entering low-
power mode. Clock-pause is initiated by the controller driver.
To exit clock-pause, controller typically wakes up the framer device.
Since wakeup precedure is controller-specific, framework calls it via
controller's function pointer to invoke it.Signed-off-by: Sagar Dharia
Signed-off-by: Srinivas Kandagatla
Reviwed-by: Mark Brown
Signed-off-by: Greg Kroah-Hartman -
This patch adds support to parse slim devices from device tree.
Signed-off-by: Srinivas Kandagatla
Reviwed-by: Mark Brown
Signed-off-by: Greg Kroah-Hartman -
This patch adds support to slim controllers in the slim core,
including some utility functions invoked by the controller and
slim device drivers.Signed-off-by: Srinivas Kandagatla
Reviwed-by: Mark Brown
Signed-off-by: Greg Kroah-Hartman -
SLIMbus (Serial Low Power Interchip Media Bus) is a specification
developed by MIPI (Mobile Industry Processor Interface) alliance.
SLIMbus is a 2-wire implementation, which is used to communicate with
peripheral components like audio-codec.
SLIMbus uses Time-Division-Multiplexing to accommodate multiple data
channels, and control channel. Control channel has messages to do
device-enumeration, messages to send/receive control-data to/from
SLIMbus devices, messages for port/channel management, and messages to
do bandwidth allocation.
The framework supports multiple instances of the bus (1 controller per
bus), and multiple slave devices per controller.This patch adds support to basic silmbus core which includes support to
SLIMbus type, slimbus device registeration and some basic data structures.Signed-off-by: Sagar Dharia
Signed-off-by: Srinivas Kandagatla
Reviwed-by: Mark Brown
Signed-off-by: Greg Kroah-Hartman
