30 Dec, 2020
1 commit
-
[ Upstream commit 39014ce6d6028614a46395923a2c92d058b6fa87 ]
Attempting to send a power request during PM operations, when the QMI
handle isn't initialized results in a NULL pointer dereference. So check
if the QMI handle has been initialized before attempting to post the
power requests.Fixes: 917809e2280b ("slimbus: ngd: Add qcom SLIMBus NGD driver")
Signed-off-by: Bjorn Andersson
Signed-off-by: Srinivas Kandagatla
Link: https://lore.kernel.org/r/20201127102451.17114-7-srinivas.kandagatla@linaro.org
Signed-off-by: Greg Kroah-Hartman
Signed-off-by: Sasha Levin
25 Sep, 2020
1 commit
-
In QMI new server notification we enable the NGD however during
delete server notification we do not disable the NGD.This can lead to multiple instances of NGD being enabled, so make
sure that we disable NGD in delete server callback to fix this issue!Fixes: 917809e2280b ("slimbus: ngd: Add qcom SLIMBus NGD driver")
Signed-off-by: Srinivas Kandagatla
Link: https://lore.kernel.org/r/20200925095520.27316-4-srinivas.kandagatla@linaro.org
Signed-off-by: Greg Kroah-Hartman
28 Apr, 2020
2 commits
-
remove redundant assignment, as this is already done fewlines lines before.
Signed-off-by: Srinivas Kandagatla
Link: https://lore.kernel.org/r/20200417093914.22052-1-srinivas.kandagatla@linaro.org
Signed-off-by: Greg Kroah-Hartman -
Get drvdata directly from parent instead of ngd dev, as ngd
dev can probe defer and previously set drvdata will become null.Signed-off-by: Srinivas Kandagatla
Link: https://lore.kernel.org/r/20200417093618.7929-1-srinivas.kandagatla@linaro.org
Signed-off-by: Greg Kroah-Hartman
12 Mar, 2020
1 commit
-
This patch adds compatible for SlimBus Controller on SDM845.
Signed-off-by: Srinivas Kandagatla
Link: https://lore.kernel.org/r/20200312152510.12224-1-srinivas.kandagatla@linaro.org
Signed-off-by: Greg Kroah-Hartman
15 Jan, 2020
1 commit
-
dma_request_slave_channel() is a wrapper on top of dma_request_chan()
eating up the error code.By using dma_request_chan() directly the driver can support deferred
probing against DMA.Signed-off-by: Peter Ujfalusi
Signed-off-by: Srinivas Kandagatla
Link: https://lore.kernel.org/r/20200109103148.5612-3-srinivas.kandagatla@linaro.org
Signed-off-by: Greg Kroah-Hartman
18 Aug, 2019
1 commit
-
Each iteration of for_each_available_child_of_node puts the previous
node, but in the case of a return from the middle of the loop, there is
no put, thus causing a memory leak. Hence add an of_node_put before the
return in two places.
Issue found with Coccinelle.Signed-off-by: Nishka Dasgupta
Reviewed-by: Bjorn Andersson
Signed-off-by: Srinivas Kandagatla
Link: https://lore.kernel.org/r/20190818093902.29993-2-srinivas.kandagatla@linaro.org
Signed-off-by: Greg Kroah-Hartman
26 Apr, 2019
1 commit
-
In case platform_device_alloc fails, the fix returns an error
code to avoid the NULL pointer dereference.Signed-off-by: Kangjie Lu
Signed-off-by: Srinivas Kandagatla
Signed-off-by: Greg Kroah-Hartman
06 Dec, 2018
1 commit
-
There is a spelling mistake in a dev_err message, fix this.
Signed-off-by: Colin Ian King
Signed-off-by: Srinivas Kandagatla
Signed-off-by: Greg Kroah-Hartman
27 Nov, 2018
1 commit
-
on non DT platforms like x86 of_match_node is set to NULL, dereferencing
directly would throw an error.
Fix this by doing this in two steps, get the match then the data.Reported-by: Greg KH
Signed-off-by: Srinivas Kandagatla
Signed-off-by: Greg Kroah-Hartman
07 Nov, 2018
1 commit
-
SLIM_MSG_CLK_PAUSE_SEQ_FLG is never set in any of the slim core,
so performing a check in ngd driver is totally unnecessary.Also this patch fixes warning about mc field overflow reported
with CoverityScan.Making clk pause feature optional will be added to slim core in
next development cycle.Reported-by: Colin Ian King
Fixes: 917809e2280b ("slimbus: ngd: Add qcom SLIMBus NGD driver")
Signed-off-by: Srinivas Kandagatla
Signed-off-by: Greg Kroah-Hartman
26 Sep, 2018
4 commits
-
Validate logical address assigned by remote, in failure cases this value
is all zeors.Signed-off-by: Srinivas Kandagatla
Signed-off-by: Greg Kroah-Hartman -
Register slimbus controller only after finishing powerup sequnce so that we
do not endup in situation where core starts sending transactions before
the controller is ready.Signed-off-by: Srinivas Kandagatla
Signed-off-by: Greg Kroah-Hartman -
It looks like there is a typo in probe return. Fix it.
Signed-off-by: Srinivas Kandagatla
Signed-off-by: Greg Kroah-Hartman -
Move ngd platform driver out of loop so that it registers only once.
Signed-off-by: Srinivas Kandagatla
Signed-off-by: Greg Kroah-Hartman
14 Sep, 2018
1 commit
-
qcom_slim_ngd_runtime_suspend is protected by an #ifdef,
qcom_slim_ngd_runtime_idle is now, which causes a build time warning:drivers/slimbus/qcom-ngd-ctrl.c:1470:12: error: 'qcom_slim_ngd_runtime_idle' defined but not used [-Werror=unused-function]
Marking both as __maybe_unused lets us get rid of the warning
as well as the #ifdef.Fixes: 917809e2280b ("slimbus: ngd: Add qcom SLIMBus NGD driver")
Signed-off-by: Arnd Bergmann
Signed-off-by: Greg Kroah-Hartman
07 Jul, 2018
2 commits
-
This patch adds support to stream support, this involve implementing
user specific implementation of Data channel management and channel
management SLIMbus messages.Signed-off-by: Srinivas Kandagatla
Signed-off-by: Greg Kroah-Hartman -
This patch adds suppor to Qualcomm SLIMBus Non-Generic Device (NGD)
controller driver.
This is light-weight SLIMBus controller driver responsible for
communicating with slave HW directly over the bus using messaging
interface, and communicating with master component residing on ADSP
for bandwidth and data-channel managementBased on intial work from
Karthikeyan Ramasubramanian and
Sagar DhariaSigned-off-by: Srinivas Kandagatla
Tested-by: Craig Tatlor
Reviewed-by: Vinod Koul
Signed-off-by: Greg Kroah-Hartman