Eric Lee / smarc-fsl-linux-kernel

05 Sep, 2019

1 commit

19 Jun, 2019

1 commit

  • d2912cb15   treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500 ... Browse Code »

    Based on 2 normalized pattern(s):

    this program is free software you can redistribute it and or modify
    it under the terms of the gnu general public license version 2 as
    published by the free software foundation

    this program is free software you can redistribute it and or modify
    it under the terms of the gnu general public license version 2 as
    published by the free software foundation #

    extracted by the scancode license scanner the SPDX license identifier

    GPL-2.0-only

    has been chosen to replace the boilerplate/reference in 4122 file(s).

    Signed-off-by: Thomas Gleixner
    Reviewed-by: Enrico Weigelt
    Reviewed-by: Kate Stewart
    Reviewed-by: Allison Randal
    Cc: linux-spdx@vger.kernel.org
    Link: https://lkml.kernel.org/r/20190604081206.933168790@linutronix.de
    Signed-off-by: Greg Kroah-Hartman

    Thomas Gleixner
     

17 Jan, 2019

3 commits

  • f1b2c1c84   spi: ath79: Remove now useless code ... Browse Code »

    The custom setup/cleanup routines included in the ath79 driver only
    take care of setting the initial CS state. However that is already
    handled by the bitbang code, so this code can be removed.

    Signed-off-by: Alban Bedel
    Signed-off-by: Mark Brown

    Alban Bedel
     
  • b172fd0c8   spi: ath79: Enable support for compile test ... Browse Code »

    To allow building this driver in compile test we need to remove all
    dependency on headers from arch/mips/include. To allow this we
    explicitly define all the registers locally instead of using
    ar71xx_regs.h and we move the platform data struct definition to
    include/linux/platform_data/spi-ath79.h.

    Signed-off-by: Alban Bedel
    Signed-off-by: Mark Brown

    Alban Bedel
     
  • 797622d7a   spi: ath79: Simplify ath79_spi_chipselect() ... Browse Code »

    First of all this callback was slightly misused to setup the clock
    polarity at the beginning of a transfer. Beside being at the wrong
    place, it is also useless as only SPI mode 1 is supported. Instead
    just make sure the base value used for IOC is suitable to start a
    transfer by clearing the clock and data bits during the controller
    setup.

    This also remove the last direct usage of the GPIO API, so we can
    remove the direct dependency on GPIOLIB.

    Signed-off-by: Alban Bedel
    Signed-off-by: Mark Brown

    Alban Bedel
     

09 Jan, 2019

1 commit

  • 8db79547e   spi: ath79: Convert to use CS GPIO descriptors ... Browse Code »

    This converts the ATH79 SPI master driver to use GPIO descriptors
    for chip select handling.

    The ATH79 driver was requesting the GPIO and driving it from the
    bitbang .chipselect callback. Do not request it anymore as the SPI
    core will request it, remove the line inversion semantics for the
    GPIO case (handled by gpiolib) and let the SPI core deal with
    requesting the GPIO line from the device tree node of the controller.

    This driver can be instantiated from a board file (no device tree)
    but the board files only use native CS (no GPIO lines) so we should
    be fine just letting the SPI core grab the GPIO from the device.

    The fact that the driver is actively driving the GPIO in the
    ath79_spi_chipselect() callback is confusing since the host does
    not set SPI_MASTER_GPIO_SS so this should not ever get called when
    using GPIO CS. I put in a comment about this.

    Cc: Felix Fietkau
    Cc: Alban Bedel
    Cc: Linuxarm
    Signed-off-by: Linus Walleij
    Signed-off-by: Mark Brown

    Linus Walleij
     

01 Aug, 2018

1 commit

17 Jul, 2017

1 commit

15 Dec, 2016

2 commits

24 Nov, 2016

1 commit

  • d7a32394e   spi: ath79: Fix module autoload for OF registration ... Browse Code »

    If the driver is built as a module, autoload won't work because the module
    alias information is not filled. So user-space can't match the registered
    device with the corresponding module.

    Export the module alias information using the MODULE_DEVICE_TABLE() macro.

    Before this patch:

    $ modinfo drivers/spi/spi-ath79.ko | grep alias
    alias: platform:ath79-spi

    After this patch:

    $ modinfo drivers/spi/spi-ath79.ko | grep alias
    alias: platform:ath79-spi
    alias: of:N*T*Cqca,ar7100-spiC*
    alias: of:N*T*Cqca,ar7100-spi

    Signed-off-by: Javier Martinez Canillas
    Signed-off-by: Mark Brown

    Javier Martinez Canillas
     

01 Oct, 2015

1 commit

27 Apr, 2015

3 commits

20 Oct, 2014

1 commit

15 Apr, 2014

1 commit

30 Mar, 2014

1 commit

03 Mar, 2014

1 commit

  • 61d1cf163   spi: spi-ath79: fix initial GPIO CS line setup ... Browse Code »

    The 'ath79_spi_setup_cs' function initializes the chip
    select line of a given SPI device in order to make sure
    that the device is inactive.

    If the SPI_CS_HIGH bit is set for a given device, it
    means that the CS line of that device is active HIGH
    so it must be set to LOW initially. In case of GPIO
    CS lines, the 'ath79_spi_setup_cs' function does the
    opposite of that due to the wrong GPIO flags.

    Fix the code to use the correct GPIO flags.

    Reported-by: Ronald Wahl
    Signed-off-by: Gabor Juhos
    Signed-off-by: Mark Brown
    Cc: stable@vger.kernel.org

    Gabor Juhos
     

03 Feb, 2014

1 commit

18 Dec, 2013

1 commit

17 Sep, 2013

1 commit

  • 94c69f765   spi: bitbang: Let spi_bitbang_start() take a reference to master ... Browse Code »

    Many drivers that use bitbang library have a leak on probe error paths.
    This is because once a spi_master_get() call succeeds, we need an additional
    spi_master_put() call to free the memory.

    Fix this issue by moving the code taking a reference to master to
    spi_bitbang_start(), so spi_bitbang_start() will take a reference to master on
    success. With this change, the caller is responsible for calling
    spi_bitbang_stop() to decrement the reference and spi_master_put() as
    counterpart of spi_alloc_master() to prevent a memory leak.

    So now we have below patten for drivers using bitbang library:

    probe:
    spi_alloc_master -> Init reference count to 1
    spi_bitbang_start -> Increment reference count
    remove:
    spi_bitbang_stop -> Decrement reference count
    spi_master_put -> Decrement reference count (reference count reaches 0)

    Fixup all users accordingly.

    Signed-off-by: Axel Lin
    Suggested-by: Uwe Kleine-Koenig
    Acked-by: Uwe Kleine-Koenig
    Signed-off-by: Mark Brown

    Axel Lin
     

29 Aug, 2013

1 commit

26 Jun, 2013

1 commit

30 May, 2013

1 commit

13 May, 2013

1 commit

  • 89e877307   spi: remove unnecessary platform_set_drvdata() ... Browse Code »

    The driver core clears the driver data to NULL after device_release
    or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
    (device-core: Ensure drvdata = NULL when no driver is bound).
    Thus, it is not needed to manually clear the device driver data to NULL.

    Signed-off-by: Jingoo Han
    Acked-by: Grant Likely
    Signed-off-by: Mark Brown

    Jingoo Han
     

06 Feb, 2013

1 commit

  • 7410e8485   spi/ath79: add shutdown handler ... Browse Code »

    The SPI controller of the AR7xxx/AR9xxx SoCs
    have a special mode which allows the SoC to
    directly read data from SPI flash chips. In
    this mode, the content of the SPI flash chip
    can be accessed via a memory mapped region.

    During early init time, the kernel expects
    that the flash chip is accessible through
    that memory region because it reads board
    specific values (e.g. MAC address, WiFi
    calibration data) from the flash on various
    boards.

    This is working if the kernel is loaded
    directly by the bootloader because that
    leaves the SPI controller in the special
    mode. However it is not working in a kexec'd
    kernel because the SPI driver does not restore
    the special mode during shutdown.

    The patch adds a shutdown handler to fix this
    issue.

    Signed-off-by: Gabor Juhos
    Signed-off-by: Grant Likely

    Gabor Juhos
     

05 Feb, 2013

5 commits

  • c4a31f430   spi/ath79: avoid multiple initialization of the SPI controller ... Browse Code »

    Currently we are initializing the SPI controller in
    the chip select line function, and that function is
    called once for each SPI device on the bus. If a
    board has multiple SPI devices, the controller will
    be initialized multiple times.

    Introduce ath79_spi_{en,dis}able helper functions,
    and call those from probe/response in order to avoid
    the mutliple initialization of the controller.

    Signed-off-by: Gabor Juhos
    Signed-off-by: Grant Likely

    Gabor Juhos
     
  • 95d79419f   spi/ath79: use gpio_request_one ... Browse Code »

    Use gpio_request_one() instead of multiple gpiolib calls.

    Signed-off-by: Gabor Juhos
    Signed-off-by: Grant Likely

    Gabor Juhos
     
  • f1e8fc989   spi/ath79: remove superfluous chip select code ... Browse Code »

    The spi_bitbang driver calls the chipselect function
    of the driver from spi_bitbang_setup in order to
    deselect the given SPI chip, so we don't have to
    initialize the CS line here.

    Signed-off-by: Gabor Juhos
    Signed-off-by: Grant Likely

    Gabor Juhos
     
  • 72611db0e   spi/ath79: add missing HIGH->LOW SCK transition ... Browse Code »

    The 'ath79_spi_txrx_mode0' function does not
    set the SCK signal to LOW at the end of a word
    transfer. This causes communications errors with
    certain devices (e.g. the PCF2123 RTC chip).

    The patch ensures that the SCK signal will be LOW.

    Signed-off-by: Gabor Juhos
    Signed-off-by: Grant Likely

    Gabor Juhos
     
  • 440114fdb   spi/ath79: add delay between SCK changes ... Browse Code »

    The driver uses the "as fast as it can" approach
    to drive the SCK signal. However this does not
    work with certain low speed SPI chips (e.g. the
    PCF2123 RTC chip).

    The patch adds per-bit slowdowns in order to be
    able to use the driver with such chips as well.

    Signed-off-by: Gabor Juhos
    Signed-off-by: Grant Likely

    Gabor Juhos
     

08 Dec, 2012

1 commit

  • fd4a319bc   spi: Remove HOTPLUG section attributes ... Browse Code »

    CONFIG_HOTPLUG is going away as an option. As result the __dev*
    markings will be going away.

    Remove use of __devinit, __devexit_p, __devinitdata, __devinitconst,
    and __devexit.

    Bill Pemberton has done most of the legwork on this series. I've used
    his script to purge the attributes from the drivers/gpio tree.

    Reported-by: Bill Pemberton
    Signed-off-by: Grant Likely

    Grant Likely
     

20 May, 2012

1 commit

08 Dec, 2011

1 commit

  • 807cc4b12   spi/ath79: fix compile error due to missing include ... Browse Code »

    Whithout including 'linux/module.h' spi-ath79 driver fails to compile
    with the these errors:

    drivers/spi/spi-ath79.c:273:12: error: 'THIS_MODULE' undeclared here (not in a function)
    drivers/spi/spi-ath79.c:278:20: error: expected declaration specifiers or '...' before string constant
    drivers/spi/spi-ath79.c:278:1: warning: data definition has no type or storage class
    drivers/spi/spi-ath79.c:278:1: warning: type defaults to 'int' in declaration of 'MODULE_DESCRIPTION'
    drivers/spi/spi-ath79.c:278:20: warning: function declaration isn't a prototype
    drivers/spi/spi-ath79.c:279:15: error: expected declaration specifiers or '...' before string constant
    drivers/spi/spi-ath79.c:279:1: warning: data definition has no type or storage class
    drivers/spi/spi-ath79.c:279:1: warning: type defaults to 'int' in declaration of 'MODULE_AUTHOR'
    drivers/spi/spi-ath79.c:279:15: warning: function declaration isn't a prototype
    drivers/spi/spi-ath79.c:280:16: error: expected declaration specifiers or '...' before string constant
    drivers/spi/spi-ath79.c:280:1: warning: data definition has no type or storage class
    drivers/spi/spi-ath79.c:280:1: warning: type defaults to 'int' in declaration of 'MODULE_LICENSE'
    drivers/spi/spi-ath79.c:280:16: warning: function declaration isn't a prototype
    drivers/spi/spi-ath79.c:281:14: error: expected declaration specifiers or '...' before string constant
    drivers/spi/spi-ath79.c:281:1: warning: data definition has no type or storage class
    drivers/spi/spi-ath79.c:281:1: warning: type defaults to 'int' in declaration of 'MODULE_ALIAS'
    drivers/spi/spi-ath79.c:281:14: warning: function declaration isn't a prototype

    Signed-off-by: Gabor Juhos
    Signed-off-by: Wolfram Sang

    Gabor Juhos
     

25 Oct, 2011

1 commit

  • 940ab8896   drivercore: Add helper macro for platform_driver boilerplate ... Browse Code »

    For simple modules that contain a single platform_driver without any
    additional setup code then ends up being a block of duplicated
    boilerplate. This patch adds a new macro, module_platform_driver(),
    which replaces the module_init()/module_exit() registrations with
    template functions.

    Signed-off-by: Grant Likely
    Acked-by: Greg Kroah-Hartman
    Reviewed-by: Magnus Damm
    Reviewed-by: Mark Brown
    Reviewed-by: Stephen Boyd

    Grant Likely
     

11 Jun, 2011

1 commit

06 Jun, 2011

1 commit

  • ca632f556   spi: reorganize drivers ... Browse Code »

    Sort the SPI makefile and enforce the naming convention spi_*.c for
    spi drivers.

    This change also rolls the contents of atmel_spi.h into the .c file
    since there is only one user of that particular include file.

    v2: - Use 'spi-' prefix instead of 'spi_' to match what seems to be
    be the predominant pattern for subsystem prefixes.
    - Clean up filenames in Kconfig and header comment blocks

    Signed-off-by: Grant Likely
    Acked-by: Wolfram Sang
    Acked-by: Linus Walleij

    Grant Likely