Eric Lee / smarc-fsl-linux-kernel

30 Dec, 2020

1 commit

  • 0c26f7b29   spi: tegra20-slink: fix reference leak in slink ops of tegra20 ... Browse Code »

    [ Upstream commit 763eab7074f6e71babd85d796156f05a675f9510 ]

    pm_runtime_get_sync will increment pm usage counter even it
    failed. Forgetting to pm_runtime_put_noidle will result in
    reference leak in two callers(tegra_slink_setup and
    tegra_slink_resume), so we should fix it.

    Fixes: dc4dc36056392 ("spi: tegra: add spi driver for SLINK controller")
    Signed-off-by: Zhang Qilong
    Link: https://lore.kernel.org/r/20201103141345.6188-1-zhangqilong3@huawei.com
    Signed-off-by: Mark Brown
    Signed-off-by: Sasha Levin

    Zhang Qilong
     

09 Sep, 2020

1 commit

28 May, 2020

1 commit

  • faedcc17a   spi: tegra20-slink: Fix runtime PM imbalance on error ... Browse Code »

    pm_runtime_get_sync() increments the runtime PM usage counter even
    when it returns an error code. Thus a pairing decrement is needed on
    the error handling path to keep the counter balanced.

    Signed-off-by: Dinghao Liu
    Link: https://lore.kernel.org/r/20200523122909.25247-1-dinghao.liu@zju.edu.cn
    Signed-off-by: Mark Brown

    Dinghao Liu
     

15 Nov, 2019

2 commits

31 May, 2019

1 commit

  • 9952f6918   treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 201 ... Browse Code »

    Based on 1 normalized pattern(s):

    this program is free software you can redistribute it and or modify
    it under the terms and conditions of the gnu general public license
    version 2 as published by the free software foundation this program
    is distributed in the hope it will be useful but without any
    warranty without even the implied warranty of merchantability or
    fitness for a particular purpose see the gnu general public license
    for more details you should have received a copy of the gnu general
    public license along with this program if not see http www gnu org
    licenses

    extracted by the scancode license scanner the SPDX license identifier

    GPL-2.0-only

    has been chosen to replace the boilerplate/reference in 228 file(s).

    Signed-off-by: Thomas Gleixner
    Reviewed-by: Allison Randal
    Reviewed-by: Steve Winslow
    Reviewed-by: Richard Fontana
    Reviewed-by: Alexios Zavras
    Cc: linux-spdx@vger.kernel.org
    Link: https://lkml.kernel.org/r/20190528171438.107155473@linutronix.de
    Signed-off-by: Greg Kroah-Hartman

    Thomas Gleixner
     

27 Mar, 2019

1 commit

  • 0e694df35   spi: tegra20-slink: change chip select action order ... Browse Code »

    To transfer via SPI the tegra20-slink driver first sets the command
    register, which contains the chip select value, and after that the
    command2 register, which contains the chip select line. This leads to a
    small spike in the chip selct 0 line between the set of the value and
    the selection of the chip select line.

    This commit changes the order of the register writes so that first the
    chip select line is chosen and then the value is set, removing the
    spike.

    Signed-off-by: Randolph Maaßen
    Reviewed-by: Sowjanya Komatineni
    Signed-off-by: Mark Brown

    Randolph Maaßen
     

03 Sep, 2018

1 commit

06 Mar, 2018

1 commit

20 Jul, 2017

1 commit

  • 73b32756c   spi: tegra20-slink: explicitly request exclusive reset control ... Browse Code »

    Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
    reset lines") started to transition the reset control request API calls
    to explicitly state whether the driver needs exclusive or shared reset
    control behavior. Convert all drivers requesting exclusive resets to the
    explicit API call so the temporary transition helpers can be removed.

    No functional changes.

    Cc: Laxman Dewangan
    Cc: Mark Brown
    Cc: Thierry Reding
    Cc: Jonathan Hunter
    Cc: linux-spi@vger.kernel.org
    Cc: linux-tegra@vger.kernel.org
    Signed-off-by: Philipp Zabel
    Signed-off-by: Mark Brown

    Philipp Zabel
     

25 Apr, 2017

1 commit

20 Oct, 2014

1 commit

08 May, 2014

1 commit

30 Mar, 2014

2 commits

16 Feb, 2014

1 commit

  • 78e39523b   spi: Remove explictly set bus_num and num_chipselect to default setting ... Browse Code »

    The purpose of commit 1e8a52e18cfb
    "spi: By default setup spi_masters with 1 chipselect and dynamics bus number"
    is to avoid setting default value for bus_num and num_chipselect in spi master
    drivers. So let's remove the duplicate code.

    Signed-off-by: Axel Lin
    Acked-by: Uwe Kleine-König
    Acked-By: David Daney
    Acked-by: Stephen Warren
    Signed-off-by: Mark Brown

    Axel Lin
     

13 Feb, 2014

1 commit

11 Feb, 2014

1 commit

  • 3c604de49   spi: tegra20-slink: Convert to use master->max_speed_hz ... Browse Code »

    Use master->max_speed_hz instead of tspi->spi_max_frequency, so spi core will
    handle checking transfer speed.

    In additional, since commit 052eb2d49006 'spi: core: Set max_speed_hz of
    spi_device default to max_speed_hz of controller',
    spi core will also set default spi->max_speed_hz if it is not set.
    So remove the duplicate code in tegra_slink_setup.

    Signed-off-by: Axel Lin
    Acked-by: Stephen Warren
    Signed-off-by: Mark Brown

    Axel Lin
     

03 Feb, 2014

1 commit

26 Jan, 2014

1 commit

  • 2d2e7d195   Merge tag 'spi-v3.14-2' of git://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi ... Browse Code »

    Pull spi updates from Mark Brown:
    "A respun version of the merges for the pull request previously sent
    with a few additional fixes. The last two merges were fixed up by
    hand since the branches have moved on and currently have the prior
    merge in them.

    Quite a busy release for the SPI subsystem, mostly in cleanups big and
    small scattered through the stack rather than anything else:

    - New driver for the Broadcom BC63xx HSSPI controller
    - Fix duplicate device registration for ACPI
    - Conversion of s3c64xx to DMAEngine (this pulls in platform and DMA
    changes upon which the transiton depends)
    - Some small optimisations to reduce the amount of time we hold locks
    in the datapath, eliminate some redundant checks and the size of a
    spi_transfer
    - Lots of fixes, cleanups and general enhancements to drivers,
    especially the rspi and Atmel drivers"

    * tag 'spi-v3.14-2' of git://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi: (112 commits)
    spi: core: Fix transfer failure when master->transfer_one returns positive value
    spi: Correct set_cs() documentation
    spi: Clarify transfer_one() w.r.t. spi_finalize_current_transfer()
    spi: Spelling s/finised/finished/
    spi: sc18is602: Convert to use bits_per_word_mask
    spi: Remove duplicate code to set default bits_per_word setting
    spi/pxa2xx: fix compilation warning when !CONFIG_PM_SLEEP
    spi: clps711x: Add MODULE_ALIAS to support module auto-loading
    spi: rspi: Add missing clk_disable() calls in error and cleanup paths
    spi: rspi: Spelling s/transmition/transmission/
    spi: rspi: Add support for specifying CPHA/CPOL
    spi/pxa2xx: initialize DMA channels to -1 to prevent inadvertent match
    spi: rspi: Add more QSPI register documentation
    spi: rspi: Add more RSPI register documentation
    spi: rspi: Remove dependency on DMAE for SHMOBILE
    spi/s3c64xx: Correct indentation
    spi: sh: Use spi_sh_clear_bit() instead of open-coded
    spi: bitbang: Grammar s/make to make/to make/
    spi: sh-hspi: Spelling s/recive/receive/
    spi: core: Improve tx/rx_nbits check comments
    ...

    Linus Torvalds
     

17 Dec, 2013

1 commit

  • 8a0a1af30   spi: tegra: checking for ERR_PTR instead of NULL ... Browse Code »

    dma_request_slave_channel() returns NULL on error and not ERR_PTRs.
    I've fixed this by using dma_request_slave_channel_reason() which does
    return ERR_PTRs.

    Fixes: a915d150f68d ('spi: tegra: convert to standard DMA DT bindings')
    Signed-off-by: Dan Carpenter
    Signed-off-by: Stephen Warren

    Dan Carpenter
     

12 Dec, 2013

2 commits

  • a915d150f   spi: tegra: convert to standard DMA DT bindings ... Browse Code »

    By using dma_request_slave_channel_or_err(), the DMA slave ID can be
    looked up from standard DT properties, and squirrelled away during
    channel allocation. Hence, there's no need to use a custom DT property
    to store the slave ID.

    Signed-off-by: Stephen Warren
    Acked-by: Mark Brown

    Stephen Warren
     
  • ff2251e3d   spi: tegra: use reset framework ... Browse Code »

    Tegra's clock driver now provides an implementation of the common
    reset API (include/linux/reset.h). Use this instead of the old Tegra-
    specific API; that will soon be removed.

    Signed-off-by: Stephen Warren
    Acked-by: Mark Brown
    Reviewed-by: Thierry Reding

    Stephen Warren
     

10 Dec, 2013

1 commit

15 Nov, 2013

1 commit

25 Oct, 2013

2 commits

17 Oct, 2013

2 commits

  • f178e3dec   spi/tegra20-slink: Move first transfer preparation to prepare_message ... Browse Code »

    This is more idiomatic for the factored out message processing and gives a
    small simplification of the code since we always set the per-transfer
    parameters in the same fashion.

    Signed-off-by: Mark Brown
    Tested-by: Stephen Warren

    Mark Brown
     
  • 63fc184cd   spi/tegra20-slink: Crude refactoring to use core message parsing ... Browse Code »

    This is a half done conversion with minimal code reorganisation provided
    for bisection purposes. A further patch will move the first transfer
    preparation into tegra_slink_prepare_message().

    The cs_change and udelay handling is removed, these should be
    implemented by the framework and in any case are buggy - the two fields
    should not be related and the cs_change handling appears to at best only
    work the first time it's used in a message.

    Signed-off-by: Mark Brown
    Tested-by: Stephen Warren

    Mark Brown
     

15 Oct, 2013

1 commit

08 Oct, 2013

1 commit

26 Sep, 2013

1 commit

17 Sep, 2013

1 commit

30 Jul, 2013

2 commits

23 May, 2013

1 commit

  • 24b5a82cf   spi: use platform_{get,set}_drvdata() ... Browse Code »

    Use the wrapper functions for getting and setting the driver data using
    platform_device instead of using dev_{get,set}_drvdata() with &pdev->dev,
    so we can directly pass a struct platform_device.

    Signed-off-by: Jingoo Han
    Signed-off-by: Mark Brown

    Jingoo Han
     

08 Apr, 2013

1 commit

07 Apr, 2013

2 commits

04 Apr, 2013

1 commit