13 Sep, 2020
1 commit
-
Remove unnecessary repeated word and
Signed-off-by: Abheek Dhawan
Link: https://lore.kernel.org/r/20200912064123.411656-1-adawesomeguy222@gmail.com
Signed-off-by: Greg Kroah-Hartman
22 Nov, 2019
1 commit
-
Adjust indentation from seven spaces to tab (+optional two spaces) as in
coding style with command like:
$ sed -e 's/^ /\t/' -i */KconfigSigned-off-by: Krzysztof Kozlowski
Link: https://lore.kernel.org/r/20191121132851.29072-1-krzk@kernel.org
Signed-off-by: Greg Kroah-Hartman
20 Nov, 2019
1 commit
-
Adjust indentation from spaces to tab (+optional two spaces) as in
coding style with command like:
$ sed -e 's/^ /\t/' -i */KconfigSigned-off-by: Krzysztof Kozlowski
Link: https://lore.kernel.org/r/20191120133907.13483-1-krzk@kernel.org
Signed-off-by: Greg Kroah-Hartman
03 Apr, 2019
2 commits
-
There are a few remaining drivers/staging/*/Makefile files that do not
have SPDX identifiers in them. Add the correct GPL-2.0 identifier to
them to make scanning tools happy.Reviewed-by: Mukesh Ojha
Signed-off-by: Greg Kroah-Hartman -
There are a few remaining drivers/staging/*/Kconfig files that do not
have SPDX identifiers in them. Add the correct GPL-2.0 identifier to
them to make scanning tools happy.Signed-off-by: Greg Kroah-Hartman
18 Mar, 2019
1 commit
-
Convert macro into an inline function to make codebase better
Signed-off-by: Madhumitha Prabakaran
Signed-off-by: Greg Kroah-Hartman
26 Feb, 2019
1 commit
-
Add blank line after the structure declaration,
struct fwtty_port *port = tty->driver_data;
Issue found using checkpatch.plSigned-off-by: Bhanusree Pola
Signed-off-by: Greg Kroah-Hartman
17 Dec, 2018
1 commit
-
Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.
Signed-off-by: Yangtao Li
Signed-off-by: Greg Kroah-Hartman
14 Sep, 2018
1 commit
-
Signed-off-by: Al Viro
16 May, 2018
1 commit
-
Just set up the show callback in the tty_operations, and use
proc_create_single_data to create the file without additional
boilerplace code.Signed-off-by: Christoph Hellwig
12 Feb, 2018
1 commit
-
This is the mindless scripted replacement of kernel use of POLL*
variables as described by Al, done by this script:for V in IN OUT PRI ERR RDNORM RDBAND WRNORM WRBAND HUP RDHUP NVAL MSG; do
L=`git grep -l -w POLL$V | grep -v '^t' | grep -v /um/ | grep -v '^sa' | grep -v '/poll.h$'|grep -v '^D'`
for f in $L; do sed -i "-es/^\([^\"]*\)\(\\)/\\1E\\2/" $f; done
donewith de-mangling cleanups yet to come.
NOTE! On almost all architectures, the EPOLL* constants have the same
values as the POLL* constants do. But they keyword here is "almost".
For various bad reasons they aren't the same, and epoll() doesn't
actually work quite correctly in some cases due to this on Sparc et al.The next patch from Al will sort out the final differences, and we
should be all done.Scripted-by: Al Viro
Signed-off-by: Linus Torvalds
15 Jan, 2018
2 commits
-
Now that the SPDX tag is in all drivers/staging/fwserial/ files, that
identifies the license in a specific and legally-defined manner. So the
extra GPL text wording can be removed as it is no longer needed at all.This is done on a quest to remove the 700+ different ways that files in
the kernel describe the GPL license text. And there's unneeded stuff
like the address (sometimes incorrect) for the FSF which is never
needed.No copyright headers or other non-license-description text was removed.
Signed-off-by: Greg Kroah-Hartman
-
It's good to have SPDX identifiers in all files to make it easier to
audit the kernel tree for correct licenses.Fix up the staging fwserial driver to have a proper SPDX identifier,
based on the license text in the file itself. The SPDX identifier is a
legally binding shorthand, which can be used instead of the full boiler
plate text.This work is based on a script and data from Thomas Gleixner, Philippe
Ombredanne, and Kate Stewart.Cc: Thomas Gleixner
Cc: Kate Stewart
Cc: Philippe Ombredanne
Signed-off-by: Greg Kroah-Hartman
14 Nov, 2017
1 commit
-
Pull staging and IIO updates from Greg KH:
"Here is the "big" staging and IIO driver update for 4.15-rc1.Lots and lots of little changes, almost all minor code cleanups as the
Outreachy application process happened during this development cycle.
Also happened was a lot of IIO driver activity, and the typec USB code
moving out of staging to drivers/usb (same commits are in the USB tree
on a persistent branch to not cause merge issues.)Overall, it's a wash, I think we added a few hundred more lines than
removed, but really only a few thousand were modified at all.All of these have been in linux-next for a while. There might be a
merge issue with Al's vfs tree in the pi433 driver (take his changes,
they are always better), and the media tree with some of the odd
atomisp cleanups (take the media tree's version)"* tag 'staging-4.15-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging: (507 commits)
staging: lustre: add SPDX identifiers to all lustre files
staging: greybus: Remove redundant license text
staging: greybus: add SPDX identifiers to all greybus driver files
staging: ccree: simplify ioread/iowrite
staging: ccree: simplify registers access
staging: ccree: simplify error handling logic
staging: ccree: remove dead code
staging: ccree: handle limiting of DMA masks
staging: ccree: copy IV to DMAable memory
staging: fbtft: remove redundant initialization of buf
staging: sm750fb: Fix parameter mistake in poke32
staging: wilc1000: Fix bssid buffer offset in Txq
staging: fbtft: fb_ssd1331: fix mirrored display
staging: android: Fix checkpatch.pl error
staging: greybus: loopback: convert loopback to use generic async operations
staging: greybus: operation: add private data with get/set accessors
staging: greybus: loopback: Fix iteration count on async path
staging: greybus: loopback: Hold per-connection mutex across operations
staging: greybus/loopback: use ktime_get() for time intervals
staging: fsl-dpaa2/eth: Extra headroom in RX buffers
...
02 Nov, 2017
1 commit
-
Many source files in the tree are missing licensing information, which
makes it harder for compliance tools to determine the correct license.By default all files without license information are under the default
license of the kernel, which is GPL version 2.Update the files which contain no license information with the 'GPL-2.0'
SPDX license identifier. The SPDX identifier is a legally binding
shorthand, which can be used instead of the full boiler plate text.This patch is based on work done by Thomas Gleixner and Kate Stewart and
Philippe Ombredanne.How this work was done:
Patches were generated and checked against linux-4.14-rc6 for a subset of
the use cases:
- file had no licensing information it it.
- file was a */uapi/* one with no licensing information in it,
- file was a */uapi/* one with existing licensing information,Further patches will be generated in subsequent months to fix up cases
where non-standard license headers were used, and references to license
had to be inferred by heuristics based on keywords.The analysis to determine which SPDX License Identifier to be applied to
a file was done in a spreadsheet of side by side results from of the
output of two independent scanners (ScanCode & Windriver) producing SPDX
tag:value files created by Philippe Ombredanne. Philippe prepared the
base worksheet, and did an initial spot review of a few 1000 files.The 4.13 kernel was the starting point of the analysis with 60,537 files
assessed. Kate Stewart did a file by file comparison of the scanner
results in the spreadsheet to determine which SPDX license identifier(s)
to be applied to the file. She confirmed any determination that was not
immediately clear with lawyers working with the Linux Foundation.Criteria used to select files for SPDX license identifier tagging was:
- Files considered eligible had to be source code files.
- Make and config files were included as candidates if they contained >5
lines of source
- File already had some variant of a license header in it (even if
Reviewed-by: Philippe Ombredanne
Reviewed-by: Thomas Gleixner
Signed-off-by: Greg Kroah-Hartman
18 Oct, 2017
1 commit
-
In preparation for unconditionally passing the struct timer_list pointer to
all timer callbacks, switch to using the new timer_setup() and from_timer()
to pass the timer pointer explicitly. Also removes redundant initialization
of fw transaction timer, which already gets initialized per-transaction.Cc: Greg Kroah-Hartman
Cc: Bhumika Goyal
Cc: devel@driverdev.osuosl.org
Signed-off-by: Kees Cook
Signed-off-by: Greg Kroah-Hartman
16 Oct, 2016
1 commit
-
The function fill_unplug_req is not used anywhere in the kernel, so
remove it. Done using Coccinelle.@r1@
identifier func;
type T;
@@
static T func(...)
{
...
}@r@
identifier r1.func;
@@
func@delete depends on !r@
identifier r1.func;
type r1.T;
@@
- static T func(...){...}Signed-off-by: Bhumika Goyal
Signed-off-by: Greg Kroah-Hartman
13 Sep, 2016
1 commit
-
Fix the following warnings:
Symbolic permissions are not preferred. Consider using octal permissions.Signed-off-by: Simon Chopin
Signed-off-by: Greg Kroah-Hartman
21 May, 2016
1 commit
-
Pull staging and IIO driver updates from Greg KH:
"Here's the big staging and iio driver update for 4.7-rc1.I think we almost broke even with this release, only adding a few more
lines than we removed, which isn't bad overall given that there's a
bunch of new iio drivers added.The Lustre developers seem to have woken up from their sleep and have
been doing a great job in cleaning up the code and pruning unused or
old cruft, the filesystem is almost readable :)Other than that, just a lot of basic coding style cleanups in the
churn. All have been in linux-next for a while with no reported
issues"* tag 'staging-4.7-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging: (938 commits)
Staging: emxx_udc: emxx_udc: fixed coding style issue
staging/gdm724x: fix "alignment should match open parenthesis" issues
staging/gdm724x: Fix avoid CamelCase
staging: unisys: rename misleading var ii with frag
staging: unisys: visorhba: switch success handling to error handling
staging: unisys: visorhba: main path needs to flow down the left margin
staging: unisys: visorinput: handle_locking_key() simplifications
staging: unisys: visorhba: fail gracefully for thread creation failures
staging: unisys: visornic: comment restructuring and removing bad diction
staging: unisys: fix format string %Lx to %llx for u64
staging: unisys: remove unused struct members
staging: unisys: visorchannel: correct variable misspelling
staging: unisys: visorhba: replace functionlike macro with function
staging: dgnc: Need to check for NULL of ch
staging: dgnc: remove redundant condition check
staging: dgnc: fix 'line over 80 characters'
staging: dgnc: clean up the dgnc_get_modem_info()
staging: lustre: lnet: enable configuration per NI interface
staging: lustre: o2iblnd: properly set ibr_why
staging: lustre: o2iblnd: remove last of kiblnd_tunables_fini
...
01 May, 2016
1 commit
-
Abstract TTY_THROTTLED bit tests with tty_throttled().
Signed-off-by: Peter Hurley
Signed-off-by: Greg Kroah-Hartman
30 Mar, 2016
2 commits
-
Removing two "!= NULL" from fwserial.c as suggested by checkpatch.pl.
Note that the associated expression "port->port.console" is a 1-bit-field
that is already assumed as an implicit boolean (that is: without comparison)Signed-off-by: Dominique van den Broeck
Signed-off-by: Greg Kroah-Hartman -
Coding-style-only modifications to remove every warning saying:
WARNING: Prefer 'unsigned int' to bare use of 'unsigned'Compiled against revision "next-20160327".
(checkpatch.pl was updated to treat "UNSPECIFIED_INT" warnings
as of commit a1ce18e4f941d20 )Signed-off-by: Dominique van den Broeck
Signed-off-by: Greg Kroah-Hartman
08 Feb, 2016
2 commits
-
Rewrite multiple comparisons to NULL as "!fifo->data"
to fix the last coding style problems of this file.Signed-off-by: Christian Colic
Signed-off-by: Greg Kroah-Hartman -
This fixes all "No space is necessary after a cast" messages
Signed-off-by: Bogicevic Sasa
Signed-off-by: Greg Kroah-Hartman
29 Jan, 2016
1 commit
-
Declare the function fwtty_port_get as static since it is used
only in this particular file. Also remove the corresponding
declaration from header file.Signed-off-by: Shraddha Barke
Signed-off-by: Greg Kroah-Hartman
16 Nov, 2015
2 commits
-
Declare the function fwtty_port_put as static since it is used
only in this particular file. Also remove the corresponding
declaration from header file.Signed-off-by: Shraddha Barke
Signed-off-by: Greg Kroah-Hartman -
fwtty_bind_console is defined in header file but not used.
Thus remove the definition.Signed-off-by: Shraddha Barke
Signed-off-by: Greg Kroah-Hartman
31 May, 2015
1 commit
-
This patch fixes the leak, which was present in fwserial driver in the
init function. In case the tty driver allocation failed the function
returned error, leaving debugfs entry in the filesystem.To fix the issue additional error label was added, so that the code will
jump to it in case of allocation failure, and free debugfs entries.Signed-off-by: Vladimirs Ambrosovs
Reviewed-by: Peter Hurley
Signed-off-by: Greg Kroah-Hartman
08 May, 2015
1 commit
-
Fixed multiple spelling errors.
Signed-off-by: Carlos E. Garcia
Signed-off-by: Greg Kroah-Hartman
16 Mar, 2015
1 commit
-
Removes extra parentheses around function arguments. Issue
detected and resolved using the following coccinelle script:@@
expression e;
identifier f;
@@f(...,
-(
e
-)
,...);Signed-off-by: Aya Mahfouz
Signed-off-by: Greg Kroah-Hartman
27 Nov, 2014
1 commit
-
This patch fixes the multiple blank lines issue complained by checkpatch.pl
by removing useless blank lines.Signed-off-by: Le Tan
Signed-off-by: Greg Kroah-Hartman
19 Jun, 2014
2 commits
-
Style-only modifications to make checkpatch.pl -f a bit happier.
Fixes warning: "void function return statements are not generally useful"Signed-off-by: Radek Dostal
Signed-off-by: Greg Kroah-Hartman -
Style-only modifications to make checkpatch.pl -f a bit happier.
Fixes warning: "Missing a blank line after declarations"Signed-off-by: Radek Dostal
Signed-off-by: Greg Kroah-Hartman
26 Apr, 2014
5 commits
-
This patch replaces rcu_assign_pointer(x, NULL) with RCU_INIT_POINTER(x, NULL)
The rcu_assign_pointer() ensures that the initialization of a structure
is carried out before storing a pointer to that structure.
And in the case of the NULL pointer, there is no structure to initialize.
So, rcu_assign_pointer(p, NULL) can be safely converted to RCU_INIT_POINTER(p, NULL)Signed-off-by: Monam Agarwal
Signed-off-by: Greg Kroah-Hartman -
Style-only modifications to make checkpatch.pl --file --strict a bit happier.
Removing FSF postal address from file top comment since it has changed in the
past, as stated by checkpatch.pl.Signed-off-by: Dominique van den Broeck
Signed-off-by: Greg Kroah-Hartman -
Style-only modifications to make checkpatch.pl --file --strict a bit happier.
Removed useless "extern" in dma_fifo.h ;
Removed one supernumerary space.Signed-off-by: Dominique van den Broeck
Signed-off-by: Greg Kroah-Hartman -
Style-only modifications to make checkpatch.pl --file --strict a bit happier.
if/else bracket matching (either none or both options should be bracketed).Signed-off-by: Dominique van den Broeck
Signed-off-by: Greg Kroah-Hartman -
Style-only modifications to make checkpatch.pl --file --strict a bit happier.
Open parenthesis alignments.Signed-off-by: Dominique van den Broeck
Signed-off-by: Greg Kroah-Hartman
07 Mar, 2014
1 commit
-
PREPARE_[DELAYED_]WORK() are being phased out. They have few users
and a nasty surprise in terms of reentrancy guarantee as workqueue
considers work items to be different if they don't have the same work
function.fwtty_peer->work is multiplexed with multiple work functions.
Introduce fwserial_peer_workfn() which invokes fwtty_peer->workfn and
always use it as the work function and update the users to set the
->workfn field instead of overriding the work function using
PREPARE_WORK().It would probably be best to route this with other related updates
through the workqueue tree.Compile tested.
Signed-off-by: Tejun Heo
Acked-by: Peter Hurley
09 Dec, 2013
1 commit
-
Allow kernel configuration of max supported ports for
TTY-over-Firewire driver.Signed-off-by: Peter Hurley
Signed-off-by: Greg Kroah-Hartman