09 Oct, 2020
1 commit
-
This patch fix long lines found by checkpatch.
Signed-off-by: Fan Fei
Link: https://lore.kernel.org/r/20201008185524.brl467kucslxoxci@ubuntu-T470
Signed-off-by: Greg Kroah-Hartman
05 Oct, 2020
1 commit
-
Reduce line length, simplify refactoring.
Signed-off-by: Ivan Safonov
Link: https://lore.kernel.org/r/20201004060921.8908-1-insafonov@gmail.com
Signed-off-by: Greg Kroah-Hartman
01 Oct, 2020
8 commits
-
Replace spaces with tab to clear checkpatch error.
ERROR: code indent should use tabs where possible
Signed-off-by: Michael Straube
Link: https://lore.kernel.org/r/20200929062847.23985-8-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman -
After the removal of cckrates_included() and cckrates_only_included()
from rtw_wlan_util.c the variable/parameter 'ratelen' is unused now.
Remove it from update_wireless_mode() and judge_network_type().Signed-off-by: Michael Straube
Link: https://lore.kernel.org/r/20200929062847.23985-7-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman -
In rtw_ieee80211.c there are rtw_is_cckrates_included() and
rtw_is_cckratesonly_included() which have the same functionality as
cckrates_included() and cckrates_only_included() defined in
rtw_wlan_util.c. Remove the functions from rtw_wlan_util.c and use
those from rtw_ieee80211.c.Signed-off-by: Michael Straube
Link: https://lore.kernel.org/r/20200929062847.23985-6-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman -
Rename field of struct rt_pmkid_list to avoid camel case.
bUsed -> used
Signed-off-by: Michael Straube
Link: https://lore.kernel.org/r/20200929062847.23985-5-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman -
Use ETH_ALEN instead of hard coded array size.
Signed-off-by: Michael Straube
Link: https://lore.kernel.org/r/20200929062847.23985-4-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman -
Rename field of struct rt_pmkid_list to avoid camel case.
Bssid -> bssid
Signed-off-by: Michael Straube
Link: https://lore.kernel.org/r/20200929062847.23985-3-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman -
Clean up remaining comparsions to NULL reported by checkpatch.
x == NULL -> !x
x != NULL -> xSigned-off-by: Michael Straube
Link: https://lore.kernel.org/r/20200929062847.23985-2-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman -
Removep unused macros and definitions from rtw_security.h leftover
from previous cleanup patches.Signed-off-by: Michael Straube
Link: https://lore.kernel.org/r/20200929062847.23985-1-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman
27 Sep, 2020
1 commit
-
Commit 515ce733e86e ("staging:r8188eu: Use lib80211 to encrypt (CCMP) tx frames")
was reverted because it caused scheduling while atomic bugs and hard
freezes. Experimentation showed that there were no freezes and no BUG
messages logged when lib80211_get_crypto_ops() was called directly
rather than indirectly through try_then_request_module().Reapply "staging:r8188eu: Use lib80211 to encrypt (CCMP) tx frames"
with resolved revert conflicts and replace try_then_request_module()
with direct call to lib80211_get_crypto_ops().Original commit message:
Put data to skb, decrypt with lib80211_crypt_ccmp, and place back to tx buffer.Cc: Ivan Safonov
Signed-off-by: Michael Straube
Link: https://lore.kernel.org/r/20200927083535.2895-1-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman
22 Sep, 2020
3 commits
-
WIFI_REASON_CODE is duplication of enum ieee80211_reasoncode.
Signed-off-by: Ivan Safonov
Link: https://lore.kernel.org/r/20200919212443.264126-1-insafonov@gmail.com
Signed-off-by: Greg Kroah-Hartman -
Clean up alignment style issues to follow kernel coding style
and clear checkpatch issues.CHECK: Alignment should match open parenthesis
Signed-off-by: Michael Straube
Link: https://lore.kernel.org/r/20200919090040.9613-2-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman -
Clean up block comment style issues to follow kernel coding style
and clear checkpatch warnings.WARNING: Block comments should align the * on each line
WARNING: Block comments use a trailing */ on a separate line
WARNING: Block comments use * on subsequent linesSigned-off-by: Michael Straube
Link: https://lore.kernel.org/r/20200919090040.9613-1-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman
18 Sep, 2020
2 commits
-
Move constants to the right side of comparsions to follow kernel
coding style and clear checkpatch warnings. In case of comparsion
to _FAIL we can use '!' since _FAIL is defined as '0'.WARNING: Comparisons should place the constant on the right side of the test
Signed-off-by: Michael Straube
Link: https://lore.kernel.org/r/20200917071330.31740-2-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman -
Use __func__ instead of hardcoded function names to clear
checkpatch warnings.Signed-off-by: Michael Straube
Link: https://lore.kernel.org/r/20200917071330.31740-1-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman
16 Sep, 2020
3 commits
-
In preparation for unconditionally passing the
struct tasklet_struct pointer to all tasklet
callbacks, switch to using the new tasklet_setup()
and from_tasklet() to pass the tasklet pointer explicitly.Signed-off-by: Romain Perier
Signed-off-by: Allen Pais
Link: https://lore.kernel.org/r/20200916062224.58203-1-allen.lkml@gmail.com
Signed-off-by: Greg Kroah-Hartman -
Add missing and remove unnecessary blank lines to clear the following
checkpatch issues.WARNING: Missing a blank line after declarations
CHECK: Please use a blank line after function/struct/union/enum declarations
CHECK: Blank lines aren't necessary before a close brace '}'
CHECK: Please don't use multiple blank linesSigned-off-by: Michael Straube
Link: https://lore.kernel.org/r/20200916064257.14902-1-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman -
Remove extra indentations to follow kernel coding style and clear
checkpatch warnings.WARNING: suspect code indent for conditional statements
Signed-off-by: Michael Straube
Link: https://lore.kernel.org/r/20200915095009.9679-1-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman
07 Sep, 2020
2 commits
-
Clean up unnecessary whitespace in wpa_set_encryption() by removing
extra spaces and replacing tabs with spaces. Clears a checkpatch error.ERROR: space prohibited before that close parenthesis ')'
Signed-off-by: Michael Straube
Link: https://lore.kernel.org/r/20200905115358.10278-1-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman -
…0211_spectrum_mgmt_actioncode
Enum rtw_ieee80211_spectrum_mgmt_actioncode is a duplication
of ieee80211_spectrum_mgmt_actioncode from include/linux/ieee80211.h.Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Link: https://lore.kernel.org/r/20200906133236.556427-1-insafonov@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
02 Sep, 2020
1 commit
-
Use __func__ instead of hardcoded function names to clear
checkpatch warnings.Signed-off-by: Michael Straube
Link: https://lore.kernel.org/r/20200830072140.14178-1-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman
18 Aug, 2020
1 commit
-
The type cast
padapter = (struct adapter *)rtw_netdev_priv(dev);
do nothing because type of rtw_netdev_priv() result
is (struct adapter *).Signed-off-by: Ivan Safonov
Link: https://lore.kernel.org/r/20200815203306.121039-1-insafonov@gmail.com
Signed-off-by: Greg Kroah-Hartman
02 Aug, 2020
1 commit
-
The function guarantees type checking of arguments and return value.
Result of rtw_netdev_priv macro can be assigned to pointer
with incompatible type without warning. The function allow compiler
to perform this check.Signed-off-by: Ivan Safonov
Link: https://lore.kernel.org/r/20200801180235.34116-1-insafonov@gmail.com
Signed-off-by: Greg Kroah-Hartman
28 Jul, 2020
2 commits
-
The variable authmode can be uninitialized. The danger would be if
it equals to _WPA_IE_ID_ (0xdd) or _WPA2_IE_ID_ (0x33). We can avoid
this by setting it to zero instead. This is the approach that was
used in the rtl8723bs driver.Fixes: 7b464c9fa5cc ("staging: r8188eu: Add files for new driver - part 4")
Co-developed-by: Dan Carpenter
Signed-off-by: Dan Carpenter
Signed-off-by: Dinghao Liu
Cc: stable
Link: https://lore.kernel.org/r/20200728072153.9202-1-dinghao.liu@zju.edu.cn
Signed-off-by: Greg Kroah-Hartman -
rtw_aes_decrypt, rtw_tkip_decrypt, rtw_wep_decrypt, rtw_aes_encrypt,
rtw_tkip_encrypt, rtw_wep_encrypt are takes (u8 *) second argiment and
always uses it as (struct recv_frame *) or (struct xmit_frame *).
This is causes a lot of unnecessary type casts
and complicates refactoring.Signed-off-by: Ivan Safonov
Link: https://lore.kernel.org/r/20200726210246.68633-1-insafonov@gmail.com
Signed-off-by: Greg Kroah-Hartman
25 Jul, 2020
1 commit
-
Running the checkpatch.pl script on the file for which patch was created, the
following error was found to exist.
ERROR: space required after that ',' (ctx:VxV)Fixed the above error which was found on line #721 by inserting a blank
space at the appropriate position.Signed-off-by: Anant Thazhemadam
Link: https://lore.kernel.org/r/20200725122041.5663-1-anant.thazhemadam@gmail.com
Signed-off-by: Greg Kroah-Hartman
24 Jul, 2020
1 commit
-
Modify equality comparison involving constants by shifting the constant
operand to the right side of the comparison as suggested by
scripts/checkpatch.plSigned-off-by: Priti Chattopadhyay
Link: https://lore.kernel.org/r/20200723092150.y34bentngeeci2oc@pritichattopadhyay
Signed-off-by: Greg Kroah-Hartman
23 Jul, 2020
3 commits
-
Only a single tab space is required after the if statement.
Fix this issue by running scripts/checkpatch.pl on the file.Signed-off-by: Mrinal Pandey
Link: https://lore.kernel.org/r/20200722151900.5dcebtavkdi5cc77@mrinalpandey
Signed-off-by: Greg Kroah-Hartman -
Replace tabs with spaces in declarations to cleanup whitespace
in rtl8188eu_recv.c.Signed-off-by: Michael Straube
Link: https://lore.kernel.org/r/20200723075243.21924-2-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman -
Clear checkpatch alignment style issues in rtl8188eu_recv.c.
CHECK: Alignment should match open parenthesisThe file is now checkpatch clean.
Signed-off-by: Michael Straube
Link: https://lore.kernel.org/r/20200723075243.21924-1-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman
20 Jul, 2020
2 commits
-
Add spaces around operators in the header files to improve readability
and clear checkpatch issues.Signed-off-by: Michael Straube
Link: https://lore.kernel.org/r/20200719114045.13595-1-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman -
This fixes the following checkpatch.pl warning
WARNING: Prefer using '"%s...", __func__' to using 'rtw_tkip_decrypt', this function's name, in a string.Signed-off-by: Anoop S
Link: https://lore.kernel.org/r/20200718103125.62528-1-anoop.skumar1507@gmail.com
Signed-off-by: Greg Kroah-Hartman
19 Jul, 2020
2 commits
-
fixed multiple blank space coding style issues
reported by checkpatchSigned-off-by: B K Karthik
Link: https://lore.kernel.org/r/20200718091442.xamnoawpguo42k7v@pesu-pes-edu
Signed-off-by: Greg Kroah-Hartman -
Clear tabstop style issues reported by checkpatch.
WARNING: Statements should start on a tabstopSigned-off-by: Michael Straube
Link: https://lore.kernel.org/r/20200718065514.16289-1-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman
17 Jul, 2020
2 commits
-
Added a blank line after declarations in
drivers/staging/rtl8188eu/core/rtw_security.c to fix a
checkpatch.pl warningSigned-off-by: Rahul Gottipati
Link: https://lore.kernel.org/r/20200715163152.GA10190@rahulg-ThinkPad-T450
Signed-off-by: Greg Kroah-Hartman -
Use static const in declarations where appropriate.
Signed-off-by: Joe Perches
Link: https://lore.kernel.org/r/818bbd25924f0c733a4a39d426fd30392d4eae80.camel@perches.com
Signed-off-by: Greg Kroah-Hartman
16 Jul, 2020
1 commit
-
Fixing WARNING: Prefer using '"%s...", __func__' to using 'function_name'
in a string in rtw_ioctl_set.cSigned-off-by: Arpitha Raghunandan
Link: https://lore.kernel.org/r/20200715154623.78315-1-98.arpi@gmail.com
Signed-off-by: Greg Kroah-Hartman
15 Jul, 2020
1 commit
-
Remove unused members of struct xmit_buf: alloc_sz, ff_hwaddr,
dma_transfer_addr, bpending and last.Acked-by: Larry Finger
Signed-off-by: Ivan Safonov
Link: https://lore.kernel.org/r/20200712123821.553420-1-insafonov@gmail.com
Signed-off-by: Greg Kroah-Hartman
10 Jul, 2020
1 commit
-
Replace the existing /* fall through */ comments and its variants with
the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary
fall-through markings when it is the case.[1] https://www.kernel.org/doc/html/latest/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through
Signed-off-by: Gustavo A. R. Silva
Link: https://lore.kernel.org/r/20200707182008.GA341@embeddedor
Signed-off-by: Greg Kroah-Hartman
