05 Dec, 2019
1 commit
-
Now that the fbops member of struct fb_info is const, we can start
making the ops const as well.This does not cover all drivers; some actually modify the fbops struct,
for example to adjust for different configurations, and others do more
involved things that I'd rather not touch in practically obsolete
drivers. Mostly this is the low hanging fruit where we can add "const"
and be done with it.v3:
- un-constify atyfb, mb862xx, nvidia and uvesabf (0day)v2:
- fix typo (Christophe de Dinechin)
- use "static const" instead of "const static" in mx3fb.c
- also constify smscufx.cCc: linux-fbdev@vger.kernel.org
Reviewed-by: Daniel Vetter
Signed-off-by: Jani Nikula
Link: https://patchwork.freedesktop.org/patch/msgid/ce67f14435f3af498f2e8bf35ce4be11f7504132.1575390740.git.jani.nikula@intel.com
03 Dec, 2019
1 commit
-
Deferred IO now preserves the fb_ops.
Cc: Steve Glendinning
Cc: linux-fbdev@vger.kernel.org
Reviewed-by: Daniel Vetter
Signed-off-by: Jani Nikula
Link: https://patchwork.freedesktop.org/patch/msgid/480dcc682481e6972e5648181d7e92120929ec6b.1575022735.git.jani.nikula@intel.com
28 Jun, 2019
1 commit
-
framebuffer_alloc() can fail only on kzalloc() memory allocation
failure and since kzalloc() will print error message in such case
we can omit printing extra error message in drivers (which BTW is
what the majority of framebuffer_alloc() users is doing already).Cc: "Bruno Prémont"
Cc: Jiri Kosina
Cc: Benjamin Tissoires
Signed-off-by: Bartlomiej Zolnierkiewicz
05 Jun, 2019
1 commit
-
Based on 1 normalized pattern(s):
this file is subject to the terms and conditions of the gnu general
public license v2 see the file copying in the main directory of this
archive for more detailsextracted by the scancode license scanner the SPDX license identifier
GPL-2.0-only
has been chosen to replace the boilerplate/reference in 11 file(s).
Signed-off-by: Thomas Gleixner
Reviewed-by: Alexios Zavras
Reviewed-by: Allison Randal
Reviewed-by: Richard Fontana
Cc: linux-spdx@vger.kernel.org
Link: https://lkml.kernel.org/r/20190529141333.582369016@linutronix.de
Signed-off-by: Greg Kroah-Hartman
28 Mar, 2018
3 commits
-
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
Cc: Steve Glendinning
Signed-off-by: Bartlomiej Zolnierkiewicz -
* Return an error code without storing it in an intermediate variable.
* Delete the label "error" and local variable "retval"
which became unnecessary with this refactoring.Signed-off-by: Markus Elfring
Cc: Steve Glendinning
Signed-off-by: Bartlomiej Zolnierkiewicz -
Up to four checks could be repeated by the ufx_usb_probe() function
during error handling even if the relevant properties can be determined
for the involved variables before by source code analysis.* Return directly after a call of the function "kzalloc" failed
at the beginning.* Adjust jump targets so that extra checks can be omitted at the end.
* Delete initialisations for the variables "info" and "retval"
which became unnecessary with this refactoring.Signed-off-by: Markus Elfring
Cc: Steve Glendinning
Signed-off-by: Bartlomiej Zolnierkiewicz
30 Dec, 2017
1 commit
-
Replace the specification of data structures by pointer dereferences
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.Signed-off-by: Markus Elfring
Cc: Steve Glendinning
Signed-off-by: Bartlomiej Zolnierkiewicz
21 Aug, 2017
1 commit
-
usb_device_id are not supposed to change at runtime. All functions
working with usb_device_id provided by work with
const usb_device_id. So mark the non-const structs as const.Signed-off-by: Arvind Yadav
Cc: Steve Glendinning
Cc: Bernie Thompson
Signed-off-by: Bartlomiej Zolnierkiewicz
14 Jun, 2017
1 commit
-
Add the missing endianness conversions when printing the USB
device-descriptor idVendor, idProduct and bcdDevice fields during probe.Signed-off-by: Johan Hovold
Cc: Steve Glendinning
Cc: Bernie Thompson
Signed-off-by: Bartlomiej Zolnierkiewicz
27 Sep, 2016
1 commit
-
The variable was only assigned with the pointer but was never used.
We can safely remove it.Signed-off-by: Sudip Mukherjee
Signed-off-by: Tomi Valkeinen
04 Dec, 2014
1 commit
-
The vfree() function performs also input parameter validation. Thus the test
around the call is not needed.This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
Signed-off-by: Tomi Valkeinen
17 Apr, 2014
1 commit
-
The drivers/video directory is a mess. It contains generic video related
files, directories for backlight, console, linux logo, lots of fbdev
device drivers, fbdev framework files.Make some order into the chaos by creating drivers/video/fbdev
directory, and move all fbdev related files there.No functionality is changed, although I guess it is possible that some
subtle Makefile build order related issue could be created by this
patch.Signed-off-by: Tomi Valkeinen
Acked-by: Laurent Pinchart
Acked-by: Geert Uytterhoeven
Acked-by: Rob Clark
Acked-by: Jingoo Han
Acked-by: Daniel Vetter
