14 Jan, 2020

1 commit

  • The setup_crash_devices_work_queue function only partially initializes
    the message it sends to chipset_init, leading to undefined behavior:

    drivers/visorbus/visorchipset.c: In function 'setup_crash_devices_work_queue':
    drivers/visorbus/visorchipset.c:333:6: error: '((unsigned char*)&msg.hdr.flags)[0]' is used uninitialized in this function [-Werror=uninitialized]
    if (inmsg->hdr.flags.response_expected)

    Set up the entire structure, zero-initializing the 'response_expected'
    flag.

    This was apparently found by the patch that added the -O3 build option
    in Kconfig.

    Fixes: 12e364b9f08a ("staging: visorchipset driver to provide registration and other services")
    Signed-off-by: Arnd Bergmann
    Link: https://lore.kernel.org/r/20200107202950.782951-1-arnd@arndb.de
    Signed-off-by: Greg Kroah-Hartman

    Arnd Bergmann
     

08 Dec, 2017

1 commit

  • Move the visorbus driver out of staging (drivers/staging/unisys/visorbus)
    and to drivers/visorbus. Modify the configuration and makefiles so they
    now reference the new location. The s-Par header file visorbus.h that is
    referenced by all s-Par drivers, is being moved into include/linux.

    Signed-off-by: David Kershner
    Reviewed-by: Tim Sell
    Signed-off-by: Greg Kroah-Hartman

    David Kershner