08 Jul, 2019
2 commits
-
The commit 5e6acc3e678e ("bcm2835-pm: Move bcm2835-watchdog's DT probe
to an MFD.") broke module autoloading on Raspberry Pi. So add a
module alias this fix this.Signed-off-by: Stefan Wahren
Reviewed-by: Guenter Roeck
Signed-off-by: Guenter Roeck
Signed-off-by: Wim Van Sebroeck -
The core will print out details now.
Signed-off-by: Wolfram Sang
Signed-off-by: Guenter Roeck
Signed-off-by: Wim Van Sebroeck
06 May, 2019
1 commit
-
There is no call to platform_get_drvdata() in the driver,
so platform_set_drvdata() is unnecessary and can be dropped.The conversion was done automatically with coccinelle using the
following semantic patches. The semantic patches and the scripts
used to generate this commit log are available at
https://github.com/groeck/coccinelle-patchesCc: Florian Fainelli
Cc: Ray Jui
Cc: Scott Branden
Cc: bcm-kernel-feedback-list@broadcom.com
Cc: Eric Anholt
Cc: Stefan Wahren
Signed-off-by: Guenter Roeck
Acked-by: Stefan Wahren
Signed-off-by: Wim Van Sebroeck
09 Jan, 2019
1 commit
-
The PM block that the wdt driver was binding to actually has multiple
features we want to expose (power domains, reset, watchdog). Move the
DT attachment to a MFD driver and make WDT probe against MFD.Signed-off-by: Eric Anholt
Reviewed-by: Guenter Roeck
Acked-by: Stefan Wahren
Signed-off-by: Stefan Wahren
24 Mar, 2018
1 commit
-
- Add SPDX identifier
- Remove boiler plate license text
- If MODULE_LICENSE and boiler plate does not match, go for boiler plate
licenseSigned-off-by: Marcus Folkesson
Acked-by: Adam Thomson
Acked-by: Baruch Siach
Acked-by: Charles Keepax
Acked-by: Keiji Hayashibara
Acked-by: Johannes Thumshirn
Acked-by: Florian Fainelli
Acked-by: Mans Rullgard
Acked-by: Matthias Brugger
Acked-by: Michal Simek
Acked-by: Neil Armstrong
Acked-by: Nicolas Ferre
Acked-by: Thierry Reding
Acked-by: Tomas Winkler
Acked-by: Patrice Chotard
Acked-by: William Breathitt Gray
Reviewed-by: Eric Anholt
Reviewed-by: Guenter Roeck
Signed-off-by: Guenter Roeck
Signed-off-by: Wim Van Sebroeck
28 Feb, 2017
1 commit
-
Fix typos and add the following to the scripts/spelling.txt:
partiton||partition
Link: http://lkml.kernel.org/r/1481573103-11329-7-git-send-email-yamada.masahiro@socionext.com
Signed-off-by: Masahiro Yamada
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
25 Feb, 2017
2 commits
-
Use device managed functions to simplify error handling, reduce
source code size, improve readability, and reduce the likelyhood of bugs.
Other improvements as listed below.The conversion was done automatically with coccinelle using the
following semantic patches. The semantic patches and the scripts used
to generate this commit log are available at
https://github.com/groeck/coccinelle-patches- Drop assignments to otherwise unused variables
- Replace of_iomap() with platform_get_resource() followed by
devm_ioremap_resource()
- Replace &pdev->dev with dev if 'struct device *dev' is a declared
variable
- Use devm_watchdog_register_driver() to register watchdog device
- Replace shutdown function with call to watchdog_stop_on_reboot()Cc: Stephen Warren
Cc: Lee Jones
Cc: Florian Fainelli
Cc: Ray Jui
Cc: Scott Branden
Acked-by: Eric Anholt
Signed-off-by: Guenter Roeck -
Use the infrastructure provided by the watchdog core to install
the restart handler.Acked-by: Eric Anholt
Signed-off-by: Guenter Roeck
16 Dec, 2016
1 commit
-
A bootloader may start the watchdog device before handing control to
the kernel - in that case, we should tell the kernel about it so the
watchdog framework can keep it alive until userspace opens
/dev/watchdog0.Signed-off-by: Rasmus Villemoes
Reviewed-by: Guenter Roeck
Acked-by: Eric Anholt
Signed-off-by: Guenter Roeck
18 Jul, 2016
2 commits
-
bcm2835_wdt_set_timeout does exactly what the watchdog framework does
in the absence of a ->set_timeout callback (see watchdog_set_timeout
in watchdog_dev.c), so remove it.Signed-off-by: Rasmus Villemoes
Reviewed-by: Guenter Roeck
Acked-by: Eric Anholt
Signed-off-by: Guenter Roeck
Signed-off-by: Wim Van Sebroeck -
These are never modified, so might as well be const.
Signed-off-by: Rasmus Villemoes
Reviewed-by: Guenter Roeck
Acked-by: Eric Anholt
Signed-off-by: Guenter Roeck
Signed-off-by: Wim Van Sebroeck
29 Dec, 2015
1 commit
-
Stopping a watchdog is a normal operation and does not warrant a log
message.Signed-off-by: Guenter Roeck
Signed-off-by: Wim Van Sebroeck
28 Sep, 2015
1 commit
-
Currently poweroff/halt results in a reboot on the Raspberry Pi.
The firmware uses the RSTS register to know which partiton to
boot from. The partiton value is spread into bits
0, 2, 4, 6, 8, 10. Partiton 63 is a special partition used by
the firmware to indicate halt.The firmware made this change in 19 Aug 2013 and was matched
by the downstream commit:
Changes for new NOOBS multi partition booting from gshSigned-off-by: Noralf Trønnes
Tested-by: Stephen Warren
Acked-by: Stephen Warren
Reviewed-by: Guenter Roeck
Signed-off-by: Wim Van Sebroeck
10 Sep, 2015
1 commit
-
/sys/class/watchdog/watchdogn/device/modalias can help to identify the
driver/module for a given watchdog node. However, many wdt devices do not
set their parent and so, we do not see an entry for device in sysfs for
such devices.This patch fixes parent of watchdog_device so that
/sys/class/watchdog/watchdogn/device is populated.Exceptions: booke, diag288, octeon, softdog and w83627hf -- They do not
have any parent. Not sure, how we can identify driver for these devices.Signed-off-by: Pratyush Anand
Reviewed-by: Johannes Thumshirn
Acked-by: Guenter Roeck
Acked-by: H Hartley Sweeten
Acked-by: Lee Jones
Acked-by: Lubomir Rintel
Acked-by: Maxime Coquelin
Acked-by: Thierry Reding
Acked-by: Viresh Kumar
Acked-by: Linus Walleij
Signed-off-by: Wim Van Sebroeck
14 May, 2015
1 commit
-
Since the WDT is what's used to drive restart and power off, it makes
more sense to keep it there, where the regs are already mapped and
definitions for them provided. Note that this means you may need to
add CONFIG_BCM2835_WDT to retain functionality of your kernel.Signed-off-by: Eric Anholt
Acked-by: Guenter Roeck
Signed-off-by: Lee Jones
20 Oct, 2014
1 commit
-
A platform_driver does not need to set an owner, it will be populated by the
driver core.Signed-off-by: Wolfram Sang
31 Mar, 2014
1 commit
-
The site-specific OOM messages are unnecessary, because they
duplicate the MM subsystem generic OOM message. For example,
k.alloc and v.alloc failures use dump_stack().Signed-off-by: Jingoo Han
Reviewed-by: Jean Delvare [for at32ap700x]
Acked-by: Lubomir Rintel [for bcm2835]
Acked-by: Viresh Kumar [for sp805_wdt]
Acked-by: Mika Westerberg [for ts72xx_wdt]
Reviewed-by: Guenter Roeck
Signed-off-by: Wim Van Sebroeck
10 Dec, 2013
1 commit
-
After commit 487722cf2 (watchdog: Get rid of MODULE_ALIAS_MISCDEV
statements) the affected drivers no longer need to include miscdevice.h.
Only exception is rt2880_wdt.c which never needed it.Signed-off-by: Guenter Roeck
Reviewed-by: Jean Delvare
Signed-off-by: Wim Van Sebroeck
18 Nov, 2013
1 commit
-
I just can't find any value in MODULE_ALIAS_MISCDEV(WATCHDOG_MINOR)
and MODULE_ALIAS_MISCDEV(TEMP_MINOR) statements.Either the device is enumerated and the driver already has a module
alias (e.g. PCI, USB etc.) that will get the right driver loaded
automatically.Or the device is not enumerated and loading its driver will lead to
more or less intrusive hardware poking. Such hardware poking should be
limited to a bare minimum, so the user should really decide which
drivers should be tried and in what order. Trying them all in
arbitrary order can't do any good.On top of that, loading that many drivers at once bloats the kernel
log. Also many drivers will stay loaded afterward, bloating the output
of "lsmod" and wasting memory. Some modules (cs5535_mfgpt which gets
loaded as a dependency) can't even be unloaded!If defining char-major-10-130 is needed then it should happen in
user-space.Signed-off-by: Jean Delvare
Acked-by: Guenter Roeck
Signed-off-by: Wim Van Sebroeck
Cc: Stephen Warren
Cc: Mike Frysinger
Cc: Wan ZongShun
Cc: Ben Dooks
Cc: Kukjin Kim
Cc: Zwane Mwaikambo
Cc: Jim Cromie
12 Jul, 2013
1 commit
-
This adds a driver for watchdog timer hardware present on Broadcom BCM2835 SoC,
used in Raspberry Pi and Roku 2 devices.Signed-off-by: Lubomir Rintel
Tested-by: Stephen Warren
Reviewed-by: Guenter Roeck
Signed-off-by: Wim Van Sebroeck
Cc: linux-rpi-kernel@lists.infradead.org
Cc: linux-watchdog@vger.kernel.org
Cc: devicetree-discuss@lists.ozlabs.org