23 Oct, 2019

1 commit

• b6dfb2477   compat_ioctl: move WDIOC handling into wdt drivers ... Browse Code »

  All watchdog drivers implement the same set of ioctl commands, and
  fortunately all of them are compatible between 32-bit and 64-bit
  architectures.

  Modern drivers always go through drivers/watchdog/wdt.c as an abstraction
  layer, but older ones implement their own file_operations on a character
  device for this.

  Move the handling from fs/compat_ioctl.c into the individual drivers.

  Note that most of the legacy drivers will never be used on 64-bit
  hardware, because they are for an old 32-bit SoC implementation, but
  doing them all at once is safer than trying to guess which ones do
  or do not need the compat_ioctl handling.

  Reviewed-by: Guenter Roeck
  Signed-off-by: Arnd Bergmann

  Arnd Bergmann

  2019-10-23 23:23:46 +0800  

31 May, 2019

1 commit

• 2874c5fd2   treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152 ... Browse Code »

  Based on 1 normalized pattern(s):

  this program is free software you can redistribute it and or modify
  it under the terms of the gnu general public license as published by
  the free software foundation either version 2 of the license or at
  your option any later version

  extracted by the scancode license scanner the SPDX license identifier

  GPL-2.0-or-later

  has been chosen to replace the boilerplate/reference in 3029 file(s).

  Signed-off-by: Thomas Gleixner
  Reviewed-by: Allison Randal
  Cc: linux-spdx@vger.kernel.org
  Link: https://lkml.kernel.org/r/20190527070032.746973796@linutronix.de
  Signed-off-by: Greg Kroah-Hartman

  Thomas Gleixner

  2019-05-31 02:26:32 +0800  

06 May, 2019

1 commit

• c5bf68fe0   *: convert stream-like files from nonseekable_open -> stream_open ... Browse Code »

  Using scripts/coccinelle/api/stream_open.cocci added in 10dce8af3422
  ("fs: stream_open - opener for stream-like files so that read and write
  can run simultaneously without deadlock"), search and convert to
  stream_open all in-kernel nonseekable_open users for which read and
  write actually do not depend on ppos and where there is no other methods
  in file_operations which assume @offset access.

  I've verified each generated change manually - that it is correct to convert -
  and each other nonseekable_open instance left - that it is either not correct
  to convert there, or that it is not converted due to current stream_open.cocci
  limitations. The script also does not convert files that should be valid to
  convert, but that currently have .llseek = noop_llseek or generic_file_llseek
  for unknown reason despite file being opened with nonseekable_open (e.g.
  drivers/input/mousedev.c)

  Among cases converted 14 were potentially vulnerable to read vs write deadlock
  (see details in 10dce8af3422):

  drivers/char/pcmcia/cm4000_cs.c:1685:7-23: ERROR: cm4000_fops: .read() can deadlock .write(); change nonseekable_open -> stream_open to fix.
  drivers/gnss/core.c:45:1-17: ERROR: gnss_fops: .read() can deadlock .write(); change nonseekable_open -> stream_open to fix.
  drivers/hid/uhid.c:635:1-17: ERROR: uhid_fops: .read() can deadlock .write(); change nonseekable_open -> stream_open to fix.
  drivers/infiniband/core/user_mad.c:988:1-17: ERROR: umad_fops: .read() can deadlock .write(); change nonseekable_open -> stream_open to fix.
  drivers/input/evdev.c:527:1-17: ERROR: evdev_fops: .read() can deadlock .write(); change nonseekable_open -> stream_open to fix.
  drivers/input/misc/uinput.c:401:1-17: ERROR: uinput_fops: .read() can deadlock .write(); change nonseekable_open -> stream_open to fix.
  drivers/isdn/capi/capi.c:963:8-24: ERROR: capi_fops: .read() can deadlock .write(); change nonseekable_open -> stream_open to fix.
  drivers/leds/uleds.c:77:1-17: ERROR: uleds_fops: .read() can deadlock .write(); change nonseekable_open -> stream_open to fix.
  drivers/media/rc/lirc_dev.c:198:1-17: ERROR: lirc_fops: .read() can deadlock .write(); change nonseekable_open -> stream_open to fix.
  drivers/s390/char/fs3270.c:488:1-17: ERROR: fs3270_fops: .read() can deadlock .write(); change nonseekable_open -> stream_open to fix.
  drivers/usb/misc/ldusb.c:310:1-17: ERROR: ld_usb_fops: .read() can deadlock .write(); change nonseekable_open -> stream_open to fix.
  drivers/xen/evtchn.c:667:8-24: ERROR: evtchn_fops: .read() can deadlock .write(); change nonseekable_open -> stream_open to fix.
  net/batman-adv/icmp_socket.c:80:1-17: ERROR: batadv_fops: .read() can deadlock .write(); change nonseekable_open -> stream_open to fix.
  net/rfkill/core.c:1146:8-24: ERROR: rfkill_fops: .read() can deadlock .write(); change nonseekable_open -> stream_open to fix.

  and the rest were just safe to convert to stream_open because their read and
  write do not use ppos at all and corresponding file_operations do not
  have methods that assume @offset file access(*):

  arch/powerpc/platforms/52xx/mpc52xx_gpt.c:631:8-24: WARNING: mpc52xx_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  arch/powerpc/platforms/cell/spufs/file.c:591:8-24: WARNING: spufs_ibox_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open.
  arch/powerpc/platforms/cell/spufs/file.c:591:8-24: WARNING: spufs_ibox_stat_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open.
  arch/powerpc/platforms/cell/spufs/file.c:591:8-24: WARNING: spufs_mbox_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open.
  arch/powerpc/platforms/cell/spufs/file.c:591:8-24: WARNING: spufs_mbox_stat_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open.
  arch/powerpc/platforms/cell/spufs/file.c:591:8-24: WARNING: spufs_wbox_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  arch/powerpc/platforms/cell/spufs/file.c:591:8-24: WARNING: spufs_wbox_stat_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open.
  arch/um/drivers/harddog_kern.c:88:8-24: WARNING: harddog_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  arch/x86/kernel/cpu/microcode/core.c:430:33-49: WARNING: microcode_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/char/ds1620.c:215:8-24: WARNING: ds1620_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/char/dtlk.c:301:1-17: WARNING: dtlk_fops: .read() and .write() have stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/char/ipmi/ipmi_watchdog.c:840:9-25: WARNING: ipmi_wdog_fops: .read() and .write() have stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/char/pcmcia/scr24x_cs.c:95:8-24: WARNING: scr24x_fops: .read() and .write() have stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/char/tb0219.c:246:9-25: WARNING: tb0219_fops: .read() and .write() have stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/firewire/nosy.c:306:8-24: WARNING: nosy_ops: .read() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/hwmon/fschmd.c:840:8-24: WARNING: watchdog_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/hwmon/w83793.c:1344:8-24: WARNING: watchdog_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/infiniband/core/ucma.c:1747:8-24: WARNING: ucma_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/infiniband/core/ucm.c:1178:8-24: WARNING: ucm_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/infiniband/core/uverbs_main.c:1086:8-24: WARNING: uverbs_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/input/joydev.c:282:1-17: WARNING: joydev_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/pci/switch/switchtec.c:393:1-17: WARNING: switchtec_fops: .read() and .write() have stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/platform/chrome/cros_ec_debugfs.c:135:8-24: WARNING: cros_ec_console_log_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/rtc/rtc-ds1374.c:470:9-25: WARNING: ds1374_wdt_fops: .read() and .write() have stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/rtc/rtc-m41t80.c:805:9-25: WARNING: wdt_fops: .read() and .write() have stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/s390/char/tape_char.c:293:2-18: WARNING: tape_fops: .read() and .write() have stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/s390/char/zcore.c:194:8-24: WARNING: zcore_reipl_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/s390/crypto/zcrypt_api.c:528:8-24: WARNING: zcrypt_fops: .read() and .write() have stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/spi/spidev.c:594:1-17: WARNING: spidev_fops: .read() and .write() have stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/staging/pi433/pi433_if.c:974:1-17: WARNING: pi433_fops: .read() and .write() have stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/acquirewdt.c:203:8-24: WARNING: acq_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/advantechwdt.c:202:8-24: WARNING: advwdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/alim1535_wdt.c:252:8-24: WARNING: ali_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/alim7101_wdt.c:217:8-24: WARNING: wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/ar7_wdt.c:166:8-24: WARNING: ar7_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/at91rm9200_wdt.c:113:8-24: WARNING: at91wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/ath79_wdt.c:135:8-24: WARNING: ath79_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/bcm63xx_wdt.c:119:8-24: WARNING: bcm63xx_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/cpu5wdt.c:143:8-24: WARNING: cpu5wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/cpwd.c:397:8-24: WARNING: cpwd_fops: .read() and .write() have stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/eurotechwdt.c:319:8-24: WARNING: eurwdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/f71808e_wdt.c:528:8-24: WARNING: watchdog_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/gef_wdt.c:232:8-24: WARNING: gef_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/geodewdt.c:95:8-24: WARNING: geodewdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/ib700wdt.c:241:8-24: WARNING: ibwdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/ibmasr.c:326:8-24: WARNING: asr_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/indydog.c:80:8-24: WARNING: indydog_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/intel_scu_watchdog.c:307:8-24: WARNING: intel_scu_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/iop_wdt.c:104:8-24: WARNING: iop_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/it8712f_wdt.c:330:8-24: WARNING: it8712f_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/ixp4xx_wdt.c:68:8-24: WARNING: ixp4xx_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/ks8695_wdt.c:145:8-24: WARNING: ks8695wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/m54xx_wdt.c:88:8-24: WARNING: m54xx_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/machzwd.c:336:8-24: WARNING: zf_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/mixcomwd.c:153:8-24: WARNING: mixcomwd_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/mtx-1_wdt.c:121:8-24: WARNING: mtx1_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/mv64x60_wdt.c:136:8-24: WARNING: mv64x60_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/nuc900_wdt.c:134:8-24: WARNING: nuc900wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/nv_tco.c:164:8-24: WARNING: nv_tco_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/pc87413_wdt.c:289:8-24: WARNING: pc87413_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/pcwd.c:698:8-24: WARNING: pcwd_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/pcwd.c:737:8-24: WARNING: pcwd_temp_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/pcwd_pci.c:581:8-24: WARNING: pcipcwd_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/pcwd_pci.c:623:8-24: WARNING: pcipcwd_temp_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/pcwd_usb.c:488:8-24: WARNING: usb_pcwd_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/pcwd_usb.c:527:8-24: WARNING: usb_pcwd_temperature_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/pika_wdt.c:121:8-24: WARNING: pikawdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/pnx833x_wdt.c:119:8-24: WARNING: pnx833x_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/rc32434_wdt.c:153:8-24: WARNING: rc32434_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/rdc321x_wdt.c:145:8-24: WARNING: rdc321x_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/riowd.c:79:1-17: WARNING: riowd_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/sa1100_wdt.c:62:8-24: WARNING: sa1100dog_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/sbc60xxwdt.c:211:8-24: WARNING: wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/sbc7240_wdt.c:139:8-24: WARNING: wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/sbc8360.c:274:8-24: WARNING: sbc8360_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/sbc_epx_c3.c:81:8-24: WARNING: epx_c3_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/sbc_fitpc2_wdt.c:78:8-24: WARNING: fitpc2_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/sb_wdog.c:108:1-17: WARNING: sbwdog_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/sc1200wdt.c:181:8-24: WARNING: sc1200wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/sc520_wdt.c:261:8-24: WARNING: wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/sch311x_wdt.c:319:8-24: WARNING: sch311x_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/scx200_wdt.c:105:8-24: WARNING: scx200_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/smsc37b787_wdt.c:369:8-24: WARNING: wb_smsc_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/w83877f_wdt.c:227:8-24: WARNING: wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/w83977f_wdt.c:301:8-24: WARNING: wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/wafer5823wdt.c:200:8-24: WARNING: wafwdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/watchdog_dev.c:828:8-24: WARNING: watchdog_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/wdrtas.c:379:8-24: WARNING: wdrtas_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/wdrtas.c:445:8-24: WARNING: wdrtas_temp_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/wdt285.c:104:1-17: WARNING: watchdog_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/wdt977.c:276:8-24: WARNING: wdt977_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/wdt.c:424:8-24: WARNING: wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/wdt.c:484:8-24: WARNING: wdt_temp_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/wdt_pci.c:464:8-24: WARNING: wdtpci_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/wdt_pci.c:527:8-24: WARNING: wdtpci_temp_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open.
  net/batman-adv/log.c:105:1-17: WARNING: batadv_log_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open.
  sound/core/control.c:57:7-23: WARNING: snd_ctl_f_ops: .read() has stream semantic; safe to change nonseekable_open -> stream_open.
  sound/core/rawmidi.c:385:7-23: WARNING: snd_rawmidi_f_ops: .read() and .write() have stream semantic; safe to change nonseekable_open -> stream_open.
  sound/core/seq/seq_clientmgr.c:310:7-23: WARNING: snd_seq_f_ops: .read() and .write() have stream semantic; safe to change nonseekable_open -> stream_open.
  sound/core/timer.c:1428:7-23: WARNING: snd_timer_f_ops: .read() has stream semantic; safe to change nonseekable_open -> stream_open.

  One can also recheck/review the patch via generating it with explanation comments included via

  $ make coccicheck MODE=patch COCCI=scripts/coccinelle/api/stream_open.cocci SPFLAGS="-D explain"

  (*) This second group also contains cases with read/write deadlocks that
  stream_open.cocci don't yet detect, but which are still valid to convert to
  stream_open since ppos is not used. For example drivers/pci/switch/switchtec.c
  calls wait_for_completion_interruptible() in its .read, but stream_open.cocci
  currently detects only "wait_event*" as blocking.

  Cc: Michael Kerrisk
  Cc: Yongzhi Pan
  Cc: Jonathan Corbet
  Cc: David Vrabel
  Cc: Juergen Gross
  Cc: Miklos Szeredi
  Cc: Tejun Heo
  Cc: Kirill Tkhai
  Cc: Arnd Bergmann
  Cc: Christoph Hellwig
  Cc: Greg Kroah-Hartman
  Cc: Julia Lawall
  Cc: Nikolaus Rath
  Cc: Han-Wen Nienhuys
  Cc: Anatolij Gustschin
  Cc: Jeff Dike
  Cc: Richard Weinberger
  Cc: Anton Ivanov
  Cc: Borislav Petkov
  Cc: Thomas Gleixner
  Cc: Ingo Molnar
  Cc: "James R. Van Zandt"
  Cc: Corey Minyard
  Cc: Harald Welte
  Acked-by: Lubomir Rintel [scr24x_cs]
  Cc: Stefan Richter
  Cc: Johan Hovold
  Cc: David Herrmann
  Cc: Jiri Kosina
  Cc: Benjamin Tissoires
  Cc: Jean Delvare
  Acked-by: Guenter Roeck [watchdog/* hwmon/*]
  Cc: Rudolf Marek
  Cc: Dmitry Torokhov
  Cc: Karsten Keil
  Cc: Jacek Anaszewski
  Cc: Pavel Machek
  Cc: Mauro Carvalho Chehab
  Cc: Kurt Schwemmer
  Acked-by: Logan Gunthorpe [drivers/pci/switch/switchtec]
  Acked-by: Bjorn Helgaas [drivers/pci/switch/switchtec]
  Cc: Benson Leung
  Acked-by: Enric Balletbo i Serra [platform/chrome]
  Cc: Alessandro Zummo
  Acked-by: Alexandre Belloni [rtc/*]
  Cc: Mark Brown
  Cc: Wim Van Sebroeck
  Cc: Florian Fainelli
  Cc: bcm-kernel-feedback-list@broadcom.com
  Cc: Wan ZongShun
  Cc: Zwane Mwaikambo
  Cc: Marek Lindner
  Cc: Simon Wunderlich
  Cc: Antonio Quartulli
  Cc: "David S. Miller"
  Cc: Johannes Berg
  Cc: Jaroslav Kysela
  Cc: Takashi Iwai
  Signed-off-by: Kirill Smelkov

  Kirill Smelkov

  2019-05-06 22:46:41 +0800  

22 Nov, 2017

1 commit

• 24ed960ab   treewide: Switch DEFINE_TIMER callbacks to struct timer_list * ... Browse Code »

  This changes all DEFINE_TIMER() callbacks to use a struct timer_list
  pointer instead of unsigned long. Since the data argument has already been
  removed, none of these callbacks are using their argument currently, so
  this renames the argument to "unused".

  Done using the following semantic patch:

  @match_define_timer@
  declarer name DEFINE_TIMER;
  identifier _timer, _callback;
  @@

  DEFINE_TIMER(_timer, _callback);

  @change_callback depends on match_define_timer@
  identifier match_define_timer._callback;
  type _origtype;
  identifier _origarg;
  @@

  void
  -_callback(_origtype _origarg)
  +_callback(struct timer_list *unused)
  { ... }

  Signed-off-by: Kees Cook

  Kees Cook

  2017-11-22 07:57:05 +0800  

05 Oct, 2017

1 commit

• 1d27e3e22   timer: Remove expires and data arguments from DEFINE_TIMER ... Browse Code »

  Drop the arguments from the macro and adjust all callers with the
  following script:

  perl -pi -e 's/DEFINE_TIMER\((.*), 0, 0\);/DEFINE_TIMER($1);/g;' \
  $(git grep DEFINE_TIMER | cut -d: -f1 | sort -u | grep -v timer.h)

  Signed-off-by: Kees Cook
  Acked-by: Geert Uytterhoeven # for m68k parts
  Acked-by: Guenter Roeck # for watchdog parts
  Acked-by: David S. Miller # for networking parts
  Acked-by: Greg Kroah-Hartman
  Acked-by: Kalle Valo # for wireless parts
  Acked-by: Arnd Bergmann
  Cc: linux-mips@linux-mips.org
  Cc: Petr Mladek
  Cc: Benjamin Herrenschmidt
  Cc: Lai Jiangshan
  Cc: Sebastian Reichel
  Cc: Kalle Valo
  Cc: Paul Mackerras
  Cc: Pavel Machek
  Cc: linux1394-devel@lists.sourceforge.net
  Cc: Chris Metcalf
  Cc: linux-s390@vger.kernel.org
  Cc: linux-wireless@vger.kernel.org
  Cc: "James E.J. Bottomley"
  Cc: Wim Van Sebroeck
  Cc: Michael Ellerman
  Cc: Ursula Braun
  Cc: Viresh Kumar
  Cc: Harish Patil
  Cc: Stephen Boyd
  Cc: Michael Reed
  Cc: Manish Chopra
  Cc: Len Brown
  Cc: Arnd Bergmann
  Cc: linux-pm@vger.kernel.org
  Cc: Heiko Carstens
  Cc: Tejun Heo
  Cc: Julian Wiedmann
  Cc: John Stultz
  Cc: Mark Gross
  Cc: linux-watchdog@vger.kernel.org
  Cc: linux-scsi@vger.kernel.org
  Cc: "Martin K. Petersen"
  Cc: Greg Kroah-Hartman
  Cc: "Rafael J. Wysocki"
  Cc: Oleg Nesterov
  Cc: Ralf Baechle
  Cc: Stefan Richter
  Cc: Guenter Roeck
  Cc: netdev@vger.kernel.org
  Cc: Martin Schwidefsky
  Cc: Andrew Morton
  Cc: linuxppc-dev@lists.ozlabs.org
  Cc: Sudip Mukherjee
  Link: https://lkml.kernel.org/r/1507159627-127660-11-git-send-email-keescook@chromium.org
  Signed-off-by: Thomas Gleixner

  Kees Cook

  2017-10-05 21:01:20 +0800  

18 Nov, 2013

1 commit

• 487722cf2   watchdog: Get rid of MODULE_ALIAS_MISCDEV statements ... Browse Code »

  I just can't find any value in MODULE_ALIAS_MISCDEV(WATCHDOG_MINOR)
  and MODULE_ALIAS_MISCDEV(TEMP_MINOR) statements.

  Either the device is enumerated and the driver already has a module
  alias (e.g. PCI, USB etc.) that will get the right driver loaded
  automatically.

  Or the device is not enumerated and loading its driver will lead to
  more or less intrusive hardware poking. Such hardware poking should be
  limited to a bare minimum, so the user should really decide which
  drivers should be tried and in what order. Trying them all in
  arbitrary order can't do any good.

  On top of that, loading that many drivers at once bloats the kernel
  log. Also many drivers will stay loaded afterward, bloating the output
  of "lsmod" and wasting memory. Some modules (cs5535_mfgpt which gets
  loaded as a dependency) can't even be unloaded!

  If defining char-major-10-130 is needed then it should happen in
  user-space.

  Signed-off-by: Jean Delvare
  Acked-by: Guenter Roeck
  Signed-off-by: Wim Van Sebroeck
  Cc: Stephen Warren
  Cc: Mike Frysinger
  Cc: Wan ZongShun
  Cc: Ben Dooks
  Cc: Kukjin Kim
  Cc: Zwane Mwaikambo
  Cc: Jim Cromie

  Jean Delvare

  2013-11-18 02:38:13 +0800  

29 Nov, 2012

1 commit

• 1d1313686   watchdog: remove use of __devinitdata ... Browse Code »

  CONFIG_HOTPLUG is going away as an option so __devinitdata is no
  longer needed.

  Signed-off-by: Bill Pemberton
  Cc: Wim Van Sebroeck
  Cc: Grant Likely
  Cc: Rob Herring
  Signed-off-by: Greg Kroah-Hartman

  Bill Pemberton

  2012-11-29 04:00:24 +0800  

28 Mar, 2012

2 commits

• 86a1e1896   watchdog: nowayout is bool ... Browse Code »

  nowayout is actually a boolean value.
  So make it bool for all watchdog device drivers.

  Signed-off-by: Wim Van Sebroeck

  Wim Van Sebroeck

  2012-03-28 02:06:02 +0800  
• 27c766aaa   watchdog: Use pr_<fmt> and pr_<level> ... Browse Code »

  Use the current logging styles.

  Make sure all output has a prefix.
  Add missing newlines.
  Remove now unnecessary PFX, NAME, and miscellaneous other #defines.
  Coalesce formats.

  Signed-off-by: Joe Perches
  Signed-off-by: Wim Van Sebroeck

  Joe Perches

  2012-03-28 01:59:26 +0800  

07 Mar, 2010

1 commit

• 42747d712   [WATCHDOG] watchdog_info constify ... Browse Code »

  make the watchdog_info struct const where possible.

  Signed-off-by: Wim Van Sebroeck

  Wim Van Sebroeck

  2010-03-07 18:30:57 +0800  

06 Aug, 2008

1 commit

• 0c06090c9   [WATCHDOG] Coding style - Indentation - part 2 ... Browse Code »

  This brings the watchdog drivers into line with coding style.
  This patch takes cares of the indentation as described in chapter 1.
  Main changes:
  * Re-structure the ioctl switch call for all drivers as follows:
  switch (cmd) {
  case WDIOC_GETSUPPORT:
  case WDIOC_GETSTATUS:
  case WDIOC_GETBOOTSTATUS:
  case WDIOC_GETTEMP:
  case WDIOC_SETOPTIONS:
  case WDIOC_KEEPALIVE:
  case WDIOC_SETTIMEOUT:
  case WDIOC_GETTIMEOUT:
  case WDIOC_GETTIMELEFT:
  default:
  }

  This to make the migration from the drivers to the uniform watchdog
  device driver easier in the future.

  Signed-off-by: Wim Van Sebroeck

  Wim Van Sebroeck

  2008-08-06 21:21:09 +0800  

14 Jun, 2008

1 commit

• 393096453   [WATCHDOG 25/57] mixcomwd: coding style locking, unlocked_ioctl ... Browse Code »

  Review and switch to unlocked_ioctl

  Signed-off-by: Alan Cox
  Signed-off-by: Wim Van Sebroeck

  Alan Cox

  2008-06-14 03:35:42 +0800  

18 Oct, 2007

1 commit

• b7e04f8c6   mv watchdog tree under drivers ... Browse Code »

  move watchdog tree from drivers/char/watchdog to drivers/watchdog.

  Signed-off-by: Wim Van Sebroeck

  Wim Van Sebroeck

  2007-10-18 18:39:03 +0800