06 Jan, 2021

1 commit

  • [ Upstream commit 8711071e9700b67045fe5518161d63f7a03e3c9e ]

    pm_runtime_get_sync() will increment pm usage counter even it
    failed. Forgetting to call pm_runtime_put_noidle will result
    in reference leak in rti_wdt_probe, so we should fix it.

    Signed-off-by: Zhang Qilong
    Reviewed-by: Guenter Roeck
    Link: https://lore.kernel.org/r/20201030154909.100023-1-zhangqilong3@huawei.com
    Signed-off-by: Guenter Roeck
    Signed-off-by: Wim Van Sebroeck
    Signed-off-by: Sasha Levin

    Zhang Qilong
     

14 Oct, 2020

1 commit

  • Common pattern of handling deferred probe can be simplified with
    dev_err_probe(). Less code and the error value gets printed.

    Signed-off-by: Krzysztof Kozlowski
    Reviewed-by: Guenter Roeck
    Link: https://lore.kernel.org/r/20200901153141.18960-3-krzk@kernel.org
    Signed-off-by: Guenter Roeck
    Signed-off-by: Wim Van Sebroeck

    Krzysztof Kozlowski
     

06 Aug, 2020

2 commits

  • PM runtime should be disabled in the fail path of probe and when
    the driver is removed.

    Fixes: 2d63908bdbfb ("watchdog: Add K3 RTI watchdog support")
    Signed-off-by: Tero Kristo
    Reviewed-by: Guenter Roeck
    Link: https://lore.kernel.org/r/20200717132958.14304-5-t-kristo@ti.com
    Signed-off-by: Guenter Roeck
    Signed-off-by: Wim Van Sebroeck

    Tero Kristo
     
  • If the RTI watchdog is running already during probe, the driver must
    configure itself to match the HW. Window size and timeout is probed from
    hardware, and the last keepalive ping is adjusted to match it also.

    Signed-off-by: Tero Kristo
    Reviewed-by: Guenter Roeck
    Link: https://lore.kernel.org/r/20200717132958.14304-4-t-kristo@ti.com
    Signed-off-by: Guenter Roeck
    Signed-off-by: Wim Van Sebroeck

    Tero Kristo
     

01 Apr, 2020

1 commit

  • Texas Instruments K3 SoCs contain an RTI (Real Time Interrupt) module
    which can be used as a watchdog. This IP provides a support for
    windowed watchdog mode, in which the watchdog must be petted within
    a certain time window. If it is petted either too soon, or too late,
    a watchdog error will be triggered.

    Signed-off-by: Tero Kristo
    Reviewed-by: Guenter Roeck
    Link: https://lore.kernel.org/r/20200312095808.19907-4-t-kristo@ti.com
    Signed-off-by: Guenter Roeck
    Signed-off-by: Wim Van Sebroeck

    Tero Kristo