01 Nov, 2005
1 commit
-
Jeff Garzik points out that this was wrong: we need to
disable local interrupts while holding KM_IRQ0 due to IRQ sharing.And holding interrupts off during a big PIO opration is expensive, so we only
want to do that if we know the page was highmem.So revert commit 17fd47ab4d33e764216b87006d8118fa050b4c92
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
31 Oct, 2005
9 commits
-
Manual #include fixups for clashes - there may be some unnecessary
-
A lot of power packed into a little patch.
This change eliminates the sharing between our controller-wide spinlock
and the SCSI core's Scsi_Host lock. As the locking in libata was
already highly compartmentalized, always referencing our own lock, and
never scsi_host::host_lock.As a side effect, this change eliminates a deadlock from calling
scsi_finish_command() while inside our spinlock. -
Integrate ata_exec() and ata_tf_to_host() into their only caller,
ata_bus_edd().Rename ata_tf_to_host_nolock() to ata_tf_to_host().
This makes locking a bit easier to review, and may help pave the way for
future changes. -
I recently picked up my older work to remove unnecessary #includes of
sched.h, starting from a patch by Dave Jones to not include sched.h
from module.h. This reduces the number of indirect includes of sched.h
by ~300. Another ~400 pointless direct includes can be removed after
this disentangling (patch to follow later).
However, quite a few indirect includes need to be fixed up for this.In order to feed the patches through -mm with as little disturbance as
possible, I've split out the fixes I accumulated up to now (complete for
i386 and x86_64, more archs to follow later) and post them before the real
patch. This way this large part of the patch is kept simple with only
adding #includes, and all hunks are independent of each other. So if any
hunk rejects or gets in the way of other patches, just drop it. My scripts
will pick it up again in the next round.Signed-off-by: Tim Schmielau
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds -
(akpm: I don't do typo patches, but one of these is in a printk string)
Signed-off-by: Jean Delvare
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds -
It's not necessary to test PageHighmem in here - kmap_atomic() does the right
thing.Cc: Bartlomiej Zolnierkiewicz
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds -
A few drivers were not following the standard meme of printing out
their driver name and version at module load time; this is fixed
as well.
30 Oct, 2005
17 commits
-
ata_pci_init_one() receives an array of struct ata_port_info. Recent
updates to the code had always obtained port information from
array element 0, rather than array element N.Change to avoid hardcoding port_info[0], thereby restoring proper
hardware information to secondary legacy ports. -
The second argument to ata_qc_complete() was being used for two
purposes: communicate the ATA Status register to the completion
function, and indicate an error. On legacy PCI IDE hardware, the latter
is often implicit in the former. On more modern hardware, the driver
often completely emulated a Status register value, passing ATA_ERR as an
indication that something went wrong.Now that previous code changes have eliminated the need to use drv_stat
arg to communicate the ATA Status register value, we can convert it to a
mask of possible error classes.This will lead to more flexible error handling in the future.
-
Remove PageReserved() calls from core code by tightening VM_RESERVED
handling in mm/ to cover PageReserved functionality.PageReserved special casing is removed from get_page and put_page.
All setting and clearing of PageReserved is retained, and it is now flagged
in the page_alloc checks to help ensure we don't introduce any refcount
based freeing of Reserved pages.MAP_PRIVATE, PROT_WRITE of VM_RESERVED regions is tentatively being
deprecated. We never completely handled it correctly anyway, and is be
reintroduced in future if required (Hugh has a proof of concept).Once PageReserved() calls are removed from kernel/power/swsusp.c, and all
arch/ and driver code, the Set and Clear calls, and the PG_reserved bit can
be trivially removed.Last real user of PageReserved is swsusp, which uses PageReserved to
determine whether a struct page points to valid memory or not. This still
needs to be addressed (a generic page_is_ram() should work).A last caveat: the ZERO_PAGE is now refcounted and managed with rmap (and
thus mapcounted and count towards shared rss). These writes to the struct
page could cause excessive cacheline bouncing on big systems. There are a
number of ways this could be addressed if it is an issue.Signed-off-by: Nick Piggin
Refcount bug fix for filemap_xip.c
Signed-off-by: Carsten Otte
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds -
We now depend on ->tf_read() to provide us with the contents
of the Error shadow register. -
This patch uses sg_set_buf/sg_init_one in some places where it was
duplicated.Signed-off-by: David Hardeman
Cc: James Bottomley
Cc: Greg KH
Cc: "David S. Miller"
Cc: Jeff Garzik
Signed-off-by: Andrew Morton
Signed-off-by: Herbert Xu -
These should really be addresses obtained with ioremap() or some
bus-specific backend, but for now...Signed-off-by: Ralf Baechle
-
trivial iomem annotations + missing memcpy_fromio() caught by
those
Signed-off-by: Al Viro
Signed-off-by: Jeff Garzik -
libata-core cleanups:
- use kzalloc() instead of kmalloc() + memset();
- use one exit path in ata_device_add();Signed-off-by: Randy Dunlap
Signed-off-by: Jeff Garzik -
Convert everyone who uses platform_bus_type to include
linux/platform_device.h.Signed-off-by: Russell King
Acked-by: Greg Kroah-Hartman -
We want ->tf_read() to get a complete snapshot of all taskfile
registers, without requiring the callers to manually call
ata_chk_status() and ata_chk_err() themselves.This also fixes a minor bug in sata_vsc where the lower bits of the
feature register were incorrectly placed in the HOB (high order bits)
portion of struct ata_taskfile. -
trivial iomem annotations + missing memcpy_fromio() caught by those
Signed-off-by: Al Viro
Signed-off-by: Linus Torvalds
29 Oct, 2005
13 commits
-
Convert megaraid to use pci_driver's shutdown method rather than
the generic device_driver shutdown method.Signed-off-by: Russell King
Signed-off-by: Greg Kroah-Hartman -
IPR scsi adapter have an exposure today in that they issue BIST to the adapter
to reset the card. If, during the time it takes to complete BIST, userspace
attempts to access PCI config space, the host bus bridge will master abort the
access since the ipr adapter does not respond on the PCI bus for a brief
period of time when running BIST. On PPC64 hardware, this master abort
results in the host PCI bridge isolating that PCI device from the rest of the
system, making the device unusable until Linux is rebooted. This patch makes
use of some newly added PCI layer APIs that allow for protection from
userspace accessing config space of a device in scenarios such as this.Signed-off-by: Brian King
Cc: Benjamin Herrenschmidt
Cc: James Bottomley
Signed-off-by: Andrew Morton
Signed-off-by: Greg Kroah-Hartmandrivers/scsi/ipr.c | 2 ++
1 file changed, 2 insertions(+) -
I'm using this card in a RAID1 with 2 new SATA drives with no problems.
Card - SATA 300 TX2plus PDC40775 (3d73)
Signed-off-by: Ed Kear
Signed-off-by: Jeff Garzik -
Contributed by Daniel Mueller @ Siemens AG.
-
- move default mode pages to the front of libata-scsi.c
so various functions can access them
- partial annotation of these pages, point out divergence
from sat-r06
- replace various mode page magic numbers with defines
- strengthen MODE SENSE command decoding: handle DBD
bit in cdb, yield block descriptor (per sat-r06) and
handle mode sub pagesSigned-off-by: Douglas Gilbert
Signed-off-by: Jeff Garzik -
Changes mostly from Mark Lord.
- fix bugs in probe-time error handling
- only complete qc if not NULL
- check port-level polling flags -
The previous patch adding the ability to nest struct class_device
changed the paramaters to the call class_device_create(). This patch
fixes up all in-kernel users of the function.Signed-off-by: Greg Kroah-Hartman
-
Driver core: pass interface to class intreface methods
Pass interface as argument to add() and remove() class interface
methods. This way a subsystem can implement generic add/remove
handlers and then call interface-specific ones.Signed-off-by: Dmitry Torokhov
Signed-off-by: Greg Kroah-Hartman
