24 Dec, 2010
25 commits
-
The call to flush_scheduled_work() in do_initcalls() is there to make
sure all works queued to system_wq by initcalls finish before the init
sections are dropped.However, the call doesn't make much sense at this point - there
already are multiple different workqueues and different subsystems are
free to create and use their own. Ordering requirements are and
should be expressed explicitly.Drop the call to prepare for the deprecation and removal of
flush_scheduled_work().Andrew suggested adding sanity check where the workqueue code checks
whether any pending or running work has the work function in the init
text section. However, checking this for running works requires the
worker to keep track of the current function being executed, and
checking only the pending works will miss most cases. As a violation
will almost always be caught by the usual page fault mechanism, I
don't think it would be worthwhile to make the workqueue code track
extra state just for this.Signed-off-by: Tejun Heo
Cc: Andrew Morton -
flush_scheduled_work() is deprecated and scheduled to be removed.
* tape_3590: Create and use tape_3590_wq instead of the system_wq.
* tape_block: Directly flush requeue_task on cleanup instead of using
flush_scheduled_work().Signed-off-by: Tejun Heo
Cc: Martin Schwidefsky
Cc: Heiko Carstens
Cc: linux390@de.ibm.com
Cc: linux-s390@vger.kernel.org -
flush_scheduled_work() is deprecated and scheduled to be removed. On
removal, directly cancel the work, and flush the uie_task in
rtc-dev.c::clear_uie().Signed-off-by: Tejun Heo
Cc: Alessandro Zummo
Cc: rtc-linux@googlegroups.com -
Workqueue creation API has been updated and flush_scheduled_work() is
deprecated and scheduled to be removed.* core/core.c: Use alloc_ordered_workqueue() instead of
create_singlethread_workqueue(). This removes an unnecessary
rescuer.* host/omap.c: Create, use and flush mmc_omap_wq instead of the
system_wq.* Flush host->mmc_carddetect_work directly on removal instead of using
flush_scheduled_work().Signed-off-by: Tejun Heo
Cc: Chris Ball
Cc: linux-mmc@vger.kernel.org -
flush_scheduled_work() is deprecated and scheduled to be removed.
* In menelaus, flush menelaus->work directly on probe failure. Also,
make sure the work isn't running on removal.* In tps65010, cancel_delayed_work() + flush_scheduled_work() ->
cancel_delayed_work_sync(). While at it, remove unnecessary (void)
casts on return value, and use schedule_delayed_work() and
to_delayed_work() instead of using delayed_work's internal work
field.Signed-off-by: Tejun Heo
Cc: Samuel Ortiz -
flush_scheduled_work() is deprecated and scheduled to be removed.
* Flush the used works directly.
* Replace the deprecated cancel_rearming_delayed_work() +
flush_scheduled_work() -> cancel_delayed_work_sync().* Make sure mantis->uart_work isn't running on exit.
Signed-off-by: Tejun Heo
Cc: Mauro Carvalho Chehab
Cc: linux-media@vger.kernel.org -
flush_scheduled_work() is deprecated and scheduled to be removed.
Directly flush led->work on removal instead.Signed-off-by: Tejun Heo
Cc: Richard Purdie -
flush_scheduled_work() is deprecated and scheduled to be removed.
Directly flush ch->workq when freeing channel and cancel it on
release.Signed-off-by: Tejun Heo
Cc: Karsten Keil
Cc: netdev@vger.kernel.org -
flush_scheduled_work() is deprecated and scheduled to be removed.
Directly flush ams_info.worker on detach instead.Signed-off-by: Tejun Heo
-
flush_scheduled_work() is deprecated and scheduled to be removed.
Directly flush info->deferred_work on removal instead.Signed-off-by: Tejun Heo
Cc: Thomas Hellstrom -
flush_scheduled_work() is deprecated and scheduled to be removed.
Directly flush chip->work instead.Signed-off-by: Tejun Heo
Cc: Debora Velarde
Cc: Rajiv Andrade -
flush_scheduled_work() is deprecated and scheduled to be removed.
Directly flush sonypi_device.input_work on removal instead.Signed-off-by: Tejun Heo
Cc: Mattia Dongili -
flush_scheduled_work() is deprecated and scheduled to be removed.
Directly cancel hp->writer and flush hp->handshaker instead.Signed-off-by: Tejun Heo
Cc: Benjamin Herrenschmidt
Cc: Paul Mackerras -
flush_scheduled_work() is deprecated and scheduled to be removed.
Directly flush info->work instead.Signed-off-by: Tejun Heo
Cc: Jeremy Fitzhardinge
Cc: Konrad Rzeszutek Wilk -
flush_scheduled_work() is deprecated and scheduled to be removed.
Directly flush work on removal instead.Signed-off-by: Tejun Heo
Cc: Jens Axboe -
flush_scheduled_work() is deprecated and scheduled to be removed.
Directly flush floppy_work instead.Signed-off-by: Tejun Heo
Cc: Jens Axboe -
flush_scheduled_work() is deprecated and scheduled to be removed.
Directly flush psw->work on removal instead.Signed-off-by: Tejun Heo
Cc: Paul Mundt
Cc: linux-sh@vger.kernel.org -
flush_scheduled_work() is deprecated and scheduled to be removed.
Directly flush toggle_charger and sharpsl_bat works on suspend
instead.Signed-off-by: Tejun Heo
Cc: Russell King -
flush_scheduled_work() is deprecated and scheduled to be removed.
Directly flush the used works on stop instead.Signed-off-by: Tejun Heo
Cc: Petr Vandrovec -
Make ttm_bo::ttm_bo_device_release call cancel_delayed_work_sync()
instead of calling cancel_delayed_work() followed by
flush_scheduled_work().This is to prepare for the deprecation and removal of
flush_scheduled_work().Signed-off-by: Tejun Heo
Cc:: Thomas Hellstrom
Cc:: Dave Airlie -
flush_scheduled_work() is deprecated and scheduled to be removed.
Directly flush the used works instead.Signed-off-by: Tejun Heo
Acked-by: Jiri Kosina
Acked-by: David Sterba -
flush_scheduled_work() is deprecated and scheduled to be removed.
* cancel_delayed_work() + flush_schedule_work() ->
cancel_delayed_work_sync().* flush qs->qs_work directly on exit instead.
Signed-off-by: Tejun Heo
Acked-by: Joel Becker
Cc: Mark Fasheh -
flush_scheduled_work() is deprecated and scheduled to be removed.
Directly flush dst->link_poll_work on remove instead.Signed-off-by: Tejun Heo
Acked-by: Lennert Buytenhek -
flush_scheduled_work() is deprecated and will be removed. Because
kcapi uses fire-and-forget type works, it's impossible to flush each
work explicitly. Create and use a dedicated workqueue instead.Please note that with recent workqueue changes, each workqueue doesn't
reserve a lot of resources and using it as a flush domain is fine.Signed-off-by: Tejun Heo
Acked-by: Jan Kiszka -
capidrv_init() could leave capictr notifier dangling after init
failure. Fix it.Signed-off-by: Tejun Heo
Acked-by: Jan Kiszka
21 Dec, 2010
1 commit
-
Currently, destroy_workqueue() makes the workqueue deny all new
queueing by setting WQ_DYING and flushes the workqueue once before
proceeding with destruction; however, there are cases where work items
queue more related work items. Currently, such users need to
explicitly flush the workqueue multiple times depending on the
possible depth of such chained queueing.This patch updates the queueing path such that a work item can queue
further work items on the same workqueue even when WQ_DYING is set.
The flush on destruction is automatically retried until the workqueue
is empty. This guarantees that the workqueue is empty on destruction
while allowing chained queueing.The flush retry logic whines if it takes too many retries to drain the
workqueue.Signed-off-by: Tejun Heo
Cc: James Bottomley
15 Dec, 2010
2 commits
-
There's no in-kernel user left for these two obsolete functions. Mark
them deprecated and schedule for removal during 2.6.39 cycle.Signed-off-by: Tejun Heo
Acked-by: David S. Miller -
cancel_rearming_delayed_work[queue]() has been superceded by
cancel_delayed_work_sync() quite some time ago. Convert all the
in-kernel users. The conversions are completely equivalent and
trivial.Signed-off-by: Tejun Heo
Acked-by: "David S. Miller"
Acked-by: Greg Kroah-Hartman
Acked-by: Evgeniy Polyakov
Cc: Jeff Garzik
Cc: Benjamin Herrenschmidt
Cc: Mauro Carvalho Chehab
Cc: netdev@vger.kernel.org
Cc: Anton Vorontsov
Cc: David Woodhouse
Cc: "J. Bruce Fields"
Cc: Neil Brown
Cc: Alex Elder
Cc: xfs-masters@oss.sgi.com
Cc: Christoph Lameter
Cc: Pekka Enberg
Cc: Andrew Morton
Cc: netfilter-devel@vger.kernel.org
Cc: Trond Myklebust
Cc: linux-nfs@vger.kernel.org
14 Dec, 2010
2 commits
-
Running the annotate branch profiler on three boxes, including my
main box that runs firefox, evolution, xchat, and is part of the distcc farm,
showed this with the likelys in the workqueue code:correct incorrect % Function File Line
------- --------- - -------- ---- ----
96 996253 99 wq_worker_sleeping workqueue.c 703
96 996247 99 wq_worker_waking_up workqueue.c 677The likely()s in this case were assuming that WORKER_NOT_RUNNING will
most likely be false. But this is not the case. The reason is
(and shown by adding trace_printks and testing it) that most of the time
WORKER_PREP is set.In worker_thread() we have:
worker_clr_flags(worker, WORKER_PREP);
[ do work stuff ]
worker_set_flags(worker, WORKER_PREP, false);
(that 'false' means not to wake up an idle worker)
The wq_worker_sleeping() is called from schedule when a worker thread
is putting itself to sleep. Which happens most of the time outside
of that [ do work stuff ].The wq_worker_waking_up is called by the wakeup worker code, which
is also callod outside that [ do work stuff ].Thus, the likely and unlikely used by those two functions are actually
backwards.Remove the annotation and let gcc figure it out.
Acked-by: Tejun Heo
Signed-off-by: Steven Rostedt
Signed-off-by: Tejun Heo -
Signed-off-by: Tejun Heo
26 Nov, 2010
1 commit
-
I found a trivial bug on initialization of workqueue.
Current init_workqueues doesn't check the result of
allocation of system_unbound_wq, this should be checked
like other queues.Signed-off-by: Hitoshi Mitake
Cc: Arjan van de Ven
Cc: David Howells
Signed-off-by: Tejun Heo
25 Nov, 2010
9 commits
-
* 'hwmon-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/groeck/staging:
hwmon: (lis3lv02d_i2c) Fix compile warnings
hwmon: (i5k_amb) Fix compile warning -
* 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/konrad/xen:
xen: remove duplicated #include
xen: x86/32: perform initial startup on initial_page_table -
* git://git.kernel.org/pub/scm/linux/kernel/git/cmetcalf/linux-tile:
arch/tile: fix memchr() not to dereference memory for zero length
arch/tile: make glibc's sysconf(_SC_NPROCESSORS_CONF) work correctly
arch/tile: fix rwlock so would-be write lockers don't block new readers -
* 'drivers' of git://git.kernel.org/pub/scm/linux/kernel/git/cmetcalf/linux-tile:
pci root complex: support for tile architecture
drivers/net/tile/: on-chip network drivers for the tile architecture
MAINTAINERS: add drivers/char/hvc_tile.c as maintained by tile -
* master.kernel.org:/home/rmk/linux-2.6-arm:
ARM: 6482/2: Fix find_next_zero_bit and related assembly
ARM: 6490/1: MM: bugfix: initialize spinlock for init_mm.context
ARM: avoid annoying 's in printk output
SCSI: arm fas216: fix missing ';'
ARM: avoid marking decompressor .stack section as having contents
ARM: 6489/1: thumb2: fix incorrect optimisation in usracc
ARM: 6488/1: nomadik: prevent sched_clock() wraparound
ARM: 6484/1: fix compile warning in mm/init.c
ARM: 6473/1: Small update to ux500 specific L2 cache code
ARM: improve compiler's ability to optimize page tables
mx25: fix spi device registration typo
ARM i.MX27 eukrea: Fix compilation
ARM i.MX spi: fix compilation for i.MX21
ARM i.MX pcm037 eet: compile fixes
ARM i.MX: sdma is merged, so remove #ifdef SDMA_IS_MERGED
ARM mx3fb: check for DMA engine type
mach-pcm037_eet: Fix section mismatch for eet_init_devices() -
…l/git/lethal/fbdev-2.6
* 'fbdev-fixes-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/lethal/fbdev-2.6:
sisfb: delete osdef.h
sisfb: move the CONFIG warning to sis_main.c
sisfb: replace SiS_SetMemory with memset_io
sisfb: remove InPort/OutPort wrappers
sisfb: use CONFIG_FB_SIS_301/315 instead of SIS301/315H
sisfb: delete redudant #define SIS_LINUX_KERNEL
sisfb: delete dead SIS_XORG_XF86 code
sisfb: delete fallback code for pci_map_rom()
sisfb: delete obsolete PCI ROM bug workaround
fbdev: Update documentation index file.
lxfb: Program panel v/h sync output polarity correctly
fbcmap: integer overflow bug
fbcmap: cleanup white space in fb_alloc_cmap()
MAINTAINERS: Add fbdev patchwork entry, tidy up file patterns.
fbdev: da8xx: punt duplicated FBIO_WAITFORVSYNC define
fbdev: sh_mobile_lcdcfb: fix bug in reconfig() -
* 'sh-fixes-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/lethal/sh-2.6:
sh: clkfwk: Build fix for non-legacy CPG changes.
sh: Use GCC __builtin_prefetch() to implement prefetch().
sh: fix vsyscall compilation due to .eh_frame issue
sh: avoid to flush all cache in sys_cacheflush
sh: clkfwk: Disable init clk op for non-legacy clocks.
sh: clkfwk: Kill off now unused algo_id in set_rate op.
sh: clkfwk: Kill off unused clk_set_rate_ex(). -
* 'for-linus' of git://neil.brown.name/md:
md: Call blk_queue_flush() to establish flush/fua support
md/raid1: really fix recovery looping when single good device fails.
md: fix return value of rdev_size_change() -
* git://git.kernel.org/pub/scm/linux/kernel/git/rusty/linux-2.6-for-linus:
virtio: fix format of sysfs driver/vendor files
Char: virtio_console, fix memory leak
virtio: return correct capacity to users
module: Update prototype for ref_module (formerly use_module)
