Eric Lee / smarc-fsl-linux-kernel

03 Dec, 2006

1 commit

14 Aug, 2006

1 commit

  • 7ee66fcb9   [LLC]: multicast receive device match ... Browse Code »

    Fix from Aji_Srinivas@emc.com, STP packets are incorrectly received on
    all LLC datagram sockets, whichever interface they are bound to. The
    llc_sap datagram receive logic sends packets with a unicast
    destination MAC to one socket bound to that SAP and MAC, and multicast
    packets to all sockets bound to that SAP. STP packets are multicast,
    and we do need to know on which interface they were received.

    Signed-off-by: Stephen Hemminger
    Signed-off-by: David S. Miller

    Stephen Hemminger
     

05 Aug, 2006

1 commit

  • 30a584d94   [LLX]: SOCK_DGRAM interface fixes ... Browse Code »

    The datagram interface of LLC is broken in a couple of ways.
    These were discovered when trying to use it to build an out-of-kernel
    version of STP.

    First it didn't pass the source address of the received packet
    in recvfrom(). It needs to copy the source address of received LLC packets
    into the socket control block. At the same time fix a security issue
    because there was uninitialized data leakage. Every recvfrom call
    was just copying out old data.

    Second, LLC should not merge multiple packets in one receive call
    on datagram sockets. LLC should preserve packet boundaries on
    SOCK_DGRAM.

    This fix goes against the old historical comments about UNIX98 semantics
    but without this fix SOCK_DGRAM is broken and useless. So either ANK's
    interpretation was incorect or UNIX98 standard was wrong.

    Signed-off-by: Stephen Hemminger
    Acked-by: Arnaldo Carvalho de Melo
    Signed-off-by: David S. Miller

    Stephen Hemminger
     

22 Jul, 2006

1 commit

01 Jul, 2006

1 commit

18 Jun, 2006

7 commits

20 Apr, 2006

1 commit

21 Mar, 2006

4 commits

04 Jan, 2006

3 commits

  • b5e5fa5e0   [NET]: Add a dev_ioctl() fallback to sock_ioctl() ... Browse Code »

    Currently all network protocols need to call dev_ioctl as the default
    fallback in their ioctl implementations. This patch adds a fallback
    to dev_ioctl to sock_ioctl if the protocol returned -ENOIOCTLCMD.
    This way all the procotol ioctl handlers can be simplified and we don't
    need to export dev_ioctl.

    Signed-off-by: Christoph Hellwig
    Signed-off-by: David S. Miller

    Christoph Hellwig
     
  • 90ddc4f04   [NET]: move struct proto_ops to const ... Browse Code »

    I noticed that some of 'struct proto_ops' used in the kernel may share
    a cache line used by locks or other heavily modified data. (default
    linker alignement is 32 bytes, and L1_CACHE_LINE is 64 or 128 at
    least)

    This patch makes sure a 'struct proto_ops' can be declared as const,
    so that all cpus can share all parts of it without false sharing.

    This is not mandatory : a driver can still use a read/write structure
    if it needs to (and eventually a __read_mostly)

    I made a global stubstitute to change all existing occurences to make
    them const.

    This should reduce the possibility of false sharing on SMP, and
    speedup some socket system calls.

    Signed-off-by: Eric Dumazet
    Signed-off-by: David S. Miller

    Eric Dumazet
     
  • c1cbe4b7a   [NET]: Avoid atomic xchg() for non-error case ... Browse Code »

    It also looks like there were 2 places where the test on sk_err was
    missing from the event wait logic (in sk_stream_wait_connect and
    sk_stream_wait_memory), while the rest of the sock_error() users look
    to be doing the right thing. This version of the patch fixes those,
    and cleans up a few places that were testing ->sk_err directly.

    Signed-off-by: Benjamin LaHaise
    Signed-off-by: David S. Miller

    Benjamin LaHaise
     

18 Nov, 2005

1 commit

  • 381998241   [LLC]: Fix compiler warnings introduced by TX window scaling changes. ... Browse Code »

    Noticed by Olaf Hering.

    The comparisons want a u8 here (the data type on the left-hand branch
    is a u8 structure member, and the constant on the right-hand branch is
    "~((u8) 128)"), but C turns it into an integer so we get:

    net/llc/llc_c_ac.c: In function `llc_conn_ac_inc_npta_value':
    net/llc/llc_c_ac.c:998: warning: comparison is always true due to limited range of data type
    net/llc/llc_c_ac.c:999: warning: large integer implicitly truncated to unsigned type

    Fix this up by explicitly recasting the right-hand branch constant
    into a "u8" once more.

    Signed-off-by: David S. Miller

    David S. Miller
     

15 Nov, 2005

2 commits

09 Oct, 2005

1 commit

  • dd0fc66fb   [PATCH] gfp flags annotations - part 1 ... Browse Code »

    - added typedef unsigned int __nocast gfp_t;

    - replaced __nocast uses for gfp flags with gfp_t - it gives exactly
    the same warnings as far as sparse is concerned, doesn't change
    generated code (from gcc point of view we replaced unsigned int with
    typedef) and documents what's going on far better.

    Signed-off-by: Al Viro
    Signed-off-by: Linus Torvalds

    Al Viro
     

22 Sep, 2005

16 commits