Eric Lee / smarc-fsl-linux-kernel

12 Sep, 2024

1 commit

28 Jul, 2023

1 commit

  • 3192f1412   leds: Explicitly include correct DT includes ... Browse Code »

    The DT of_device.h and of_platform.h date back to the separate
    of_platform_bus_type before it as merged into the regular platform bus.
    As part of that merge prepping Arm DT support 13 years ago, they
    "temporarily" include each other. They also include platform_device.h
    and of.h. As a result, there's a pretty much random mix of those include
    files used throughout the tree. In order to detangle these headers and
    replace the implicit includes with struct declarations, users need to
    explicitly include the correct includes.

    Signed-off-by: Rob Herring
    Link: https://lore.kernel.org/r/20230714174651.4058753-1-robh@kernel.org
    Signed-off-by: Lee Jones

    Rob Herring
     

25 May, 2023

1 commit

  • bf4a35e92   leds: Replace all non-returning strlcpy with strscpy ... Browse Code »

    strlcpy() reads the entire source buffer first.
    This read may exceed the destination size limit.
    This is both inefficient and can lead to linear read
    overflows if a source string is not NUL-terminated [1].
    In an effort to remove strlcpy() completely [2], replace
    strlcpy() here with strscpy().
    No return values were used, so direct replacement is safe.

    [1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy
    [2] https://github.com/KSPP/linux/issues/89

    Signed-off-by: Azeem Shaikh
    Reviewed-by: Kees Cook
    Link: https://lore.kernel.org/r/20230523021451.2406362-1-azeemshaikh38@gmail.com
    Signed-off-by: Lee Jones

    Azeem Shaikh
     

09 Feb, 2022

1 commit

  • a0386bba7   spi: make remove callback a void function ... Browse Code »

    The value returned by an spi driver's remove function is mostly ignored.
    (Only an error message is printed if the value is non-zero that the
    error is ignored.)

    So change the prototype of the remove function to return no value. This
    way driver authors are not tempted to assume that passing an error to
    the upper layer is a good idea. All drivers are adapted accordingly.
    There is no intended change of behaviour, all callbacks were prepared to
    return 0 before.

    Signed-off-by: Uwe Kleine-König
    Acked-by: Marc Kleine-Budde
    Acked-by: Andy Shevchenko
    Reviewed-by: Geert Uytterhoeven
    Acked-by: Jérôme Pouiller
    Acked-by: Miquel Raynal
    Acked-by: Jonathan Cameron
    Acked-by: Claudius Heine
    Acked-by: Stefan Schmidt
    Acked-by: Alexandre Belloni
    Acked-by: Ulf Hansson # For MMC
    Acked-by: Marcus Folkesson
    Acked-by: Łukasz Stelmach
    Acked-by: Lee Jones
    Link: https://lore.kernel.org/r/20220123175201.34839-6-u.kleine-koenig@pengutronix.de
    Signed-off-by: Mark Brown

    Uwe Kleine-König
     

27 Sep, 2020

3 commits

  • 99a013c84   leds: various: use only available OF children ... Browse Code »

    Various drivers count and iterate over OF children nodes via
    of_get_child_count and for_each_child_of_node. Instead they should use
    of_get_available_child_count and for_each_available_child_of_node, so
    that if a given node has the `status` property set to `disabled`, the
    child will be ignored.

    Signed-off-by: Marek Behún
    Cc: Andrew Lunn
    Cc: Andrey Utkin
    Cc: Baolin Wang
    Cc: Baolin Wang
    Cc: Benjamin Herrenschmidt
    Cc: Christian Mauderer
    Cc: Chunyan Zhang
    Cc: Dan Murphy
    Cc: David Rivshin
    Cc: Haojian Zhuang
    Cc: H. Nikolaus Schaller
    Cc: Michael Ellerman
    Cc: Milo Kim
    Cc: NeilBrown
    Cc: Nikita Travkin
    Cc: Orson Zhai
    Cc: Paul Mackerras
    Cc: Philippe Retornaz
    Cc: Riku Voipio
    Cc: Simon Guinot
    Cc: Simon Shields
    Cc: Vasant Hegde
    Cc: Xiaotong Lu
    Signed-off-by: Pavel Machek

    Marek Behún
     
  • 8853c95e9   leds: various: use dev_of_node(dev) instead of dev->of_node ... Browse Code »

    The dev_of_node function should be preferred.

    Signed-off-by: Marek Behún
    Cc: Orson Zhai
    Cc: Baolin Wang
    Cc: Chunyan Zhang
    Cc: Sean Wang
    Cc: Matthias Brugger
    Cc: Riku Voipio
    Signed-off-by: Pavel Machek

    Marek Behún
     
  • 2779f4724   leds: various: use device_get_match_data ... Browse Code »

    Simply use device_get_match_data instead of matching against the match
    table again.

    Signed-off-by: Marek Behún
    Cc: H. Nikolaus Schaller
    Cc: David Rivshin
    Cc: Sebastian Reichel
    Cc: Christian Mauderer
    Cc: Andrew Lunn
    Signed-off-by: Pavel Machek

    Marek Behún
     

25 May, 2019

1 commit