17 Oct, 2007

4 commits

  • Johannes Berg reports (Thanks!) that &struct names are not highlighted in
    html output format when they are inside a DOC: block.

    DOC: blocks were not escaped thru xml_escape() like other kernel-doc
    comments were. Fixed that.

    However, that left a problem with

    ($blankline_html) being processed
    thru xml_escape(), converting it to <p>, which isn't good for the
    generated html output (the

    should remain unchanged), so this patch also
    introduces the notion of "local" kernel-doc meta-characters
    ('\\\\mnemonic:'), which are converted to html just before writing the
    stream to its output file.

    Please report any problems that you (anyone) see in "highlighting" in any
    output mode (text, man, html, xml).

    Also update copyright to include me.

    Signed-off-by: Randy Dunlap
    Cc: Johannes Berg
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Randy Dunlap
     
  • This version brings a number of new checks, and a number of bug
    fixes. Of note:

    - better categorisation and space checks for dual use unary/binary
    operators
    - warn on deprecated use of {SPIN,RW}_LOCK_UNLOCKED
    - check if/for/while with trailing ';' for hanging statements
    - detect DOS line endings
    - detect redundant casts for kalloc()

    Andy Whitcroft (18):
    Version: 0.10
    asmlinkage is also a storage type
    pull out inline specifiers
    allow only some operators before a unary operator
    parenthesised values may span line ends
    add additional attribute matching
    handle sparse annotations within pointer type space checks
    support alternative function definition syntax for typedefs
    check if/for/while with trailing ';' for hanging statements
    fix output format for case checks
    deprecate SPIN_LOCK_UNLOCKED and RW_LOCK_UNLOCKED
    allow complex macros with bracketing braces
    detect and report DOS line endings
    fastcall is a valid function attribute
    bracket spacing is ok for 'for'
    categorise operators into unary/binary/definitions
    add heuristic to pick up on unannotated types
    remove spurious warnings from cat_vet

    Dave Jones (1):
    Make checkpatch warn about pointless casting of kalloc returns.

    Signed-off-by: Andy Whitcroft
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Andy Whitcroft
     
  • Simply fill out the bits in checkstack.pl for Blackfin. I thought I already
    sent this, but I don't see it in -mm anywhere ...

    Signed-off-by: Mike Frysinger
    Cc: Bryan Wu
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Mike Frysinger
     
  • * git://git.kernel.org/pub/scm/linux/kernel/git/sam/kbuild: (40 commits)
    kbuild: introduce ccflags-y, asflags-y and ldflags-y
    kbuild: enable 'make CPPFLAGS=...' to add additional options to CPP
    kbuild: enable use of AFLAGS and CFLAGS on commandline
    kbuild: enable 'make AFLAGS=...' to add additional options to AS
    kbuild: fix AFLAGS use in h8300 and m68knommu
    kbuild: check for wrong use of CFLAGS
    kbuild: enable 'make CFLAGS=...' to add additional options to CC
    kbuild: fix up CFLAGS usage
    kbuild: make modpost detect unterminated device id lists
    kbuild: call export_report from the Makefile
    kbuild: move Kai Germaschewski to CREDITS
    kconfig/menuconfig: distinguish between selected-by-another options and comments
    kconfig: tristate choices with mixed tristate and boolean values
    include/linux/Kbuild: remove duplicate entries
    kbuild: kill backward compatibility checks
    kbuild: kill EXTRA_ARFLAGS
    kbuild: fix documentation in makefiles.txt
    kbuild: call make once for all targets when O=.. is used
    kbuild: pass -g to assembler under CONFIG_DEBUG_INFO
    kbuild: update _shipped files for kconfig syntax cleanup
    ...

    Fix up conflicts in arch/um/sys-{x86_64,i386}/Makefile manually.

    Linus Torvalds
     

16 Oct, 2007

3 commits

  • Introduce ccflags-y, asflags-y and ldflags-y so we soon can
    deprecate use of EXTRA_CFLAGS, EXTRA_AFLAGS and EXTRA_LDFLAGS.
    This patch does not touch any in-tree users - thats next round.
    Lets get this committed first and then fix the users of the
    soon to be deprecated variants next.

    The rationale behind this change is to introduce support for
    makefile fragments like:

    ccflags-$(CONFIG_WHATEVER_DEBUG) := -DDEBUG

    As a replacement for the uglier:
    ifeq ($(CONFIG_WHATEVER_DEBUG),y)
    EXTRA_CFLAGS := -DDEBUG
    endif

    Signed-off-by: Sam Ravnborg

    Sam Ravnborg
     
  • The variable CPPFLAGS is a wellknown variable and the usage by
    kbuild may result in unexpected behaviour.

    This patch replace use of CPPFLAGS with KBUILD_CPPFLAGS all over the
    tree and enabling one to use:
    make CPPFLAGS=...
    to specify additional CPP commandline options.

    Patch was tested on following architectures:
    alpha, arm, i386, x86_64, mips, sparc, sparc64, ia64, m68k, s390

    Signed-off-by: Sam Ravnborg

    Sam Ravnborg
     
  • The variable AFLAGS is a wellknown variable and the usage by
    kbuild may result in unexpected behaviour.
    On top of that several people over time has asked for a way to
    pass in additional flags to gcc.

    This patch replace use of AFLAGS with KBUILD_AFLAGS all over
    the tree.

    Patch was tested on following architectures:
    alpha, arm, i386, x86_64, mips, sparc, sparc64, ia64, m68k, s390

    Signed-off-by: Sam Ravnborg

    Sam Ravnborg
     

15 Oct, 2007

2 commits

  • External modules have in a few cases modifed gcc option
    by modifying CFLAGS. This has never been documented and
    was a bad practice.
    With the check to use KBUILD_CFLAGS it will no longer work
    so we better error out and tell what was wrong as a service
    to the external module users.

    This check can be overruled if
    KBUILD_NOPEDANTIC is set to something.
    Addid this possibility may allow older external
    module to build without any code modifications but potentially
    only loosing some un-important gcc options.

    Signed-off-by: Sam Ravnborg

    Sam Ravnborg
     
  • The variable CFLAGS is a wellknown variable and the usage by
    kbuild may result in unexpected behaviour.
    On top of that several people over time has asked for a way to
    pass in additional flags to gcc.

    This patch replace use of CFLAGS with KBUILD_CFLAGS all over the
    tree and enabling one to use:
    make CFLAGS=...
    to specify additional gcc commandline options.

    One usecase is when trying to find gcc bugs but other
    use cases has been requested too.

    Patch was tested on following architectures:
    alpha, arm, i386, x86_64, mips, sparc, sparc64, ia64, m68k

    Test was simple to do a defconfig build, apply the patch and check
    that nothing got rebuild.

    Signed-off-by: Sam Ravnborg

    Sam Ravnborg
     

14 Oct, 2007

1 commit

  • I2C devices do not have any form of ID as PCI or USB devices have.
    No driver uses "MODULE_DEVICE_TABLE(i2c, ...)" because it doesn't
    make sense. So we can get rid of struct i2c_device_id and the
    associated support code.

    Signed-off-by: Jean Delvare
    Cc: Greg KH

    Jean Delvare
     

13 Oct, 2007

24 commits

  • Cause modpost to fail if any device id lists are incorrectly terminated,
    after reporting the offender.
    Improved reporting by akpm

    Signed-off-by: Kees Cook
    Cc: Greg KH
    Cc: Alexey Dobriyan
    Cc: Jeff Garzik
    Cc: Ben Collins
    Cc: Michael Wu
    Cc: Rusty Russell
    Signed-off-by: Andrew Morton
    Signed-off-by: Sam Ravnborg

    Kees Cook
     
  • menuconfig currently represents options implied by another option ('select'
    directive in Kconfig) by prefixing them with '---'. Unfortunately the same
    notation is used for comments. If the implied option is module capable,
    user can still switch between Y and M, all without any feedback until she
    visits option's help. (try saying M to MAC80211 and then toggling
    CFG80211)

    This patch changes notation of selected-by-another items by introducing 2
    new representations for implied options: {*} or {M} for options selected by
    another modularized one, thus builtin or module capable, -*- or -M- for
    options that cannot be at the moment changed by user.

    The idea is to represent actual capability of the option by braces (dashes)
    around and to always report actual state by * or M inside.

    Signed-off-by: Matej Laitl
    Acked-by: Randy Dunlap
    Cc: Roman Zippel
    Signed-off-by: Andrew Morton
    Signed-off-by: Sam Ravnborg

    Matej Laitl
     
  • Change kconfig behavior so that mixing bool and tristate config settings in
    a choice is possible and has the desired effect of offering just the
    tristate options individually if the choice gets set to M, and a normal
    boolean selection if the choice gets set to Y.

    Signed-off-by: Jan Beulich
    Cc: Roman Zippel
    Signed-off-by: Andrew Morton
    Signed-off-by: Sam Ravnborg

    Jan Beulich
     
  • These checks has been present for several kernel releases (> 5).
    So lets just get rid of them.
    With this we no longer check for use of:
    EXTRA_TARGETS, O_TARGET, L_TARGET, list-multi, export-objs

    There were three remaining in-tree users of O_TARGET in some
    unmaintained sh64 code - mail sent to the maintainer + list.

    Signed-off-by: Sam Ravnborg

    Sam Ravnborg
     
  • EXTRA_ARFLAGS have never been used so no need to carry
    around on this.
    A google search did not reveal any external module
    using this either.

    Signed-off-by: Sam Ravnborg

    Sam Ravnborg
     
  • Change the invocations of make in the output directory Makefile and the
    main Makefile for separate object trees to pass all goals to one $(MAKE)
    via a new phony target "sub-make" and the existing target _all.

    When compiling with separate object directories, a separate make is called
    in the context of another directory (from the output directory the main
    Makefile is called, the Makefile is then restarted with current directory
    set to the object tree). Before this patch, when multiple make command
    goals are specified, each target results in a separate make invocation.
    With make -j, these invocations may run in parallel, resulting in multiple
    commands running in the same directory clobbering each others results.

    I did not try to address make -j for mixed dot-config and no-dot-config
    targets. Because the order does matter, a solution was not obvious.
    Perhaps a simple check for MAKEFLAGS having -j and refusing to run would
    be appropriate.

    Signed-off-by: Milton Miller
    Signed-off-by: Sam Ravnborg

    Milton Miller
     
  • Update _shipped files so regular user does not
    need to have bison/flex/gperf installed.
    Code changes were contained in previous commit.

    Used following program versions (on fedora):
    bison (GNU Bison) 2.3
    flex 2.5.33
    GNU gperf 3.0.2

    Cc: Adrian Bunk
    Signed-off-by: Sam Ravnborg

    Sam Ravnborg
     
  • Remove the following redundant and never or rarely used kconfig syntax:

    - "def_boolean" (same as "def_bool")
    - "requires" (same as "depends on")
    - "depends" (same as "depends on")

    This patch contains the code changes and Kconfig updates.
    The shipped files are in next patch to let actual codechange stand out.

    Signed-off-by: Adrian Bunk
    Cc: "Randy.Dunlap"
    Cc: Bryan Wu
    Cc: Paul Mackerras
    Cc: Benjamin Herrenschmidt
    Cc: Dmitry Torokhov
    Cc: "John W. Linville"
    Cc: Roman Zippel
    Cc: Richard Purdie
    Signed-off-by: Andrew Morton
    Signed-off-by: Sam Ravnborg

    Adrian Bunk
     
  • With specific configurations requesting help for certain
    menu lines caused menuconfig to crash.
    This was tracked down to a null pointer bug.
    Thanks to "Miles Lane" for inital reporting
    and to Gabriel C for the backtrace
    that helped me locating the bug.

    Signed-off-by: Sam Ravnborg

    Sam Ravnborg
     
  • Matěj Laitl noticed that there was no way
    to distingush between comments and un-selectable menu lines.
    This patch marks comments with *** comment ***

    Cc: Matěj Laitl
    Signed-off-by: Sam Ravnborg

    Sam Ravnborg
     
  • Previously kbuild choked over the following:
    obj-y += ../../../arch/i386/kernel/bootflag.o

    This has resulted in some rather ugly workarounds in
    current x86_64 tree.
    This patch fixes kbuild to allow the above and enable
    potential cleanups in x86_64 and maybe in other places.

    Signed-off-by: Sam Ravnborg

    Sam Ravnborg
     
  • - fix typos/spellos in docproc.c and Makefile
    - add a little whitespace {while, switch} (coding style)
    - use NULL instead of 0 for pointer testing

    Signed-off-by: Randy Dunlap
    Signed-off-by: Sam Ravnborg

    Randy Dunlap
     
  • This patch updates the _shipped files for genksyms.
    See previous patch for actual functional changes.

    Signed-off-by: Sam Ravnborg

    Sam Ravnborg
     
  • Recently the __extension__ keyword has been introduced in the kernel.
    Teach genksyms about this keyword so it can generate correct CRC for
    exported symbols that uses a symbol marked __extension__.
    For now only the typedef variant:

    __extension__ typedef ...

    is supported.
    Later we may add more variants as needed.

    This patch contains the actual source file changes. The
    following patch will hold modifications to the generated
    files (*_shipped) and only after the second patch the fix
    has effect.

    Signed-off-by: Sam Ravnborg

    Sam Ravnborg
     
  • When enabling GENERATE_PARSER the genksyms Makefile
    failed to create _shipped version of generated files.

    Modifying keywords.gperf failed to cause a rebuild
    of genksyms.
    Fixed by specifying keywowrds .c as explicit prerequisite
    of the lexer.

    Signed-off-by: Sam Ravnborg

    Sam Ravnborg
     
  • Currently scripts/ver_linux prints "Binutils" or other random
    information for the version number in the "binutils" output line
    on some distributions. This patch corrects that.

    When I initially submitted a patch to correct that, I was not aware
    that the output from "ld -v" could differ as much as it turned out
    it can, so my original fix turned out to not cover all bases.
    This patch works correctly with all the different "ld -v" output
    that people posted in replys to my first patch, so it should be a
    clear win over what we have currently.

    Signed-off-by: Jesper Juhl
    Signed-off-by: Sam Ravnborg

    Jesper Juhl
     
  • Fix ver_linux glibc version printing (for real this time)

    Alexey Dobriyan reported that commit
    4a645d5ea65baaa5736bcb566673bf4a351b2ad8
    broke ver_linux when glibc has a 3 digit
    version number, and proposed a patch.
    Al Viro then suggested a simpler way to
    solve the problem which I've then simply
    put into patch form.

    Signed-off-by: Alexey Dobriyan
    Signed-off-by: Al Viro
    Signed-off-by: Jesper Juhl
    Signed-off-by: Sam Ravnborg

    Jesper Juhl
     
  • Currently, if you call scripts/gcc-version.sh without arguments it will
    generate this output :

    $ sh scripts/gcc-version.sh
    scripts/gcc-version.sh: line 12: [: =: unary operator expected
    scripts/gcc-version.sh: line 16: -E: command not found
    scripts/gcc-version.sh: line 17: -E: command not found
    0000

    Not too pretty. I believe this is an improvement :

    $ sh scripts/gcc-version.sh
    Error: No compiler specified.
    Usage:
    scripts/gcc-version.sh

    Signed-off-by: Jesper Juhl
    Signed-off-by: Sam Ravnborg

    Jesper Juhl
     
  • Fix modpost segfault.

    Before:
    -------
    ynezz@ntbk:~/linux-2.6.git$ scripts/mod/modpost vmlinux ath_pci.o
    Segmentation fault

    After:
    ------
    ynezz@ntbk:~/linux-2.6.git$ scripts/mod/modpost vmlinux ath_pci.o
    FATAL: section header offset=815726848 in file 'ath_pci.o' is bigger then filesize=153968

    Sam: This seems to warn for a binutils issue. Anyway modpost should not
    segfault.

    Signed-off-by: Petr Stetiar
    Signed-off-by: Sam Ravnborg

    Petr Stetiar
     
  • Fixes some subtle perl coding bug observed
    by Jan Engelhardt
    This patch applies on top of Adrian's fix.

    Signed-off-by: Ram Pai
    Acked-by: Jan Engelhardt
    Signed-off-by: Sam Ravnborg

    Ram Pai
     
  • This patch fixes an annoying bug of export_report.pl missing the usages
    of some exports.

    Signed-off-by: Adrian Bunk
    Signed-off-by: Sam Ravnborg

    Adrian Bunk
     
  • To avoid having to look manually for used but undefined Kconfig variables,
    I've written a script which tries do this efficiently, in case all other
    attention fail. It accounts for _MODULE suffix and for UML_ prefixes to
    Kconfig variable, but otherwise looks for exact matches (i.e. \
    Cc: Roman Zippel
    Cc: Adrian Bunk
    Signed-off-by: Andrew Morton
    Signed-off-by: Sam Ravnborg

    Paolo 'Blaisorblade' Giarrusso
     
  • cygwin provides the header file but the lib file needs
    to be added manually. A generic fix is to check if
    we can compile and link a program that uses gettext()
    and if it fails fall back to NO_NLS.

    International users of cygwin may have to specify
    HOST_LOADLIBES := "-lintl" on the make command line.

    Signed-off-by: Sam Ravnborg

    Sam Ravnborg
     
  • The Elfnn_Section is not available on all platforms,
    noteworthy are cygwin.
    Use the safe replacement _Half.

    Signed-off-by: Sam Ravnborg

    Sam Ravnborg
     

12 Oct, 2007

3 commits

  • * 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-2.6: (867 commits)
    [SKY2]: status polling loop (post merge)
    [NET]: Fix NAPI completion handling in some drivers.
    [TCP]: Limit processing lost_retrans loop to work-to-do cases
    [TCP]: Fix lost_retrans loop vs fastpath problems
    [TCP]: No need to re-count fackets_out/sacked_out at RTO
    [TCP]: Extract tcp_match_queue_to_sack from sacktag code
    [TCP]: Kill almost unused variable pcount from sacktag
    [TCP]: Fix mark_head_lost to ignore R-bit when trying to mark L
    [TCP]: Add bytes_acked (ABC) clearing to FRTO too
    [IPv6]: Update setsockopt(IPV6_MULTICAST_IF) to support RFC 3493, try2
    [NETFILTER]: x_tables: add missing ip6t_modulename aliases
    [NETFILTER]: nf_conntrack_tcp: fix connection reopening
    [QETH]: fix qeth_main.c
    [NETLINK]: fib_frontend build fixes
    [IPv6]: Export userland ND options through netlink (RDNSS support)
    [9P]: build fix with !CONFIG_SYSCTL
    [NET]: Fix dev_put() and dev_hold() comments
    [NET]: make netlink user -> kernel interface synchronious
    [NET]: unify netlink kernel socket recognition
    [NET]: cleanup 3rd argument in netlink_sendskb
    ...

    Fix up conflicts manually in Documentation/feature-removal-schedule.txt
    and my new least favourite crap, the "mod_devicetable" support in the
    files include/linux/mod_devicetable.h and scripts/mod/file2alias.c.

    (The latter files seem to be explicitly _designed_ to get conflicts when
    different subsystems work with them - that have an absolutely horrid
    lack of subsystem separation!)

    Signed-off-by: Linus Torvalds

    Linus Torvalds
     
  • * 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/hskinnemoen/avr32-2.6:
    [AVR32] Fix random segfault with preemption
    [AVR32] Don't use __builtin_xchg()
    [AVR32] ngw100 i2c-gpio tweaks
    [AVR32] Ignore a few irrelevant syscalls
    [AVR32] SMC configuration in clock cycles
    [AVR32] Drop support for redundant "keepinitrd" boot-time parm.
    [AVR32] Make dma_sync_*_for_cpu no-ops
    [AVR32] Remove unneeded 8K alignment of .text section
    [AVR32] Kill a few hardcoded constants in vmlinux.lds
    [AVR32] rename vmlinux.lds
    [AVR32] fix command line parsing in early_parse_fbmem
    [AVR32] checkstack support
    [AVR32] Wire up USBA device
    [AVR32] add multidrive support for pio driver
    [AVR32] /sys/kernel/debug/at32ap_clk
    [AVR32] Move AT32_PM_BASE definition into pm.h

    Linus Torvalds
     
  • * 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/drzeus/mmc: (67 commits)
    mmc: don't use weight32()
    pxamci: support arbitrary block size
    sdio: make the IRQ thread more resilient in the presence of bad states
    sdio: fix IRQ diagnostic message
    sdhci: remove old dma module params
    sdhci: add SDHCI_QUIRK_BROKEN_DMA quirk
    sdhci: remove DMA capability check from controller's PCI Class reg
    sdhci: fix a typo
    mmc: Disabler for Ricoh MMC controller
    sdio: adaptive interrupt polling
    mmc: pxamci: add SDIO card interrupt reporting capability
    mmc: pxamci: set proper buswidth capabilities according to PXA flavor
    mmc: pxamci: set proper block capabilities according to PXA flavor
    mmc: pxamci: better pending IRQ determination
    arm: i.MX/MX1 SDHC implements SD cards read-only switch read-back
    mmc: add led trigger
    mmc_spi host driver
    MMC core learns about SPI
    MMC/SD card driver learns SPI
    MMC headers learn about SPI
    ...

    Linus Torvalds
     

11 Oct, 2007

3 commits