13 Jan, 2012

1 commit


08 Jan, 2012

1 commit

  • * 'driver-core-next' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core: (73 commits)
    arm: fix up some samsung merge sysdev conversion problems
    firmware: Fix an oops on reading fw_priv->fw in sysfs loading file
    Drivers:hv: Fix a bug in vmbus_driver_unregister()
    driver core: remove __must_check from device_create_file
    debugfs: add missing #ifdef HAS_IOMEM
    arm: time.h: remove device.h #include
    driver-core: remove sysdev.h usage.
    clockevents: remove sysdev.h
    arm: convert sysdev_class to a regular subsystem
    arm: leds: convert sysdev_class to a regular subsystem
    kobject: remove kset_find_obj_hinted()
    m86k: gpio - convert sysdev_class to a regular subsystem
    mips: txx9_sram - convert sysdev_class to a regular subsystem
    mips: 7segled - convert sysdev_class to a regular subsystem
    sh: dma - convert sysdev_class to a regular subsystem
    sh: intc - convert sysdev_class to a regular subsystem
    power: suspend - convert sysdev_class to a regular subsystem
    power: qe_ic - convert sysdev_class to a regular subsystem
    power: cmm - convert sysdev_class to a regular subsystem
    s390: time - convert sysdev_class to a regular subsystem
    ...

    Fix up conflicts with 'struct sysdev' removal from various platform
    drivers that got changed:
    - arch/arm/mach-exynos/cpu.c
    - arch/arm/mach-exynos/irq-eint.c
    - arch/arm/mach-s3c64xx/common.c
    - arch/arm/mach-s3c64xx/cpu.c
    - arch/arm/mach-s5p64x0/cpu.c
    - arch/arm/mach-s5pv210/common.c
    - arch/arm/plat-samsung/include/plat/cpu.h
    - arch/powerpc/kernel/sysfs.c
    and fix up cpu_is_hotpluggable() as per Greg in include/linux/cpu.h

    Linus Torvalds
     

07 Jan, 2012

1 commit

  • This resolves the conflict in the arch/arm/mach-s3c64xx/s3c6400.c file,
    and it fixes the build error in the arch/x86/kernel/microcode_core.c
    file, that the merge did not catch.

    The microcode_core.c patch was provided by Stephen Rothwell
    who was invaluable in the merge issues involved
    with the large sysdev removal process in the driver-core tree.

    Signed-off-by: Greg Kroah-Hartman

    Greg Kroah-Hartman
     

23 Dec, 2011

1 commit

  • Add another vendor specific ID for BCM20702A0.

    output of usb-devices:
    T: Bus=06 Lev=01 Prnt=01 Port=00 Cnt=01 Dev#= 4 Spd=12 MxCh= 0
    D: Ver= 2.00 Cls=ff(vend.) Sub=01 Prot=01 MxPS=64 #Cfgs= 1
    P: Vendor=0a5c ProdID=21e3 Rev=01.12
    S: Manufacturer=Broadcom Corp
    S: Product=BCM20702A0
    S: SerialNumber=9439E5CBF66C
    C: #Ifs= 4 Cfg#= 1 Atr=e0 MxPwr=0mA
    I: If#= 0 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=01 Prot=01 Driver=(none)
    I: If#= 1 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=01 Prot=01 Driver=(none)
    I: If#= 2 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none)
    I: If#= 3 Alt= 0 #EPs= 0 Cls=fe(app. ) Sub=01 Prot=01 Driver=(none)

    Signed-off-by: Wen-chien Jesse Sung
    Acked-by: Marcel Holtmann
    Signed-off-by: Gustavo F. Padovan

    Jesse Sung
     

21 Dec, 2011

1 commit


03 Dec, 2011

2 commits

  • Gustavo F. Padovan
     
  • This patch fixes the following memory leak reported by kmemleak:

    unreferenced object 0xffff880060a53840 (size 192):
    comm "softirq", pid 0, jiffies 4320571771 (age 1406.569s)
    hex dump (first 32 bytes):
    01 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
    00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
    backtrace:
    [] create_object+0x187/0x28b
    [] kmemleak_alloc+0x73/0x98
    [] __kmalloc+0xfc/0x123
    [] usb_alloc_urb+0x1e/0x48
    [] btusb_send_frame+0x86/0x385 [btusb]
    [] hci_send_frame+0xa0/0xa5 [bluetooth]
    [] hci_cmd_task+0xa0/0xfb [bluetooth]
    [] tasklet_action+0x8f/0xef
    [] __do_softirq+0xf4/0x1db
    [] run_ksoftirqd+0x84/0x129
    [] kthread+0xa0/0xa8
    [] kernel_thread_helper+0x4/0x10
    [] 0xffffffffffffffff

    The problem is that when inc_tx() returns non-zero, we forgot
    to call usb_free_urb().

    Cc: Marcel Holtmann
    Cc: "Gustavo F. Padovan"
    Signed-off-by: WANG Cong
    Acked-by: Marcel Holtmann
    Signed-off-by: Gustavo F. Padovan

    Cong Wang
     

19 Nov, 2011

1 commit


10 Nov, 2011

1 commit


08 Nov, 2011

2 commits

  • Since this device declares itself as vendor specific, must add
    a new entry to device ID table to support it.

    usb-device output of this device:

    T: Bus=01 Lev=02 Prnt=02 Port=03 Cnt=01 Dev#= 3 Spd=12 MxCh= 0
    D: Ver= 2.00 Cls=ff(vend.) Sub=01 Prot=01 MxPS=64 #Cfgs= 1
    P: Vendor=413c ProdID=8197 Rev=01.12
    S: Manufacturer=Broadcom Corp
    S: Product=BCM20702A0
    S: SerialNumber=D0DF9AA9C9F1
    C: #Ifs= 4 Cfg#= 1 Atr=e0 MxPwr=0mA
    I: If#= 0 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=01 Prot=01 Driver=(none)
    I: If#= 1 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=01 Prot=01 Driver=(none)
    I: If#= 2 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none)
    I: If#= 3 Alt= 0 #EPs= 0 Cls=fe(app. ) Sub=01 Prot=01 Driver=(none)

    Signed-off-by: Wen-chien Jesse Sung
    Signed-off-by: Gustavo F. Padovan

    Wen-chien Jesse Sung
     
  • Signed-off-by: Luiz Augusto von Dentz
    Acked-by: Marcel Holtmann
    Signed-off-by: Gustavo F. Padovan

    Luiz Augusto von Dentz
     

25 Oct, 2011

1 commit

  • * 'pm-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm: (63 commits)
    PM / Clocks: Remove redundant NULL checks before kfree()
    PM / Documentation: Update docs about suspend and CPU hotplug
    ACPI / PM: Add Sony VGN-FW21E to nonvs blacklist.
    ARM: mach-shmobile: sh7372 A4R support (v4)
    ARM: mach-shmobile: sh7372 A3SP support (v4)
    PM / Sleep: Mark devices involved in wakeup signaling during suspend
    PM / Hibernate: Improve performance of LZO/plain hibernation, checksum image
    PM / Hibernate: Do not initialize static and extern variables to 0
    PM / Freezer: Make fake_signal_wake_up() wake TASK_KILLABLE tasks too
    PM / Hibernate: Add resumedelay kernel param in addition to resumewait
    MAINTAINERS: Update linux-pm list address
    PM / ACPI: Blacklist Vaio VGN-FW520F machine known to require acpi_sleep=nonvs
    PM / ACPI: Blacklist Sony Vaio known to require acpi_sleep=nonvs
    PM / Hibernate: Add resumewait param to support MMC-like devices as resume file
    PM / Hibernate: Fix typo in a kerneldoc comment
    PM / Hibernate: Freeze kernel threads after preallocating memory
    PM: Update the policy on default wakeup settings
    PM / VT: Cleanup #if defined uglyness and fix compile error
    PM / Suspend: Off by one in pm_suspend()
    PM / Hibernate: Include storage keys in hibernation image on s390
    ...

    Linus Torvalds
     

11 Oct, 2011

2 commits

  • There are still three calls of usb_submit_urb() that will print errors
    if those calls return -EPERM or -ENODEV. I have never triggered these,
    so I'm not sure when these return values might be seen. It still makes
    sense to be silent if these occur (since "urb is being killed" and
    "device got disconnected" aren't things to worry about).

    Signed-off-by: Paul Bolle
    Signed-off-by: Gustavo F. Padovan

    Paul Bolle
     
  • usb_submit_urb() returns -ENODEV when a usb device is disconnected. In
    commit 4935f1c164ac528dff3538f97953b385ba500710 ("Bluetooth: btusb: be
    quiet on device disconnect") I stopped treating that return as an error
    in the three btusb_*_complete() functions.

    It turns out btusb_send_frame() generates a similar error if the system
    is suspended while the bluetooth usb device is enabled. The sensible
    thing to do here seems to be to treat -ENODEV (and -EPERM) just like the
    btusb_*_complete() functions now do.

    Signed-off-by: Paul Bolle
    Signed-off-by: Gustavo F. Padovan

    Paul Bolle
     

08 Oct, 2011

1 commit

  • * pm-runtime:
    PM / Tracing: build rpm-traces.c only if CONFIG_PM_RUNTIME is set
    PM / Runtime: Replace dev_dbg() with trace_rpm_*()
    PM / Runtime: Introduce trace points for tracing rpm_* functions
    PM / Runtime: Don't run callbacks under lock for power.irq_safe set
    USB: Add wakeup info to debugging messages
    PM / Runtime: pm_runtime_idle() can be called in atomic context
    PM / Runtime: Add macro to test for runtime PM events
    PM / Runtime: Add might_sleep() to runtime PM functions

    Rafael J. Wysocki
     

30 Sep, 2011

1 commit

  • From 0cea73465cd22373c5cd43a3edd25fbd4bb532ef Mon Sep 17 00:00:00 2001
    From: Oliver Neukum
    Date: Wed, 21 Sep 2011 11:37:15 +0200
    Subject: [PATCH] btusb: add device entry for Broadcom SoftSailing

    This device declares itself to be vendor specific
    It therefore needs to be added to the device table
    to make btusb bind.

    Signed-off-by: Oliver Neukum
    Signed-off-by: Gustavo F. Padovan

    Oliver Neukum
     

28 Sep, 2011

1 commit

  • Removed tests which prevent transmission of ACL packets
    when the device is in HCI_RAW mode. These tests verified that
    there are ACL or LE links currently tracked by the HCI
    connection manager. However, a HCI_RAW mode device does not
    use the connection manager. In these circumstances, the connection
    counts will be zero, and thus, transmitted ACL packets dropped.

    The acl_num test is actually a vestige of a previous bulk URB
    scheme that is no longer used by this driver (bulk URBs were not
    started until at least one ACL connection was created). This was
    incompatible with some endpoint implementations and was dropped -
    see commit 43c2e57f94.

    The utility of these tests is marginal - currently, the hci tx
    scheduler cannot send an ACL or LE packet for an untracked connection
    (except if the device is in HCI_RAW mode).

    Lastly, no other transport layer driver enforces these same tests.

    Signed-off-by: Peter Hurley
    Acked-by: Acked-by: Marcel Holtmann
    Signed-off-by: Gustavo F. Padovan

    Peter Hurley
     

18 Sep, 2011

2 commits


20 Aug, 2011

1 commit

  • This patch (as1482) adds a macro for testing whether or not a
    pm_message value represents an autosuspend or autoresume (i.e., a
    runtime PM) event. Encapsulating this notion seems preferable to
    open-coding the test all over the place.

    Signed-off-by: Alan Stern
    Acked-by: Greg Kroah-Hartman
    Signed-off-by: Rafael J. Wysocki

    Alan Stern
     

12 Aug, 2011

2 commits

  • Blacklist Toshiba-branded AR3011 based AR5B195 [0930:0215] and add to
    ath3k.c for firmware loading.

    Signed-off-by: Ricardo Mendoza
    Signed-off-by: Gustavo F. Padovan

    Ricardo Mendoza
     
  • Disabling the bluetooth usb device embedded in (some) ThinkPads tends to
    lead to errors like these:
    btusb_bulk_complete: hci0 urb ffff88011b9bfd68 failed to resubmit (19)
    btusb_intr_complete: hci0 urb ffff88011b46a318 failed to resubmit (19)
    btusb_bulk_complete: hci0 urb ffff88011b46a000 failed to resubmit (19)

    That is because usb_disconnect() doesn't "quiesces" pending urbs.

    Disconnecting a device is a normal thing to happen so it's no big deal
    that usb_submit_urb() returns -ENODEV. The simplest way to get rid of
    these errors is to stop treating that return as an error. Trivial,
    actually.

    While we're at it, add comments to be explicit about the reasons we're
    not complaining about -EPERM and -ENODEV.

    Signed-off-by: Paul Bolle
    Signed-off-by: Gustavo F. Padovan

    Paul Bolle
     

02 Jul, 2011

1 commit

  • The new Ath3k needs to download patch and radio table,
    and it keeps same PID/VID even after downloading the patch and radio
    table. This patch is to use the bcdDevice (Device Release Number) to
    judge whether the chip has been patched or not. The init bcdDevice
    value of the chip is 0x0001, this value increases after patch and
    radio table downloading.

    Signed-off-by: Steven.Li
    Signed-off-by: Gustavo F. Padovan

    Steven.Li
     

12 May, 2011

1 commit


01 Apr, 2011

2 commits


19 Mar, 2011

1 commit

  • * 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial: (47 commits)
    doc: CONFIG_UNEVICTABLE_LRU doesn't exist anymore
    Update cpuset info & webiste for cgroups
    dcdbas: force SMI to happen when expected
    arch/arm/Kconfig: remove one to many l's in the word.
    asm-generic/user.h: Fix spelling in comment
    drm: fix printk typo 'sracth'
    Remove one to many n's in a word
    Documentation/filesystems/romfs.txt: fixing link to genromfs
    drivers:scsi Change printk typo initate -> initiate
    serial, pch uart: Remove duplicate inclusion of linux/pci.h header
    fs/eventpoll.c: fix spelling
    mm: Fix out-of-date comments which refers non-existent functions
    drm: Fix printk typo 'failled'
    coh901318.c: Change initate to initiate.
    mbox-db5500.c Change initate to initiate.
    edac: correct i82975x error-info reported
    edac: correct i82975x mci initialisation
    edac: correct commented info
    fs: update comments to point correct document
    target: remove duplicate include of target/target_core_device.h from drivers/target/target_core_hba.c
    ...

    Trivial conflict in fs/eventpoll.c (spelling vs addition)

    Linus Torvalds
     

04 Mar, 2011

1 commit


24 Feb, 2011

1 commit

  • This reverts commit 556ea928f78a390fe16ae584e6433dff304d3014.

    Jeff Chua reports that it can cause some bluetooth devices (he mentions
    an Bluetooth Intermec scanner) to just stop responding after a while
    with messages like

    [ 4533.361959] btusb 8-1:1.0: no reset_resume for driver btusb?
    [ 4533.361964] btusb 8-1:1.1: no reset_resume for driver btusb?

    from the kernel. See also

    https://bugzilla.kernel.org/show_bug.cgi?id=26182

    for other reports.

    Reported-by: Jeff Chua
    Reported-by: Andrew Meakovski
    Reported-by: Jim Faulkner
    Acked-by: Greg KH
    Acked-by: Matthew Garrett
    Acked-by: Gustavo F. Padovan
    Cc: stable@kernel.org (for 2.6.37)
    Signed-off-by: Linus Torvalds

    Linus Torvalds
     

19 Feb, 2011

1 commit


17 Feb, 2011

3 commits


12 Feb, 2011

1 commit


27 Jan, 2011

1 commit


19 Jan, 2011

1 commit

  • Fix a bunch of
    warning: ‘inline’ is not at beginning of declaration
    messages when building a 'make allyesconfig' kernel with -Wextra.

    These warnings are trivial to kill, yet rather annoying when building with
    -Wextra.
    The more we can cut down on pointless crap like this the better (IMHO).

    A previous patch to do this for a 'allnoconfig' build has already been
    merged. This just takes the cleanup a little further.

    Signed-off-by: Jesper Juhl
    Signed-off-by: Jiri Kosina

    Jesper Juhl
     

02 Dec, 2010

2 commits

  • Atheros 3011 has small sflash firmware and needs to be
    blacklisted in transport driver to load actual firmware
    in DFU driver.

    Signed-off-by: Bala Shanmugam
    Acked-by: Marcel Holtmann
    Signed-off-by: Gustavo F. Padovan

    Bala Shanmugam
     
  • If a device is autosuspended an inability to resubmit URBs is
    to be expected. Check the error code and only log real errors.
    (Now that autosuspend is default enabled for btusb, those log
    messages were happening all the time e.g. with a BT mouse)

    Signed-off-by: Stefan Seyfried
    Signed-off-by: Oliver Neukum
    Acked-by: Marcel Holtmann
    Signed-off-by: Gustavo F. Padovan

    Stefan Seyfried
     

09 Nov, 2010

2 commits

  • Adding the new MacBookAir3,1(2) to btusb.

    Output without the patch and btusb loaded :

    T: Bus=03 Lev=02 Prnt=03 Port=02 Cnt=01 Dev#= 6 Spd=12 MxCh= 0
    D: Ver= 2.00 Cls=ff(vend.) Sub=01 Prot=01 MxPS=64 #Cfgs= 1
    P: Vendor=05ac ProdID=821b Rev= 0.34
    S: Manufacturer=Apple Inc.
    S: Product=Bluetooth USB Host Controller
    C:* #Ifs= 4 Cfg#= 1 Atr=e0 MxPwr= 0mA
    I:* If#= 0 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=01 Prot=01 Driver=(none)
    E: Ad=81(I) Atr=03(Int.) MxPS= 16 Ivl=1ms
    E: Ad=82(I) Atr=02(Bulk) MxPS= 64 Ivl=0ms
    E: Ad=02(O) Atr=02(Bulk) MxPS= 64 Ivl=0ms
    I:* If#= 1 Alt= 0 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=(none)
    E: Ad=83(I) Atr=01(Isoc) MxPS= 0 Ivl=1ms
    E: Ad=03(O) Atr=01(Isoc) MxPS= 0 Ivl=1ms
    I: If#= 1 Alt= 1 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=(none)
    E: Ad=83(I) Atr=01(Isoc) MxPS= 9 Ivl=1ms
    E: Ad=03(O) Atr=01(Isoc) MxPS= 9 Ivl=1ms
    I: If#= 1 Alt= 2 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=(none)
    E: Ad=83(I) Atr=01(Isoc) MxPS= 17 Ivl=1ms
    E: Ad=03(O) Atr=01(Isoc) MxPS= 17 Ivl=1ms
    I: If#= 1 Alt= 3 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=(none)
    E: Ad=83(I) Atr=01(Isoc) MxPS= 32 Ivl=1ms
    E: Ad=03(O) Atr=01(Isoc) MxPS= 32 Ivl=1ms
    I: If#= 1 Alt= 4 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=(none)
    E: Ad=83(I) Atr=01(Isoc) MxPS= 64 Ivl=1ms
    E: Ad=03(O) Atr=01(Isoc) MxPS= 64 Ivl=1ms
    I: If#= 1 Alt= 5 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=(none)
    E: Ad=83(I) Atr=01(Isoc) MxPS= 64 Ivl=1ms
    E: Ad=03(O) Atr=01(Isoc) MxPS= 64 Ivl=1ms
    I:* If#= 2 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none)
    E: Ad=84(I) Atr=02(Bulk) MxPS= 32 Ivl=0ms
    E: Ad=04(O) Atr=02(Bulk) MxPS= 32 Ivl=0ms
    I:* If#= 3 Alt= 0 #EPs= 0 Cls=fe(app. ) Sub=01 Prot=01 Driver=(none)

    Output with the patch and btusb loaded :

    T: Bus=03 Lev=02 Prnt=03 Port=02 Cnt=01 Dev#= 6 Spd=12 MxCh= 0
    D: Ver= 2.00 Cls=ff(vend.) Sub=01 Prot=01 MxPS=64 #Cfgs= 1
    P: Vendor=05ac ProdID=821b Rev= 0.34
    S: Manufacturer=Apple Inc.
    S: Product=Bluetooth USB Host Controller
    C:* #Ifs= 4 Cfg#= 1 Atr=e0 MxPwr= 0mA
    I:* If#= 0 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=01 Prot=01 Driver=btusb
    E: Ad=81(I) Atr=03(Int.) MxPS= 16 Ivl=1ms
    E: Ad=82(I) Atr=02(Bulk) MxPS= 64 Ivl=0ms
    E: Ad=02(O) Atr=02(Bulk) MxPS= 64 Ivl=0ms
    I:* If#= 1 Alt= 0 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
    E: Ad=83(I) Atr=01(Isoc) MxPS= 0 Ivl=1ms
    E: Ad=03(O) Atr=01(Isoc) MxPS= 0 Ivl=1ms
    I: If#= 1 Alt= 1 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
    E: Ad=83(I) Atr=01(Isoc) MxPS= 9 Ivl=1ms
    E: Ad=03(O) Atr=01(Isoc) MxPS= 9 Ivl=1ms
    I: If#= 1 Alt= 2 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
    E: Ad=83(I) Atr=01(Isoc) MxPS= 17 Ivl=1ms
    E: Ad=03(O) Atr=01(Isoc) MxPS= 17 Ivl=1ms
    I: If#= 1 Alt= 3 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
    E: Ad=83(I) Atr=01(Isoc) MxPS= 32 Ivl=1ms
    E: Ad=03(O) Atr=01(Isoc) MxPS= 32 Ivl=1ms
    I: If#= 1 Alt= 4 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
    E: Ad=83(I) Atr=01(Isoc) MxPS= 64 Ivl=1ms
    E: Ad=03(O) Atr=01(Isoc) MxPS= 64 Ivl=1ms
    I: If#= 1 Alt= 5 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
    E: Ad=83(I) Atr=01(Isoc) MxPS= 64 Ivl=1ms
    E: Ad=03(O) Atr=01(Isoc) MxPS= 64 Ivl=1ms
    I:* If#= 2 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none)
    E: Ad=84(I) Atr=02(Bulk) MxPS= 32 Ivl=0ms
    E: Ad=04(O) Atr=02(Bulk) MxPS= 32 Ivl=0ms
    I:* If#= 3 Alt= 0 #EPs= 0 Cls=fe(app. ) Sub=01 Prot=01 Driver=(none)

    Signed-off-by: Edgar (gimli) Hucek
    Acked-by: Marcel Holtmann
    Signed-off-by: Gustavo F. Padovan

    Edgar (gimli) Hucek
     
  • We've done this for a while in Fedora without any obvious problems other
    than some interaction with input devices. Those should be fixed now, so
    let's try this in mainline.

    Signed-off-by: Matthew Garrett
    Acked-by: Marcel Holtmann
    Signed-off-by: Gustavo F. Padovan

    Matthew Garrett