11 Apr, 2013
1 commit
-
The s3c-fb driver requires header files from the samsung platforms
to find its platform_data definition, but this no longer works on
multiplatform kernels, so let's move the data into a new header
file under include/linux/platform_data.Signed-off-by: Arnd Bergmann
Cc: linux-fbdev@vger.kernel.org
Acked-by: Jingoo Han
Signed-off-by: Tomi Valkeinen
23 Jan, 2013
1 commit
-
Convert all uses of devm_request_and_ioremap() to the newly introduced
devm_ioremap_resource() which provides more consistent error handling.devm_ioremap_resource() provides its own error messages so all explicit
error messages can be removed from the failure code paths.Signed-off-by: Thierry Reding
Cc: Florian Tobias Schandinat
Acked-by: Jingoo Han
Signed-off-by: Greg Kroah-Hartman
04 Jan, 2013
1 commit
-
CONFIG_HOTPLUG is going away as an option. As a result, the __dev*
markings need to be removed.This change removes the use of __devinit, __devexit_p, __devinitdata,
__devinitconst, and __devexit from these drivers.Based on patches originally written by Bill Pemberton, but redone by me
in order to handle some of the coding style issues better, by hand.Cc: Bill Pemberton
Signed-off-by: Greg Kroah-Hartman
26 Nov, 2012
6 commits
-
Green pixel and blue pixel are 3 bits and 2 bits respectively
at ARGB232 format. Thus, the value of red offset should be 5,
not 4. Also, the value of red length should be 2, because
red pixel is 2 bits at ARGB232 format.Signed-off-by: Jingoo Han
-
This patch returns an error, when bpp is invalid in
s3c_fb_check_var(). If invalid bpp is requested,
an error should be returned.Signed-off-by: Jingoo Han
-
This patch adds a "drop through" comment to improve
the readability.Signed-off-by: Jingoo Han
-
Because there is no need to access to the platform device in
suspend/resume and runtime_suspend/resume, dev_get_drvdata()
can be used instead of platform_get_drvdata() to make the code
smaller.Signed-off-by: Jingoo Han
-
This patch uses FIMD_V8_VIDTCON0 as the address definition
of VIDTCON0 register, because the address offset of VIDTCONx
registers is changed from 0x0 to 0x20000 for EXYNOS5 FIMD.
So, FIMD_V8_VIDTCON0 should be used.Signed-off-by: Jingoo Han
-
"sturucture" should be "structure".
Signed-off-by: Jingoo Han
10 Oct, 2012
1 commit
-
Convert clk_enable/clk_disable to clk_prepare_enable/clk_disable_unprepare
calls as required by common clock framework.Signed-off-by: Thomas Abraham
Acked-by: Jingoo Han
Signed-off-by: Florian Tobias Schandinat
20 Sep, 2012
1 commit
-
…/kgene/linux-samsung into fbdev-next
23 Aug, 2012
1 commit
-
The devm_ functions allocate memory that is released when a driver
detaches. This patch uses devm_clk_get() for these functions.Signed-off-by: Jingoo Han
Signed-off-by: Florian Tobias Schandinat
08 Aug, 2012
1 commit
-
This patch moves the contents from regs-fb-v4.h and regs-fb.h to
include/video/samsung_fimd.h. Also updates the header inclusion in
machine files and driver files accordingly.Signed-off-by: Leela Krishna Amudala
Cc: Florian Tobias Schandinat
Signed-off-by: Kukjin Kim
25 Jul, 2012
1 commit
-
Pull trivial tree from Jiri Kosina:
"Trivial updates all over the place as usual."* 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial: (29 commits)
Fix typo in include/linux/clk.h .
pci: hotplug: Fix typo in pci
iommu: Fix typo in iommu
video: Fix typo in drivers/video
Documentation: Add newline at end-of-file to files lacking one
arm,unicore32: Remove obsolete "select MISC_DEVICES"
module.c: spelling s/postition/position/g
cpufreq: Fix typo in cpufreq driver
trivial: typo in comment in mksysmap
mach-omap2: Fix typo in debug message and comment
scsi: aha152x: Fix sparse warning and make printing pointer address more portable.
Change email address for Steve Glendinning
Btrfs: fix typo in convert_extent_bit
via: Remove bogus if check
netprio_cgroup.c: fix comment typo
backlight: fix memory leak on obscure error path
Documentation: asus-laptop.txt references an obsolete Kconfig item
Documentation: ManagementStyle: fixed typo
mm/vmscan: cleanup comment error in balance_pgdat
mm: cleanup on the comments of zone_reclaim_stat
...
24 Jul, 2012
1 commit
-
Correct spelling typo in debug messages and comments
within drivers/video.Signed-off-by: Masanari Iida
Signed-off-by: Jiri Kosina
14 Jun, 2012
2 commits
-
Divider value can be zero and it makes division by zero
from debug message in s3c_fb_calc_pixclk; therefore, it
should be fixed.Signed-off-by: Jingoo Han
Signed-off-by: Florian Tobias Schandinat -
All bits of SHADOWCON register should be cleared when clearing
hardware window registers; however, some bits of SHADOWCON register
are not cleared previously.Signed-off-by: Jingoo Han
Signed-off-by: Florian Tobias Schandinat
13 May, 2012
1 commit
-
This patch uses pr_debug instead of printk to allow dynamic debugging.
Signed-off-by: Jingoo Han
Signed-off-by: Florian Tobias Schandinat
09 May, 2012
1 commit
-
Since s3c_fb_missing_pixclock() is called from s3c_fb_set_rgb_timing()
which is used in the suspend/resume paths it can't be marked __devinit
as this could result in it being discarded after boot.Signed-off-by: Mark Brown
Acked-by: Jingoo Han
Signed-off-by: Florian Tobias Schandinat
16 Apr, 2012
1 commit
-
This patch adds runtime_get/put to suspend/resume, which should be
necessary to prevent the problem to access the fimd register
without block power on.Signed-off-by: Jingoo Han
Signed-off-by: Florian Tobias Schandinat
10 Apr, 2012
2 commits
-
The decision to enable or disable the data output to the lcd panel from
the controller need not be based on the value of 'default_win' element
in the platform data. Instead, the data output to the panel is enabled
if any of the windows are active, else data output is disabled.Cc: Ben Dooks
Signed-off-by: Jingoo Han
Signed-off-by: Thomas Abraham
Signed-off-by: Florian Tobias Schandinat -
The video interface timing is independent of the window setup data.
The resolution of the window can be smaller than that of the lcd
panel to which the video data is output.So move the video timing data from the per-window setup data to the
platform specific section in the platform data. This also removes
the restriction that atleast one window should have the same
resolution as that of the panel attached.Cc: Ben Dooks
Signed-off-by: Thomas Abraham
Acked-by: Jingoo Han
Signed-off-by: Florian Tobias Schandinat
06 Mar, 2012
1 commit
-
This patch adds s3c_fb_driverdata s3c_fb_data_exynos5 for EXYNOS5
and adds extended timing control setting.EXYNOS5 FIMD needs extended setting for video timing control.
Additional bits are added to VIDTCON2, VIDWxxADD2, VIDOSDxA and
VIDOSDxB registers in order to set timing value for lager resolution.Also, address offset of VIDTCONx registers is changed from 0x0
to 0x20000, thus variable type should be changed to int type
to handle the address offset of VIDTCONx registers for EXYNOS5 FIMD.Signed-off-by: Jingoo Han
Signed-off-by: Florian Tobias Schandinat
24 Feb, 2012
1 commit
-
The devm_ functions allocate memory that is released when a driver
detaches. This patch uses devm_request_irq of these functions.Signed-off-by: Jingoo Han
Signed-off-by: Florian Tobias Schandinat
29 Jan, 2012
4 commits
-
This patch adds video clock running at data under-flow.
It means that the pixel clock is continuously provided
to lcd module, even when under-run occurs.Signed-off-by: Jingoo Han
Signed-off-by: Florian Tobias Schandinat -
This patch adds alpha value width setting according to
transparency value of each window format, using BLENDCON
register. When alpha value is 8 bits, BLENDCON will set
alpha value width as 8 bits.Signed-off-by: Jingoo Han
Signed-off-by: Florian Tobias Schandinat -
This patch fixes the checkpatch error listed below:
ERROR: trailing statements should be on next line
Signed-off-by: Jingoo Han
Signed-off-by: Florian Tobias Schandinat -
Saves some code, especially useful as the code saved is mostly in the
infrequently tested error paths.Signed-off-by: Mark Brown
Acked-by: Jingoo Han
Signed-off-by: Florian Tobias Schandinat
04 Jan, 2012
6 commits
-
Allow the controller to be runtime suspended when the screen is blanked
by not taking a runtime reference while the device is open. This allows
greater system wide power savings when used with a standard application
layer and ensures that the screen does not blank unless requested.Signed-off-by: Mark Brown
Acked-by: Jingoo Han
Signed-off-by: Florian Tobias Schandinat -
Take a runtime PM reference whenever updating registers in preparation
for suspending the device when the framebuffer is blanked.Signed-off-by: Mark Brown
Acked-by: Jingoo Han
Signed-off-by: Florian Tobias Schandinat -
When the framebuffer is unblanked hold a runtime PM reference. This
prevents us powering down when userspace has left an image on the
framebuffer and prepares the way for being able to power down the hardware
when an application still has the device open.Since we now hold a runtime PM reference whenever the display is unblanked
there is no need for the runtime power management to disable and enable
the display, and doing so would lead to runtime PM trying to recurse into
itself when called from the blanking code, so split the runtime PM into
separate functions which only deal with the clocks. The PM core will
runtime resume the device prior to system suspend.Signed-off-by: Mark Brown
Acked-by: Jingoo Han
Signed-off-by: Florian Tobias Schandinat -
Signed-off-by: Mark Brown
Acked-by: Jingoo Han
Signed-off-by: Florian Tobias Schandinat -
The s3c-fb driver has a function called s3c_fb_enable() which turns on
and off the physical output. However it is only actually used in paths
which disable the screen, the enabling just writes to the register. Make
the code less confusing by ensuring that the enable also goes through
the same path.Signed-off-by: Mark Brown
Acked-by: Jingoo Han
Signed-off-by: Florian Tobias Schandinat -
The change in "video: s3c-fb: modify runtime pm functions" (commit
35784b) renders the runtime power management for the device completely
ineffectual as while it leaves runtime power management notionally
enabled a runtime power reference is held for the entire time the device
is registered meaning it will never actually do anything.A further issue is introduced as runtime power management is added
during the system suspend path which is not something which drivers are
supposed to do and would interact poorly if there were any operations
done in the runtime power management callbacks.While this does make things simpler (the main motivation for the
original change) it will not only cause us to use more power in the
framebuffer controller but will also prevent us entering lower power
domain and SoC wide states as we can never power down the domain
containing the device. Since neither of these things is desirable
revert the change.Signed-off-by: Mark Brown
Acked-by: Jingoo Han
Signed-off-by: Florian Tobias Schandinat
20 Dec, 2011
3 commits
-
Shadow registers should be protectd whenever the registers are
updated. Shadow registers are updated after SHADOWCON shadow
register is cleared.Signed-off-by: Jingoo Han
Signed-off-by: Florian Tobias Schandinat -
Runtime suspend and runtime resume are modified in order to
reduce the complexity and improve the usability of runtime pm.
After probe function, s3c-fb driver is not suspended until
suspend or remove is called.The scheme is changed as follows:
runtime_get is only called in probe and resume.
runtime_put is only called in remove and suspend.
open/close cannot call the runtime_get/put.Also, runtime_susepnd/resume are just called by runtime pm,
not doing suspend/resume routine any longer. This is because
open/close cannot call the runtime_get/put; the suspend/resume
routine in runtime_suspend/resume were previously used when
open and close were called.The name of s3c-fb dev_pm_ops is changed from s3cfb_pm_ops to
s3c_fb_pm_ops in order to use more consistent naming.Signed-off-by: Jingoo Han
Signed-off-by: Florian Tobias Schandinat -
This patch set missing bitmask of enabled hardware window which
should be checked whenever the hardware window is enabled.Signed-off-by: Jingoo Han
Signed-off-by: Florian Tobias Schandinat
04 Dec, 2011
2 commits
-
The s3c-fb driver has separate runtime and system PM functions but the
implementations are identical so far as I can tell so unify them for
simplicity.Signed-off-by: Mark Brown
Acked-by: Jingoo Han
Signed-off-by: Florian Tobias Schandinat -
This patch converts the drivers in drivers/video/* to use the
module_platform_driver() macro which makes the code smaller and a bit
simpler.Cc: Ben Dooks
Cc: Manuel Lauss
Signed-off-by: Axel Lin
Acked-by: Wan ZongShun
Acked-by: Sascha Hauer
Acked-by: Lennert Buytenhek
Acked-by: Alexey Charkov
Acked-by: Damian Hobson-Garcia
Acked-by: Jingoo Han
Signed-off-by: Florian Tobias Schandinat
12 Nov, 2011
1 commit
-
Transparency length is fixed for pixel blending in order to support
ARGB 8888 format.Signed-off-by: Jingoo Han
Signed-off-by: Florian Tobias Schandinat