Eric Lee / smarc-fsl-linux-kernel

10 Aug, 2010

1 commit

  • 2ee7c922f   sys_personality: remove the bogus checks in sys_personality()->__set_personality() path ... Browse Code »

    Cleanup, no functional changes.

    - __set_personality() always changes ->exec_domain/personality, the
    special case when ->exec_domain remains the same buys nothing but
    complicates the code. Unify both cases to simplify the code.

    - The -EINVAL check in sys_personality() was never right. If we assume
    that set_personality() can fail we should check the value it returns
    instead of verifying that task->personality was actually changed.

    Remove it. Before the previous patch it was possible to hit this case
    due to overflow problems, but this -EINVAL just indicated the kernel
    bug.

    OTOH, probably it makes sense to change lookup_exec_domain() to return
    ERR_PTR() instead of default_exec_domain if the search in exec_domains
    list fails, and report this error to the user-space. But this means
    another user-space change, and we have in-kernel users which need fixes.
    For example, PER_OSF4 falls into PER_MASK for unkown reason and nobody
    cares to register this domain.

    Signed-off-by: Oleg Nesterov
    Cc: Wenming Zhang
    Cc: "H. Peter Anvin"
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Oleg Nesterov
     

05 Jun, 2010

1 commit

  • 485d52768   sys_personality: change sys_personality() to accept "unsigned int" instead of u_long ... Browse Code »

    task_struct->pesonality is "unsigned int", but sys_personality() paths use
    "unsigned long pesonality". This means that every assignment or
    comparison is not right. In particular, if this argument does not fit
    into "unsigned int" __set_personality() changes the caller's personality
    and then sys_personality() returns -EINVAL.

    Turn this argument into "unsigned int" and avoid overflows. Obviously,
    this is the user-visible change, we just ignore the upper bits. But this
    can't break the sane application.

    There is another thing which can confuse the poorly written applications.
    User-space thinks that this syscall returns int, not long. This means
    that the returned value can be negative and look like the error code. But
    note that libc won't be confused and thus errno won't be set, and with
    this patch the user-space can never get -1 unless sys_personality() really
    fails. And, most importantly, the negative RET != -1 is only possible if
    that app previously called personality(RET).

    Pointed-out-by: Wenming Zhang
    Suggested-by: Linus Torvalds
    Signed-off-by: Oleg Nesterov
    Cc: "H. Peter Anvin"
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Oleg Nesterov
     

01 Apr, 2009

2 commits

14 Jan, 2009

1 commit

23 Oct, 2008

1 commit

27 Jul, 2008

1 commit

22 Jul, 2008

1 commit

19 Oct, 2007

1 commit

01 Jul, 2006

1 commit

24 Mar, 2006

1 commit

17 Apr, 2005

1 commit

  • 1da177e4c   Linux-2.6.12-rc2 ... Browse Code »

    Initial git repository build. I'm not bothering with the full history,
    even though we have it. We can create a separate "historical" git
    archive of that later if we want to, and in the meantime it's about
    3.2GB when imported into git - space that would just make the early
    git days unnecessarily complicated, when we don't have a lot of good
    infrastructure for it.

    Let it rip!

    Linus Torvalds