12 Jan, 2009
1 commit
-
fix m68k build failure:
tip/kernel/up.c: In function 'smp_call_function_single':
tip/kernel/up.c:16: error: dereferencing pointer to incomplete type
make[2]: *** [kernel/up.o] Error 1Signed-off-by: Ingo Molnar
11 Jan, 2009
2 commits
-
Impact: build fix on Alpha
kernel/up.c: In function 'smp_call_function_single':
kernel/up.c:12: error: 'cpuid' undeclared (first use in this function)
kernel/up.c:12: error: (Each undeclared identifier is reported only once
kernel/up.c:12: error: for each function it appears in.)The typo didnt show up on x86 because 'cpuid' happens to be a
function address as well ...Signed-off-by: Ingo Molnar
-
If you do
smp_call_function_single(expression-with-side-effects, ...)
then expression-with-side-effects never gets evaluated on UP builds.
As always, implementing it in C is the correct thing to do.
While we're there, uninline it for size and possible header dependency
reasons.And create a new kernel/up.c, as a place in which to put
uniprocessor-specific code and storage. It should mirror kernel/smp.c.Signed-off-by: Andrew Morton
Signed-off-by: Ingo Molnar