15 Sep, 2005
6 commits
-
per-socket multicast filters were not being applied to all sockets
in the case of an exact-match bound address, due to an over-exuberant
"return" in the look-up code. Fix below. IPv4 does not have this problem.Thanks to Hoerdt Mickael for reporting the bug.
Signed-off-by: David L Stevens
Signed-off-by: David S. Miller -
ip_vs_ftp when loaded can create NAT connections with unknown client
port for passive FTP. For such expectations we lookup with cport=0 on
incoming packet but it matches the format of the persistence templates
causing packets to other persistent virtual servers to be forwarded to
real server without creating connection. Later the reply packets are
treated as foreign and not SNAT-ed.This patch changes the connection lookup for packets from clients:
* introduce IP_VS_CONN_F_TEMPLATE connection flag to mark the
connection as template* create new connection lookup function just for templates -
ip_vs_ct_in_get* make sure ip_vs_conn_in_get hits only connections with
IP_VS_CONN_F_NO_CPORT flag set when s_port is 0. By this way
we avoid returning template when looking for cport=0 (ftp)Signed-off-by: Julian Anastasov
Signed-off-by: David S. Miller -
Agostino di Salle noticed that persistent templates are not
invalidated due to buggy optimization.Signed-off-by: Julian Anastasov
Signed-off-by: David S. Miller -
Here's a slightly altered patch, originally from Mark Glines who
diagnosed and fixed the problem.Signed-off-by: Bart De Schuymer
Signed-off-by: David S. Miller -
This patch fixes line dupes at /ipv4/igmp.c and /ipv6/mcast.c in the
2.6 kernel, where MCAST_EXCLUDE is mistakenly used instead of
MCAST_INCLUDE.Signed-off-by: Denis Lukianov
Signed-off-by: David L Stevens
Signed-off-by: David S. Miller -
The problem is that the SACK fragmenting code may incorrectly call
tcp_fragment() with a length larger than the skb->len. This happens
when the skb on the transmit queue completely falls to the LHS of the
SACK.And add a BUG() check to tcp_fragment() so we can spot this kind of
error more quickly in the future.Signed-off-by: Herbert Xu
Signed-off-by: David S. Miller
14 Sep, 2005
8 commits
-
Eliciting a SYNCACK in response, we were handling SYNC packets
only in the DCCP_OPEN state, in dccp_rcv_established.Signed-off-by: Arnaldo Carvalho de Melo
-
It is possible to receive more than one CLOSEREQ packet if the
CLOSE packet sent in response is somehow lost, change the state
to DCCP_CLOSING only on the first CLOSEREQ packet received.Signed-off-by: Arnaldo Carvalho de Melo
-
In 2.6.13-rcX the MASQUERADE target was changed not to exclude local
packets for better source address consistency. This breaks DHCP clients
using UDP sockets when the DHCP requests are caught by a MASQUERADE rule
because the MASQUERADE target drops packets when no address is configured
on the outgoing interface. This patch makes it ignore packets with a
source address of 0.Thanks to Rusty for this suggestion.
Signed-off-by: Patrick McHardy
Signed-off-by: David S. Miller -
Signed-off-by: Patrick McHardy
Signed-off-by: David S. Miller -
Don't parse the packet, the data is already available in the conntrack
structure.Signed-off-by: Patrick McHardy
Signed-off-by: David S. Miller -
With large port numbers the helper_names buffer can overflow.
Noticed by Samir BellabesSigned-off-by: Patrick McHardy
Signed-off-by: David S. Miller
13 Sep, 2005
16 commits
-
Change a printk(KERN_WARNING to dprintk, and it is really only interesting
when trying to debug a problem, and can occur normally without error.Remove various gratuitous gotos in surrounding code, and remove some
type-cast assignments from inside 'if' conditionals, as that is just
obscuring what it going on.Signed-off-by: Neil Brown
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds -
This patch adds additional checks to prevent RFCOMM connections be
established through the RAW socket interface.Signed-off-by: Marcel Holtmann
-
This patch adds the handling of the extended inquiry responses and
inserts them into the inquiry cache.Signed-off-by: Marcel Holtmann
-
NET/ROM's virtual interfaces don't have a proper private data
structure yet. Create struct nr_private and put the statistics there.Signed-off-by: Ralf Baechle DL5RB
Signed-off-by: David S. Miller -
NET/ROM is lacking a connection reset like TCP's RST flag which at times
may result in a connecting having to slowly timing out instead of just being
reset. An earlier attempt to reset the connection by sending a
NR_CONNACK | NR_CHOKE_FLAG transport was inacceptable as it did result in
crashes of BPQ systems. An alternative approach of introducing a new
transport type 7 (NR_RESET) has be implemented several years ago in
Paula Jayne Dowie G8PZT's Xrouter.Implement NR_RESET for Linux's NET/ROM but like any messing with the state
engine consider this experimental for now and thus control it by a sysctl
(net.netrom.reset) which for the time being defaults to off.Signed-off-by: Ralf Baechle DL5RB
Signed-off-by: David S. Miller -
ARP over ROSE does not exist so it's obviously not implemented on any
ROSE stack, so the ROSE interfaces really should default to IFF_NOARP.Signed-off-by: Ralf Baechle DL5RB
Signed-off-by: David S. Miller -
ARP over NET/ROM does not exist so it's obviously not implemented on any
NET/ROM stack, so the NET/ROM interfaces really should default to IFF_NOARP.Signed-off-by: Ralf Baechle DL5RB
Signed-off-by: David S. Miller -
NET/ROM uses virtual interfaces so setting a queue length is wrong.
Signed-off-by: Ralf Baechle DL5RB
Signed-off-by: David S. Miller -
Reformat iniitalization of ax25_proto_ops.
Signed-off-by: Ralf Baechle DL5RB
Signed-off-by: David S. Miller -
Small formatting changes.
Signed-off-by: Ralf Baechle DL5RB
Signed-off-by: David S. Miller -
Remove error tests that have already been performed by the caller.
Signed-off-by: Ralf Baechle DL5RB
Signed-off-by: David S. Miller -
Calling an incoming NET/ROM-encapsulated IP packet an error if the
interface isn't up is probably a bit over the top, so count it as
dropped instead of an error.Signed-off-by: Ralf Baechle DL5RB
Signed-off-by: David S. Miller -
For reason that probably nobody recalls NET/ROM does it's actual
packet transmission in nr_rebuild_header and even treats invocation of
it's hard_start_xmit method nr_xmit as a bug. Fix that by splitting
the job done by nr_rebuild_header into two halves. Along with that we
now also can get rid of the silly clone of the skb on transmit.Signed-off-by: Ralf Baechle DL5RB
Signed-off-by: David S. Miller -
Rename ax25_encapsulate to ax25_hard_header which these days more
accurately describes what the function is supposed to do.Signed-off-by: Ralf Baechle DL5RB
Signed-off-by: David S. Miller -
Signed-off-by: Arnaldo Carvalho de Melo
Signed-off-by: David S. Miller -
Use schedule_timeout_{,un}interruptible() instead of
set_current_state()/schedule_timeout() to reduce kernel size. Also use
human-time conversion functions instead of hard-coded division to avoid
rounding issues.Signed-off-by: Nishanth Aravamudan
Signed-off-by: Andrew Morton
Signed-off-by: David S. Miller
11 Sep, 2005
1 commit
-
There is an extra left_out/lost_out adjustment in tcp_fragment which
means that the lost_out accounting is always wrong. This patch removes
that chunk of code.Signed-off-by: Herbert Xu
Signed-off-by: David S. Miller
10 Sep, 2005
9 commits
-
Signed-off-by: Brian Haley
Signed-off-by: YOSHIFUJI Hideaki
Signed-off-by: David S. Miller -
Also use some BUG_ON where appropriate and use LIMIT_NETDEBUG for the unlikely
cases where we, at this stage, want to know about, that in my tests hasn't
appeared in the radar.Signed-off-by: Arnaldo Carvalho de Melo
-
Signed-off-by: Arnaldo Carvalho de Melo
-
To match more closely what is described in RFC 3448.
Signed-off-by: Arnaldo Carvalho de Melo
Signed-off-by: Ian McDonald -
This converts the final 20 DEFINE_SPINLOCK holdouts. (another 580 places
are already using DEFINE_SPINLOCK). Build tested on x86.Signed-off-by: Ingo Molnar
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds -
Clean up timer initialization by introducing DEFINE_TIMER a'la
DEFINE_SPINLOCK. Build and boot-tested on x86. A similar patch has been
been in the -RT tree for some time.Signed-off-by: Ingo Molnar
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds -
With the use of RCU in files structure, the look-up of files using fds can now
be lock-free. The lookup is protected by rcu_read_lock()/rcu_read_unlock().
This patch changes the readers to use lock-free lookup.Signed-off-by: Maneesh Soni
Signed-off-by: Ravikiran Thirumalai
Signed-off-by: Dipankar Sarma
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
