Eric Lee / smarc-fsl-linux-kernel

01 Dec, 2008

1 commit

  • 211f05a03   input: replace spin_lock_bh with spin_lock_irqsave in ml_ff_playback ... Browse Code »

    ml_ff_playback() uses spin_(un)lock_bh. However this function is called
    with interrupts disabled from erase_effect() in drivers/input/ff-core.c:196.

    This is not permitted, and will result in a WARN_ON in the bottom half handling code.
    This patch changes this function to just use spin_lock_irqsave() instead, solving
    the problem and simplifying the locking logic.

    This was reported as entry #106559 in kerneloops.org

    Reported-by: kerneloops.org
    Signed-off-by: Arjan van de Ven
    Signed-off-by: Linus Torvalds

    Arjan van de Ven
     

17 May, 2008

1 commit

15 Feb, 2007

1 commit

  • cd354f1ae   [PATCH] remove many unneeded #includes of sched.h ... Browse Code »

    After Al Viro (finally) succeeded in removing the sched.h #include in module.h
    recently, it makes sense again to remove other superfluous sched.h includes.
    There are quite a lot of files which include it but don't actually need
    anything defined in there. Presumably these includes were once needed for
    macros that used to live in sched.h, but moved to other header files in the
    course of cleaning it up.

    To ease the pain, this time I did not fiddle with any header files and only
    removed #includes from .c-files, which tend to cause less trouble.

    Compile tested against 2.6.20-rc2 and 2.6.20-rc2-mm2 (with offsets) on alpha,
    arm, i386, ia64, mips, powerpc, and x86_64 with allnoconfig, defconfig,
    allmodconfig, and allyesconfig as well as a few randconfigs on x86_64 and all
    configs in arch/arm/configs on arm. I also checked that no new warnings were
    introduced by the patch (actually, some warnings are removed that were emitted
    by unnecessarily included header files).

    Signed-off-by: Tim Schmielau
    Acked-by: Russell King
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Tim Schmielau
     

24 Nov, 2006

1 commit

19 Jul, 2006

1 commit