30 Dec, 2008
1 commit
-
I hit similar build failure due to the change in the netif_rx_reschedule()
drivers/net/ehea/ehea_main.c: In function 'ehea_poll':
drivers/net/ehea/ehea_main.c:844: warning: passing argument 1 of 'netif_rx_reschedule' from incompatible pointer type
drivers/net/ehea/ehea_main.c:844: error: too many arguments to function 'netif_rx_reschedule'
make[3]: *** [drivers/net/ehea/ehea_main.o] Error 1greping through the sources for the changes missed out, we have
./drivers/net/arm/ixp4xx_eth.c:507: netif_rx_reschedule(dev, napi)) {
./drivers/net/arm/ep93xx_eth.c:310: if (more && netif_rx_reschedule(dev, napi))
./drivers/net/wan/ixp4xx_hss.c:657: netif_rx_reschedule(dev, napi)) {Signed-off-by: Kamalesh Babulal
Acked-by: Neil Horman
Signed-off-by: David S. Miller
26 Dec, 2008
5 commits
-
The symbols are only references within the translation unit they are
defined in, so un-EXPORT them und make them 'static'.Fix this sparse warnings:
drivers/net/wan/z85230.c:604:25: warning: symbol 'z8530_dma_sync' was not declared. Should it be static?
drivers/net/wan/z85230.c:613:25: warning: symbol 'z8530_txdma_sync' was not declared. Should it be static?Signed-off-by: Hannes Eder
Signed-off-by: David S. Miller -
Fix this sparse warning:
drivers/net/wan/x25_asy.c:623:5: warning: symbol 'x25_asy_esc' was not declared. Should it be static?
Signed-off-by: Hannes Eder
Signed-off-by: David S. Miller -
Fix this sparse warnings:
drivers/net/wan/wanxl.c:414:3: warning: do-while statement is not a compound statement
drivers/net/wan/wanxl.c:441:3: warning: do-while statement is not a compound statementSigned-off-by: Hannes Eder
Signed-off-by: David S. Miller -
arg is checked not to be NULL a few lines before.
A simplified version of the semantic patch that makes this change is as
follows: (http://www.emn.fr/x-info/coccinelle/)//
@r exists@
local idexpression x;
expression E;
position p1,p2;
@@if (x@p1 == NULL || ...) { ... when forall
return ...; }
... when != \(x=E\|x--\|x++\|--x\|++x\|x-=E\|x+=E\|x|=E\|x&=E\|&x\)
(
x@p2 == NULL
|
x@p2 != NULL
)// another path to the test that is not through p1?
@s exists@
local idexpression r.x;
position r.p1,r.p2;
@@... when != x@p1
(
x@p2 == NULL
|
x@p2 != NULL
)@fix depends on !s@
position r.p1,r.p2;
expression x,E;
statement S1,S2;
@@(
- if ((x@p2 != NULL) || ...)
S1
|
- if ((x@p2 == NULL) && ...) S1
|
- BUG_ON(x@p2 == NULL);
)
//Signed-off-by: Julia Lawall
Signed-off-by: David S. Miller
23 Dec, 2008
1 commit
-
When the napi api was changed to separate its 1:1 binding to the net_device
struct, the netif_rx_[prep|schedule|complete] api failed to remove the now
vestigual net_device structure parameter. This patch cleans up that api by
properly removing it..Signed-off-by: Neil Horman
Signed-off-by: David S. Miller
22 Dec, 2008
4 commits
-
arg is checked not to be NULL a few lines before.
A simplified version of the semantic patch that makes this change is as
follows: (http://www.emn.fr/x-info/coccinelle/)//
@r exists@
local idexpression x;
expression E;
position p1,p2;
@@if (x@p1 == NULL || ...) { ... when forall
return ...; }
... when != \(x=E\|x--\|x++\|--x\|++x\|x-=E\|x+=E\|x|=E\|x&=E\|&x\)
(
x@p2 == NULL
|
x@p2 != NULL
)// another path to the test that is not through p1?
@s exists@
local idexpression r.x;
position r.p1,r.p2;
@@... when != x@p1
(
x@p2 == NULL
|
x@p2 != NULL
)@fix depends on !s@
position r.p1,r.p2;
expression x,E;
statement S1,S2;
@@(
- if ((x@p2 != NULL) || ...)
S1
|
- if ((x@p2 == NULL) && ...) S1
|
- BUG_ON(x@p2 == NULL);
)
//Signed-off-by: Julia Lawall
Signed-off-by: Krzysztof Hałasa -
Signed-off-by: Krzysztof Hałasa
-
Signed-off-by: Krzysztof Hałasa
-
Signed-off-by: Krzysztof Hałasa
06 Dec, 2008
2 commits
-
Remove all the extra casting while we are cleaning up
Signed-off-by: Alan Cox
Signed-off-by: David S. Miller -
We have various drivers that poke around directly and we need to clean this
up before it causes problems.Signed-off-by: Alan Cox
Signed-off-by: David S. Miller
26 Nov, 2008
1 commit
-
this warning:
drivers/net/wan/z85230.c: In function ‘z8530_interrupt’:
drivers/net/wan/z85230.c:713: warning: ‘intr’ may be used uninitialized in this functionis clearly bogus - annotate it.
Signed-off-by: Ingo Molnar
Signed-off-by: David S. Miller
25 Nov, 2008
1 commit
-
1. convert netdev->priv to netdev_priv().
2. make sbni_pci_probe() be static.Signed-off-by: Wang Chen
Signed-off-by: David S. Miller
22 Nov, 2008
19 commits
-
pc300too driver works around a bug in PCI9050 bridge. Unfortunately
it was doing that too late.Signed-off-by: Krzysztof Hałasa
-
Signed-off-by: Krzysztof Hałasa
-
Signed-off-by: Krzysztof Hałasa
-
Signed-off-by: Krzysztof Hałasa
-
Signed-off-by: Krzysztof Hałasa
-
Signed-off-by: Krzysztof Hałasa
-
Signed-off-by: Krzysztof Hałasa
-
Signed-off-by: Krzysztof Hałasa
-
Signed-off-by: Krzysztof Hałasa
-
Signed-off-by: Krzysztof Hałasa
-
Signed-off-by: Krzysztof Hałasa
-
Signed-off-by: Krzysztof Hałasa
-
Signed-off-by: Krzysztof Hałasa
-
Signed-off-by: Krzysztof Hałasa
-
Signed-off-by: Krzysztof Hałasa
-
Supporting both original SCA and SCA-II in one file was nice at some
point but now it's increasingly painful.Signed-off-by: Krzysztof Hałasa
-
When compile test my previous patch, I found PC300 driver was broken.
And there is no explanation about the broken.
Add the reason about why change this driver to broken in Kconfig.Signed-off-by: Wang Chen
Signed-off-by: David S. Miller -
netdev's private data should be hdlc.
pc300dev_t is the private data of hdlc.Signed-off-by: Wang Chen
Signed-off-by: David S. Miller -
For killing directly reference of netdev->priv, use netdev->ml_priv to replace it.
Because the private pvc data comes from add_pvc() and can't be allocated in
alloc_netdev().Signed-off-by: Wang Chen
Acked-by: Krzysztof Halasa
Signed-off-by: David S. Miller
20 Nov, 2008
1 commit
-
1. Make device driver to allocate memory for netdev.
2. Convert all directly reference of netdev->priv to netdev_priv().Signed-off-by: Wang Chen
Signed-off-by: David S. Miller
13 Nov, 2008
1 commit
-
We have some reasons to kill netdev->priv:
1. netdev->priv is equal to netdev_priv().
2. netdev_priv() wraps the calculation of netdev->priv's offset, obviously
netdev_priv() is more flexible than netdev->priv.
But we cann't kill netdev->priv, because so many drivers reference to it
directly.This patch is a safe convert for netdev->priv to netdev_priv(netdev).
Since all of the netdev->priv is only for read.
But it is too big to be sent in one mail.
I split it to 4 parts and make every part smaller than 100,000 bytes,
which is max size allowed by vger.Signed-off-by: Wang Chen
Signed-off-by: David S. Miller
04 Nov, 2008
1 commit
-
The generic packet receive code takes care of setting
netdev->last_rx when necessary, for the sake of the
bonding ARP monitor.Drivers need not do it any more.
Some cases had to be skipped over because the drivers
were making use of the ->last_rx value themselves.Signed-off-by: David S. Miller
31 Oct, 2008
3 commits
-
Conflicts:
drivers/net/wireless/p54/p54common.c
-
Remove excess kernel-doc function parameters from networking header
& driver files:Warning(include/net/sock.h:946): Excess function parameter or struct member 'sk' description in 'sk_filter_release'
Warning(include/linux/netdevice.h:1545): Excess function parameter or struct member 'cpu' description in 'netif_tx_lock'
Warning(drivers/net/wan/z85230.c:712): Excess function parameter or struct member 'regs' description in 'z8530_interrupt'Signed-off-by: Randy Dunlap
Signed-off-by: David S. Miller -
Use the newly introduced pci_ioremap_bar() function in drivers/net.
pci_ioremap_bar() just takes a pci device and a bar number, with the goal
of making it really hard to get wrong, while also having a central place
to stick sanity checks.Signed-off-by: Arjan van de Ven
Signed-off-by: Jeff Garzik
