19 Oct, 2006
14 commits
-
This patch (as797) fixes device_add() in the driver core. It needs to
pay attention when the driver for a new device reports an error.At the same time, since bus_remove_device() undoes the effects of both
bus_add_device() and bus_attach_device(), it needs to check whether
the bus_attach_device step failed.Signed-off-by: Alan Stern
Signed-off-by: Greg Kroah-Hartman -
If kmalloc() fails to allocate space for 'old_symlink_name' in
drivers/base/core.c::device_rename(), then we'll leak 'old_class_name'.Spotted by the Coverity checker.
Signed-off-by: Jesper Juhl
Signed-off-by: Greg Kroah-Hartman -
Return the return value of sysfs_create_group() in topology_add_dev().
Signed-off-by: Cornelia Huck
Signed-off-by: Greg Kroah-Hartman -
Check for device_create_file() return value in dma_pool_create().
Signed-off-by: Cornelia Huck
Signed-off-by: Greg Kroah-Hartman -
Check for return code of device_create_file() and correct cleanup in
the error case in device_add().Signed-off-by: Cornelia Huck
Signed-off-by: Greg Kroah-Hartman -
Correct cleanup in the error path of bus_add_device().
Signed-off-by: Cornelia Huck
Signed-off-by: Greg Kroah-Hartman -
Check return value of bus_add_attrs() in bus_register().
Signed-off-by: Cornelia Huck
Signed-off-by: Greg Kroah-Hartman -
Check for return value of sysfs_create_link() in class_device_add().
Signed-off-by: Cornelia Huck
Signed-off-by: Greg Kroah-Hartman -
And the obsolete comment should be updated (or totally removed).
Signed-off-by: Hidetoshi Seto
Signed-off-by: Greg Kroah-Hartman -
Following function can drops d_count twice against one reference
by lookup_one_len./**
* sysfs_update_file - update the modified timestamp on an object attribute.
* @kobj: object we're acting for.
* @attr: attribute descriptor.
*/
int sysfs_update_file(struct kobject * kobj, const struct attribute * attr)
{
struct dentry * dir = kobj->dentry;
struct dentry * victim;
int res = -ENOENT;mutex_lock(&dir->d_inode->i_mutex);
victim = lookup_one_len(attr->name, dir, strlen(attr->name));
if (!IS_ERR(victim)) {
/* make sure dentry is really there */
if (victim->d_inode &&
(victim->d_parent->d_inode == dir->d_inode)) {
victim->d_inode->i_mtime = CURRENT_TIME;
fsnotify_modify(victim);/**
* Drop reference from initial sysfs_get_dentry().
*/
dput(victim);
res = 0;
} else
d_drop(victim);/**
* Drop the reference acquired from sysfs_get_dentry() above.
*/
dput(victim);
}
mutex_unlock(&dir->d_inode->i_mutex);return res;
}PCI-hotplug (drivers/pci/hotplug/pci_hotplug_core.c) is only user of
this function. I confirmed that dentry of /sys/bus/pci/slots/XXX/*
have negative d_count value.This patch removes unnecessary dput().
Signed-off-by: Hidetoshi Seto
Acked-by: Maneesh Soni
Signed-off-by: Greg Kroah-Hartman -
I suspect that not many people is subscribed to the bugzilla mailing list,
not surprising since the URLs doesn't seem to be in the tree :)After fixing my english, I wonder if the following patch could be applied...
Signed-off-by: Diego Calleja
Acked-by: Randy Dunlap
Signed-off-by: Greg Kroah-Hartman -
Make dev_printk usable from non-GPL modules again
dev_printk now calls dev_driver_string. We want even proprietary modules
to be calling dev_printk, so the export of dev_driver_string needs to be
non-GPL-only.Signed-off-by: Matthew Wilcox
Signed-off-by: Greg Kroah-Hartman -
Make sure data is freed if the kthread fails to start.
Signed-off-by: Duncan Sands
Signed-off-by: Greg Kroah-Hartman -
Fix typo in newly added feature remove schedule item.
Signed-off-by: Dominik Brodowski
Cc: Kay Sievers
Signed-off-by: Greg Kroah-Hartman
18 Oct, 2006
26 commits
-
Signed-off-by: David S. Miller
-
This patch fixes a typo to make kernel compilable when floppy driver
for Sparc is build.Signed-off-by: Krzysztof Helt
Signed-off-by: David S. Miller -
This patch adds profiling support to the sparc architecture. It is a
copy of the sparc64 implementation.Signed-off-by: Martin Habets
Signed-off-by: David S. Miller -
We should not be calling kernel_execve() directly and this
causes module build failures because kernel_execve() is not
exported to modules.Signed-off-by: David S. Miller
-
Signed-off-by: Ben Collins
Signed-off-by: David S. Miller -
For Hummingbird PCI controllers, we should create the root
PCI memory space resource as the full 4GB area, and then
allocate the IOMMU DMA translation window out of there.The old code just assumed that the IOMMU DMA translation base
to the top of the 4GB area was unusable. This is not true on
many systems such as SB100 and SB150, where the IOMMU DMA
translation window sits at 0xc0000000->0xdfffffff.So what would happen is that any device mapped by the firmware
at the top section 0xe0000000->0xffffffff would get remapped
by Linux somewhere else leading to all kinds of problems and
boot failures.While we're here, report more cases of OBP resource assignment
conflicts. The only truly valid ones are ROM resource conflicts.Signed-off-by: David S. Miller
-
Unused, but still allow the '-s' boot option to be passed
down to init.Based upon patches by Martin Habets.
Signed-off-by: David S. Miller
-
It would fail the compile due to the newly added error checking testing
a bad macro for a "return value" unless USB_GADGET_DEBUG_FILES was
enabled.Pointed out by Stephen Hemminger.
Acked-by: Stephen Hemminger
Signed-off-by: Linus Torvalds -
* master.kernel.org:/pub/scm/linux/kernel/git/gregkh/usb-2.6: (47 commits)
USB: Add device id for Sierra Wireless MC8755
USB: cleanup sierra wireless driver a bit
USB: Sierra Wireless driver update
USB: ftdi_sio whitespace fixes
USB-SERIAL:cp2101 Add new device ID
USB/gadget/net2280: handle sysfs errors
usbtouchscreen: fix data reading for ITM touchscreens
UEAGLE: fix ueagle-atm Oops
USB: xpad: dance pad support
USB: input: extract() and implement() are bit field manipulation routines
USB: Memory leak in drivers/usb/serial/airprime.c
USB Storage: unusual_devs.h entry for Sony Ericsson P990i
USB: fix usbatm tiny race
USB: unusual_devs entry for Nokia 6234
USB: mos7840.c: fix a check-after-dereference
USB: ftdi-elan.c: remove dead code
USB: Mitsumi USB FDD 061M: UNUSUAL_DEV multilun fix
USB: fix dereference in drivers/usb/misc/adutux.c
USB: add USB serial mos7720 driver
USB: move trancevibrator.c to the proper usb directory
... -
* 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/roland/infiniband:
IB/mthca: Use mmiowb after doorbell ring
IB/ipath: Initialize diagpkt file on device init only
RDMA/amso1100: Fix a NULL dereference in error path
RDMA/amso1100: pci_module_init() conversion -
Adds the device id used by the UMTS cards in Lenovo X60s notebooks sold
in Europe.Signed-off-by: Jan Luebbe
Cc: Kevin Lloyd
Signed-off-by: Greg Kroah-Hartman -
This saves over 30 lines and fixes a warning from sparse and allows
debugging to work dynamically like all other usb-serial drivers.Cc: Kevin Lloyd
Signed-off-by: Greg Kroah-Hartman -
The largest feature in this patch is that it adds significant throughput
increase to the Sierra driver and adds support for modem status line
control (e.g. the DTR line). This patch also updates the current sierra.c
driver so that it supports both 3-port Sierra devices and 1-port legacy
devices and removes Sierra's references in other related files (Kconfig and
airprime.c).Signed-off-by: Kevin Lloyd
Signed-off-by: Greg Kroah-Hartman -
Whitespace fixups for drivers/usb/serial/ftdi_sio.c ...
removing end-of-line whitespace, and space-before-tab.Signed-off-by: David Brownell
Signed-off-by: Greg Kroah-Hartman -
This patch adds device ID 0xEA61. This is another factory default ID
used by SILabs.Signed-off-by: Craig Shelley
Signed-off-by: Greg Kroah-Hartman -
Signed-off-by: Jeff Garzik
Signed-off-by: Greg Kroah-Hartman -
ITM devices seem to report only garbage when not touched. update usbtouchscreen
to do data reading like itmtouch. also fix wrong mask on pressure bits.Signed-off-by: Daniel Ritz
Signed-off-by: Greg Kroah-Hartman -
The array of attribute passed to sysfs_create_group() must be
NULL-terminated.The sysfs entries are created before the start of the modem state machine
to avoid to stop it in case of errors in sysfs creation. Also
{destroy,create}_fs_entries are removed as they do nothing.Signed-off-by: Laurent Riffard
Signed-off-by: Matthieu CASTET
Signed-off-by: Andrew Morton
Signed-off-by: Greg Kroah-Hartman -
Adds support for dance pads to the xpad driver. Dance pads require the
d-pad to be mapped to four buttons instead of two axes, so that
combinations of up/down and left/right can be hit simultaneously.
Known dance pads are detected, and there is a module parameter added
to default unknown xpad devices to map the d-pad to buttons if this is
desired. (dpad_to_buttons). Minor modifications were made to port the
changes in the original patch to a newer kernel version.This patch was originally from Dominic Cerquetti originally written
for kernel 2.6.11.4, with minor modifications (API changes for USB,
spelling fixes to the documentation added in the original patch) made
to apply to the current kernel. I have modified Dominic's original
patch per some suggestions from Dmitry Torokhov. (There was nothing
in the patch format description about multiple From: lines, so I
haven't added myself.)[akpm@osdl.org: cleanups]
Signed-off-by: Adam Buchbinder
Acked-by: Dmitry Torokhov
Signed-off-by: Andrew Morton
Signed-off-by: Greg Kroah-Hartman -
extract() and implement() have brain damaged attempts to handle 32-bit wide
"fields".The problem is the index math in the original code didn't clear all the
relevant bits. (offset >> 5) only compensated for 32-bit index. We need
(offset >> 6) if we want to use 64-bit loads.But it was also wrong in that it tried to use quasi-aligned loads. Ie
"report" was only incremented in multiples of 4 bytes and then the offset
was masked off for values greater than 4 bytes. The right way is to
pretend "report" points at a byte array. And offset is then only minor
adjustment for < 8 bits of offset. "n" (field width) can then be as big as
24 (assuming 32-bit loads) since "offset" will never be bigger than 7.If someone needs either function to handle more than 24-bits, please
document why - point at a specification or specific USB hid device - in
comments in the code.extract/implement() are also an eyesore to read. Please banish whoever
wrote it to read CodingStyle 3 times in a row to a classroom full of 1st
graders armed with rubberbands. Or just flame them. Whatever. Globbing
all the code together on two lines does NOT make it faster and is Just
Wrong.I've tested this patch on j6000 (dual 750Mhz PA-RISC, 32-bit 2.6.12-rc5).
Kyle McMartin tested on c3000 (up 400Mhz PA-RISC, same kernel). "p2-mate"
(Peter De Schrijver?) tested on sb1250 (dual core Mips, broadcom "swarm"
eval board).Signed-off-by: Grant Grundler
Signed-off-by: Matthew Wilcox
Cc: Vojtech Pavlik
Cc: Dmitry Torokhov
Signed-off-by: Andrew Morton
Signed-off-by: Greg Kroah-Hartman -
the commit
http://www.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=5dda171202f94127e49c12daf780cdae1b4e668b
added a memory leak. In case we cant allocate an urb, we dont free the
buffer and leak it. Coverity id #1438Signed-off-by: Eric Sesterhenn
Acked-by: Andy Gay
Signed-off-by: Andrew Morton
Signed-off-by: Greg Kroah-Hartman -
USB Storage: this patch adds support for Sony Ericsson P990i
Signed-off-by: Jan Mate
Signed-off-by: Andrew Morton
Signed-off-by: Greg Kroah-Hartman -
ia64:
drivers/usb/atm/usbatm.c: In function `usbatm_do_heavy_init':
drivers/usb/atm/usbatm.c:1004: warning: implicit declaration of function `get_current'
drivers/usb/atm/usbatm.c:1004: error: invalid type argument of `->'Signed-off-by: Duncan Sands
Signed-off-by: Andrew Morton
Signed-off-by: Greg Kroah-Hartman -
This patch (as803) adds an unusual_devs entry for the Nokia 6234
mobile phone.Signed-off-by: Alan Stern
Signed-off-by: Greg Kroah-Hartman -
This patch fixes an obvious check-after-dereference spotted by the
Coverity checker.Signed-off-by: Adrian Bunk
Signed-off-by: Greg Kroah-Hartman -
The Coverity checker spotted this obviously dead code.
Signed-off-by: Adrian Bunk
Signed-off-by: Greg Kroah-Hartman
