Eric Lee / smarc-fsl-linux-kernel

06 May, 2007

17 commits

01 Apr, 2007

1 commit

  • 07da60c1f   [SCSI] lpfc: fix oops when parsing dodgy VPD ... Browse Code »

    We have seen two cases where VPD on an emulex card has been incorrect
    and we end up walking off the end of memory. It looks like someone made
    an update (increased the length of a string) without increasing the
    Length field. Then we do:

    Length -= (3+i);

    And since Length is unsigned it becomes very large and we loop forever
    in the encapsulating:

    while (Length > 0) {

    If we make Length signed then we fall out of the loop and proceed on.

    Its important to note we have only seen this in the lab and it may be
    the only two cases of this in existence, but since the rest of the code
    has been written to be resilient against bad VPD we may as well fix this
    too.

    Signed-off-by: Anton Blanchard
    Acked-by: James Smart
    Signed-off-by: James Bottomley

    Anton Blanchard
     

11 Mar, 2007

1 commit

  • 5daa49ef0   [SCSI] lpfc: avoid double-free during PCI error failure ... Browse Code »

    If a PCI error is detected that cannot be recovered from, there
    will be a double call of lpfc_pci_remove_one(), with the second call
    resulting in a null-pointer dereference. The first call occurs in
    lpfc_io_error_detected(), and the second call during pci device
    remove. This patch eliminates the first call; its un-needed.

    Signed-off-by: Linas Vepstas
    Acked-by: James Smart
    Signed-off-by: James Bottomley

    Linas Vepstas
     

16 Feb, 2007

1 commit

  • 8d63f3750   [SCSI] lpfc: add PCI error recovery support ... Browse Code »

    This patch adds PCI Error recovery support to the
    Emulex Lightpulse Fibrechannel (lpfc) SCSI device driver.
    Lightly tested at this point, works.

    Signed-off-by: Linas Vepstas
    Acked-by: Bino.Sebastian@Emulex.Com
    Acked-by: James Smart
    Signed-off-by: James Bottomley

    Linas Vepstas
     

06 Jan, 2007

1 commit

03 Dec, 2006

9 commits

31 Oct, 2006

1 commit

  • 7259f0d05   [PATCH] lockdep: annotate DECLARE_WAIT_QUEUE_HEAD ... Browse Code »

    kernel: INFO: trying to register non-static key.
    kernel: the code is fine but needs lockdep annotation.
    kernel: turning off the locking correctness validator.
    kernel: [] show_trace_log_lvl+0x58/0x16a
    kernel: [] show_trace+0xd/0x10
    kernel: [] dump_stack+0x19/0x1b
    kernel: [] __lock_acquire+0xf0/0x90d
    kernel: [] lock_acquire+0x4b/0x6b
    kernel: [] _spin_lock_irqsave+0x22/0x32
    kernel: [] prepare_to_wait+0x17/0x4b
    kernel: [] lpfc_do_work+0xdd/0xcc2 [lpfc]
    kernel: [] kthread+0xc3/0xf2
    kernel: [] kernel_thread_helper+0x5/0xb

    Another case of non-static lockdep keys; duplicate the paradigm set by
    DECLARE_COMPLETION_ONSTACK and introduce DECLARE_WAIT_QUEUE_HEAD_ONSTACK.

    Signed-off-by: Peter Zijlstra
    Cc: Greg KH
    Cc: Markus Lidel
    Acked-by: Ingo Molnar
    Cc: Arjan van de Ven
    Cc: James Bottomley
    Cc: Marcel Holtmann
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Peter Zijlstra
     

26 Oct, 2006

2 commits

05 Oct, 2006

2 commits

  • 7d12e780e   IRQ: Maintain regs pointer globally rather than passing to IRQ handlers ... Browse Code »

    Maintain a per-CPU global "struct pt_regs *" variable which can be used instead
    of passing regs around manually through all ~1800 interrupt handlers in the
    Linux kernel.

    The regs pointer is used in few places, but it potentially costs both stack
    space and code to pass it around. On the FRV arch, removing the regs parameter
    from all the genirq function results in a 20% speed up of the IRQ exit path
    (ie: from leaving timer_interrupt() to leaving do_IRQ()).

    Where appropriate, an arch may override the generic storage facility and do
    something different with the variable. On FRV, for instance, the address is
    maintained in GR28 at all times inside the kernel as part of general exception
    handling.

    Having looked over the code, it appears that the parameter may be handed down
    through up to twenty or so layers of functions. Consider a USB character
    device attached to a USB hub, attached to a USB controller that posts its
    interrupts through a cascaded auxiliary interrupt controller. A character
    device driver may want to pass regs to the sysrq handler through the input
    layer which adds another few layers of parameter passing.

    I've build this code with allyesconfig for x86_64 and i386. I've runtested the
    main part of the code on FRV and i386, though I can't test most of the drivers.
    I've also done partial conversion for powerpc and MIPS - these at least compile
    with minimal configurations.

    This will affect all archs. Mostly the changes should be relatively easy.
    Take do_IRQ(), store the regs pointer at the beginning, saving the old one:

    struct pt_regs *old_regs = set_irq_regs(regs);

    And put the old one back at the end:

    set_irq_regs(old_regs);

    Don't pass regs through to generic_handle_irq() or __do_IRQ().

    In timer_interrupt(), this sort of change will be necessary:

    - update_process_times(user_mode(regs));
    - profile_tick(CPU_PROFILING, regs);
    + update_process_times(user_mode(get_irq_regs()));
    + profile_tick(CPU_PROFILING);

    I'd like to move update_process_times()'s use of get_irq_regs() into itself,
    except that i386, alone of the archs, uses something other than user_mode().

    Some notes on the interrupt handling in the drivers:

    (*) input_dev() is now gone entirely. The regs pointer is no longer stored in
    the input_dev struct.

    (*) finish_unlinks() in drivers/usb/host/ohci-q.c needs checking. It does
    something different depending on whether it's been supplied with a regs
    pointer or not.

    (*) Various IRQ handler function pointers have been moved to type
    irq_handler_t.

    Signed-Off-By: David Howells
    (cherry picked from 1b16e7ac850969f38b375e511e3fa2f474a33867 commit)

    David Howells
     
  • 97d41e90f   Merge master.kernel.org:/pub/scm/linux/kernel/git/jejb/scsi-misc-2.6 ... Browse Code »

    * master.kernel.org:/pub/scm/linux/kernel/git/jejb/scsi-misc-2.6: (54 commits)
    [SCSI] Initial Commit of qla4xxx
    [SCSI] raid class: handle component-add errors
    [SCSI] SCSI megaraid_sas: handle thrown errors
    [SCSI] SCSI aic94xx: handle sysfs errors
    [SCSI] SCSI st: fix error handling in module init, sysfs
    [SCSI] SCSI sd: fix module init/exit error handling
    [SCSI] SCSI osst: add error handling to module init, sysfs
    [SCSI] scsi: remove hosts.h
    [SCSI] scsi: Scsi_Cmnd convertion in aic7xxx_old.c
    [SCSI] megaraid_sas: sets ioctl timeout and updates version,changelog
    [SCSI] megaraid_sas: adds tasklet for cmd completion
    [SCSI] megaraid_sas: prints pending cmds before setting hw_crit_error
    [SCSI] megaraid_sas: function pointer for disable interrupt
    [SCSI] megaraid_sas: frame count optimization
    [SCSI] megaraid_sas: FW transition and q size changes
    [SCSI] qla2xxx: Update version number to 8.01.07-k2.
    [SCSI] qla2xxx: Stall mid-layer error handlers while rport is blocked.
    [SCSI] qla2xxx: Add MODULE_FIRMWARE tags.
    [SCSI] qla2xxx: Add support for host port state FC transport attribute.
    [SCSI] qla2xxx: Add support for fabric name FC transport attribute.
    ...

    Linus Torvalds
     

02 Oct, 2006

1 commit

  • 96b644bde   [PATCH] namespaces: utsname: use init_utsname when appropriate ... Browse Code »

    In some places, particularly drivers and __init code, the init utsns is the
    appropriate one to use. This patch replaces those with a the init_utsname
    helper.

    Changes: Removed several uses of init_utsname(). Hope I picked all the
    right ones in net/ipv4/ipconfig.c. These are now changed to
    utsname() (the per-process namespace utsname) in the previous
    patch (2/7)

    [akpm@osdl.org: CIFS fix]
    Signed-off-by: Serge E. Hallyn
    Cc: Kirill Korotaev
    Cc: "Eric W. Biederman"
    Cc: Herbert Poetzl
    Cc: Andrey Savochkin
    Cc: Serge Hallyn
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Serge E. Hallyn
     

27 Sep, 2006

1 commit

05 Sep, 2006

3 commits