04 Aug, 2014
2 commits
-
Use ATTRIBUTE_GROUPS macro and devm_hwmon_device_register_with_groups() to
simplify the code a bit.Signed-off-by: Axel Lin
Acked-by: Kevin Lo
Signed-off-by: Guenter Roeck -
Reorder functions to avoid forward declaration.
Signed-off-by: Axel Lin
Acked-by: Kevin Lo
Signed-off-by: Guenter Roeck
25 Jun, 2014
1 commit
-
Current code is buggy, it shows the current fan speed as minimum fan speed.
Fix up show_fan_reg macro to correctly report fan and fan_min speed.Signed-off-by: Axel Lin
Acked-by: Kevin Lo
Signed-off-by: Guenter Roeck
12 Dec, 2013
2 commits
-
The W83L786NG stores the fan speed on 4 bits while the sysfs interface
uses a 0-255 range. Thus the driver should scale the user input down
to map it to the device range, and scale up the value read from the
device before presenting it to the user. The reserved register nibble
should be left unchanged.Signed-off-by: Jean Delvare
Cc: stable@vger.kernel.org
Reviewed-by: Guenter Roeck -
The wrong mask is used, which causes some fan speed control modes
(pwmX_enable) to be incorrectly reported, and some modes to be
impossible to set.[JD: add subject and description.]
Signed-off-by: Brian Carnes
Cc: stable@vger.kernel.org
Signed-off-by: Jean Delvare
26 Jan, 2013
1 commit
-
SENSORS_LIMIT and the generic clamp_val have the same functionality,
and clamp_val is more efficient.This patch reduces text size by 9052 bytes and bss size by 11624 bytes
for x86_64 builds.Signed-off-by: Guenter Roeck
Acked-by: George Joseph
Acked-by: Jean Delvare
06 Nov, 2012
1 commit
-
These got broken by recent patches fixing checkpatch warnings in these
drivers. The trick is that the patches themselves looked good, but the
source files after applying them do not. That's why I am not a big fan
of using tabs inside comments.Signed-off-by: Jean Delvare
Acked-by: Guenter Roeck
10 Oct, 2012
1 commit
-
Many hwmon drivers use jiffies but omit the inclusion of the header
file. Fix that, and also fix one driver which was including the header
file but didn't need it.Signed-off-by: Jean Delvare
Acked-by: Guenter Roeck
Acked-by: Luca Tettamanti
Cc: Marc Hulsman
Cc: Rudolf Marek
24 Sep, 2012
1 commit
-
Convert to use devm_ functions to reduce code size and simplify the code.
Signed-off-by: Guenter Roeck
19 Mar, 2012
4 commits
-
Signed-off-by: Guenter Roeck
-
Fixed:
ERROR: code indent should use tabs where possible
ERROR: do not use assignment in if condition
ERROR: space required after that ',' (ctx:VxV)
WARNING: braces {} are not necessary for single statement blocks
WARNING: please, no space before tabs
WARNING: please, no spaces at the start of a line
WARNING: simple_strtol is obsolete, use kstrtol instead
WARNING: simple_strtoul is obsolete, use kstrtoul instead
WARNING: space prohibited between function name and open parenthesis '('Not fixed (false positive):
ERROR: Macros with complex values should be enclosed in parenthesisSigned-off-by: Guenter Roeck
-
This patch converts the drivers in drivers/hwmon/* to use the
module_i2c_driver() macro which makes the code smaller and a bit simpler.Signed-off-by: Axel Lin
Cc: Corentin Labbe
Cc: Dirk Eibach
Cc: "Mark M. Hoffman"
Cc: Steve Glendinning
Cc: Riku Voipio
Cc: Guillaume Ligneul
Cc: David George
Cc: "Hans J. Koch"
Cc: Marc Hulsman
Cc: Rudolf Marek
Signed-off-by: Guenter Roeck -
fix checkpatch ERROR:
return is not a function, parentheses are not requiredSigned-off-by: Frans Meulenbroeks
Signed-off-by: Guenter Roeck
13 Jan, 2012
1 commit
-
module_param(bool) used to counter-intuitively take an int. In
fddd5201 (mid-2009) we allowed bool or int/unsigned int using a messy
trick.It's time to remove the int/unsigned int option. For this version
it'll simply give a warning, but it'll break next kernel version.Acked-by: Mauro Carvalho Chehab
Signed-off-by: Rusty Russell
15 Dec, 2009
3 commits
-
This macro simply declares an enum, so drivers might as well declare
it themselves.Signed-off-by: Jean Delvare
Tested-by: Wolfram Sang -
Struct i2c_client_address_data only contains one field at this point,
which makes its usefulness questionable. Get rid of it and pass simple
address lists around instead.Signed-off-by: Jean Delvare
Tested-by: Wolfram Sang -
The "kind" parameter always has value -1, and nobody is using it any
longer, so we can remove it.Signed-off-by: Jean Delvare
Tested-by: Wolfram Sang
10 Dec, 2009
1 commit
-
As kind is now hard-coded to -1, there is room for code clean-ups.
Signed-off-by: Jean Delvare
Acked-by: Corentin Labbe
Cc: "Mark M. Hoffman"
Cc: Juerg Haefliger
Cc: Riku Voipio
Acked-by: "Hans J. Koch"
Cc: Rudolf Marek
17 Jul, 2008
1 commit
-
The new-style w83l786ng driver implements the optional detect()
callback to cover the use cases of the legacy driver.Signed-off-by: Jean Delvare
Cc: Kevin Lo
19 Feb, 2008
1 commit
-
Signed-off-by: Mark M. Hoffman
08 Feb, 2008
1 commit
-
Signed-off-by: Kevin Lo
Signed-off-by: Mark M. Hoffman
