Eric Lee / smarc-fsl-linux-kernel

20 Oct, 2014

1 commit

31 Mar, 2014

1 commit

  • 78411be4c   watchdog: geodewdt: Use platform_driver_probe ... Browse Code »

    Using platform_driver_probe instead of platform_driver_register has
    two benefits:
    * The driver will fail to load if device probing fails.
    * The probe function can be marked __init.

    Signed-off-by: Jean Delvare
    Reviewed-by: Guenter Roeck
    Signed-off-by: Wim Van Sebroeck

    Jean Delvare
     

18 Nov, 2013

1 commit

  • 487722cf2   watchdog: Get rid of MODULE_ALIAS_MISCDEV statements ... Browse Code »

    I just can't find any value in MODULE_ALIAS_MISCDEV(WATCHDOG_MINOR)
    and MODULE_ALIAS_MISCDEV(TEMP_MINOR) statements.

    Either the device is enumerated and the driver already has a module
    alias (e.g. PCI, USB etc.) that will get the right driver loaded
    automatically.

    Or the device is not enumerated and loading its driver will lead to
    more or less intrusive hardware poking. Such hardware poking should be
    limited to a bare minimum, so the user should really decide which
    drivers should be tried and in what order. Trying them all in
    arbitrary order can't do any good.

    On top of that, loading that many drivers at once bloats the kernel
    log. Also many drivers will stay loaded afterward, bloating the output
    of "lsmod" and wasting memory. Some modules (cs5535_mfgpt which gets
    loaded as a dependency) can't even be unloaded!

    If defining char-major-10-130 is needed then it should happen in
    user-space.

    Signed-off-by: Jean Delvare
    Acked-by: Guenter Roeck
    Signed-off-by: Wim Van Sebroeck
    Cc: Stephen Warren
    Cc: Mike Frysinger
    Cc: Wan ZongShun
    Cc: Ben Dooks
    Cc: Kukjin Kim
    Cc: Zwane Mwaikambo
    Cc: Jim Cromie

    Jean Delvare
     

29 Nov, 2012

3 commits

  • 4b12b896c   watchdog: remove use of __devexit ... Browse Code »

    CONFIG_HOTPLUG is going away as an option so __devexit is no
    longer needed.

    Signed-off-by: Bill Pemberton
    Cc: Wim Van Sebroeck
    Cc: Wan ZongShun
    Cc: Ben Dooks
    Cc: Kukjin Kim
    Acked-by: Mark Brown
    Signed-off-by: Greg Kroah-Hartman

    Bill Pemberton
     
  • 2d991a164   watchdog: remove use of __devinit ... Browse Code »

    CONFIG_HOTPLUG is going away as an option so __devinit is no longer
    needed.

    Signed-off-by: Bill Pemberton
    Cc: Wim Van Sebroeck
    Cc: Wan ZongShun
    Cc: Ben Dooks
    Cc: Kukjin Kim
    Acked-by: Mark Brown
    Signed-off-by: Greg Kroah-Hartman

    Bill Pemberton
     
  • 82268714b   watchdog: remove use of __devexit_p ... Browse Code »

    CONFIG_HOTPLUG is going away as an option so __devexit_p is no longer
    needed.

    Signed-off-by: Bill Pemberton
    Cc: Wim Van Sebroeck
    Cc: Wan ZongShun
    Cc: Ben Dooks
    Cc: Kukjin Kim
    Acked-by: Mark Brown
    Signed-off-by: Greg Kroah-Hartman

    Bill Pemberton
     

28 Mar, 2012

2 commits

07 Mar, 2010

1 commit

19 Dec, 2009

1 commit

25 Mar, 2009

1 commit

23 Sep, 2008

1 commit

07 Aug, 2008

1 commit

06 Aug, 2008

3 commits

  • 0c06090c9   [WATCHDOG] Coding style - Indentation - part 2 ... Browse Code »

    This brings the watchdog drivers into line with coding style.
    This patch takes cares of the indentation as described in chapter 1.
    Main changes:
    * Re-structure the ioctl switch call for all drivers as follows:
    switch (cmd) {
    case WDIOC_GETSUPPORT:
    case WDIOC_GETSTATUS:
    case WDIOC_GETBOOTSTATUS:
    case WDIOC_GETTEMP:
    case WDIOC_SETOPTIONS:
    case WDIOC_KEEPALIVE:
    case WDIOC_SETTIMEOUT:
    case WDIOC_GETTIMEOUT:
    case WDIOC_GETTIMELEFT:
    default:
    }

    This to make the migration from the drivers to the uniform watchdog
    device driver easier in the future.

    Signed-off-by: Wim Van Sebroeck

    Wim Van Sebroeck
     
  • 5eb82498e   [WATCHDOG] Coding style - Indentation - part 1 ... Browse Code »

    This brings the watchdog drivers into line with coding style.
    This patch takes cares of the indentation as described in chapter 1:
    The preferred way to ease multiple indentation levels in a switch
    statement is to align the "switch" and its subordinate "case"
    labels in the same column instead of "double-indenting" the "case"
    labels.

    Signed-off-by: Wim Van Sebroeck

    Wim Van Sebroeck
     
  • 089ab0791   [WATCHDOG] Clean-up includes ... Browse Code »

    Use #include instead of
    Use #include instead of
    Clean-up includes.

    Signed-off-by: Wim Van Sebroeck

    Wim Van Sebroeck
     

31 May, 2008

1 commit

  • 57f50ca12   drivers/watchdog/geodewdt.c: build fix ... Browse Code »

    * Wim Van Sebroeck wrote:

    > Author: Jordan Crouse
    > Date: Mon Jan 21 10:07:00 2008 -0700
    >
    > [WATCHDOG] Add a watchdog driver based on the CS5535/CS5536 MFGPT timers

    -tip testing found the following build failure on latest -git:

    drivers/watchdog/geodewdt.c: In function 'geodewdt_probe':
    drivers/watchdog/geodewdt.c:225: error: too many arguments to function 'geode_mfgpt_alloc_timer'
    make[1]: *** [drivers/watchdog/geodewdt.o] Error 1
    make: *** [drivers/watchdog/geodewdt.o] Error 2

    with this config:

    http://redhat.com/~mingo/misc/config-Fri_May_30_15_19_52_CEST_2008.bad

    find the fix below.

    Signed-off-by: Ingo Molnar
    Acked-by: Jordan Crouse
    Signed-off-by: Linus Torvalds

    Ingo Molnar
     

25 May, 2008

1 commit