07 Jan, 2006
32 commits
-
Signed-off-by: Alexey Dobriyan
Signed-off-by: David S. Miller -
And fix trivial warnings that emerged.
Signed-off-by: Alexey Dobriyan
Signed-off-by: David S. Miller -
This patch contains two corrections to the LSM-IPsec Nethooks patches
previously applied.(1) free a security context on a failed insert via xfrm_user
interface in xfrm_add_policy. Memory leak.(2) change the authorization of the allocation of a security context
in a xfrm_policy or xfrm_state from both relabelfrom and relabelto
to setcontext.Signed-off-by: Trent Jaeger
Signed-off-by: David S. Miller -
pktgen_find_thread() and pktgen_create_thread() are only called at
initialization time.Signed-off-by: Luiz Capitulino
Signed-off-by: David S. Miller -
From: Joe
Signed-off-by: David S. Miller
-
It looks like the bridge netfilter code does not correctly update
the hardware checksum after popping off the VLAN header.This is by inspection, I have *not* tested this.
To test you would need to set up a filtering bridge with vlans
and a device the does hardware receive checksum (skge, or sungem)Signed-off-by: Stephen Hemminger
Signed-off-by: David S. Miller -
When a user-space server application calls bind on a socket, then in kernel
space this bound socket is considered 'x25-linked' and the SOCK_ZAPPED flag
is unset.(As in x25_bind()/af_x25.c).Now when a user-space client application attempts to connect to the server
on the listening socket, if the kernel accepts this in-coming call, then it
returns a new socket to userland and attempts to reply to the caller.The reply/x25_sendmsg() will fail, because the new socket created on
call-accept has its SOCK_ZAPPED flag set by x25_make_new().
(sock_init_data() called by x25_alloc_socket() called by x25_make_new()
sets the flag to SOCK_ZAPPED)).Fix: Using the sock_copy_flag() routine available in sock.h fixes this.
Tested on 32 and 64 bit kernels with x25 over tcp.
Signed-off-by: Shaun Pereira
Signed-off-by: Andrew Morton
Signed-off-by: David S. Miller -
It should return an unsigned value, and fix sk_filter() as well.
Signed-off-by: Kris Katterjohn
Signed-off-by: David S. Miller -
This uses is_multicast_ether_addr() because it has recently been
changed to do the same thing these seperate tests are doing.Signed-off-by: Kris Katterjohn
Signed-off-by: David S. Miller -
Now when kbuild passes KBUILD_MODNAME with "" do not __stringify it when
used. Remove __stringnify for all users.
This also fixes the output of:$ ls -l /sys/module/
drwxr-xr-x 4 root root 0 2006-01-05 14:24 pcmcia
drwxr-xr-x 4 root root 0 2006-01-05 14:24 pcmcia_core
drwxr-xr-x 3 root root 0 2006-01-05 14:24 "processor"
drwxr-xr-x 3 root root 0 2006-01-05 14:24 "psmouse"The quoting of the module names will be gone again.
Thanks to GregKH + Kay Sievers for reproting this.Signed-off-by: Sam Ravnborg
-
Print messages when an unsupported encrytion algorthm is requested or
there is an error locating a supported algorthm.Signed-off-by: Kevin Coffman
Signed-off-by: J. Bruce Fields
Signed-off-by: Trond Myklebust -
Print messages when an unsupported encrytion algorthm is requested or
there is an error locating a supported algorthm.Signed-off-by: Kevin Coffman
Signed-off-by: J. Bruce Fields
Signed-off-by: Trond Myklebust -
Also update the tokenlen calculations to accomodate g_token_size().
Signed-off-by: Andy Adamson
Signed-off-by: J. Bruce Fields
Signed-off-by: Trond Myklebust -
We ought never to be calling xprt_destroy() if there are still active
rpc_tasks. Optimise away the broken code that attempts to "fix" that case.Signed-off-by: Trond Myklebust
-
If the server decides to close the RPC socket, we currently don't actually
respond until either another RPC call is scheduled, or until xprt_autoclose()
gets called by the socket expiry timer (which may be up to 5 minutes
later).This patch ensures that xprt_autoclose() is called much sooner if the
server closes the socket.Signed-off-by: Trond Myklebust
-
Clean up: Every ULP that uses the in-kernel RPC client, except the NLM
client, sets cl_chatty. There's no reason why NLM shouldn't set it, so
just get rid of cl_chatty and always be verbose.Test-plan:
Compile with CONFIG_NFS enabled.Signed-off-by: Chuck Lever
Signed-off-by: Trond Myklebust -
At some point, transport endpoint addresses will no longer be IPv4. To hide
the structure of the rpc_xprt's address field from ULPs and port mappers,
add an API for setting the port number during an RPC bind operation.Test-plan:
Destructive testing (unplugging the network temporarily). Connectathon
with UDP and TCP. NFSv2/3 and NFSv4 mounting should be carefully checked.
Probably need to rig a server where certain services aren't running, or
that returns an error for some typical operation.Signed-off-by: Chuck Lever
Signed-off-by: Trond Myklebust -
We'd like to hide fields in rpc_xprt and rpc_clnt from upper layer protocols.
Start by creating an API to force RPC rebind, replacing logic that simply
sets cl_port to zero.Test-plan:
Destructive testing (unplugging the network temporarily). Connectathon
with UDP and TCP. NFSv2/3 and NFSv4 mounting should be carefully checked.
Probably need to rig a server where certain services aren't running, or
that returns an error for some typical operation.Signed-off-by: Chuck Lever
Signed-off-by: Trond Myklebust -
Add RPC client transport switch support for replacing buffer management
on a per-transport basis.In the current IPv4 socket transport implementation, RPC buffers are
allocated as needed for each RPC message that is sent. Some transport
implementations may choose to use pre-allocated buffers for encoding,
sending, receiving, and unmarshalling RPC messages, however. For
transports capable of direct data placement, the buffers can be carved
out of a pre-registered area of memory rather than from a slab cache.Test-plan:
Millions of fsx operations. Performance characterization with "sio" and
"iozone". Use oprofile and other tools to look for significant regression
in CPU utilization.Signed-off-by: Chuck Lever
Signed-off-by: Trond Myklebust -
This patch removes ths unused function xdr_decode_string().
Signed-off-by: Adrian Bunk
Acked-by: Neil Brown
Acked-by: Charles Lever
Signed-off-by: Trond Myklebust -
Signed-off-by: Trond Myklebust
-
...and make sure that the "intr" flag also enables SIGHUP and SIGTERM to
interrupt RPC calls too (as per the Solaris implementation).Signed-off-by: Trond Myklebust
-
Signed-off-by: Trond Myklebust
-
Signed-off-by: Trond Myklebust
-
The NFSv4 model requires us to complete all RPC calls that might
establish state on the server whether or not the user wants to
interrupt it. We may also need to schedule new work (including
new RPC calls) in order to cancel the new state.The asynchronous RPC model will allow us to ensure that RPC calls
always complete, but in order to allow for "synchronous" RPC, we
want to add the ability to wait for completion.
The waits are, of course, interruptible.Signed-off-by: Trond Myklebust
-
Signed-off-by: Trond Myklebust
-
Shrink the RPC task structure. Instead of storing separate pointers
for task->tk_exit and task->tk_release, put them in a structure.Also pass the user data pointer as a parameter instead of passing it via
task->tk_calldata. This enables us to nest callbacks.Signed-off-by: Trond Myklebust
-
Signed-off-by: Trond Myklebust
-
I submitted this one previously - svc_tcp_recvfrom currently returns
any errors to the caller, including ECONNRESET and the like.This is something svc_recv isn't able to deal with:
len = svsk->sk_recvfrom(rqstp);
[...]
if (len == 0 || len == -EAGAIN) {
[...]
return -EAGAIN;
}[...]
return len;The nfsd main loop will exit when it sees an error code other than
EAGAIN.The following patch fixes this problem
svc_recv is not equipped to deal with error codes other than EAGAIN,
and will propagate anything else (such as ECONNRESET) up to nfsd,
causing it to exit.Signed-off-by: Olaf Kirch
Cc: Trond Myklebust
Cc: Neil Brown
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds -
The hash.h hash_long function, when used on a 64 bit machine, ignores many
of the middle-order bits. (The prime chosen it too bit-sparse).IP addresses for clients of an NFS server are very likely to differ only in
the low-order bits. As addresses are stored in network-byte-order, these
bits become middle-order bits in a little-endian 64bit 'long', and so do
not contribute to the hash. Thus you can have the situation where all
clients appear on one hash chain.So, until hash_long is fixed (or maybe forever), us a hash function that
works well on IP addresses - xor the bytes together.Thanks to "Iozone" for identifying this problem.
Cc: "Iozone"
Signed-off-by: Neil Brown
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
06 Jan, 2006
8 commits
-
These patches add the header linux/if_ether.h and change 1500 to
ETH_DATA_LEN in some files.Signed-off-by: Kris Katterjohn
Signed-off-by: David S. Miller -
Signed-off-by: Andrew Morton
Signed-off-by: David S. Miller -
HOPLIMIT metric is appropriate to TCP reset sent by REJECT target
than hard-coded max TTL. Thanks to David S. Miller for hint.Signed-off-by: Yasuyuki Kozakai
Signed-off-by: David S. Miller -
CC [M] net/ipv4/netfilter/nf_conntrack_l3proto_ipv4.o
net/ipv4/netfilter/nf_conntrack_l3proto_ipv4.c: In function 'ipv4_refrag':
net/ipv4/netfilter/nf_conntrack_l3proto_ipv4.c:198: error: dereferencing pointer to incomplete type
make[3]: *** [net/ipv4/netfilter/nf_conntrack_l3proto_ipv4.o] Error 1Signed-off-by: Patrick McHardy
Signed-off-by: David S. Miller -
Signed-off-by: Patrick McHardy
Signed-off-by: David S. Miller -
The original ipv6_find_hdr() finds the specified header in IPv6 packets.
This makes it possible to get transport header so that we can kill similar
loop in ip6_match_packet().Signed-off-by: Patrick McHardy
Signed-off-by: David S. Miller -
Call POST_ROUTING hook before fragmentation to get rid of the okfn use
in ip_refrag and save the useless fragmentation/defragmentation step
when NAT is used.The patch introduces one user-visible change, the POSTROUTING chain
in the mangle table gets entire packets, not fragments, which should
simplify use of the MARK and CLASSIFY targets for queueing as a nice
side-effect.Signed-off-by: Patrick McHardy
Signed-off-by: David S. Miller -
okfn should only be used from different contexts to avoid deep call chains,
i.e. by nf_queue.Acked-by: Julian Anastasov
Signed-off-by: Patrick McHardy
Signed-off-by: David S. Miller
