08 Nov, 2013
2 commits
-
BUG() used in the driver is just to spit the stack trace on buggy
points, not really needed to stop the whole operation. For that
purpose, it'd be more convenient to use WARN() instead with more
error information.Cc: patches@opensource.wolfsonmicro.com
Signed-off-by: Takashi Iwai
Signed-off-by: Mark Brown
02 Nov, 2013
2 commits
-
Signed-off-by: Richard Fitzgerald
Signed-off-by: Mark Brown -
Signed-off-by: Richard Fitzgerald
Signed-off-by: Mark Brown
30 Oct, 2013
1 commit
-
When using DT binding to pass private data, there would be Kernel panic
occuring due to NULL pointer access in wm8962_i2c_probe(). Thus fix it.Signed-off-by: Nicolin Chen
Signed-off-by: Mark Brown
18 Oct, 2013
2 commits
-
This is more idiomatic and is required for robust operation since we must
ensure that the clocking configuration is valid as rapidly as possible.Signed-off-by: Mark Brown
-
This is more idiomatic and fixes bugs in the error handling paths.
Signed-off-by: Mark Brown
23 Aug, 2013
1 commit
-
ASoC: Updates for v3.12
- DAPM is now mandatory for CODEC drivers in order to avoid the repeated
regressions in the special cases for non-DAPM CODECs and make it
easier to integrate with other components on boards. All existing
drivers have had some level of DAPM support added.
- A lot of cleanups in DAPM plus support for maintaining controls in a
specific state while a DAPM widget all contributed by Lars-Peter Clausen.
- Core helpers for bitbanged AC'97 reset from Markus Pargmann.
- New drivers and support for Analog Devices ADAU1702 and ADAU1401(a),
Asahi Kasei Microdevices AK4554, Atmel AT91ASM9x5 and WM8904 based
machines, Freescale S/PDIF and SSI AC'97, Renesas R-Car SoCs, Samsung
Exynos5420 SoCs, Texas Instruments PCM1681 and PCM1792A and Wolfson
Microelectronics WM8997.
- Support for building drivers that can support it cross-platform for
compile test.
22 Jul, 2013
1 commit
-
The accessory detect debounce work is not performance sensitive so let
the scheduler run it wherever is most efficient rather than in a per CPU
workqueue by using the system power efficient workqueue.Signed-off-by: Mark Brown
Acked-by: Viresh Kumar
21 Jul, 2013
1 commit
-
The usage of strict_strto*() is not preferred, because
strict_strto*() is obsolete. Thus, kstrto*() should be
used.Signed-off-by: Jingoo Han
Signed-off-by: Takashi Iwai
20 Jul, 2013
1 commit
-
Currently after playing any audio file, we get the following error message:
$ aplay clarinet.wav
Playing WAVE 'clarinet.wav' : Signed 16 bit Little Endian, Rate 44100 Hz, Stereo
$ wm8962 0-001a: Unsupported sysclk ratio 544This error message appears about 5 seconds after the audio playback has
finished.Quoting Mark Brown [1]:
"The issue here is triggered by the machine
switching from the FLL to direct MCLK usage where the MCLK isn't
generating a useful ratio.I suspect we should just kill the configure_bclk() in set_sysclk(), that
one isn't safe as we can't reconfigure a live SYSCLK and it's probably
the one that generates your warnings."Confirmed that the "Unsupported sysclk ratio" error message comes from
wm8962_set_dai_sysclk(), so get rid of wm8962_configure_bclk() inside this
function.[1] http://mailman.alsa-project.org/pipermail/alsa-devel/2013-July/064241.html
Signed-off-by: Fabio Estevam
Signed-off-by: Mark Brown
04 Jul, 2013
1 commit
-
There is an error in merge commit 384b834 on conflict resolution which
causes the following NULL pdata pointer bug.wm8962 0-001a: customer id 0 revision D
Unable to handle kernel NULL pointer dereference at virtual address 00000004
pgd = 80004000
[00000004] *pgd=00000000
Internal error: Oops: 5 [#1] SMP ARM
Modules linked in:
CPU: 0 PID: 1 Comm: swapper/0 Not tainted 3.10.0+ #1
task: bf870000 ti: bf874000 task.ti: bf874000
PC is at wm8962_probe+0x134/0x6c8
LR is at regmap_unlock_mutex+0x10/0x14
pc : [] lr : [] psr: a0000113
sp : bf875c98 ip : 00000000 fp : bf875cd4
r10: 00000000 r9 : bfb1830c r8 : 80779bc4
r7 : 00000000 r6 : 00000001 r5 : bfbac010 r4 : bfb33e00
r3 : 80304ce4 r2 : 00000000 r1 : 00000001 r0 : fffffffb
Flags: NzCv IRQs on FIQs on Mode SVC_32 ISA ARM Segment kernel
Control: 10c53c7d Table: 1000404a DAC: 00000017
Process swapper/0 (pid: 1, stack limit = 0xbf874238)
Stack: (0xbf875c98 to 0xbf876000)
...Fix the error by assigning pdata a correct pointer.
Signed-off-by: Shawn Guo
Signed-off-by: Mark Brown
18 Jun, 2013
1 commit
14 Jun, 2013
3 commits
-
This part of bias settings are essential for WM8962 to power up. Without it
"wm8962 0-001a: DC servo timed out" might be prompted due to power-up failure
that happens to FLL if being used.The driver's also bringing the bias down in the suspend path so it needs to be
powered up in the resume path for symmetry.According to dapm_pre_sequence_async(), DAPM would call pm_runtime_get_sync()
to let driver finish the bias settings in pm_runtime_resume() before the bias
level being set to STANDBY. So no need to worry about disordered settings for
VMID of WM8962.Signed-off-by: Nicolin Chen
Signed-off-by: Mark Brown -
…ie/sound into asoc-wm8962
Conflicts:
sound/soc/codecs/wm8962.c -
Also fix return values for headphone switch updates.
Signed-off-by: Nicolin Chen
Signed-off-by: Mark Brown
Cc: stable@vger.kernel.org
10 Jun, 2013
1 commit
-
After the device has been reset we need to repeat the same
initialisation we do on probe to make sure that the device is in
a known state.Tested-by: Nicolin Chen
Signed-off-by: Mark Brown
07 Jun, 2013
1 commit
-
Document the device tree binding for the WM8962 codec, and modify the
driver to extract platform data from the device tree, if present.Based on work of WM8903 by Stephen Warren
Signed-off-by: Nicolin Chen
Signed-off-by: Mark Brown
06 Jun, 2013
1 commit
-
Embed a copy of struct wm8962_pdata in stuct wm8962_priv
so that there's no need to check validity of pdata any more.Signed-off-by: Nicolin Chen
Signed-off-by: Mark Brown
24 Dec, 2012
3 commits
-
If the FLL is being shut down we will exit early so there is no need to
check here and in fact we're checking the wrong thing anyway.Reported-by: Graeme Gregory
Signed-off-by: Mark Brown -
Signed-off-by: Mark Brown
-
Add device tree support.
Signed-off-by: Fabio Estevam
Signed-off-by: Mark Brown
09 Dec, 2012
1 commit
-
CONFIG_HOTPLUG is going away as an option. As result the __dev*
markings will be going away.Remove use of __devinit, __devexit_p, __devinitdata, __devinitconst,
and __devexit.Signed-off-by: Bill Pemberton
Signed-off-by: Mark Brown
02 Dec, 2012
1 commit
-
devm_regmap_init_i2c() is device managed and makes error
handling and code cleanup simpler.Signed-off-by: Sachin Kamat
Signed-off-by: Mark Brown
29 Nov, 2012
1 commit
-
devm_regulator_bulk_get() is device managed and makes error
handling and code cleanup simpler.Signed-off-by: Sachin Kamat
Signed-off-by: Mark Brown
09 Aug, 2012
1 commit
-
The core will bring the bias level up for us since we use idle_bias_off,
duplicating this may be harmful.Signed-off-by: Mark Brown
01 Aug, 2012
1 commit
-
Required for reliable power up from cold.
Signed-off-by: Mark Brown
Cc: stable@vger.kernel.org
13 Jul, 2012
1 commit
-
Ensure robust startup of the part by going through the reset procedure
prior to resyncing the full register cache, avoiding potential intermittent
faults in some designs.Signed-off-by: Mark Brown
Cc: stable@vger.kernel.org
04 Jul, 2012
1 commit
-
Signed-off-by: Mark Brown
03 Jun, 2012
1 commit
-
Signed-off-by: Mark Brown
04 Apr, 2012
1 commit
-
In order to support CODECCODEC links remove the assumption that there
is only a single CODEC on a DAI link by removing the use of the CODEC
pointer in the rtd from the CODEC drivers. They are already being passed
their DAI whenever they are passed an rtd and can get the CODEC from
there.Signed-off-by: Mark Brown
01 Apr, 2012
6 commits
-
Signed-off-by: Mark Brown
-
Signed-off-by: Mark Brown
-
Signed-off-by: Mark Brown
-
Signed-off-by: Mark Brown
-
Signed-off-by: Mark Brown
-
We can simply use the register cache code to synchronise the current
configuration down to the device when bringing up the DSP.Signed-off-by: Mark Brown
19 Mar, 2012
1 commit
06 Mar, 2012
2 commits
-
Save a little RAM.
Signed-off-by: Mark Brown
-
The default pm_runtime status is enabled which is what we want.
Signed-off-by: Mark Brown