Eric Lee / smarc-fsl-linux-kernel

02 Jun, 2010

5 commits

  • f9447c493   menuconfig: improive help text a bit ... Browse Code »

    Suggested-by: Randy Dunlap
    Signed-off-by: Li Zefan
    Acked-by: Randy Dunlap
    Signed-off-by: Michal Marek

    Li Zefan
     
  • 3fb9acb32   kconfig: fix to tag NEW symbols correctly ... Browse Code »

    Those configs are not new:

    $ cat .config
    ...
    CONFIG_NAMESPACES=y
    ...
    CONFIG_BLOCK=y
    ...

    But are tagged as NEW:

    $ yes "" | make config > myconf
    $ cat myconf | grep '(NEW)'
    Namespaces support (NAMESPACES) [Y/?] (NEW) y
    ...
    Enable the block layer (BLOCK) [Y/?] (NEW) y
    ...

    You can also notice this bug when using gconfig/xconfig.

    It's because the SYMBOL_DEF_USER bit of an invisible symbol is cleared
    when the config file is read:

    int conf_read(const char *name)
    {
    ...
    for_all_symbols(i, sym) {
    if (sym_has_value(sym) && !sym_is_choice_value(sym)) {
    /* Reset values of generates values, so they'll appear
    * as new, if they should become visible, but that
    * doesn't quite work if the Kconfig and the saved
    * configuration disagree.
    */
    if (sym->visible == no && !conf_unsaved)
    sym->flags &= ~SYMBOL_DEF_USER;
    ...
    }

    But a menu item which represents an invisible symbol is still
    visible, if it's sub-menu is visible, so its SYMBOL_DEF_USER
    bit should be set to indicate it's not NEW.

    Signed-off-by: Li Zefan
    Signed-off-by: Michal Marek

    Li Zefan
     
  • 70ed07471   kconfig: print the range of integer/hex symbol in help text ... Browse Code »

    Without this patch, one has to refer to the Kconfig file to find
    out the range of an integer/hex symbol.

    │ Symbol: NR_CPUS [=4]
    │ Type : integer
    │ Range : [2 8]
    │ Prompt: Maximum number of CPUs
    │ Defined at arch/x86/Kconfig:761
    │ Depends on: SMP [=y] && !MAXSMP [=n]
    │ Location:
    │ -> Processor type and features

    Signed-off-by: Li Zefan
    Signed-off-by: Michal Marek

    Li Zefan
     
  • b040b44c3   kconfig: print symbol type in help text ... Browse Code »

    Randy suggested to print out the symbol type in gconfig.

    Note this change does more than Randy's suggestion, that it also
    affects menuconfig and "make config".

    │ Symbol: BLOCK [=y]
    │ Type : boolean
    │ Prompt: Enable the block layer
    │ Defined at block/Kconfig:4
    │ Depends on: EMBEDDED [=n]

    Signed-off-by: Li Zefan
    Acked-by: Randy Dunlap
    Signed-off-by: Michal Marek

    Li Zefan
     
  • f0778c8c4   kconfig: introduce nonint_oldconfig and loose_nonint_oldconfig ... Browse Code »

    This patch has been around for a long time in Fedora and Red Hat Enterprise
    Linux kernels and it may be useful for others. The nonint_oldconfig target
    will fail and print the unset config options while loose_nonint_oldconfig will
    simply let the config option unset. They're useful in distro kernel packages
    where the config files are built using a combination of smaller config files.

    Arjan van de Ven wrote the initial nonint_config and Roland McGrath added the
    loose_nonint_oldconfig.

    Signed-off-by: Arjan van de Ven [defunct email]
    Whatevered-by: Kyle McMartin
    Acked-by: Arjan van de Ven
    Acked-by: Randy Dunlap
    Signed-off-by: Aristeu Rozanski
    [mmarek: whitespace fixes]
    Signed-off-by: Michal Marek

    Aristeu Rozanski
     

27 May, 2010

1 commit

06 May, 2010

1 commit

  • fb994ecc2   kbuild: Fix checking of scm-identifier variable ... Browse Code »

    I'm looking Makefile in the -mm branch (dated 2010-04-28-16-53) and
    seeing what looks like a bug in the checking of scm-identifier. The
    "ifneq ($scm-identifier)" seems to always execute "ifeq
    ($(LOCALVERSION,)) ...". This patch fixes the checking of
    scm-identifier.

    Signed-off-by: Greg Thelen
    Acked-by: David Rientjes
    Signed-off-by: Michal Marek

    Greg Thelen
     

14 Apr, 2010

6 commits

  • 06f9a55cf   gconfig: add support to show hidden options that have prompts ... Browse Code »

    There's a button in gconfig to "Show all options", but I think
    normally we are not interested in those configs which have no
    prompt and thus can't be changed, so here I add a new button to
    show hidden options which have prompts.

    Signed-off-by: Li Zefan
    Signed-off-by: Michal Marek

    Li Zefan
     
  • 22c7eca61   menuconfig: add support to show hidden options which have prompts ... Browse Code »

    Usage:
    Press to show all config symbols which have prompts.

    Quote Tim Bird:

    | I've been bitten by this numerous times. I most often
    | use ftrace on ARM, but when I go back to x86, I almost
    | always go through a sequence of searching for the
    | function graph tracer in the menus, then realizing it's
    | completely missing until I disable CC_OPTIMIZE_FOR_SIZE.
    |
    | Is there any way to have the menu item appear, but be
    | unsettable unless the SIZE option is disabled? I'm
    | not a Kconfig guru...

    I myself found this useful too. For example, I need to test
    ftrace/tracing and want to be sure all the tracing features are
    enabled, so I enter the "Tracers" menu, and press to
    see if there is any config hidden.

    I also noticed gconfig and xconfig have a button "Show all options",
    but that's a bit too much, and I think normally what we are not
    interested in those configs which have no prompt thus can't be
    changed by users.

    Exmaple:

    --- Tracers
    -*- Kernel Function Tracer
    - - Kernel Function Graph Tracer
    [*] Interrupts-off Latency Tracer
    - - Preemption-off Latency Tracer
    [*] Sysprof Tracer

    Here you can see 2 tracers are not selectable, and then can find
    out how to make them selectable.

    Signed-off-by: Li Zefan
    Signed-off-by: Michal Marek

    Li Zefan
     
  • 7b5d87215   gconfig: remove show_debug option ... Browse Code »

    This option is a no-op, so remove it.

    Signed-off-by: Li Zefan
    Signed-off-by: Michal Marek

    Li Zefan
     
  • 294423543   gconfig: remove dbg_print_ptype() and dbg_print_stype() ... Browse Code »

    Just use sym_get_type() and prop_get_type_name().

    Signed-off-by: Li Zefan
    Signed-off-by: Michal Marek

    Li Zefan
     
  • c6ccc30fd   kconfig: fix zconfdump() ... Browse Code »

    zconfdump(), which is used for debugging, can't recognize P_SELECT,
    P_RANGE and P_MENU (if associated with a symbol, aka "menuconfig"),
    and output something like this:

    config X86
    boolean
    default y
    unknown prop 6!
    unknown prop 6!
    unknown prop 6!
    ...

    Signed-off-by: Li Zefan
    Signed-off-by: Michal Marek

    Li Zefan
     
  • 4280eae09   kconfig: some small fixes ... Browse Code »

    - fix a typo in documentation
    - fix a typo in a printk on error
    - fix comments in dialog_inputbox()

    Signed-off-by: Li Zefan
    Signed-off-by: Michal Marek

    Li Zefan
     

08 Apr, 2010

1 commit

23 Mar, 2010

4 commits

  • b83419363   kbuild: Include gen_initramfs_list.sh and the file list in the .d file ... Browse Code »

    Expand the dependency set used for the initrd to include the
    CONFIG_INITRAMFS_SOURCE file and the generator script itself.
    Otherwise changing the initramfs file list does not rebuild the CPIO.

    Signed-off-by: Jason Gunthorpe
    Signed-off-by: Michal Marek

    Jason Gunthorpe
     
  • da6df879b   kconfig: recalc symbol value before showing search results ... Browse Code »

    A symbol's value won't be recalc-ed until we save config file or
    enter the menu where the symbol sits.

    So If I enable OPTIMIZE_FOR_SIZE, and search FUNCTION_GRAPH_TRACER:

    Symbol: FUNCTION_GRAPH_TRACER [=y]
    Prompt: Kernel Function Graph Tracer
    Defined at kernel/trace/Kconfig:140
    Depends on: ... [=y] && (!X86_32 [=y] || !CC_OPTIMIZE_FOR_SIZE [=y])
    ...

    From the dependency it should result in FUNCTION_GRAPH_TRACER=n,
    but it still shows FUNCTION_GRAPH_TRACER=y.

    Signed-off-by: Li Zefan
    Signed-off-by: Michal Marek

    Li Zefan
     
  • 52b80025e   .gitignore: ignore *.lzo files ... Browse Code »

    Ignore files compressed with lzop.

    Signed-off-by: Philipp Kohlbecher
    Signed-off-by: Michal Marek

    Philipp Kohlbecher
     
  • 1dcd81002   headerdep: perlcritic warning ... Browse Code »

    Minor perlcritic warning:
    headerdep.pl: "return" statement with explicit "undef" at line 84, column 2. See page 199 of PBP. (Severity: 5)

    The rationale according to PBP is that an explicit return of undef
    (contrary to most people's expectations) doesn't
    always evaluate as false. It has to with the fact that perl return value
    depends on context the function is called. If function is used in
    list context, the appropriate return value for false is an empty list;
    whereas in scalar context the return value for false is undefined.
    By just using a "return" both cases are handled.

    In the context of a trivial script this doesn't matter. But one script
    may be cut-paste into later code (most people like me only know 50%
    of perl), that is why perlcritic always complains

    Signed-off-by: Stephen Hemminger
    Signed-off-by: Michal Marek

    Stephen Hemminger
     

11 Mar, 2010

1 commit

10 Mar, 2010

1 commit

08 Mar, 2010

10 commits

  • e93bc1a0c   Revert "kbuild: specify absolute paths for cscope" ... Browse Code »

    This reverts commit eb8f844c0a41c4529a7d06b7801296eca9ae67aa. Ian
    Campbell writes:
    > I keep my kernel source tree on a more powerful build box where I run my
    > builds etc (including "make cscope") but run my editor from my
    > workstation with an NFS mount to the source. This worked fine for me
    > using relative paths for cscope. Using absolute paths in cscope breaks
    > this previously working setup because the root path is not the same on
    > both systems. I guess this is similar to moving the source tree around.
    >
    > Without wanting to start a flamewar it really sounds to me like we are
    > working around a vim (or cscope) bug here, emacs with cscope bindings
    > works fine in this configuration.

    Given that absolute paths can be forced by make O=. cscope, change the
    default back to relative paths.

    Ian Campbell
    Cc: Daniel Vetter
    Signed-off-by: Michal Marek

    Michal Marek
     
  • a6c366324   kbuild: Do not unnecessarily regenerate modules.builtin ... Browse Code »

    Only regenerate it if the configuration has changed. Also, do this after
    the modules build to fix errors with some weird Makefiles that are
    generated during build.

    Reported-by: Eric Miao
    Signed-off-by: Michal Marek

    Michal Marek
     
  • bae4cecc0   headers_install: use local file handles ... Browse Code »

    Better practice to use 3 arg open and local file handles.

    Signed-off-by: Stephen Hemminger
    Acked-by: WANG Cong
    Cc: Michal Marek
    Signed-off-by: Andrew Morton
    Signed-off-by: Michal Marek

    Stephen Hemminger
     
  • dbbe33e99   headers_check: fix perl warnings ... Browse Code »

    According to PBP; best way practice is to use local reference for file
    handle and three argument open. Also perl prototypes are a mistake.

    Signed-off-by: Stephen Hemminger
    Acked-by: WANG Cong
    Cc: Michal Marek
    Signed-off-by: Andrew Morton
    Signed-off-by: Michal Marek

    Stephen Hemminger
     
  • 91416cfdf   export_report: fix perl warnings ... Browse Code »

    Use local file handles, use three argument open.
    Don't modify arguments in perl grep (use sed instead)

    Signed-off-by: Stephen Hemminger
    Acked-by: WANG Cong
    Cc: Michal Marek
    Signed-off-by: Andrew Morton
    Signed-off-by: Michal Marek

    Stephen Hemminger
     
  • 9c49fd307   profile2linkerlist: fix perl warnings ... Browse Code »

    Turn on strict checking.
    Simplify code by using "unless" statement.

    Signed-off-by: Stephen Hemminger
    Acked-by: WANG Cong
    Cc: Michal Marek
    Signed-off-by: Andrew Morton
    Signed-off-by: Michal Marek

    Stephen Hemminger
     
  • 86d08e569   namespace: perlcritic warnings ... Browse Code »

    Use local file handle not global.
    Make loop and other variables local in scope.

    Signed-off-by: Stephen Hemminger
    Cc: Hui Zhu
    Cc: Cong Wang
    Cc: Michal Marek
    Signed-off-by: Andrew Morton
    Signed-off-by: Michal Marek

    Stephen Hemminger
     
  • a208868fc   checkversion: perl cleanup ... Browse Code »

    Turn on strict checking.
    Use three arguement open
    Standard practice in perl is to use undef not zero for false

    Signed-off-by: Stephen Hemminger
    Cc: Cong Wang
    Cc: Ralf Baechle
    Cc: Michal Marek
    Signed-off-by: Andrew Morton
    Signed-off-by: Michal Marek

    Stephen Hemminger
     
  • 3da271573   checkincludes: fix perlcritic warnings ... Browse Code »

    Turn on strict checking.
    Use local file handles.
    Use three argument open.

    Signed-off-by: Stephen Hemminger
    Cc: Cong Wang
    Cc: Michal Marek
    Signed-off-by: Andrew Morton
    Signed-off-by: Michal Marek

    Stephen Hemminger
     
  • 1f2a144f5   scripts: improve checkstack ... Browse Code »

    Cleanup checkstack script:
    * Turn on strict checking
    * Fix resulting error message because the declaration syntax
    was incorrect.
    * Remove incorrect and misleading use of prototype
    - prototype not required for this type of sort function
    because $a and $b are being used in this contex
    - if prototype was being used it should be for both arguments
    * Use closure for sort function

    Signed-off-by: Stephen Hemminger
    Cc: Steven Rostedt
    Cc: Arjan van de Ven
    Cc: Cong Wang
    Cc: Michal Marek
    Signed-off-by: Andrew Morton
    Signed-off-by: Michal Marek

    Stephen Hemminger
     

07 Mar, 2010

1 commit

03 Mar, 2010

9 commits