11 Oct, 2007
4 commits
-
It seems I was actually able to hit this deadlock, on my quad G5 softmac
locks up more often than not. This fixes it by using an own workqueue
that can safely be flushed under RTNL.Not sure if the patch is correct with the workqueue naming. And don't
think with the patch it doesn't continually lock up. It still does, just
doesn't invoke lockdep warnings all the time.Signed-off-by: Johannes Berg
Signed-off-by: John W. Linville
Signed-off-by: David S. Miller -
This is nicer than the MAC_FMT stuff.
Signed-off-by: Joe Perches
Signed-off-by: David S. Miller -
This patch makes /proc/net per network namespace. It modifies the global
variables proc_net and proc_net_stat to be per network namespace.
The proc_net file helpers are modified to take a network namespace argument,
and all of their callers are fixed to pass &init_net for that argument.
This ensures that all of the /proc/net files are only visible and
usable in the initial network namespace until the code behind them
has been updated to be handle multiple network namespaces.Making /proc/net per namespace is necessary as at least some files
in /proc/net depend upon the set of network devices which is per
network namespace, and even more files in /proc/net have contents
that are relevant to a single network namespace.Signed-off-by: Eric W. Biederman
Signed-off-by: David S. Miller -
Hopefully captured all single statement cases under net/. I'm
not too sure if there is some policy about #includes that are
"guaranteed" (ie., in the current tree) to be available through
some other #included header, so I just added linux/kernel.h to
each changed file that didn't #include it previously.Signed-off-by: Ilpo Järvinen
Signed-off-by: David S. Miller
04 Oct, 2007
1 commit
-
…nville/wireless-2.6 into upstream-fixes
03 Oct, 2007
1 commit
-
CC net/ieee80211/softmac/ieee80211softmac_wx.o
/home/kernel/src/net/ieee80211/softmac/ieee80211softmac_wx.c: In function âieee80211softmac_wx_set_essidâ:
/home/kernel/src/net/ieee80211/softmac/ieee80211softmac_wx.c:117: warning: label âoutâ defined but not useddue to commit: efe870f9f4ad74410a18ecbf0d9ba7c14b50a0fb. Removing the label.
Signed-off-by: Richard Knutsson
Signed-off-by: John W. Linville
02 Oct, 2007
1 commit
-
Reported by Chris Evans :
> The summary is that an evil 80211 frame can crash out a victim's
> machine. It only applies to drivers using the 80211 wireless code, and
> only then to certain drivers (and even then depends on a card's
> firmware not dropping a dubious packet). I must confess I'm not
> keeping track of Linux wireless support, and the different protocol
> stacks etc.
>
> Details are as follows:
>
> ieee80211_rx() does not explicitly check that "skb->len >= hdrlen".
> There are other skb->len checks, but not enough to prevent a subtle
> off-by-two error if the frame has the IEEE80211_STYPE_QOS_DATA flag
> set.
>
> This leads to integer underflow and crash here:
>
> if (frag != 0)
> flen -= hdrlen;
>
> (flen is subsequently used as a memcpy length parameter).How about this?
Signed-off-by: John W. Linville
Signed-off-by: David S. Miller
21 Sep, 2007
1 commit
-
Commit 4cf92a3c was submitted as a fix for bug #8686 at bugzilla.kernel.org
(http://bugzilla.kernel.org/show_bug.cgi?id=8686). Unfortunately, the fix led to
a new bug, reported by Yoshifuji Hideaki, that prevented association for WEP
encrypted networks that use ifconfig to control the device. This patch effectively
reverts the earlier commit and does a proper fix for bug #8686.Signed-off-by: Larry Finger
Signed-off-by: John W. Linville
07 Aug, 2007
1 commit
-
The essid wireless extension does deadlock against the assoc mutex,
as we don't unlock the assoc mutex when flushing the workqueue, which
also holds the lock.Signed-off-by: Michael Buesch
Signed-off-by: John W. Linville
18 Jul, 2007
1 commit
-
SoftMAC outputs the channel twice in the scan output. It should
display frequency and channel, but only once for each.Signed-off-by: Jean Tourrilhes
Signed-off-by: Larry Finger
Signed-off-by: John W. Linville
11 Jul, 2007
1 commit
-
Victor Porton reported that the SoftMAC layer had random problem when setting the ESSID :
http://bugzilla.kernel.org/show_bug.cgi?id=8686 After investigation, it turned out to be
worse, the SoftMAC layer is left in an inconsistent state. The fix is pretty trivial.Signed-off-by: Jean Tourrilhes
Acked-by: Michael Buesch
Acked-by: Larry Finger
Signed-off-by: John W. Linville
09 Jul, 2007
1 commit
-
Cleanup using list_for_each_entry.
Cc: Johannes Berg
Cc: Joe Jezak
Cc: Daniel Drake
Signed-off-by: Akinobu Mita
Signed-off-by: John W. Linville
29 May, 2007
2 commits
-
This patch adds missing NULL check and trims a line longer than 80 columns.
Cc: Johannes Berg
Cc: Joe Jezak
Cc: Daniel Drake
Signed-off-by: Akinobu Mita
Signed-off-by: John W. Linville -
Fix error message:
Unable to network device. --> Unable to allocate network device.Cc: James Ketrenos
Signed-off-by: Akinobu Mita
Signed-off-by: John W. Linville
08 May, 2007
2 commits
-
In ieee80211, the output of scan results lists channels, but not
frequencies, which are needed by NetworkManager. This patch uses
the new ieee80211_channel_to_freq routine to add the frequency to the output.Signed-off-by: Larry Finger
Signed-off-by: John W. Linville -
The routines that interrogate the ieee80211_geo struct are missing a
channel to frequency entry. This patch adds it.Signed-off-by: Larry Finger
Signed-off-by: John W. Linville
28 Apr, 2007
3 commits
-
Using any of the IEEE80211_DEBUG_XXXX macros in any ieee80211_crypt
routine built as a module results in a missing global for
'ieee80211_debug_level'. The fix is to export the symbol in ieee80211.Signed-off-by: Larry Finger
Signed-off-by: John W. Linville -
There are messages arising from ieee80211_crypt that spam the logs
of casual users. These are changed to be logged only if the user
specifically requests the IEEE80211_DEBUG_DROP messages. In either
case, the error/drop count is incremented.Signed-off-by: Larry Finger
Signed-off-by: John W. Linville -
After 13 years of use, it looks like my email address is finally going
to disappear. While this is likely to drop the amount of incoming spam
greatly ;-), it may also affect more appropriate messages, so let's
update my email address in various places. In addition, Host AP mailing
list is subscribers-only and linux-wireless can also be used for
discussing issues related to this driver which is now shown in
MAINTAINERS.Signed-off-by: Jouni Malinen
Signed-off-by: John W. Linville
26 Apr, 2007
12 commits
-
This patch refactors the wireless Kconfig all over and already
introduces net/wireless/Kconfig with just the WEXT bit for now,
the cfg80211 patch will add to that as well.Signed-off-by: Johannes Berg
Signed-off-by: John W. Linville
Signed-off-by: David S. Miller -
To clearly state the intent of copying to linear sk_buffs, _offset being a
overly long variant but interesting for the sake of saving some bytes.Signed-off-by: Arnaldo Carvalho de Melo
-
To clearly state the intent of copying from linear sk_buffs, _offset being a
overly long variant but interesting for the sake of saving some bytes.Signed-off-by: Arnaldo Carvalho de Melo
-
Now to convert the last one, skb->data, that will allow many simplifications
and removal of some of the offset helpers.Signed-off-by: Arnaldo Carvalho de Melo
Signed-off-by: David S. Miller -
So that it is also an offset from skb->head, reduces its size from 8 to 4 bytes
on 64bit architectures, allowing us to combine the 4 bytes hole left by the
layer headers conversion, reducing struct sk_buff size to 256 bytes, i.e. 4
64byte cachelines, and since the sk_buff slab cache is SLAB_HWCACHE_ALIGN...
:-)Many calculations that previously required that skb->{transport,network,
mac}_header be first converted to a pointer now can be done directly, being
meaningful as offsets or pointers.Signed-off-by: Arnaldo Carvalho de Melo
Signed-off-by: David S. Miller -
Renaming skb->h to skb->transport_header, skb->nh to skb->network_header and
skb->mac to skb->mac_header, to match the names of the associated helpers
(skb[_[re]set]_{transport,network,mac}_header).Signed-off-by: Arnaldo Carvalho de Melo
Signed-off-by: David S. Miller -
Signed-off-by: Arnaldo Carvalho de Melo
Signed-off-by: David S. Miller -
This time of the type:
skb->nh.iph = (struct iphdr *)skb->data;
That is completely equivalent to:
skb->nh.raw = skb->data;
Wonder why people love casts... :-)
Signed-off-by: Arnaldo Carvalho de Melo
Signed-off-by: David S. Miller -
For the common, open coded 'skb->nh.raw = skb->data' operation, so that we can
later turn skb->nh.raw into a offset, reducing the size of struct sk_buff in
64bit land while possibly keeping it as a pointer on 32bit.This one touches just the most simple case, next will handle the slightly more
"complex" cases.Signed-off-by: Arnaldo Carvalho de Melo
Signed-off-by: David S. Miller -
For the common, open coded 'skb->mac.raw = skb->data' operation, so that we can
later turn skb->mac.raw into a offset, reducing the size of struct sk_buff in
64bit land while possibly keeping it as a pointer on 32bit.This one touches just the most simple case, next will handle the slightly more
"complex" cases.Signed-off-by: Arnaldo Carvalho de Melo
Signed-off-by: David S. Miller -
One less thing for drivers writers to worry about.
Signed-off-by: Arnaldo Carvalho de Melo
Signed-off-by: David S. Miller -
Signed-off-by: YOSHIFUJI Hideaki
Signed-off-by: David S. Miller
25 Mar, 2007
1 commit
-
This is just a QA / cosmetic fix ..
[ "a modules" => "a module" ]
Signed-off-by: Linus Torvalds
18 Feb, 2007
2 commits
-
Conflicts:
net/ieee80211/softmac/ieee80211softmac_module.c
net/ieee80211/softmac/ieee80211softmac_wx.c
15 Feb, 2007
1 commit
-
There is a bug in ieee80211softmac that always sets the user rate
to 11Mbs, no matter the capabilities of the device. This bug was
probably beneficial as long as the bcm43xx cards were rate limited;
however, most are now capable of relatively high speeds. This patch
fixes that bug and eliminates an assert that is no longer needed.Once the cards are capable of full OFDM speeds, the 24 Mbs rate will
be changed to 54 Mbs.Signed-off-by: Larry Finger
Signed-off-by: John W. Linville
11 Feb, 2007
1 commit
-
Signed-off-by: YOSHIFUJI Hideaki
Signed-off-by: David S. Miller
10 Feb, 2007
2 commits
-
…wireless-2.6 into upstream
-
Sparse issues the warning "warning: symbol 'crypt' shadows an earlier one"
in net/ieee80211/ieee80211_tx.c.Signed-off-by: Larry Finger
Signed-off-by: John W. Linville
06 Feb, 2007
1 commit
-
Unconfigured bcm43xx device can hit an assert() during wx_get_rate
queries. This is because bcm43xx calls ieee80211softmac_start late
(i.e. during open instead of probe).bcm43xx_net_open ->
bcm43xx_init_board ->
bcm43xx_select_wireless_core ->
ieee80211softmac_startFix is to check that device is running before completing
ieee80211softmac_wx_get_rate.Signed-off-by: John W. Linville
20 Dec, 2006
1 commit
-
ieee80211softmac_wx_get_genie locks the associnfo mutex at
function exit. This patch fixes it. The patch is against Linus'
tree (commit af1713e0).Signed-off-by: Ulrich Kunitz
Signed-off-by: Michael Buesch
Acked-by: Johannes Berg
Signed-off-by: Larry Finger
Signed-off-by: Andrew Morton
Signed-off-by: John W. Linville
