09 Sep, 2016
16 commits
-
The prepare_ext_ctrls() function is actually internal to the
v4l2-ctrls.c implementation, so it doesn't have a declaration
for the kAPI header to reference it.Signed-off-by: Mauro Carvalho Chehab
-
The V4L version 1 structures had long gone from the Linux Kernel.
It doesn't make sense to use cross-references for them, as they
won't be found.So, get rid of them.
Signed-off-by: Mauro Carvalho Chehab
-
instead of declaring the uAPI structs using usual refs, e. g.:
.. _foo-struct:Use the C domain way:
.. c:type:: foo_structThis way, the kAPI documentation can use cross-references to
point to the uAPI symbols.That solves about ~100 undefined warnings like:
WARNING: c:type reference target not found: foo_structSigned-off-by: Mauro Carvalho Chehab
-
The typedefs and a macro are not defined. While here, improve a
few bits on the documentation.Signed-off-by: Mauro Carvalho Chehab
-
There are some structs/enums that aren't documented via
kernel-doc markup. Add documentation for them.Fix those warnings:
./include/media/rc-map.h:103: WARNING: c:type reference target not found: rc_map_list
./include/media/rc-map.h:110: WARNING: c:type reference target not found: rc_map_list
./include/media/rc-map.h:117: WARNING: c:type reference target not found: rc_mapSigned-off-by: Mauro Carvalho Chehab
-
There are some functions/macros used by the mediactl documentation
that are alien to the media subsystem. Ignore them.After this patch, the media core will only complain about this
static function:
Documentation/media/kapi/mc-core.rst:97: WARNING: c:func reference target not found: media_devnode_releaseSigned-off-by: Mauro Carvalho Chehab
-
There are several issues on the documentation:
- the media.h header were not properly referenced;
- verbatim expressions were not properly marked as such;
- struct member references were wrong;
- some notes were not using the right markup;
- a comment that were moved to the kernel-doc markup were
duplicated as a comment inside the struct media_entity;
- some args were not pointing to the struct they're using;
- macros weren't documented.Signed-off-by: Mauro Carvalho Chehab
-
The kernel-doc parser didn't handle well the private:
tag. Rewrite it.Signed-off-by: Mauro Carvalho Chehab
-
The cross-reference to "struct media_pad" was pointing to
a place that doesn't exist. Fix it, and adjust the second
reference on the same paragraph to use the same text.Signed-off-by: Mauro Carvalho Chehab
-
demux.h was lacking documentation for the DMX_FE_ENTRY macro:
./drivers/media/dvb-core/demux.h:511: WARNING: c:func reference target not found: DMX_FE_ENTRYWhile here, get rid of unused parameters and fix a few minor issues
at the header file.Signed-off-by: Mauro Carvalho Chehab
-
There are a few define macros not documented, because the ReST
output was causing more warnings.Now that this got fixed, document them. While here, fix the
remaining coding style issues.Signed-off-by: Mauro Carvalho Chehab
-
Instead of keeping those notes at the file on a non-structured
way, move them to dtv-core.rst, using the proper ReST tags.Signed-off-by: Mauro Carvalho Chehab
-
There are several functions there there weren't properly
documented. Add documentation for them.While here, make checkpatch.pl happier.
Signed-off-by: Mauro Carvalho Chehab
-
There a some other types and functions that aren't declared
inside the media document but are elsewhere. Add them to the
ignore list.Signed-off-by: Mauro Carvalho Chehab
-
Instead of keep using the normal reference, move to the C
domain ones. Using C domains everywhere will allow
cross-references between kAPI and uAPI docs.Acked-by: Jonathan Corbet
Signed-off-by: Mauro Carvalho Chehab -
Add a parser for the --debug option, in order to allow
seeing what the parser is doing.Acked-by: Jonathan Corbet
Signed-off-by: Mauro Carvalho Chehab
07 Sep, 2016
15 commits
-
This patch adds DT binding documentation for STMicroelectronics hva
driver.Signed-off-by: Yannick Fertre
Signed-off-by: Jean-Christophe Trotin
Acked-by: Peter Griffin
Signed-off-by: Hans Verkuil
Signed-off-by: Mauro Carvalho Chehab -
Update the cobalt EDID, fixing various incorrect values (wrong name,
product code, various video capabilities).Signed-off-by: Hans Verkuil
Signed-off-by: Mauro Carvalho Chehab -
Update the vivid EDID, fixing various incorrect values (wrong name,
product code, various video capabilities).Signed-off-by: Hans Verkuil
Signed-off-by: Mauro Carvalho Chehab -
As warned by smatch:
drivers/media/pci/tw5864/tw5864-core.c:160 tw5864_h264_isr() error: double lock 'irqsave:flags'
drivers/media/pci/tw5864/tw5864-core.c:174 tw5864_h264_isr() error: double unlock 'irqsave:flags'Two different spinlocks are obtained, so having two calls is correct,
but second irqsave is superfluous, and using same "flags" variable is
just wrong.Reported-by: Mauro Carvalho Chehab
Signed-off-by: Andrey Utkin
Signed-off-by: Hans Verkuil
Signed-off-by: Mauro Carvalho Chehab -
This reverts commit 617e901a12ad ("[media] tw5864: remove double irq lock code").
That commit was rejected by Andrey Utkin ,
but it had already been merged. Revert and apply Andrey's corrected
patch next.Signed-off-by: Hans Verkuil
Signed-off-by: Mauro Carvalho Chehab -
Fix some small things:
- clean up setup function
- use MSGEND instead of 0xfe
- don't assign "return value" from cec_phys_addr to err,
it has return type void.Signed-off-by: Johan Fjeldtvedt
Signed-off-by: Hans Verkuil
Signed-off-by: Mauro Carvalho Chehab -
Replace the 'IS_ERR_VALUE(irq)' with 'ret < 0' in
function 'atmel_isc_probe'.Reported-by: Hans Verkuil
Signed-off-by: Songjun Wu
Signed-off-by: Hans Verkuil
Signed-off-by: Mauro Carvalho Chehab -
This commit adds support for VIDIOC_ENUM_FRAMESIZES
and VIDIOC_ENUM_FRAMEINTERVALS enumeration ioctls.Signed-off-by: Ezequiel Garcia
Signed-off-by: Hans Verkuil
Signed-off-by: Mauro Carvalho Chehab -
When the configuration is changed, they are also written to the adapter.
This allows the adapter to continue operating in autonomous mode with
the same settings when it is disconnected from the driver (typically by
going into suspend). For adapters with firmware version 2 or greater, the
settings are also persisted in EEPROM.A new module parameter is added to optionally also use the configuration
already present in the adapter when it is connected. This option is
enabled by default.When a new configuration is written, the autonomous mode is
automatically enabled. When the device is unconfigured, autonomous mode
is disabled.Signed-off-by: Johan Fjeldtvedt
Signed-off-by: Hans Verkuil
Signed-off-by: Mauro Carvalho Chehab -
The pulse8 dongle has some quirky behaviors when in autonomous mode.
Document these.Signed-off-by: Johan Fjeldtvedt
Signed-off-by: Hans Verkuil
Signed-off-by: Mauro Carvalho Chehab -
Make sending messages to the adapter serialized within the driver.
send_and_wait is split into send_and_wait_once, which only sends once
and checks for the result, and the higher level send_and_wait, which
performs locking and retries.Signed-off-by: Johan Fjeldtvedt
Signed-off-by: Hans Verkuil
Signed-off-by: Mauro Carvalho Chehab -
It makes sense for adapters such as the Pulse-Eight to be configurable
both from within the driver and from user space, so remove the
requirement that drivers only can call cec_s_log_addrs or
cec_s_phys_addr if they don't expose those capabilities to user space.Signed-off-by: Johan Fjeldtvedt
Signed-off-by: Hans Verkuil
Signed-off-by: Mauro Carvalho Chehab -
The field "owner" is set by core. Thus delete an extra initialisation.
Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
Signed-off-by: Markus Elfring
Signed-off-by: Hans Verkuil
Signed-off-by: Mauro Carvalho Chehab -
This patch add g/s_selection for MT8173 V4L2 Encoder.
Only output queue support g/s_selection to configure crop.
The top/left of active rectangle should always be (0,0)Signed-off-by: Tiffany Lin
Signed-off-by: Hans Verkuil
Signed-off-by: Mauro Carvalho Chehab -
The field "owner" is set by core. Thus delete an extra initialisation.
Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
Signed-off-by: Markus Elfring
Signed-off-by: Hans Verkuil
Signed-off-by: Mauro Carvalho Chehab
06 Sep, 2016
9 commits
-
The clock framework is generally so well supported that there's no reason
to keep this one around.Signed-off-by: Sakari Ailus
Reviewed-by: Sebastian Reichel
Signed-off-by: Mauro Carvalho Chehab -
Switch from the old gpio API to the new descriptor based gpiod API.
Signed-off-by: Sakari Ailus
Reviewed-by: Sebastian Reichel
Signed-off-by: Mauro Carvalho Chehab -
The data may now be const as well.
Signed-off-by: Sakari Ailus
Reviewed-by: Sebastian Reichel
Signed-off-by: Mauro Carvalho Chehab -
The clock may be provided by a driver which is yet to probe. Print the
actual error code as well.Signed-off-by: Sakari Ailus
Reviewed-by: Sebastian Reichel
Signed-off-by: Mauro Carvalho Chehab -
This is really configuration to the driver originating from DT or
elsewhere. Do not call it platform data.Signed-off-by: Sakari Ailus
Reviewed-by: Sebastian Reichel
Signed-off-by: Mauro Carvalho Chehab -
Unify enforced 8-bit read access with that based on actual need.
Signed-off-by: Sakari Ailus
Reviewed-by: Sebastian Reichel
Signed-off-by: Mauro Carvalho Chehab -
Without this patch, a bug is issued when the module is removed:
[ 1417.425863] cx231xx 1-3.1.4:1.1: Cx231xx dvb Extension removed
[ 1417.571923] BUG: unable to handle kernel paging request at ffffffffc081a024
[ 1417.571962] IP: [] string+0x24/0x80
[ 1417.571987] PGD 1c09067 PUD 1c0b067 PMD 88e653067 PTE 0
[ 1417.572013] Oops: 0000 [#1] SMP
[ 1417.572026] Modules linked in: mb86a20s dvb_core cx231xx_alsa ir_kbd_i2c(-) tda18271 tea5767 tuner cx25840 cx231xx i2c_mux videobuf_vmalloc tveeprom cx2341x videobuf_core rc_core v4l2_common videodev media bnep usblp fuse xt_CHECKSUM iptable_mangle tun ebtable_filter ebtables ip6table_filter ip6_tables xt_physdev br_netfilter bridge nf_log_ipv4 nf_log_common xt_LOG xt_conntrack ipt_MASQUERADE nf_nat_masquerade_ipv4 iptable_nat nf_conntrack_ipv4 nf_defrag_ipv4 nf_nat_ipv4 nf_nat nf_conntrack cpufreq_stats vfat fat snd_hda_codec_hdmi snd_hda_codec_realtek snd_hda_codec_generic intel_rapl x86_pkg_temp_thermal intel_powerclamp coretemp kvm_intel snd_hda_intel snd_hda_codec kvm snd_hda_core snd_hwdep snd_seq snd_seq_device snd_pcm irqbypass crct10dif_pclmul iTCO_wdt crc32_pclmul nfsd hci_uart iTCO_vendor_support
[ 1417.572317] snd_timer ghash_clmulni_intel btbcm intel_cstate btqca snd intel_uncore btintel intel_rapl_perf mei_me bluetooth mei shpchp soundcore pcspkr i2c_i801 auth_rpcgss wmi acpi_als kfifo_buf nfs_acl industrialio rfkill lockd pinctrl_sunrisepoint pinctrl_intel tpm_tis tpm intel_lpss_acpi intel_lpss acpi_pad grace sunrpc binfmt_misc hid_logitech_hidpp hid_logitech_dj 8021q garp stp llc mrp i915 i2c_algo_bit drm_kms_helper drm e1000e sdhci_pci sdhci mmc_core crc32c_intel ptp pps_core video i2c_hid fjes analog gameport joydev [last unloaded: rc_pixelview_002t]
[ 1417.572487] CPU: 4 PID: 24493 Comm: rmmod Tainted: G W 4.7.0+ #2
[ 1417.572504] Hardware name: /NUC6i7KYB, BIOS KYSKLi70.86A.0041.2016.0817.1130 08/17/2016
[ 1417.572526] task: ffff880894b81e80 ti: ffff880896bdc000 task.ti: ffff880896bdc000
[ 1417.572544] RIP: 0010:[] [] string+0x24/0x80
[ 1417.572564] RSP: 0018:ffff880896bdfbe8 EFLAGS: 00010286
[ 1417.572577] RAX: ffffffffc081a025 RBX: ffff8808935aa15c RCX: ffff0a00ffffff04
[ 1417.572594] RDX: ffffffffc081a024 RSI: ffffffffffffffff RDI: ffff8808935aa15c
[ 1417.572610] RBP: ffff880896bdfbe8 R08: fffffffffffffffe R09: ffff8808935aa91c
[ 1417.572628] R10: ffffffffc07b85d6 R11: 0000000000000000 R12: ffff8808935aa91c
[ 1417.572644] R13: 00000000000007c5 R14: ffffffffc07b85dd R15: ffffffffc07b85dd
[ 1417.572662] FS: 00007f5a5392d700(0000) GS:ffff8808bed00000(0000) knlGS:0000000000000000
[ 1417.572681] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[ 1417.572705] CR2: ffffffffc081a024 CR3: 0000000897188000 CR4: 00000000003406e0
[ 1417.572735] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
[ 1417.572761] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
[ 1417.572778] Stack:
[ 1417.572785] ffff880896bdfc48 ffffffff813dcf77 0000000000000005 ffff8808935aa157
[ 1417.572806] ffff880896bdfc58 ffff0a00ffffff04 000000009d27375e ffff8808935aa000
[ 1417.572829] 0000000000000800 ffff880896182800 0000000000000000 ffff88089e898ae0
[ 1417.572850] Call Trace:
[ 1417.572860] [] vsnprintf+0x2d7/0x500
[ 1417.572873] [] add_uevent_var+0x82/0x120
[ 1417.572890] [] rc_dev_uevent+0x2d/0x60 [rc_core]
[ 1417.572907] [] dev_uevent+0xd9/0x2d0
[ 1417.572921] [] kobject_uevent_env+0x2d9/0x4f0
[ 1417.572938] [] kobject_uevent+0xb/0x10
[ 1417.572954] [] device_del+0x18f/0x260
[ 1417.572974] [] ? kobject_put+0x27/0x50
[ 1417.572998] [] rc_unregister_device+0x75/0xb0 [rc_core]
[ 1417.573028] [] ir_remove+0x23/0x30 [ir_kbd_i2c]
[ 1417.573055] [] i2c_device_remove+0x58/0xb0
[ 1417.573078] [] __device_release_driver+0xa1/0x160
[ 1417.573102] [] driver_detach+0xa6/0xb0
[ 1417.573122] [] bus_remove_driver+0x55/0xd0
[ 1417.573146] [] driver_unregister+0x2c/0x50
[ 1417.573168] [] i2c_del_driver+0x22/0x50
[ 1417.573194] [] ir_kbd_driver_exit+0x10/0x46c [ir_kbd_i2c]
[ 1417.573227] [] SyS_delete_module+0x1b8/0x220
[ 1417.573254] [] entry_SYSCALL_64_fastpath+0x1a/0xa4
[ 1417.573279] Code: eb e9 76 ff ff ff 90 55 49 89 f1 48 89 ce 48 c1 fe 30 48 81 fa ff 0f 00 00 48 89 e5 4c 8d 46 ff 76 40 48 85 f6 74 4e 48 8d 42 01 b6 12 84 d2 74 43 49 01 c0 31 f6 eb 0c 48 83 c0 01 0f b6 50
[ 1417.573437] RIP [] string+0x24/0x80
[ 1417.573455] RSP
[ 1417.573465] CR2: ffffffffc081a024
[ 1417.580053] ---[ end trace 4ca9e2eced326a62 ]---Signed-off-by: Mauro Carvalho Chehab
-
The driver should not ignore errors while registering the I2C
bus, as this device can't even minimally work without the buses,
as it uses those buses internally to talk with the several IP
blocks inside the chip.Cc: stable@vger.kernel.org
Signed-off-by: Mauro Carvalho Chehab -
The cx231xx_get_i2c_adap() function should return the I2C
adapter that will be used to talk with a device. It should never
be NULL, as otherwise the driver will try to dereference a
null pointer.We might instead fix the callers, but if this condition
ever happens, it is really a driver bug, because i2c_port
should always be a value from enum CX231XX_I2C_MASTER_PORT.Found when checking the code due to this bug:
[ 39.769021] BUG: unable to handle kernel NULL pointer dereference at 0000000000000002
[ 39.769105] IP: [] i2c_master_send+0x13/0x70Signed-off-by: Mauro Carvalho Chehab
