04 Dec, 2009

10 commits


09 Nov, 2009

17 commits

  • A pointer to stk17ta8_rtc_probe is passed to the core via
    platform_driver_register and so the function must not disappear when the
    .init sections are discarded. Otherwise (if also having HOTPLUG=y)
    unbinding and binding a device to the driver via sysfs will result in an
    oops as does a device being registered late.

    An alternative to this patch is using platform_driver_probe instead of
    platform_driver_register plus removing the pointer to the probe function
    from the struct platform_driver.

    Signed-off-by: Uwe Kleine-König
    Cc: Anton Vorontsov
    Cc: Alessandro Zummo
    Cc: David Brownell
    Cc: Paul Mundt
    Cc: Andrew Morton
    Cc: Hannes Eder
    Cc: Jiri Kosina
    Cc: David Brownell
    Acked-by: Alessandro Zummo
    Signed-off-by: Jiri Kosina

    Uwe Kleine-König
     
  • This patch fixes a type mismatch when calling dev_info() in the
    atmel_lcdfb.c driver.

    Signed-off-by: Claudio Scordino
    Signed-off-by: Nicolas Ferre
    Signed-off-by: Jiri Kosina

    Claudio Scordino
     
  • Trivial patch which adds the __init/__exit macros to the module_init/
    module_exit functions of the following drivers in media video:
    drivers/media/video/ivtv/ivtv-driver.c
    drivers/media/video/cx18/cx18-driver.c
    drivers/media/video/davinci/dm355_ccdc.c
    drivers/media/video/davinci/dm644x_ccdc.c
    drivers/media/video/saa7164/saa7164-core.c
    drivers/media/video/saa7134/saa7134-core.c
    drivers/media/video/cx23885/cx23885-core.c

    Signed-off-by: Peter Huewe
    Acked-by: Andy Walls
    Acked-by: Laurent Pinchart
    Acked-by: Muralidharan Karicheri
    Acked-By: Steven Toth
    Signed-off-by: Jiri Kosina

    Peter Huewe
     
  • fixed printk calls to consistently specify a KERN_xxx level.

    Signed-off-by: Anders Larsen
    Signed-off-by: Jiri Kosina

    Anders Larsen
     
  • There is a nice gem in drivers/block/ataflop.c::do_fd_request()

    void do_fd_request(struct request_queue * q)
    {
    unsigned long flags;

    DPRINT(("do_fd_request for pid %d\n",current->pid));
    while( fdc_busy ) sleep_on( &fdc_wait );
    fdc_busy = 1;
    stdma_lock(floppy_irq, NULL);

    atari_disable_irq( IRQ_MFP_FDC );
    local_save_flags(flags); /* The request function is called with ints
    local_irq_disable(); * disabled... so must save the IPL for later */
    redo_fd_request();
    local_irq_restore(flags);
    atari_enable_irq( IRQ_MFP_FDC );
    }

    If you look at the code long enough, you will notioce that the
    local_irq_disable() call is actually commented out. This has been
    introduced back in 2002 in [1], but as you can see, the same bug has been
    there even before, with the sti() call being commented out in the very
    same way :)

    I am not familiar with the code myself at all, but I guess that the whole
    stuff can just be removed. Why do we need save_flags/restore_flags at all,
    without actually disabling the local IRQs afterwards? The
    redo_fd_request() doesn't seem to do anything that would mess with flags
    inconsistently.

    [1] http://lkml.org/lkml/2002/12/27/58

    Jens:
    That does look odd. The comment is correct that the function is entered
    with interrupts disabled (and the queue lock held). So I'd say your
    patch looks fine, the whole save/restore business looks meaningless.

    Signed-off-by: Jiri Kosina
    Acked-by: Jens Axboe
    Acked-by: Michael Schmitz

    Jiri Kosina
     
  • Remove the dump_tlb_all() function that has been commented out for
    many years.

    Signed-off-by: Jiri Kosina
    Acked-by: Jesper Nilsson

    Jiri Kosina
     
  • This is a followup to my patches that fixed this all over the tree quite some
    time ago. This one went unnoticed for some reason.

    TLB handling for CRIS contains local_irq_disable() after local_save_flags().
    Turn this into local_irq_save().

    Signed-off-by: Jiri Kosina
    Acked-by: Jesper Nilsson

    Jiri Kosina
     
  • This patch was generated by

    git grep -E -i -l '[Aa]quire' | xargs -r perl -p -i -e 's/([Aa])quire/$1cquire/'

    and the cumsumed was found by checking the diff for aquire.

    Signed-off-by: Uwe Kleine-König
    Signed-off-by: Jiri Kosina

    Uwe Kleine-König
     
  • If some of the flags are documented there, they all should be.

    Signed-off-by: Nick Bowler
    Acked-by: Randy Dunlap
    Signed-off-by: Jiri Kosina

    Nick Bowler
     
  • This patch was generated by

    git grep -E -i -l 's(le|el)ct' | xargs -r perl -p -i -e 's/([Ss])(le|el)ct/$1elect/

    with only skipping net/netfilter/xt_SECMARK.c and
    include/linux/netfilter/xt_SECMARK.h which have a struct member called
    selctx.

    Signed-off-by: Uwe Kleine-König
    Signed-off-by: Jiri Kosina

    Uwe Kleine-König
     
  • Additionally, some excessive newlines removed.

    Signed-off-by: Michael Roth
    Signed-off-by: Jiri Kosina

    Michael Roth
     
  • Fix typos in core_pipe_limit info.

    Signed-off-by: Randy Dunlap
    Cc: Neil Horman
    Signed-off-by: Jiri Kosina

    Randy Dunlap
     
  • Signed-off-by: Otavio Salvador
    Signed-off-by: Jiri Kosina

    Otavio Salvador
     
  • Trivial patch which adds the __init/__exit macros to the module_init/
    module_exit functions of the following drivers in media/omap:
    drivers/video/omap/lcd_ams_delta.c
    drivers/video/omap/lcd_mipid.c

    Signed-off-by: Peter Huewe
    Acked-by: Imre Deak
    Signed-off-by: Jiri Kosina

    Peter Huewe
     
  • something-bility is spelled as something-blity
    so a grep for 'blit' would find these lines

    this is so trivial that I didn't split it by subsystem / copy
    additional maintainers - all changes are to comments
    The only purpose is to get fewer false positives when grepping
    around the kernel sources.

    Signed-off-by: Dirk Hohndel
    Signed-off-by: Jiri Kosina

    Dirk Hohndel
     
  • Signed-off-by: Andrew Sharp
    Signed-off-by: Jiri Kosina

    Andrew Sharp
     
  • That URL is out of date. Update it.

    Cc: Thomas Gleixner
    Cc: Randy Dunlap
    Cc: Matt LaPlante
    Cc: Jiri Kosina
    Signed-off-by: WANG Cong
    Acked-by: Matt LaPlante
    Signed-off-by: Jiri Kosina

    Amerigo Wang
     

06 Nov, 2009

13 commits