31 Oct, 2005

2 commits

  • Fix warnings from sparse due to un-declared functions that should either
    have a header file or have been declared static

    fs/ext2/bitmap.c:14:15: warning: symbol 'ext2_count_free' was not declared. Should it be static?
    fs/ext2/namei.c:92:15: warning: symbol 'ext2_get_parent' was not declared. Should it be static?
    fs/ext3/bitmap.c:15:15: warning: symbol 'ext3_count_free' was not declared. Should it be static?
    fs/ext3/namei.c:1013:15: warning: symbol 'ext3_get_parent' was not declared. Should it be static?
    fs/ext3/xattr.c:214:1: warning: symbol 'ext3_xattr_block_get' was not declared. Should it be static?
    fs/ext3/xattr.c:358:1: warning: symbol 'ext3_xattr_block_list' was not declared. Should it be static?
    fs/ext3/xattr.c:630:1: warning: symbol 'ext3_xattr_block_find' was not declared. Should it be static?
    fs/ext3/xattr.c:863:1: warning: symbol 'ext3_xattr_ibody_find' was not declared. Should it be static?

    Signed-off-by: Ben Dooks
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Ben Dooks
     
  • I noticed some problems while running ext3 with the debug flag set on.
    More precisely, I was unable to umount the filesystem. Some investigation
    took me to the patch that follows.

    At a first glance , the lock/unlock I've taken out seems really not
    necessary, as the main code (outside debug) does not lock the super. The
    only additional danger operations that debug code introduces seems to be
    related to bitmap, but bitmap operations tends to be all atomic anyway.

    I also took the opportunity to fix 2 spelling errors.

    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Glauber de Oliveira Costa
     

23 Sep, 2005

1 commit


29 Jun, 2005

1 commit

  • Currently in ext3 block reservation code, the global filesystem reservation
    tree lock (rsv_block) is hold during the process of searching for a space
    to make a new reservation window, including while scaning the block bitmap
    to verify if the avalible window has a free block. Holding the lock during
    bitmap scan is unnecessary and could possibly cause scalability issue and
    latency issues.

    This patch tries to address this by dropping the lock before scan the
    bitmap. Before that we need to reserve the open window in case someone
    else is targetting at the same window. Question was should we reserve the
    whole free reservable space or just the window size we need. Reserve the
    whole free reservable space will possibly force other threads which
    intended to do block allocation nearby move to another block group(cause
    bad layout). In this patch, we just reserve the desired size before drop
    the lock and scan the block bitmap. This patch fixed a ext3 reservation
    latency issue seen on a cvs check out test. Patch is tested with many fsx,
    tiobench, dbench and untar a kernel test.

    Signed-Off-By: Mingming Cao
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Mingming Cao
     

17 Apr, 2005

1 commit

  • Initial git repository build. I'm not bothering with the full history,
    even though we have it. We can create a separate "historical" git
    archive of that later if we want to, and in the meantime it's about
    3.2GB when imported into git - space that would just make the early
    git days unnecessarily complicated, when we don't have a lot of good
    infrastructure for it.

    Let it rip!

    Linus Torvalds