14 Apr, 2009

1 commit


06 Feb, 2009

1 commit

  • Fix namespace violations by changing non-kconfig CONFIG_ names to CNFG_*.

    Fixes breakage in staging/, which adds a real CONFIG_PANEL.

    Signed-off-by: Randy Dunlap
    Cc: Benjamin Herrenschmidt
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Randy Dunlap
     

11 Dec, 2008

1 commit

  • This reverts commit b1ee26bab14886350ba12a5c10cbc0696ac679bf, along with
    the "fixes" for it that all just caused problems:

    - c4c6fa9891f3d1bcaae4f39fb751d5302965b566 "radeonfb: fix problem with
    color expansion & alignment"

    - f3179748a157c21d44d929fd3779421ebfbeaa93 "radeonfb: Disable new color
    expand acceleration unless explicitely enabled"

    because even when disabled, it breaks for people. See

    http://bugzilla.kernel.org/show_bug.cgi?id=12191

    for the latest example.

    Acked-by: Benjamin Herrenschmidt
    Acked-by: David S. Miller
    Cc: Krzysztof Halasa
    Cc: James Cloos
    Cc: "Rafael J. Wysocki"
    Cc: Krzysztof Helt
    Cc: Jean-Luc Coulon
    Cc: Andrew Morton
    Signed-off-by: Linus Torvalds

    Linus Torvalds
     

10 Dec, 2008

1 commit

  • This new color expansion acceleration for radeonfb appears to trigger
    problems with X on VT switch and suspend/resume on some machines. It
    might be a problem in the VT layer or in X, but I haven't quite found
    it yet, so in the meantime, this disables the acceleration by default,
    reverting to 2.6.27 state. It can be enabled using the "accel_cexp"
    module parameter or fbdev argument.

    Signed-off-by: Benjamin Herrenschmidt
    Acked-by: David S. Miller
    Signed-off-by: Linus Torvalds

    Benjamin Herrenschmidt
     

02 Dec, 2008

1 commit

  • The engine on some radeon variants locks up if color expansion is called
    for non aligned source data. This patch enables a feature of the core
    fbdev to request aligned input pixmaps and uses the HW clipping engine to
    clip the output to the requested size

    Addresses http://bugzilla.kernel.org/show_bug.cgi?id=11875

    Signed-off-by: Benjamin Herrenschmidt
    Tested-by: James Cloos
    Cc: "Rafael J. Wysocki"
    Cc: "David S. Miller"
    Cc: Krzysztof Helt
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Benjamin Herrenschmidt
     

17 Oct, 2008

2 commits

  • Implement support for HW color expansion of 1bpp images, along with some
    improvements to the FIFO handling and other accel operations.

    The offset fixup code is now unnecessary as the fbcon core will call our
    set_par upon switch back from KD_GRAPHICS before anything else happens. I
    removed it as it would slow down accel operations.

    The fifo wait has been improved to avoid hitting the HW register as often,
    and the various accel ops are now performing better caching of register
    values.

    Overall, this improve accel performances. The imageblit acceleration does
    result in a small overall regression in performances on some machines (on
    the order of 5% on some x86), probably becaus the SW path provides a
    better bus utilisation, but I decided to ingnore that as the performances
    is still very good, and on the other hand, some machines such as some
    sparc64 get a 3 fold performance improvement.

    Signed-off-by: Benjamin Herrenschmidt
    Acked-by: David S. Miller
    Cc: Krzysztof Halasa
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Benjamin Herrenschmidt
     
  • Fix a couple of incomplete tests of the chip families in the engine
    init/reset code and proper initialization of the destination cache mode.
    The result should better match what the latest X radeon driver does.

    Signed-off-by: Benjamin Herrenschmidt
    Acked-by: David S. Miller
    Cc: Krzysztof Halasa
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Benjamin Herrenschmidt
     

25 Jul, 2008

2 commits

  • Signed-off-by: Akinobu Mita
    Cc: Benjamin Herrenschmidt
    Cc: "Antonino A. Daplas"
    Cc: Krzysztof Helt
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Akinobu Mita
     
  • Current kernel builds warn about:
    drivers/video/aty/radeon_base.c: In function 'radeonfb_pci_register':
    drivers/video/aty/radeon_base.c:2334: warning: ignoring return value of 'sysfs_create_bin_file', declared with attribute warn_unused_result
    drivers/video/aty/radeon_base.c:2336: warning: ignoring return value of 'sysfs_create_bin_file', declared with attribute warn_unused_result

    Do minimal checking of these functions and issue a warning if either
    fails. They don't seem to be critical..

    [akpm@linux-foundation.org: coding-style fixes]
    Signed-off-by: Tony Breeds
    Cc: "Antonino A. Daplas"
    Cc: Benjamin Herrenschmidt
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Tony Breeds
     

23 May, 2008

1 commit

  • drivers/video/aty/atyfb_base.c:3359:26: warning: Using plain integer as NULL pointer
    drivers/video/aty/radeon_base.c:2280:32: warning: Using plain integer as NULL pointer
    drivers/video/matrox/matroxfb_base.h:203:25: warning: Using plain integer as NULL pointer
    drivers/video/matrox/matroxfb_base.h:203:25: warning: Using plain integer as NULL pointer
    drivers/video/sis/sis_main.c:5790:44: warning: Using plain integer as NULL pointer

    Signed-off-by: Harvey Harrison
    Signed-off-by: Linus Torvalds

    Harvey Harrison
     

28 Apr, 2008

3 commits

  • RTRACE() does exactly the same thing as the standard pr_debug() call, so just
    use the latter.

    Signed-off-by: Jean Delvare
    Acked-by: Benjamin Herrenschmidt
    Cc: "Antonino A. Daplas"
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Jean Delvare
     
  • Fix CONFIG_FB_RADEON_DEBUG. DEBUG must be defined before including any kernel
    header, otherwise dev_dbg() resolves to a no-op. Also, when debugging is
    disabled, don't set DEBUG at all instead of setting it to 0, to comply with
    what the kernel headers expect.

    Signed-off-by: Jean Delvare
    Acked-by: Benjamin Herrenschmidt
    Cc: "Antonino A. Daplas"
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Jean Delvare
     
  • Additionally provide PCI device id in character format if possible. (The
    printable characters were commonly used to identify the cards.)

    Signed-off-by: Andreas Herrmann
    Cc: "Antonino A. Daplas"
    Cc: Benjamin Herrenschmidt
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Andreas Herrmann
     

27 Nov, 2007

1 commit


17 Oct, 2007

2 commits

  • Make radeonfb work ith the 200m Xpress RC410. In my tests it was terribly
    unstable and would freeze until I set a refresh rate in the kernel argument
    to 75.

    e.g video=radeonfb:1280x800@75

    Now it is rock solid.

    Cc: Benjamin Herrenschmidt
    Cc: "Antonino A. Daplas"
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Sellout Bessie
     
  • This patch replaces with after the
    checkpatch.pl hint. The include of is removed if the driver
    does not use it.

    Signed-off-by: Krzysztof Helt
    Signed-off-by: Antonino Daplas
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Krzysztof Helt
     

13 Sep, 2007

2 commits

  • This fixes a problem introduced with commit
    b5f2f4d1a6d7efde39cfb5e1d034981c69f2214c
    The commit added a wrong chip definition to radeonfb which causes
    a blank console on my Laptop if radeonfb is loaded.

    The patch
    - renames PCI_CHIP_RS485_5975 to PCI_CHIP_RS482_5975
    - corrects the chip family (RS480 instead of R300) for 0x5975
    - ensures that PCI IDs are in ascending order in ati_ids.h

    Signed-off-by: Andreas Herrmann
    Tentatively-acked-by: Ben Herrenschmidt
    Signed-off-by: Linus Torvalds

    aherrman@arcor.de
     
  • As observed with various Radeon X300 cards console goes blank
    without that fix.

    Acked-by: Benjamin Herrenschmidt
    Signed-off-by: Andreas Herrmann
    Signed-off-by: Linus Torvalds

    aherrman@arcor.de
     

18 Jul, 2007

1 commit


12 Jul, 2007

2 commits

  • Well, first of all, I don't want to change so many files either.

    What I do:
    Adding a new parameter "struct bin_attribute *" in the
    .read/.write methods for the sysfs binary attributes.

    In fact, only the four lines change in fs/sysfs/bin.c and
    include/linux/sysfs.h do the real work.
    But I have to update all the files that use binary attributes
    to make them compatible with the new .read and .write methods.
    I'm not sure if I missed any. :(

    Why I do this:
    For a sysfs attribute, we can get a pointer pointing to the
    struct attribute in the .show/.store method,
    while we can't do this for the binary attributes.
    I don't know why this is different, but this does make it not
    so handy to use the binary attributes as the regular ones.
    So I think this patch is reasonable. :)

    Who benefits from it:
    The patch that exposes ACPI tables in sysfs
    requires such an improvement.
    All the table binary attributes share the same .read method.
    Parameter "struct bin_attribute *" is used to get
    the table signature and instance number which are used to
    distinguish different ACPI table binary attributes.

    Without this parameter, we need to offer different .read methods
    for different ACPI table binary attributes.
    This is impossible as there are various ACPI tables on different
    platforms, and we don't know what they are until they are loaded.

    Signed-off-by: Zhang Rui
    Signed-off-by: Greg Kroah-Hartman

    Zhang Rui
     
  • sysfs is now completely out of driver/module lifetime game. After
    deletion, a sysfs node doesn't access anything outside sysfs proper,
    so there's no reason to hold onto the attribute owners. Note that
    often the wrong modules were accounted for as owners leading to
    accessing removed modules.

    This patch kills now unnecessary attribute->owner. Note that with
    this change, userland holding a sysfs node does not prevent the
    backing module from being unloaded.

    For more info regarding lifetime rule cleanup, please read the
    following message.

    http://article.gmane.org/gmane.linux.kernel/510293

    (tweaked by Greg to not delete the field just yet, to make it easier to
    merge things properly.)

    Signed-off-by: Tejun Heo
    Cc: Cornelia Huck
    Cc: Andrew Morton
    Signed-off-by: Greg Kroah-Hartman

    Tejun Heo
     

09 May, 2007

2 commits

  • * 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/paulus/powerpc: (77 commits)
    [POWERPC] Abolish powerpc_flash_init()
    [POWERPC] Early serial debug support for PPC44x
    [POWERPC] Support for the Ebony 440GP reference board in arch/powerpc
    [POWERPC] Add device tree for Ebony
    [POWERPC] Add powerpc/platforms/44x, disable platforms/4xx for now
    [POWERPC] MPIC U3/U4 MSI backend
    [POWERPC] MPIC MSI allocator
    [POWERPC] Enable MSI mappings for MPIC
    [POWERPC] Tell Phyp we support MSI
    [POWERPC] RTAS MSI implementation
    [POWERPC] PowerPC MSI infrastructure
    [POWERPC] Rip out the existing powerpc msi stubs
    [POWERPC] Remove use of 4level-fixup.h for ppc32
    [POWERPC] Add powerpc PCI-E reset API implementation
    [POWERPC] Holly bootwrapper
    [POWERPC] Holly DTS
    [POWERPC] Holly defconfig
    [POWERPC] Add support for 750CL Holly board
    [POWERPC] Generalize tsi108 PCI setup
    [POWERPC] Generalize tsi108 PHY types
    ...

    Fixed conflict in include/asm-powerpc/kdebug.h manually

    Signed-off-by: Linus Torvalds

    Linus Torvalds
     
  • Added support for radeon xpress 200m(rs480). Note that the card doesn't
    like dynclk turned on.

    Signed-off-by: Johan Henriksson
    Cc: Benjamin Herrenschmidt
    Cc: "Antonino A. Daplas"
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    johan henriksson
     

02 May, 2007

1 commit


26 Apr, 2007

1 commit


05 Mar, 2007

1 commit


03 Mar, 2007

1 commit

  • If you'll recall, over a year ago, I pointed out that the current
    Radeon driver erroneously returns -EINVAL for valid blanking codes,
    here is a link to that thread:

    http://lkml.org/lkml/2006/1/28/6

    No other driver does this, and it confuses the X server into thinking
    that the device does not support blanking properly.

    I looked again and there is simply no reason for the Radeon driver to
    return -EINVAL for FB_BLANK_NORMAL. It claims it wants to do this in
    order to convince fbcon to blank in software, right here:

    if (fb_blank(info, blank))
    fbcon_generic_blank(vc, info, blank);

    to software blank the screen. But it only causes that to happen
    in the FB_BLANK_NORMAL case.

    That makes no sense because the Radeon code does this:

    val |= CRTC_DISPLAY_DIS;

    in the FB_BLANK_NORMAL case so should be blanking the hardware, and
    there is therefore no reason to SW blank by returning -EINVAL.

    Signed-off-by: David S. Miller
    Acked-by: Antonino Daplas

    David S. Miller
     

20 Feb, 2007

1 commit

  • fb_info->bl_mutex is badly thought out and the backlight class doesn't
    need it if the framebuffer/backlight register/unregister order is
    consistent, particularly after the backlight locking fixes.

    Fix the drivers to use the order:

    backlight_device_register()
    register_framebuffer()
    unregister_framebuffer()
    backlight_device_unregister()

    and turn bl_mutex into a lock for the bl_curve data only.

    Signed-off-by: Richard Purdie

    Richard Purdie
     

01 Aug, 2006

2 commits

  • Paul Mackerras
     
  • Many IBM Thinkpad T4* models and some R* and X* with radeon video cards draw
    too much power when suspended to RAM, reducing drastically the battery
    lifetime. The solution is to enable suspend-to-D2 on these machines. They
    are whitelisted through their subsystem vendor/device ID. This fixes
    http://bugzilla.kernel.org/show_bug.cgi?id=3022

    The patch introduces a framework to alter the pm_mode and reinit_func fields
    of the radeonfb_info structure based on a whitelist. This should facilitate
    future hardware-dependent workarounds. The workaround for the Samsung P35
    that is already in the radeonfb code has been rewritten using this framework.

    The behavior can be overridden with module options:

    i) video=radeonfb:force_sleep=1
    enable suspend-to-D2 also on non-whitelisted machines (useful for
    testing new notebook models),

    ii) video=radeonfb:ignore_devlist=1
    Disable checking the whitelist and do not apply any workarounds.

    Cc: Benjamin Herrenschmidt
    Cc: "Antonino A. Daplas"
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Volker Braun
     

31 Jul, 2006

1 commit


11 Jul, 2006

1 commit

  • MAX_NR_CONSOLES, fg_console, want_console and last_console are more of a
    function of the VT layer than the TTY one. Moving these to vt.h and vt_kern.h
    allows all of the framebuffer and VT console drivers to remove their
    dependency on tty.h.

    [akpm@osdl.org: fix alpha build]
    Signed-off-by: Jon Smirl
    Signed-off-by: Antonino Daplas
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Jon Smirl
     

01 Jul, 2006

1 commit


27 Jun, 2006

1 commit

  • Detaching fbcon allows individual drivers to be unloaded. However several
    drivers call pci_disable_device() upon exit. This function will disable the
    BAR's which will kill VGA text mode and/or affect X/DRM.

    To prevent this, remove calls to pci_disable_device() from several drivers.

    Signed-off-by: Antonino Daplas
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Antonino A. Daplas
     

26 Jun, 2006

1 commit

  • This patch contains a total rewrite of the backlight infrastructure for
    portable Apple computers. Backward compatibility is retained. A sysfs
    interface allows userland to control the brightness with more steps than
    before. Userland is allowed to upload a brightness curve for different
    monitors, similar to Mac OS X.

    [akpm@osdl.org: add needed exports]
    Signed-off-by: Michael Hanselmann
    Acked-by: Benjamin Herrenschmidt
    Cc: Richard Purdie
    Cc: "Antonino A. Daplas"
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Michael Hanselmann
     

20 Apr, 2006

1 commit

  • Marking radeon_pci_register() as __devinit clears up all section
    mismatch warnings that are caused by radeon_pci_register() calling
    various __devinit function. Is there some reason not to do this?

    WARNING: drivers/video/aty/radeonfb.o - Section mismatch: reference to .init.text: from .text.radeonfb_pci_register after 'radeonfb_pci_register' (at offset 0x628)
    WARNING: drivers/video/aty/radeonfb.o - Section mismatch: reference to .init.text: from .text.radeonfb_pci_register after 'radeonfb_pci_register' (at offset 0x6b5)
    WARNING: drivers/video/aty/radeonfb.o - Section mismatch: reference to .init.text: from .text.radeonfb_pci_register after 'radeonfb_pci_register' (at offset 0x6bd)
    WARNING: drivers/video/aty/radeonfb.o - Section mismatch: reference to .init.text:radeon_probe_screens from .text.radeonfb_pci_register after 'radeonfb_pci_register' (at offset 0x7d6)
    WARNING: drivers/video/aty/radeonfb.o - Section mismatch: reference to .init.text:radeon_check_modes from .text.radeonfb_pci_register after 'radeonfb_pci_register' (at offset 0x7e5)

    Signed-off-by: Randy Dunlap
    Cc: "Antonino A. Daplas"
    Acked-by: Benjamin Herrenschmidt
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Randy Dunlap
     

28 Mar, 2006

1 commit

  • A set of 3 small bugfixes, all of which are related to bogus return values
    of fb colormap-setting functions.

    First, fb_alloc_cmap returns -1 if memory allocation fails. This is a hard
    condition to reproduce since you'd have to be really low on memory, but from
    studying the contexts in which it is called, I think this function should be
    returning a negative errno, and the -1 will be seen as an EPERM. Switching it
    to -ENOMEM makes sense.

    Second, the store_cmap function which is called for writes to
    /sys/class/graphics/fb0/color_map returns 0 for success, but it should be
    returning the count of bytes written since its return value ends up in
    userspace as the result of the write() syscall.

    Third, radeonfb returns 1 instead of a negative errno when FBIOPUTCMAP is
    called with an oversized colormap. This is seen in userspace as a return
    value of 1 from the ioctl() syscall with errno left unchanged. A more
    useful return value would be -EINVAL.

    Signed-off-by: Alan Curry
    Cc: "Antonino A. Daplas"
    Cc: Benjamin Herrenschmidt
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Alan Curry
     

15 Jan, 2006

1 commit


03 Jan, 2006

1 commit


07 Nov, 2005

1 commit