Eric Lee / smarc-fsl-linux-kernel

08 Jan, 2009

1 commit

17 Oct, 2007

1 commit

12 Oct, 2007

1 commit

  • 0b75f2dfa   backlight: Fix cr_bllcd allocations and error paths ... Browse Code »

    After fixing the too small memory allocation in cr_backlight_probe()
    from drivers/video/backlight/cr_bllcd.c
    (commit e3bbb3f05339de438faf54124f25c92e6fe4ac2e) I noticed that the
    Coverity checker also thought there were a few memory leaks in there.
    I took a closer look and confirmed that there were indeed several
    leaks.

    At the start of the function we allocate storage for a
    'struct cr_panel' and store the pointer in a variable named 'crp'.

    Then we call pci_get_device() and pci_read_config_byte() and if
    either of them fail we return without freeing the memory allocated
    for the 'struct cr_panel'. These two leaks are easy to fix since we
    don't even use 'crp' for anything up to this point, so I simply
    moved the allocation further down in the function so it only happens
    just before we actually need it.

    A bit further down we call backlight_device_register() and store the
    result in 'crp->cr_backlight_device'. In case of error we return
    'crp->cr_backlight_device' from the function, thus leaking 'crp'
    itself. The same thing happens with the call to lcd_device_register().
    To fix these two leaks I declare two new pointers to hold the return
    values, so that in case of error we can return the pointer (as before)
    but without leaking 'crp'.

    This version of the patch also adds missing
    backlight_device_unregister() / lcd_device_unregister() / pci_dev_put()
    calls to error paths.
    Thanks to Richard Purdie for noticing.

    Signed-off-by: Jesper Juhl
    Signed-off-by: Andrew Morton
    Signed-off-by: Richard Purdie

    Jesper Juhl
     

23 Jul, 2007

1 commit

22 Jul, 2007

1 commit

20 Jul, 2007

1 commit

16 Jul, 2007

1 commit

  • 655bfd7ae   backlight: Convert from struct class_device to struct device ... Browse Code »

    Convert the backlight and LCD classes from struct class_device
    to struct device since class_device is scheduled for removal.

    One nasty API break is the backlight power attribute has had to be
    renamed to bl_power and the LCD power attribute has had to be renamed
    to lcd_power since the original names clash with the core. I can't see
    a way around this.

    Signed-off-by: Richard Purdie
    Acked-by: Greg Kroah-Hartman

    Richard Purdie
     

09 May, 2007

1 commit