Eric Lee / smarc-fsl-linux-kernel

24 Sep, 2009

1 commit

  • 6d729e44a   fs: Make unload_nls() NULL pointer safe ... Browse Code »

    Most call sites of unload_nls() do:
    if (nls)
    unload_nls(nls);

    Check the pointer inside unload_nls() like we do in kfree() and
    simplify the call sites.

    Signed-off-by: Thomas Gleixner
    Cc: Steve French
    Cc: OGAWA Hirofumi
    Cc: Roman Zippel
    Cc: Dave Kleikamp
    Cc: Petr Vandrovec
    Cc: Anton Altaparmakov
    Signed-off-by: Al Viro

    Thomas Gleixner
     

09 Sep, 2009

1 commit

24 Jul, 2009

1 commit

  • 4a19fb11a   jfs: Fix early release of acl in jfs_get_acl ... Browse Code »

    BugLink: http://bugs.launchpad.net/ubuntu/+bug/396780

    Commit 073aaa1b142461d91f83da66db1184d7c1b1edea "helpers for acl
    caching + switch to those" introduced new helper functions for
    acl handling but seems to have introduced a regression for jfs as
    the acl is released before returning it to the caller, instead of
    leaving this for the caller to do.
    This causes the acl object to be used after freeing it, leading
    to kernel panics in completely different places.

    Thanks to Christophe Dumez for reporting and bisecting into this.

    Reported-by: Christophe Dumez
    Tested-by: Christophe Dumez
    Signed-off-by: Stefan Bader
    Acked-by: Andy Whitcroft
    Signed-off-by: Dave Kleikamp

    Stefan Bader
     

25 Jun, 2009

1 commit

24 Jun, 2009

2 commits

17 Jun, 2009

2 commits

12 Jun, 2009

2 commits

  • 337eb00a2   Push BKL down into ->remount_fs() ... Browse Code »

    [xfs, btrfs, capifs, shmem don't need BKL, exempt]

    Signed-off-by: Alessio Igor Bogani
    Signed-off-by: Al Viro

    Alessio Igor Bogani
     
  • 6cfd01484   push BKL down into ->put_super ... Browse Code »

    Move BKL into ->put_super from the only caller. A couple of
    filesystems had trivial enough ->put_super (only kfree and NULLing of
    s_fs_info + stuff in there) to not get any locking: coda, cramfs, efs,
    hugetlbfs, omfs, qnx4, shmem, all others got the full treatment. Most
    of them probably don't need it, but I'd rather sort that out individually.
    Preferably after all the other BKL pushdowns in that area.

    [AV: original used to move lock_super() down as well; these changes are
    removed since we don't do lock_super() at all in generic_shutdown_super()
    now]
    [AV: fuse, btrfs and xfs are known to need no damn BKL, exempt]

    Signed-off-by: Christoph Hellwig
    Signed-off-by: Al Viro

    Christoph Hellwig
     

24 May, 2009

1 commit

07 Apr, 2009

1 commit

  • 9c83633ad   missing unlock in jfs_quota_write() ... Browse Code »

    We should unlock &inode->i_mutex on the error path. This bug was
    in ext2_quota_write(). I sent a patch to them today as well.

    Found by smatch (http://repo.or.cz/w/smatch.git). Compile tested.

    regards,
    dan carpenter

    Signed-off-by: Dan Carpenter
    Signed-off-by: Dave Kleikamp

    Dan Carpenter
     

01 Apr, 2009

1 commit

31 Mar, 2009

2 commits

  • 99b762338   proc 2/2: remove struct proc_dir_entry::owner ... Browse Code »

    Setting ->owner as done currently (pde->owner = THIS_MODULE) is racy
    as correctly noted at bug #12454. Someone can lookup entry with NULL
    ->owner, thus not pinning enything, and release it later resulting
    in module refcount underflow.

    We can keep ->owner and supply it at registration time like ->proc_fops
    and ->data.

    But this leaves ->owner as easy-manipulative field (just one C assignment)
    and somebody will forget to unpin previous/pin current module when
    switching ->owner. ->proc_fops is declared as "const" which should give
    some thoughts.

    ->read_proc/->write_proc were just fixed to not require ->owner for
    protection.

    rmmod'ed directories will be empty and return "." and ".." -- no harm.
    And directories with tricky enough readdir and lookup shouldn't be modular.
    We definitely don't want such modular code.

    Removing ->owner will also make PDE smaller.

    So, let's nuke it.

    Kudos to Jeff Layton for reminding about this, let's say, oversight.

    http://bugzilla.kernel.org/show_bug.cgi?id=12454

    Signed-off-by: Alexey Dobriyan

    Alexey Dobriyan
     
  • ffd142851   Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/shaggy/jfs-2.6 ... Browse Code »

    * 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/shaggy/jfs-2.6:
    jfs: needs crc32_le
    jfs: Fix error handling in metapage_writepage()
    jfs: return f_fsid for statfs(2)
    jfs: remove xtLookupList()
    jfs: clean up a dangling comment

    Linus Torvalds
     

28 Mar, 2009

2 commits

  • 3ae5080f4   Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs-2.6 ... Browse Code »

    * 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs-2.6: (37 commits)
    fs: avoid I_NEW inodes
    Merge code for single and multiple-instance mounts
    Remove get_init_pts_sb()
    Move common mknod_ptmx() calls into caller
    Parse mount options just once and copy them to super block
    Unroll essentials of do_remount_sb() into devpts
    vfs: simple_set_mnt() should return void
    fs: move bdev code out of buffer.c
    constify dentry_operations: rest
    constify dentry_operations: configfs
    constify dentry_operations: sysfs
    constify dentry_operations: JFS
    constify dentry_operations: OCFS2
    constify dentry_operations: GFS2
    constify dentry_operations: FAT
    constify dentry_operations: FUSE
    constify dentry_operations: procfs
    constify dentry_operations: ecryptfs
    constify dentry_operations: CIFS
    constify dentry_operations: AFS
    ...

    Linus Torvalds
     
  • ad28b4ef1   constify dentry_operations: JFS ... Browse Code »

    Signed-off-by: Al Viro

    Al Viro
     

26 Mar, 2009

1 commit

03 Feb, 2009

2 commits

31 Jan, 2009

1 commit

28 Jan, 2009

1 commit

  • b5c816a4f   jfs: return f_fsid for statfs(2) ... Browse Code »

    This patch makes jfs return f_fsid info for statfs(2). By Andreas'
    suggestion, this patch populates a persistent f_fsid between boots/mounts
    with help of on-disk uuid record.

    Signed-off-by: Coly Li
    Signed-off-by: Dave Kleikamp

    Coly Li
     

22 Jan, 2009

1 commit

10 Jan, 2009

3 commits

  • c4be0c1dc   filesystem freeze: add error handling of write_super_lockfs/unlockfs ... Browse Code »

    Currently, ext3 in mainline Linux doesn't have the freeze feature which
    suspends write requests. So, we cannot take a backup which keeps the
    filesystem's consistency with the storage device's features (snapshot and
    replication) while it is mounted.

    In many case, a commercial filesystem (e.g. VxFS) has the freeze feature
    and it would be used to get the consistent backup.

    If Linux's standard filesystem ext3 has the freeze feature, we can do it
    without a commercial filesystem.

    So I have implemented the ioctls of the freeze feature.
    I think we can take the consistent backup with the following steps.
    1. Freeze the filesystem with the freeze ioctl.
    2. Separate the replication volume or create the snapshot
    with the storage device's feature.
    3. Unfreeze the filesystem with the unfreeze ioctl.
    4. Take the backup from the separated replication volume
    or the snapshot.

    This patch:

    VFS:
    Changed the type of write_super_lockfs and unlockfs from "void"
    to "int" so that they can return an error.
    Rename write_super_lockfs and unlockfs of the super block operation
    freeze_fs and unfreeze_fs to avoid a confusion.

    ext3, ext4, xfs, gfs2, jfs:
    Changed the type of write_super_lockfs and unlockfs from "void"
    to "int" so that write_super_lockfs returns an error if needed,
    and unlockfs always returns 0.

    reiserfs:
    Changed the type of write_super_lockfs and unlockfs from "void"
    to "int" so that they always return 0 (success) to keep a current behavior.

    Signed-off-by: Takashi Sato
    Signed-off-by: Masayuki Hamaguchi
    Cc:
    Cc:
    Cc: Christoph Hellwig
    Cc: Dave Kleikamp
    Cc: Dave Chinner
    Cc: Alasdair G Kergon
    Cc: Al Viro
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Takashi Sato
     
  • fec1878fe   jfs: remove xtLookupList() ... Browse Code »

    xtLookupList() was a more generalized version of xtLookup() with a
    nastier interface. Its only caller, extHint(), is actually better
    suited to using xtLookup() than xtLookupList(). This also lets us
    remove the definition of lxd_t, an obnoxious packed structure that was
    only used in-memory.

    Signed-off-by: Dave Kleikamp

    Dave Kleikamp
     
  • da9c138e9   jfs: clean up a dangling comment ... Browse Code »

    viro cleaned up an hlist hack, but left a comment where it no longer
    belongs. Combine the old comment with his new one.

    Signed-off-by: Dave Kleikamp

    Dave Kleikamp
     

06 Jan, 2009

1 commit

01 Jan, 2009

1 commit

31 Dec, 2008

1 commit

17 Dec, 2008

1 commit

14 Nov, 2008

1 commit

  • 8f659adfa   CRED: Wrap task credential accesses in the JFS filesystem ... Browse Code »

    Wrap access to task credentials so that they can be separated more easily from
    the task_struct during the introduction of COW creds.

    Change most current->(|e|s|fs)[ug]id to current_(|e|s|fs)[ug]id().

    Change some task->e?[ug]id to task_e?[ug]id(). In some places it makes more
    sense to use RCU directly rather than a convenient wrapper; these will be
    addressed by later patches.

    Signed-off-by: David Howells
    Reviewed-by: James Morris
    Acked-by: Serge Hallyn
    Acked-by: Dave Kleikamp
    Cc: jfs-discussion@lists.sourceforge.net
    Signed-off-by: James Morris

    David Howells
     

24 Oct, 2008

1 commit

  • 224848564   Merge git://git.kernel.org/pub/scm/linux/kernel/git/viro/bdev ... Browse Code »

    * git://git.kernel.org/pub/scm/linux/kernel/git/viro/bdev: (66 commits)
    [PATCH] kill the rest of struct file propagation in block ioctls
    [PATCH] get rid of struct file use in blkdev_ioctl() BLKBSZSET
    [PATCH] get rid of blkdev_locked_ioctl()
    [PATCH] get rid of blkdev_driver_ioctl()
    [PATCH] sanitize blkdev_get() and friends
    [PATCH] remember mode of reiserfs journal
    [PATCH] propagate mode through swsusp_close()
    [PATCH] propagate mode through open_bdev_excl/close_bdev_excl
    [PATCH] pass fmode_t to blkdev_put()
    [PATCH] kill the unused bsize on the send side of /dev/loop
    [PATCH] trim file propagation in block/compat_ioctl.c
    [PATCH] end of methods switch: remove the old ones
    [PATCH] switch sr
    [PATCH] switch sd
    [PATCH] switch ide-scsi
    [PATCH] switch tape_block
    [PATCH] switch dcssblk
    [PATCH] switch dasd
    [PATCH] switch mtd_blkdevs
    [PATCH] switch mmc
    ...

    Linus Torvalds
     

23 Oct, 2008

2 commits

21 Oct, 2008

1 commit

14 Oct, 2008

1 commit

  • a447c0932   vfs: Use const for kernel parser table ... Browse Code »

    This is a much better version of a previous patch to make the parser
    tables constant. Rather than changing the typedef, we put the "const" in
    all the various places where its required, allowing the __initconst
    exception for nfsroot which was the cause of the previous trouble.

    This was posted for review some time ago and I believe its been in -mm
    since then.

    Signed-off-by: Steven Whitehouse
    Cc: Alexander Viro
    Signed-off-by: Linus Torvalds

    Steven Whitehouse
     

27 Jul, 2008

2 commits

  • e6305c43e   [PATCH] sanitize ->permission() prototype ... Browse Code »

    * kill nameidata * argument; map the 3 bits in ->flags anybody cares
    about to new MAY_... ones and pass with the mask.
    * kill redundant gfs2_iop_permission()
    * sanitize ecryptfs_permission()
    * fix remaining places where ->permission() instances might barf on new
    MAY_... found in mask.

    The obvious next target in that direction is permission(9)

    folded fix for nfs_permission() breakage from Miklos Szeredi

    Signed-off-by: Al Viro

    Al Viro
     
  • 51cc50685   SL*B: drop kmem cache argument from constructor ... Browse Code »

    Kmem cache passed to constructor is only needed for constructors that are
    themselves multiplexeres. Nobody uses this "feature", nor does anybody uses
    passed kmem cache in non-trivial way, so pass only pointer to object.

    Non-trivial places are:
    arch/powerpc/mm/init_64.c
    arch/powerpc/mm/hugetlbpage.c

    This is flag day, yes.

    Signed-off-by: Alexey Dobriyan
    Acked-by: Pekka Enberg
    Acked-by: Christoph Lameter
    Cc: Jon Tollefson
    Cc: Nick Piggin
    Cc: Matt Mackall
    [akpm@linux-foundation.org: fix arch/powerpc/mm/hugetlbpage.c]
    [akpm@linux-foundation.org: fix mm/slab.c]
    [akpm@linux-foundation.org: fix ubifs]
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Alexey Dobriyan
     

26 Jul, 2008

1 commit

  • 74abb9890   quota: move function-macros from quota.h to quotaops.h ... Browse Code »

    Move declarations of some macros, which should be in fact functions to
    quotaops.h. This way they can be later converted to inline functions
    because we can now use declarations from quota.h. Also add necessary
    includes of quotaops.h to a few files.

    [akpm@linux-foundation.org: fix JFS build]
    [akpm@linux-foundation.org: fix UFS build]
    [vegard.nossum@gmail.com: fix QUOTA=n build]
    Signed-off-by: Jan Kara
    Cc: Vegard Nossum
    Cc: Arjen Pool
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Jan Kara
     

11 Jun, 2008

1 commit

  • ec1aef336   jfs: remove DIRENTSIZ ... Browse Code »

    After fat gets fixed the unused DIRENTSIZ macro was the last user of
    struct dirent we should get rid of since the kernel and userspace
    versions differed.

    Signed-off-by: Adrian Bunk
    Signed-off-by: Dave Kleikamp

    Adrian Bunk