Eric Lee / smarc-fsl-linux-kernel

23 Jul, 2012

1 commit

23 May, 2012

2 commits

28 Mar, 2012

4 commits

29 Feb, 2012

1 commit

  • 78d3e00bb   watchdog: fix error in probe() of s3c2410_wdt (reset at booting) ... Browse Code »

    Probe function of s3c2410 watchdog calls request_irq before initializing
    required value (wdt_count). This incurs resetting watchdog counter value
    and watchdog-reboot during booting up.

    This patch addresses such an issue by calling request_irq later.

    Error handling in probe function and calling oder in remove function are
    also revised accordingly.

    Reported-by: Chanwoo Park
    Signed-off-by: MyungJoo Ham
    Signed-off-by: Kyungmin Park
    Signed-off-by: Wim Van Sebroeck

    MyungJoo Ham
     

06 Jan, 2012

1 commit

17 Nov, 2011

1 commit

  • 20403e845   watchdog: fix initialisation printout in s3c2410_wdt ... Browse Code »

    Looks like a typo creeped in, and driver prints
    s3c2410-wdt s3c2410-wdt: watchdog active, reset abled, irq abled

    instead of
    s3c2410-wdt s3c2410-wdt: watchdog active, reset enabled, irq enabled

    Also it may completely disinform about irq status, as it prints
    "irq enabled" when S3C2410_WTCON_INTEN is in fact 0.

    Fix it.

    Signed-off-by: Dmitry Artamonow
    Tested-by: Thomas Abraham
    Signed-off-by: Wim Van Sebroeck

    Dmitry Artamonow
     

06 Nov, 2011

1 commit

22 Jul, 2011

1 commit

29 Mar, 2011

1 commit

16 Mar, 2011

1 commit

09 Aug, 2010

1 commit

  • 9a3725631   watchdog: s3c2410_wdt - Fix removing of platform device ... Browse Code »

    When removing the watchdog platform device, we need to
    disable the access to userspace first. It makes no sense
    to remove the drivers clock, irq's, ... and then disable
    userspace access.
    the order of removal has also been changed so that it
    is the reverse of probing (this way the clock is also
    disabled sooner).

    Cc: Ben Dooks
    Signed-off-by: Wim Van Sebroeck

    Wim Van Sebroeck
     

25 May, 2010

2 commits

  • 100fb76f0   watchdog: s3c2410_wdt - Fix on handling of the request_mem_region fail ... Browse Code »

    If the request for wdt_mem region fails, this patch modifies the driver
    such that, it does not try to release the wdt_mem region on exit.

    Signed-off-by: Banajit Goswami
    Signed-off-by: Kukjin Kim
    Signed-off-by: Ben Dooks
    Signed-off-by: Wim Van Sebroeck

    Banajit Goswami
     
  • 76550d329   watchdog: fix several MODULE_PARM_DESC strings ... Browse Code »

    Fix MODULE_PARM_DESC() strings in several watchdog drivers.
    Some are simple as add a parenthesis.
    Others are problems from __stringify() being used on a
    variable name instead of a macro name, so the variable name
    is produced in the string instead of its build-time value.
    In these cases, create a macro for the value so that the
    module param description string is useful.

    Only pc87413_wdt has been built (due to toolchains).

    Signed-off-by: Randy Dunlap
    Signed-off-by: Wim Van Sebroeck

    Randy Dunlap
     

30 Mar, 2010

1 commit

  • 5a0e3ad6a   include cleanup: Update gfp.h and slab.h includes to prepare for breaking implic… ... Browse Code »

    …it slab.h inclusion from percpu.h

    percpu.h is included by sched.h and module.h and thus ends up being
    included when building most .c files. percpu.h includes slab.h which
    in turn includes gfp.h making everything defined by the two files
    universally available and complicating inclusion dependencies.

    percpu.h -> slab.h dependency is about to be removed. Prepare for
    this change by updating users of gfp and slab facilities include those
    headers directly instead of assuming availability. As this conversion
    needs to touch large number of source files, the following script is
    used as the basis of conversion.

    http://userweb.kernel.org/~tj/misc/slabh-sweep.py

    The script does the followings.

    * Scan files for gfp and slab usages and update includes such that
    only the necessary includes are there. ie. if only gfp is used,
    gfp.h, if slab is used, slab.h.

    * When the script inserts a new include, it looks at the include
    blocks and try to put the new include such that its order conforms
    to its surrounding. It's put in the include block which contains
    core kernel includes, in the same order that the rest are ordered -
    alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
    doesn't seem to be any matching order.

    * If the script can't find a place to put a new include (mostly
    because the file doesn't have fitting include block), it prints out
    an error message indicating which .h file needs to be added to the
    file.

    The conversion was done in the following steps.

    1. The initial automatic conversion of all .c files updated slightly
    over 4000 files, deleting around 700 includes and adding ~480 gfp.h
    and ~3000 slab.h inclusions. The script emitted errors for ~400
    files.

    2. Each error was manually checked. Some didn't need the inclusion,
    some needed manual addition while adding it to implementation .h or
    embedding .c file was more appropriate for others. This step added
    inclusions to around 150 files.

    3. The script was run again and the output was compared to the edits
    from #2 to make sure no file was left behind.

    4. Several build tests were done and a couple of problems were fixed.
    e.g. lib/decompress_*.c used malloc/free() wrappers around slab
    APIs requiring slab.h to be added manually.

    5. The script was run on all .h files but without automatically
    editing them as sprinkling gfp.h and slab.h inclusions around .h
    files could easily lead to inclusion dependency hell. Most gfp.h
    inclusion directives were ignored as stuff from gfp.h was usually
    wildly available and often used in preprocessor macros. Each
    slab.h inclusion directive was examined and added manually as
    necessary.

    6. percpu.h was updated not to include slab.h.

    7. Build test were done on the following configurations and failures
    were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my
    distributed build env didn't work with gcov compiles) and a few
    more options had to be turned off depending on archs to make things
    build (like ipr on powerpc/64 which failed due to missing writeq).

    * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
    * powerpc and powerpc64 SMP allmodconfig
    * sparc and sparc64 SMP allmodconfig
    * ia64 SMP allmodconfig
    * s390 SMP allmodconfig
    * alpha SMP allmodconfig
    * um on x86_64 SMP allmodconfig

    8. percpu.h modifications were reverted so that it could be applied as
    a separate patch and serve as bisection point.

    Given the fact that I had only a couple of failures from tests on step
    6, I'm fairly confident about the coverage of this conversion patch.
    If there is a breakage, it's likely to be something in one of the arch
    headers which should be easily discoverable easily on most builds of
    the specific arch.

    Signed-off-by: Tejun Heo <tj@kernel.org>
    Guess-its-ok-by: Christoph Lameter <cl@linux-foundation.org>
    Cc: Ingo Molnar <mingo@redhat.com>
    Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>

    Tejun Heo
     

24 Dec, 2009

1 commit

  • b782a5637   [WATCHDOG] use resource_size() ... Browse Code »

    Use resource_size().

    Signed-off-by: H Hartley Sweeten
    Cc: Kevin Hilman
    Cc: Kevin Hilman
    Cc: Ulrik Bech Hald
    Cc: Henrique de Moraes Holschuh
    Cc: Ming Lei
    Cc: Vincent Sanders
    Acked-by: Thierry Reding
    Signed-off-by: Wim Van Sebroeck
    Signed-off-by: Andrew Morton

    H Hartley Sweeten
     

04 Dec, 2009

1 commit

18 Jun, 2009

1 commit

03 Nov, 2008

1 commit

30 Oct, 2008

1 commit

29 Oct, 2008

1 commit

27 Aug, 2008

3 commits

16 Aug, 2008

1 commit

  • 8b5942c39   [ARM] Fix a pile of broken watchdog drivers ... Browse Code »

    These patches from Adrian fix:
    - ixp4xx_wdt: 20d35f3e50ea7e573f9568b9fce4e98523aaee5d
    CC drivers/watchdog/ixp4xx_wdt.o
    ixp4xx_wdt.c:32: error: expected '=', ',', ';', 'asm' or '__attribute__'
    ixp4xx_wdt.c: In function 'wdt_enable':
    ixp4xx_wdt.c:41: error: 'wdt_lock' undeclared (first use in this
    ixp4xx_wdt.c:41: error: (Each undeclared identifier is reported only
    ixp4xx_wdt.c:41: error: for each function it appears in.)
    ixp4xx_wdt.c: In function 'wdt_disable':
    ixp4xx_wdt.c:52: error: 'wdt_lock' undeclared (first use in this
    ixp4xx_wdt.c: In function 'ixp4xx_wdt_init':
    ixp4xx_wdt.c:186: error: 'wdt_lock' undeclared (first use in this
    make[3]: *** [drivers/watchdog/ixp4xx_wdt.o] Error 1

    - at91rm9200_wdt: 2760600da2a13d5a2a335ba012d0f3ad5df4c098
    CC drivers/watchdog/at91rm9200_wdt.o
    at91rm9200_wdt.c:188: error: 'at91_wdt_ioctl' undeclared here (not in a
    make[3]: *** [drivers/watchdog/at91rm9200_wdt.o] Error 1

    - wdt285: d0e58eed05f9baf77c4f75e794ae245f6dae240a
    CC [M] drivers/watchdog/wdt285.o
    wdt285.c: In function 'footbridge_watchdog_init':
    wdt285.c:211: error: 'KERN_WARN' undeclared (first use in this function)
    wdt285.c:211: error: (Each undeclared identifier is reported only once
    wdt285.c:211: error: for each function it appears in.)
    wdt285.c:212: error: expected ')' before string constant
    make[3]: *** [drivers/watchdog/wdt285.o] Error 1

    And this patch from rmk:
    - s3c2410_wdt: 41dc8b72e37c514f7332cbc3f3dd864910c2a1fa
    CC drivers/watchdog/s3c2410_wdt.o
    s3c2410_wdt.c: In function `s3c2410wdt_start':
    s3c2410_wdt.c:161: warning: `return' with a value, in function returning void

    Reported-by: Adrian Bunk
    Signed-off-by: Adrian Bunk
    Signed-off-by: Russell King

    Adrian Bunk
     

09 Aug, 2008

1 commit

  • 097d9eb53   Merge Linus' latest into master ... Browse Code »

    Conflicts:

    drivers/watchdog/at91rm9200_wdt.c
    drivers/watchdog/davinci_wdt.c
    drivers/watchdog/ep93xx_wdt.c
    drivers/watchdog/ixp2000_wdt.c
    drivers/watchdog/ixp4xx_wdt.c
    drivers/watchdog/ks8695_wdt.c
    drivers/watchdog/omap_wdt.c
    drivers/watchdog/pnx4008_wdt.c
    drivers/watchdog/sa1100_wdt.c
    drivers/watchdog/wdt285.c

    Russell King
     

08 Aug, 2008

1 commit

07 Aug, 2008

1 commit

06 Aug, 2008

1 commit

  • 0c06090c9   [WATCHDOG] Coding style - Indentation - part 2 ... Browse Code »

    This brings the watchdog drivers into line with coding style.
    This patch takes cares of the indentation as described in chapter 1.
    Main changes:
    * Re-structure the ioctl switch call for all drivers as follows:
    switch (cmd) {
    case WDIOC_GETSUPPORT:
    case WDIOC_GETSTATUS:
    case WDIOC_GETBOOTSTATUS:
    case WDIOC_GETTEMP:
    case WDIOC_SETOPTIONS:
    case WDIOC_KEEPALIVE:
    case WDIOC_SETTIMEOUT:
    case WDIOC_GETTIMEOUT:
    case WDIOC_GETTIMELEFT:
    default:
    }

    This to make the migration from the drivers to the uniform watchdog
    device driver easier in the future.

    Signed-off-by: Wim Van Sebroeck

    Wim Van Sebroeck
     

05 Aug, 2008

1 commit

11 Apr, 2008

1 commit

  • f37d193c7   watchdog: fix platform driver hotplug/coldplug ... Browse Code »

    Since 43cc71eed1250755986da4c0f9898f9a635cb3bf, the platform modalias is
    prefixed with "platform:". Add MODULE_ALIAS() to the hotpluggable watchdog
    drivers, to re-enable auto loading.

    [dbrownell@users.sourceforge.net: more drivers; registration fixes]
    Signed-off-by: Kay Sievers
    Signed-off-by: David Brownell
    Cc: Wim Van Sebroeck
    Cc: Greg KH
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Kay Sievers
     

06 Mar, 2008

1 commit

18 Oct, 2007

1 commit