07 Apr, 2009
1 commit
-
Replace all DMA_32BIT_MASK macro with DMA_BIT_MASK(32)
Signed-off-by: Yang Hongyang
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
24 Mar, 2009
3 commits
20 Feb, 2009
1 commit
-
The usage and comments make it clear values of 1/0 were intended
rather than -1/0Noticed by sparse:
sound/pci/pcxhr/pcxhr.h:100:20: error: dubious one-bit signed bitfield
sound/pci/pcxhr/pcxhr.h:101:22: error: dubious one-bit signed bitfield
sound/pci/pcxhr/pcxhr.h:102:24: error: dubious one-bit signed bitfield
sound/pci/pcxhr/pcxhr.h:103:21: error: dubious one-bit signed bitfield
sound/pci/pcxhr/pcxhr.h:104:25: error: dubious one-bit signed bitfield
sound/pci/pcxhr/pcxhr.h:105:20: error: dubious one-bit signed bitfieldSigned-off-by: Harvey Harrison
Signed-off-by: Takashi Iwai
05 Feb, 2009
1 commit
-
Remove NOP hwdep ops in sound drivers.
Signed-off-by: Takashi Iwai
01 Feb, 2009
1 commit
-
Signed-off-by: Tim Blechmann
Signed-off-by: Takashi Iwai
23 Jan, 2009
1 commit
-
- add support for gpio ports (2 GPI, 2 GPO) of pcxhr stereo cards
- minor bugfixes : allow setting clock to internal by the mixer
even if there is no stream (but monitoring)Signed-off-by: Markus Bollinger
Signed-off-by: Takashi Iwai
12 Jan, 2009
1 commit
-
Convert from snd_card_new() to the new snd_card_create() function
in sound/pci/*.Signed-off-by: Takashi Iwai
25 Dec, 2008
2 commits
21 Dec, 2008
1 commit
18 Dec, 2008
1 commit
-
Replace all tasklet_hi_schedule() callers with the normal
tasklet_schedule(). The former often causes troubles with
RT-kernels, and has actually no merit.Signed-off-by: Takashi Iwai
01 Dec, 2008
1 commit
-
- compatibility issue : change firmware filenames
the pcxhr driver version 1.0.17. Keep the old firmware files
and add new firmware files with different namesSigned-off-by: Markus Bollinger
Signed-off-by: Takashi Iwai
27 Nov, 2008
1 commit
-
The function snd_mixart_create creates a link between mgr and card that
allows snd_mixart_free to free card as well. But if snd_mixart_create
fails, then the link has not been created and card has to be freed explicitly.The semantic match that finds the problem is as follows:
(http://www.emn.fr/x-info/coccinelle/)//
@r exists@
local idexpression x;
statement S,S1;
position p1,p2,p3;
expression E,E1;
type T,T1;
expression *ptr != NULL;
@@(
if ((x@p1 = snd_card_new(...)) == NULL) S
|
x@p1 = snd_card_new(...);
)
... when != snd_card_free(...,(T)x,...)
when != if (...) { }
when != true x == NULL || ...
when != x = E
when != E = (T)x
when any
(
if (x == NULL || ...) S1
|
if@p2 (...) {
... when != snd_card_free(...,(T1)x,...)
when != if (...) { }
when != x = E1
when != E1 = (T1)x
(
return \(0\|\|ptr\);
|
return@p3 ...;
)
}
)@ script:python @
p1 << r.p1;
p3 << r.p3;
@@print "* file: %s snd_card_new: %s return: %s" % (p1[0].file,p1[0].line,p3[0].line)
//
Signed-off-by: Julia Lawall
Signed-off-by: Takashi Iwai
25 Nov, 2008
4 commits
-
- add support for pcxhr stereo cards mixer controls
- adjust tlv db scales to real dBu values
- fix bug with monitoring volume control pcxhr_monitor_vol_put
- do some cleanupSigned-off-by: Markus Bollinger
Signed-off-by: Takashi Iwai -
- Add support for pcxhr stereo cards and their firmware
- autorize sound cards without analog IO
- do some cleanupSigned-off-by: Markus Bollinger
Signed-off-by: Takashi Iwai -
- Add support for pcxhr stereo cards
- minor bugfixes : period and buffer size consraints
- fix PLL register values
- do some clean upSigned-off-by: Markus Bollinger
Signed-off-by: Takashi Iwai -
- Add support for pcxhr stereo cards
- do some clean upSigned-off-by: Markus Bollinger
Signed-off-by: Takashi Iwai
16 Nov, 2008
1 commit
-
Error handling code following a kzalloc should free the allocated data.
The error handling code is adjusted to call pci_disable_device(pci); as
well, as done later in the functionThe semantic match that finds the problem is as follows:
(http://www.emn.fr/x-info/coccinelle/)//
@r exists@
local idexpression x;
statement S;
expression E;
identifier f,l;
position p1,p2;
expression *ptr != NULL;
@@(
if ((x@p1 = \(kmalloc\|kzalloc\|kcalloc\)(...)) == NULL) S
|
x@p1 = \(kmalloc\|kzalloc\|kcalloc\)(...);
...
if (x == NULL) S
)
}
x->f = E
...>
(
return \(0\|\|ptr\);
|
return@p2 ...;
)@script:python@
p1 << r.p1;
p2 << r.p2;
@@print "* file: %s kmalloc %s return %s" % (p1[0].file,p1[0].line,p2[0].line)
//Signed-off-by: Julia Lawall
Signed-off-by: Takashi Iwai
13 Aug, 2008
1 commit
-
Kill snd_assert() in sound/pci/*, either removed or replaced with
if () with snd_BUG_ON().Signed-off-by: Takashi Iwai
Signed-off-by: Jaroslav Kysela
15 Jul, 2008
1 commit
-
Conflicts:
sound/pci/Kconfig
10 Jul, 2008
2 commits
-
Fix a const pointer usage warning in the Digigram pcxhr compatible soundcard
driver. A const pointer is being passed to copy_from_user() to load the
firmware into. This is okay in this case because the function has allocated
the firmware struct itself, but the const qualifier is part of the firmware
struct - so the patch casts the const away.Signed-off-by: David Howells
Signed-off-by: David Woodhouse -
Signed-off-by: David Woodhouse
27 May, 2008
1 commit
-
Replace CONFIG_SND_DEBUG_DETECT with CONFIG_SND_DEBUG_VERBOSE to
represent its meaning more better. This config isn't provided only
for the detection but for more verbose debug prints in general.Signed-off-by: Takashi Iwai
24 Apr, 2008
4 commits
-
sparc64:
sound/pci/pcxhr/pcxhr.c: In function `pcxhr_update_r_buffer':
sound/pci/pcxhr/pcxhr.c:459: warning: cast to pointer from integer of different size
sound/pci/pcxhr/pcxhr.c: In function `pcxhr_trigger_tasklet':
sound/pci/pcxhr/pcxhr.c:628: warning: long int format, different type arg (arg 4)Signed-off-by: Andrew Morton
Signed-off-by: Takashi Iwai -
sound/pci/pcxhr/pcxhr_core.c: In function `pcxhr_set_pipe_state':
sound/pci/pcxhr/pcxhr_core.c:899: warning: long int format, different type arg (arg 4)suseconds_t is int on sparc64.
Signed-off-by: Andrew Morton
Signed-off-by: Takashi Iwai -
The variable is_capture is initialized but never used otherwise.
The semantic patch that makes this change is as follows:
(http://www.emn.fr/x-info/coccinelle/)//
@@
type T;
identifier i;
constant C;
@@(
extern T i;
|
- T i;
)
//Signed-off-by: Julia Lawall
Signed-off-by: Takashi Iwai -
Inner loop redeclares err with u32 rather than int, stupid fix here
is to change the inner err to err2.
sound/pci/pcxhr/pcxhr_core.c:1008:8: warning: symbol 'err' shadows an earlier one
sound/pci/pcxhr/pcxhr_core.c:983:6: originally declared hereSigned-off-by: Harvey Harrison
Signed-off-by: Takashi Iwai
01 Feb, 2008
2 commits
-
This header file exists only for some hacks to adapt alsa-driver
tree. It's useless for building in the kernel. Let's move a few
lines in it to sound/core.h and remove it.
With this patch, sound/driver.h isn't removed but has just a single
compile warning to include it. This should be really killed in
future.Signed-off-by: Takashi Iwai
Signed-off-by: Jaroslav Kysela -
Check the value ranges in ctl put callbacks properly in the rest of
PCI drivers.Signed-off-by: Takashi Iwai
Signed-off-by: Jaroslav Kysela
16 Oct, 2007
5 commits
-
Some dB level information is wrong in pcxhr driver according to the
datasheet. Fixed now.Signed-off-by: Takashi Iwai
Signed-off-by: Jaroslav Kysela -
The non-linked streams couldn't be started properly due to missing
setting of stream->status.Signed-off-by: Takashi Iwai
Signed-off-by: Jaroslav Kysela -
Set the SNDRV_PCM_INFO_SYNC_START flag and the substream's sync ID
(only) if the substream actually can be linked to another one.Signed-off-by: Clemens Ladisch
Signed-off-by: Jaroslav Kysela -
It is possible to have linked substreams that belong to different cards
and/or different drivers. This patch changes some drivers to make sure
that they do not incorrectly try to handle substreams of a different
card.Signed-off-by: Clemens Ladisch
Signed-off-by: Jaroslav Kysela -
Clean up codes using the new common snd_ctl_boolean_*_info() callbacks.
Signed-off-by: Takashi Iwai
Signed-off-by: Jaroslav Kysela
11 May, 2007
3 commits
-
Add MODULE_FIRMWARE() entries, where appropriate.
Signed-off-by: Clemens Ladisch
Signed-off-by: Jaroslav Kysela -
Minor optimization in trigger start callback. This fixes a nasty
compile warning, too.Signed-off-by: Takashi Iwai
Signed-off-by: Jaroslav Kysela -
Added a new macro snd_pcm_group_for_each_entry() just for code cleanup.
Old macros, snd_pcm_group_for_each() and snd_pcm_group_substream_entry(),
are removed.Signed-off-by: Takashi Iwai
Signed-off-by: Jaroslav Kysela
09 Feb, 2007
1 commit
-
Mark TLV data as 'const'
Signed-of-by: Philipp Matthias HahnSigned-off-by: Takashi Iwai
Signed-off-by: Jaroslav Kysela