08 Feb, 2020
2 commits
-
Pull i2c updates from Wolfram Sang:
"i2c core:- huge improvements and refactorizations of the Linux I2C
documentation (lots of thanks to Luca for doing it and Jean for the
careful review)- subsystem wide API conversion to i2c_new_client_device()
- remove obsolete parport-light driver
- smaller core updates (removal of 'extern', enabling more compile
testing, use more helper macros)- and quite a bunch of driver updates (new IDs, simplifications,
better PM, support of atomic transfers and other improvements)i2c-mux:
- The main feature is the idle-state rework of the pca954x driver
from Biwen Liat24 driver:
- minor maintenance: update the license tag, sort headers
- move support for the write-protect pin into nvmem core
- add a reference to the new wp-gpios property in nvmem to at25
bindings- add support for regulator and pm_runtime control"
* 'i2c/for-5.6' of git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux: (91 commits)
i2c: cros-ec-tunnel: Fix ACPI identifier
i2c: cros-ec-tunnel: Fix slave device enumeration
i2c: stm32f7: add PM_SLEEP suspend/resume support
i2c: cadence: Fix wording in i2c-cadence driver
i2c: cadence: Fix power management order of operations
i2c: cadence: Fix error printing in case of defer
i2c: cadence: Handle transfer_size rollover
i2c: i801: Add support for Intel Comet Lake PCH-V
docs: i2c: writing-clients: properly name the stop condition
docs: i2c: i2c-protocol: use same wording as smbus-protocol
docs: i2c: rename sections so the overall picture is clearer
docs: i2c: old-module-parameters: use monospace instead of ""
docs: i2c: old-module-parameters: clarify this is for obsolete kernels
docs: i2c: old-module-parameters: fix internal hyperlink
docs: i2c: instantiating-devices: use monospace for sysfs attributes
docs: i2c: instantiating-devices: rearrange static instatiation
docs: i2c: instantiating-devices: fix internal hyperlink
docs: i2c: smbus-protocol: improve I2C Block transactions description
docs: i2c: smbus-protocol: fix punctuation
docs: i2c: smbus-protocol: fix typo
... -
Pull more ACPI updates from Rafael Wysocki:
"Add Hisilicon Hip08-Lite I2C controller clock frequency support to the
ACPI driver for AMD SoCs (APD) and to the Designware I2C driver
(Hanjun Guo)"* tag 'acpi-5.6-rc1-3' of git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm:
i2c: designware: Add ACPI HID for Hisilicon Hip08-Lite I2C controller
ACPI / APD: Add clock frequency for Hisilicon Hip08-Lite I2C controller
04 Feb, 2020
1 commit
-
'PTR_ERR(p) == -E*' is a stronger condition than IS_ERR(p).
Hence, IS_ERR(p) is unneeded.The semantic patch that generates this commit is as follows:
//
@@
expression ptr;
constant error_code;
@@
-IS_ERR(ptr) && (PTR_ERR(ptr) == - error_code)
+PTR_ERR(ptr) == - error_code
//Link: http://lkml.kernel.org/r/20200106045833.1725-1-masahiroy@kernel.org
Signed-off-by: Masahiro Yamada
Cc: Julia Lawall
Acked-by: Stephen Boyd [drivers/clk/clk.c]
Acked-by: Bartosz Golaszewski [GPIO]
Acked-by: Wolfram Sang [drivers/i2c]
Acked-by: Rafael J. Wysocki [acpi/scan.c]
Acked-by: Rob Herring
Cc: Eric Biggers
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
03 Feb, 2020
1 commit
-
Add ACPI HID HISI02A3 for Hisilicon Hip08 Lite, which has different
clock frequency from Hip08 for I2C controller.Tested-by: Sheng Feng
Signed-off-by: Hanjun Guo
Acked-by: Nikula
Reviewed-by: Andy Shevchenko
Signed-off-by: Rafael J. Wysocki
31 Jan, 2020
2 commits
-
The initial patch was using the incorrect identifier.
Fixes: 9af1563a5486 ("i2c: cros-ec-tunnel: Make the device acpi compatible")
Signed-off-by: Raul E Rangel
Acked-by: Enric Balletbo i Serra
Signed-off-by: Wolfram Sang -
During adding of the adapter the slave device registration
use to fail as the acpi companion field was not populated.Fixes: 9af1563a5486 ("i2c: cros-ec-tunnel: Make the device acpi compatible")
Signed-off-by: Akshu Agrawal
Acked-by: Raul E Rangel
Reviewed-by: Enric Balletbo i Serra
Signed-off-by: Wolfram Sang
30 Jan, 2020
9 commits
-
Backup/restore I2C registers as part of the suspend/resume
handlers. The device is marked as suspended to ensure that
transfers are rejected during the suspended period.Signed-off-by: Pierre-Yves MORDRET
Signed-off-by: Alain Volmat
Signed-off-by: Wolfram Sang -
Fix wording based on checkpatch.pl
Signed-off-by: Michal Simek
Signed-off-by: Shubhrajyoti Datta
Signed-off-by: Wolfram Sang -
E.g. pm_runtime_set_active must be called while the power
management system is disabled. Fixes extra hanging clk_enable.Signed-off-by: Topi Kuutela
Acked-by: Sören Brinkmann
Signed-off-by: Michal Simek
Signed-off-by: Shubhrajyoti Datta
Signed-off-by: Wolfram Sang -
Do not print error in case of EPROBE_DEFER.
Signed-off-by: Shubhrajyoti Datta
Signed-off-by: Wolfram Sang -
Under certain conditions, Cadence's I2C controller's transfer_size
register will roll over and generate invalid read transactions. Before
this change, the ISR relied solely on the RXDV bit to determine when to
write more data to the user's buffer. The invalid read data would cause
overruns, smashing stacks and worse.This change stops the buffer writes to the requested boundary and
reports the error. The controller will be reset so normal transactions
may resume.Signed-off-by: Alex Williams
Reviewed-by: Shubhrajyoti Datta
Reviewed-by: Michal Simek # in a seperate mail
Signed-off-by: Wolfram Sang -
Add support for Intel Comet Lake PCH-V which is based on Intel Kaby
Lake. Difference between it and other Comet Lake variants is that former
uses previous iTCO version 4 and latter use version 6 like Intel Cannon
Lake PCH.Signed-off-by: Jarkko Nikula
Reviewed-by: Jean Delvare
Signed-off-by: Wolfram Sang -
The main feature is the idle-state rework of the pca954x driver from Biwen Li.
-
There is a statement that is indented one level too deeply, remove
the extraneous tab.Fixes: b4c119dbc300 ("i2c: xiic: Add timeout to the rx fifo wait loop")
Signed-off-by: Colin Ian King
Reviewed-by: Shubhrajyoti Datta
Signed-off-by: Wolfram Sang -
There is a spelling mistake in a module parameter description.
Fix it.Signed-off-by: Colin Ian King
Reviewed-by: Jean Delvare
Signed-off-by: Wolfram Sang
28 Jan, 2020
1 commit
-
Pull ioremap updates from Christoph Hellwig:
"Remove the ioremap_nocache API (plus wrappers) that are always
identical to ioremap"* tag 'ioremap-5.6' of git://git.infradead.org/users/hch/ioremap:
remove ioremap_nocache and devm_ioremap_nocache
MIPS: define ioremap_nocache to ioremap
23 Jan, 2020
2 commits
-
Update the help text to reflect current support devices:
1. The Exynos high speed I2C driver supports Exynos5 (ARMv7), Exynos5433
and Exynos7 (both ARMv8) SoCs,
2. The S3C I2C driver supports S3C, S5Pv210 and Exynos{3,4,5} SoCs.Signed-off-by: Krzysztof Kozlowski
Signed-off-by: Wolfram Sang -
Some of the I2C bus drivers can be compile tested to increase build
coverage. This requires also:
1. Adding dependencies on COMMON_CLK for BCM2835 and Meson I2C
controllers,
2. Adding 'if' conditional to 'default y' so they will not get enabled
by default on all other architectures,
3. Limiting few compile test options to supported architectures (which
provide the readsX()/writesX() primitives).Signed-off-by: Krzysztof Kozlowski
[wsa: revert chunk for ZX2967. it needs more preparation]
Signed-off-by: Wolfram Sang
16 Jan, 2020
22 commits
-
The recommendation is that the set_active should be done
with pm runtime disabled.
Also fix the remove path for clocking.Signed-off-by: Shubhrajyoti Datta
Signed-off-by: Michal Simek
Signed-off-by: Wolfram Sang -
It's not always the case that clock is already available when i2c
driver get probed at the first time, e.g. the clock is provided by
clock wizard which may be probed after i2c driver. So let's defer
the probe when devm_clk_get() call fails and give it chance to
try later.Signed-off-by: Venkatesh Yadav Abbarapu
Signed-off-by: Michal Simek
Signed-off-by: Shubhrajyoti Datta
Signed-off-by: Wolfram Sang -
Add timeout to the rx fifo empty wait loop. Also check for the return
value for xiic_reinit and pass it to xiic_start_xfer.Signed-off-by: Shubhrajyoti Datta
Signed-off-by: Michal Simek
Signed-off-by: Wolfram Sang -
size_t should be printed with its own format to be 64-bit friendly and
fix warning when compiling on 64-bit platform (e.g. with COMPILE_TEST):drivers/i2c/busses/i2c-highlander.c: In function ‘highlander_i2c_smbus_xfer’:
drivers/i2c/busses/i2c-highlander.c:325:22: warning:
format ‘%d’ expects argument of type ‘int’,
but argument 3 has type ‘size_t {aka long unsigned int}’ [-Wformat=]Signed-off-by: Krzysztof Kozlowski
Signed-off-by: Wolfram Sang -
resource_size_t should be printed with its own size-independent format
to fix warnings when compiling on 64-bit platform (e.g. with
COMPILE_TEST):drivers/i2c/busses/i2c-pnx.c: In function ‘i2c_pnx_probe’:
drivers/i2c/busses/i2c-pnx.c:737:47: warning:
format ‘%x’ expects argument of type ‘unsigned int’,
but argument 5 has type ‘resource_size_t {aka long long unsigned int}’ [-Wformat=]Signed-off-by: Krzysztof Kozlowski
Signed-off-by: Wolfram Sang -
resource_size_t should be printed with its own size-independent format
to fix warnings when compiling on 64-bit platform (e.g. with
COMPILE_TEST):drivers/i2c/busses/i2c-pmcmsp.c: In function ‘pmcmsptwi_probe’:
drivers/i2c/busses/i2c-pmcmsp.c:276:25: warning:
format ‘%x’ expects argument of type ‘unsigned int’,
but argument 3 has type ‘resource_size_t {aka long long unsigned int}’ [-Wformat=]Signed-off-by: Krzysztof Kozlowski
Signed-off-by: Wolfram Sang -
Move away from the deprecated API and return the shiny new ERRPTR where
useful.Signed-off-by: Wolfram Sang
Signed-off-by: Wolfram Sang -
Move away from the deprecated API and return the shiny new ERRPTR where
useful.Signed-off-by: Wolfram Sang
Signed-off-by: Wolfram Sang -
Move away from the deprecated API and return the shiny new ERRPTR where
useful.Signed-off-by: Wolfram Sang
Acked-by: Mika Westerberg
Signed-off-by: Wolfram Sang -
Move away from the deprecated API and return the shiny new ERRPTR where
useful.Signed-off-by: Wolfram Sang
Acked-by: Michal Simek
Signed-off-by: Wolfram Sang -
Move away from the deprecated API and return the shiny new ERRPTR where
useful.Signed-off-by: Wolfram Sang
Reviewed-by: Jean Delvare
Tested-by: Jean Delvare
Signed-off-by: Wolfram Sang -
Move away from the deprecated API and return the shiny new ERRPTR where
useful.Signed-off-by: Wolfram Sang
Signed-off-by: Wolfram Sang -
Move away from the deprecated API and return the shiny new ERRPTR where
useful.Signed-off-by: Wolfram Sang
Reviewed-by: Andrew Lunn
Reviewed-by: Peter Korsgaard
Signed-off-by: Wolfram Sang -
Move away from the deprecated API and return the shiny new ERRPTR where
useful.Signed-off-by: Wolfram Sang
Signed-off-by: Wolfram Sang -
Move away from the deprecated API and return the shiny new ERRPTR where
useful.Signed-off-by: Wolfram Sang
Reviewed-by: Jean Delvare
Signed-off-by: Wolfram Sang -
Move away from the deprecated API and return the shiny new ERRPTR where
useful.Signed-off-by: Wolfram Sang
Tested-by: Hans de Goede
Reviewed-by: Hans de Goede
Signed-off-by: Wolfram Sang -
When handling devm_gpiod_get_optional() errors, free the memory already
allocated. This fixes Smatch warnings:drivers/i2c/busses/i2c-iop3xx.c:437 iop3xx_i2c_probe() warn: possible memory leak of 'new_adapter'
drivers/i2c/busses/i2c-iop3xx.c:442 iop3xx_i2c_probe() warn: possible memory leak of 'new_adapter'Fixes: fdb7e884ad61 ("i2c: iop: Use GPIO descriptors")
Reported-by: kbuild test robot
Reported-by: Dan Carpenter
Signed-off-by: Krzysztof Kozlowski
Signed-off-by: Wolfram Sang -
iomem pointers should be printed with pointer format to hide the
actual value and fix warnings when compiling on 64-bit platform (e.g. with
COMPILE_TEST):drivers/i2c/busses/i2c-stu300.c: In function ‘stu300_wait_while_busy’:
drivers/i2c/busses/i2c-stu300.c:446:76: warning:
cast from pointer to integer of different size [-Wpointer-to-int-cast]Signed-off-by: Krzysztof Kozlowski
Reviewed-by: Linus Walleij
Signed-off-by: Wolfram Sang -
It is more robust to check completion status in addition to the left time
in a case of DMA transfer because transfer's completion happens in two
phases [one is ISR, other is tasklet] and thus it is possible that DMA is
completed while I2C completion awaiting times out because of the deferred
notification done by the DMA driver. The DMA completion status becomes
100% actual after DMA synchronization. This fixes spurious DMA timeouts
when system is under load.Tested-by: Thierry Reding
Signed-off-by: Dmitry Osipenko
Signed-off-by: Wolfram Sang -
It is possible that I2C could error out in the middle of DMA transfer and
in this case DMA channel needs to be reset, otherwise a follow up transfer
will fail because DMA channel stays blocked.Tested-by: Thierry Reding
Signed-off-by: Dmitry Osipenko
Signed-off-by: Wolfram Sang -
There is nothing to synchronize in regards to memory accesses for PIO
transfers and for DMA transfers the DMA API takes care of the syncing.Tested-by: Thierry Reding
Signed-off-by: Dmitry Osipenko
Signed-off-by: Wolfram Sang -
DMA is preferred for a larger transfers, while PIO is preferred for a
smaller transfers to avoid unnecessary DMA overhead. There is no strict
size limitations for the PIO-mode transfers, so let's rename the constant
for clarity.Tested-by: Thierry Reding
Signed-off-by: Dmitry Osipenko
Signed-off-by: Wolfram Sang
