05 Aug, 2008

26 commits


02 Aug, 2008

14 commits

  • rt2x00usb_vendor_request_large_buff is write-only, so it is
    safe to make the argument a const.

    Fixes compile warning:
    drivers/net/wireless/rt2x00/rt73usb.c: In function 'rt73usb_load_firmware':
    drivers/net/wireless/rt2x00/rt73usb.c:916: warning: passing argument 5 of 'rt2x00usb_vendor_request_large_buff' discards qualifiers from pointer target typ

    Signed-off-by: Ivo van Doorn
    Signed-off-by: David S. Miller

    Ivo van Doorn
     
  • David S. Miller
     
  • Currently function tty_ldisc_get() tries to load an ldisc driver module
    only when tty_ldisc_try_get() returns -EAGAIN. This happens only if
    module is being unloaded. If ldisc module is not loaded
    tty_ldisc_try_get() returns -EINVAL and this case is not handled in
    tty_ldisc_get(), so request_module() is not called.

    Attached patch fixes this by calling request_module() if
    tty_ldisc_try_get() returned any error code.

    I discovered this when my UMTS modem stopped working with 2.6.27-rc1
    because module ppp_async was not loaded.

    Signed-off-by: Eugeniy Meshcheryakov
    Signed-off-by: Alan Cox
    Signed-off-by: Linus Torvalds

    Eugeniy Meshcheryakov
     
  • * 'zero-len' of git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/misc-2.6:
    drivers/media, include/media: delete zero-length files

    Linus Torvalds
     
  • Each resource should be printed on its own line, so start snprintf'ing
    at the beginning of the buffer every time through the loop.

    Also, use scnprintf() rather than snprintf() when building up the
    buffer to print. scnprintf() returns the number of characters actually
    written into the buffer (not including the trailing NULL).

    snprintf() returns the number of characters that *would be* written,
    assuming everything would fit in the buffer. That's nice if we want to
    resize the buffer to make sure everything fits, but in this case, I
    just want to keep from overflowing the buffer, and it's OK if the
    output is truncated.

    Using snprintf() meant that my "len" could grow to be more than the
    the buffer size, which makes "sizeof(buf) - len" negative, which causes
    this alarming WARN_ON:
    http://marc.info/?l=linux-kernel&m=121736480005656&w=2

    More useful snprintf/scnprintf discussion:
    http://lwn.net/Articles/69419/

    Signed-off-by: Bjorn Helgaas
    Reported-by: Pete Clements
    Cc: Rene Herman
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Bjorn Helgaas
     
  • Some module parameters with only one line have the '\n' at the end of the
    description. This is not needed nor wanted as after the description the
    type (i.e. int) is followed by a newline.

    Some modules contain a multi-line description, these are not affected
    by this patch.

    Signed-off-by: Niels de Vos
    Acked-by: Randy Dunlap
    Cc: John W. Linville
    Cc: Ed L. Cashin
    Cc: Dave Airlie
    Cc: Roland Dreier
    Acked-by: Mauro Carvalho Chehab
    Cc: Jeff Garzik
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Niels de Vos
     
  • * 'upstream-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/libata-dev:
    pata_it821x: Driver updates and reworking
    libata.h: replace __FUNCTION__ with __func__
    ata_piix: subsys 106b:00a3 is apple ich8m too
    libata-core: make sure that ata_force_tbl is freed in case of an error
    libata: update atapi disable handling
    pata_via: add VX800 flag; add function for fixing h/w bugs
    pata_ali: misplaced pci_dev_put()

    Linus Torvalds
     
  • iwl3945_rx_reply_rx was sending packets too early to
    mac80211, before updating signal strength/quality.
    This resulted in garbage power levels.

    Signed-off-by: Maxim Levitsky
    Signed-off-by: John W. Linville

    Maxim Levitsky
     
  • Use the standard offsetof() macro to fix a compile warning below:
    CC [M] drivers/net/wireless/prism54/isl_ioctl.o
    drivers/net/wireless/prism54/isl_ioctl.c: In function 'prism2_ioctl_set_generic_element':
    drivers/net/wireless/prism54/isl_ioctl.c:2658: warning: cast from pointer to integer of different size

    Signed-off-by: Takashi Iwai
    Signed-off-by: John W. Linville

    Takashi Iwai
     
  • ipw_write8() can't be used alone with a loop because of a wrong definition.

    CC [M] drivers/net/wireless/ipw2200.o
    drivers/net/wireless/ipw2200.c: In function 'ipw_ethtool_set_eeprom':
    drivers/net/wireless/ipw2200.c:10579: warning: array subscript is above array bounds
    drivers/net/wireless/ipw2200.c: In function 'ipw_load':
    drivers/net/wireless/ipw2200.c:2663: warning: array subscript is above array bounds

    Add missing do {} while (0) to fix them.

    Signed-off-by: Takashi Iwai
    Signed-off-by: John W. Linville

    Takashi Iwai
     
  • Some users of the RTL8187B have experienced difficulties since commit
    49292d56352a6ab90d04c3448dd8b6106dfef2d6 that introduced the power
    management wext hooks. This difficulty has not made much sense until
    it was realized that it was possible for mac80211 to make a call to the
    config routine while that routine was already being executed. On this
    device, it is necessary to loopback the TX when changing channels. Unless
    this is properly restored, the device will lockup. A mutex now protects
    the device state, and the private data in several places.

    The problem was found by Herton Ronaldo Krzesinski ,
    who also suggested this type of fix.

    Signed-off-by: Larry Finger
    Acked-by: Herton Ronaldo Krzesinski
    Acked-by: Hin-Tak Leung
    Signed-off-by: John W. Linville

    Larry Finger
     
  • In kernel version 2.6.26-rc9 my wireless LAN card worked; but in the
    released 2.6.26, my RaLink rt2500 card wouldn't associate.

    Git-bisect led me to this patch:

    61486e0f68d1f8966c09b734566a187d42d65c54
    rt2x00: Remove ieee80211_tx_control argument from write_tx_desc()

    I believe that there is a problem with that patch --- it
    (inadvertantly) removes an extra line of code, that used to set the
    DATABYTE_COUNT field.

    This patch reinstates that line, and with it my card works again.

    Signed-off-by: Peter Chubb
    Acked-by: Ivo van Doorn
    Signed-off-by: John W. Linville

    Peter Chubb
     
  • Since only mesh-enabled firmware has the CMD_802_11_MONITOR_MODE on
    which the rtap functionality depends, only expose the rtap functionality
    when mesh is also available.

    Signed-off-by: Dan Williams
    Signed-off-by: John W. Linville

    Dan Williams
     
  • The sequence counter can be accessed in IRQ context,
    which means the lock protecting the counter should
    be irqsave. To prevent making the entire intf->lock irqsave
    without reason, create a new lock which only protects
    the sequence counter.

    Signed-off-by: Ivo van Doorn
    Signed-off-by: John W. Linville

    Ivo van Doorn