20 Mar, 2019

2 commits

  • As a preparation for introducing a smooth switching between replicast
    and broadcast method for multicast message, We have to introduce a new
    capability flag TIPC_MCAST_RBCTL to handle this new feature.

    During a cluster upgrade a node can come back with this new capabilities
    which also must be reflected in the cluster capabilities field.
    The new feature is only applicable if all node in the cluster supports
    this new capability.

    Acked-by: Jon Maloy
    Signed-off-by: Hoang Le
    Signed-off-by: David S. Miller

    Hoang Le
     
  • Currently, a multicast stream uses either broadcast or replicast as
    transmission method, based on the ratio between number of actual
    destinations nodes and cluster size.

    However, when an L2 interface (e.g., VXLAN) provides pseudo
    broadcast support, this becomes very inefficient, as it blindly
    replicates multicast packets to all cluster/subnet nodes,
    irrespective of whether they host actual target sockets or not.

    The TIPC multicast algorithm is able to distinguish real destination
    nodes from other nodes, and hence provides a smarter and more
    efficient method for transferring multicast messages than
    pseudo broadcast can do.

    Because of this, we now make it possible for users to force
    the broadcast link to permanently switch to using replicast,
    irrespective of which capabilities the bearer provides,
    or pretend to provide.
    Conversely, we also make it possible to force the broadcast link
    to always use true broadcast. While maybe less useful in
    deployed systems, this may at least be useful for testing the
    broadcast algorithm in small clusters.

    We retain the current AUTOSELECT ability, i.e., to let the broadcast link
    automatically select which algorithm to use, and to switch back and forth
    between broadcast and replicast as the ratio between destination
    node number and cluster size changes. This remains the default method.

    Furthermore, we make it possible to configure the threshold ratio for
    such switches. The default ratio is now set to 10%, down from 25% in the
    earlier implementation.

    Acked-by: Jon Maloy
    Signed-off-by: Hoang Le
    Signed-off-by: David S. Miller

    Hoang Le
     

19 Mar, 2019

31 commits

  • The variable is never used.

    CC: Michael S. Tsirkin
    CC: Jason Wang
    CC: virtualization@lists.linux-foundation.org
    CC: netdev@vger.kernel.org
    CC: linux-kernel@vger.kernel.org
    Signed-off-by: Peter Xu
    Signed-off-by: David S. Miller

    Peter Xu
     
  • Provide an explanation of what is expected with respect to sending new
    versions of specific patches within a patch series, as well as what
    happens if an earlier patch series accidentally gets merged).

    Signed-off-by: Florian Fainelli
    Signed-off-by: David S. Miller

    Florian Fainelli
     
  • Julian Wiedmann says:

    ====================
    s390/qeth: fixes 2019-03-18

    please apply the following three patches to -net. The first two are fixes
    for minor race conditions in the probe code, while the third one gets
    dropwatch working (again).
    ====================

    Signed-off-by: David S. Miller

    David S. Miller
     
  • As part of the TX completion path, qeth_release_skbs() frees the completed
    skbs with __skb_queue_purge(). This ends in kfree_skb(), reporting every
    completed skb as dropped.
    On the other hand when dropping an skb in .ndo_start_xmit, we end up
    calling consume_skb()... where we should be using kfree_skb() so that
    drop monitors get notified.

    Switch the drop/consume logic around, and also don't accumulate dropped
    packets in the tx_errors statistics.

    Fixes: dc149e3764d8 ("s390/qeth: replace open-coded skb_queue_walk()")
    Signed-off-by: Julian Wiedmann
    Signed-off-by: David S. Miller

    Julian Wiedmann
     
  • The ucast IP table is utilized by some of the L3-specific sysfs attributes
    that qeth_l3_create_device_attributes() provides. So initialize the table
    _before_ registering the attributes.

    Fixes: ebccc7397e4a ("s390/qeth: add missing hash table initializations")
    Signed-off-by: Julian Wiedmann
    Signed-off-by: David S. Miller

    Julian Wiedmann
     
  • The HW trap and VNICC configuration is exposed via sysfs, and may have
    already been modified when qeth_l?_probe_device() attempts to initialize
    them. So (1) initialize the VNICC values a little earlier, and (2) don't
    bother about the HW trap mode, it was already initialized before.

    Signed-off-by: Julian Wiedmann
    Signed-off-by: David S. Miller

    Julian Wiedmann
     
  • The device ID alone does not uniquely identify a device. Test both the
    vendor and device ID to make sure we don't mistakenly think some other
    vendor's 0xB410 device is a Digium HFC4S. Also, instead of the bare hex
    ID, use the same constant (PCI_DEVICE_ID_DIGIUM_HFC4S) used in the device
    ID table.

    No functional change intended.

    Signed-off-by: Bjorn Helgaas
    Signed-off-by: David S. Miller

    Bjorn Helgaas
     
  • Xin Long says:

    ====================
    sctp: fix ignoring asoc_id for tcp-style sockets on some setsockopts

    This is a patchset to fix ignoring asoc_id for tcp-style sockets on
    some setsockopts, introduced by SCTP_CURRENT_ASSOC of the patchset:

    [net-next,00/24] sctp: support SCTP_FUTURE/CURRENT/ALL_ASSOC
    (https://patchwork.ozlabs.org/cover/1031706/)

    As Marcelo suggested, we fix it on each setsockopt that is using
    SCTP_CURRENT_ASSOC one by one by adding the check:

    if (sctp_style(sk, TCP))
    xxx.xxx_assoc_id = SCTP_FUTURE_ASSOC;

    so that assoc_id will be completely ingored for tcp-style socket on
    setsockopts, and works as SCTP_FUTURE_ASSOC.
    ====================

    Signed-off-by: David S. Miller

    David S. Miller
     
  • A similar fix as Patch "sctp: fix ignoring asoc_id for tcp-style sockets on
    SCTP_DEFAULT_SEND_PARAM sockopt" on SCTP_STREAM_SCHEDULER sockopt.

    Fixes: 7efba10d6bd2 ("sctp: add SCTP_FUTURE_ASOC and SCTP_CURRENT_ASSOC for SCTP_STREAM_SCHEDULER sockopt")
    Signed-off-by: Xin Long
    Signed-off-by: David S. Miller

    Xin Long
     
  • A similar fix as Patch "sctp: fix ignoring asoc_id for tcp-style sockets on
    SCTP_DEFAULT_SEND_PARAM sockopt" on SCTP_EVENT sockopt.

    Fixes: d251f05e3ba2 ("sctp: use SCTP_FUTURE_ASSOC and add SCTP_CURRENT_ASSOC for SCTP_EVENT sockopt")
    Signed-off-by: Xin Long
    Signed-off-by: David S. Miller

    Xin Long
     
  • A similar fix as Patch "sctp: fix ignoring asoc_id for tcp-style sockets on
    SCTP_DEFAULT_SEND_PARAM sockopt" on SCTP_ENABLE_STREAM_RESET sockopt.

    Fixes: 99a62135e127 ("sctp: use SCTP_FUTURE_ASSOC and add SCTP_CURRENT_ASSOC for SCTP_ENABLE_STREAM_RESET sockopt")
    Signed-off-by: Xin Long
    Signed-off-by: David S. Miller

    Xin Long
     
  • A similar fix as Patch "sctp: fix ignoring asoc_id for tcp-style sockets on
    SCTP_DEFAULT_SEND_PARAM sockopt" on SCTP_DEFAULT_PRINFO sockopt.

    Fixes: 3a583059d187 ("sctp: use SCTP_FUTURE_ASSOC and add SCTP_CURRENT_ASSOC for SCTP_DEFAULT_PRINFO sockopt")
    Signed-off-by: Xin Long
    Signed-off-by: David S. Miller

    Xin Long
     
  • A similar fix as Patch "sctp: fix ignoring asoc_id for tcp-style sockets on
    SCTP_DEFAULT_SEND_PARAM sockopt" on SCTP_AUTH_DEACTIVATE_KEY sockopt.

    Fixes: 2af66ff3edc7 ("sctp: use SCTP_FUTURE_ASSOC and add SCTP_CURRENT_ASSOC for SCTP_AUTH_DEACTIVATE_KEY sockopt")
    Signed-off-by: Xin Long
    Signed-off-by: David S. Miller

    Xin Long
     
  • A similar fix as Patch "sctp: fix ignoring asoc_id for tcp-style sockets on
    SCTP_DEFAULT_SEND_PARAM sockopt" on SCTP_AUTH_DELETE_KEY sockopt.

    Fixes: 3adcc300603e ("sctp: use SCTP_FUTURE_ASSOC and add SCTP_CURRENT_ASSOC for SCTP_AUTH_DELETE_KEY sockopt")
    Signed-off-by: Xin Long
    Signed-off-by: David S. Miller

    Xin Long
     
  • A similar fix as Patch "sctp: fix ignoring asoc_id for tcp-style sockets on
    SCTP_DEFAULT_SEND_PARAM sockopt" on SCTP_AUTH_ACTIVE_KEY sockopt.

    Fixes: bf9fb6ad4f29 ("sctp: use SCTP_FUTURE_ASSOC and add SCTP_CURRENT_ASSOC for SCTP_AUTH_ACTIVE_KEY sockopt")
    Signed-off-by: Xin Long
    Signed-off-by: David S. Miller

    Xin Long
     
  • A similar fix as Patch "sctp: fix ignoring asoc_id for tcp-style sockets on
    SCTP_DEFAULT_SEND_PARAM sockopt" on SCTP_AUTH_KEY sockopt.

    Fixes: 7fb3be13a236 ("sctp: use SCTP_FUTURE_ASSOC and add SCTP_CURRENT_ASSOC for SCTP_AUTH_KEY sockopt")
    Signed-off-by: Xin Long
    Signed-off-by: David S. Miller

    Xin Long
     
  • A similar fix as Patch "sctp: fix ignoring asoc_id for tcp-style sockets on
    SCTP_DEFAULT_SEND_PARAM sockopt" on SCTP_MAX_BURST sockopt.

    Fixes: e0651a0dc877 ("sctp: use SCTP_FUTURE_ASSOC and add SCTP_CURRENT_ASSOC for SCTP_MAX_BURST sockopt")
    Signed-off-by: Xin Long
    Signed-off-by: David S. Miller

    Xin Long
     
  • A similar fix as Patch "sctp: fix ignoring asoc_id for tcp-style sockets on
    SCTP_DEFAULT_SEND_PARAM sockopt" on SCTP_CONTEXT sockopt.

    Fixes: 49b037acca8c ("sctp: use SCTP_FUTURE_ASSOC and add SCTP_CURRENT_ASSOC for SCTP_CONTEXT sockopt")
    Signed-off-by: Xin Long
    Signed-off-by: David S. Miller

    Xin Long
     
  • A similar fix as Patch "sctp: fix ignoring asoc_id for tcp-style sockets on
    SCTP_DEFAULT_SEND_PARAM sockopt" on SCTP_DEFAULT_SNDINFO sockopt.

    Fixes: 92fc3bd928c9 ("sctp: use SCTP_FUTURE_ASSOC and add SCTP_CURRENT_ASSOC for SCTP_DEFAULT_SNDINFO sockopt")
    Signed-off-by: Xin Long
    Signed-off-by: David S. Miller

    Xin Long
     
  • A similar fix as Patch "sctp: fix ignoring asoc_id for tcp-style sockets on
    SCTP_DEFAULT_SEND_PARAM sockopt" on SCTP_DELAYED_SACK sockopt.

    Fixes: 9c5829e1c49e ("sctp: use SCTP_FUTURE_ASSOC and add SCTP_CURRENT_ASSOC for SCTP_DELAYED_SACK sockopt")
    Signed-off-by: Xin Long
    Signed-off-by: David S. Miller

    Xin Long
     
  • Currently if the user pass an invalid asoc_id to SCTP_DEFAULT_SEND_PARAM
    on a TCP-style socket, it will silently ignore the new parameters.
    That's because after not finding an asoc, it is checking asoc_id against
    the known values of CURRENT/FUTURE/ALL values and that fails to match.

    IOW, if the user supplies an invalid asoc id or not, it should either
    match the current asoc or the socket itself so that it will inherit
    these later. Fixes it by forcing asoc_id to SCTP_FUTURE_ASSOC in case it
    is a TCP-style socket without an asoc, so that the values get set on the
    socket.

    Fixes: 707e45b3dc5a ("sctp: use SCTP_FUTURE_ASSOC and add SCTP_CURRENT_ASSOC for SCTP_DEFAULT_SEND_PARAM sockopt")
    Signed-off-by: Marcelo Ricardo Leitner
    Signed-off-by: David S. Miller

    Marcelo Ricardo Leitner
     
  • Now sctp_copy_descendant() copies pd_lobby from old sctp scok to new
    sctp sock. If sctp_sock_migrate() returns error, it will panic when
    releasing new sock and trying to purge pd_lobby due to the incorrect
    pointers in pd_lobby.

    [ 120.485116] kasan: CONFIG_KASAN_INLINE enabled
    [ 120.486270] kasan: GPF could be caused by NULL-ptr deref or user
    [ 120.509901] Call Trace:
    [ 120.510443] sctp_ulpevent_free+0x1e8/0x490 [sctp]
    [ 120.511438] sctp_queue_purge_ulpevents+0x97/0xe0 [sctp]
    [ 120.512535] sctp_close+0x13a/0x700 [sctp]
    [ 120.517483] inet_release+0xdc/0x1c0
    [ 120.518215] __sock_release+0x1d2/0x2a0
    [ 120.519025] sctp_do_peeloff+0x30f/0x3c0 [sctp]

    We fix it by not copying sctp_sock pd_lobby in sctp_copy_descendan(),
    and skb_queue_head_init() can also be removed in sctp_sock_migrate().

    Reported-by: syzbot+85e0b422ff140b03672a@syzkaller.appspotmail.com
    Fixes: 89664c623617 ("sctp: sctp_sock_migrate() returns error if sctp_bind_addr_dup() fails")
    Signed-off-by: Xin Long
    Signed-off-by: David S. Miller

    Xin Long
     
  • sctp_hdr(skb) only works when skb->transport_header is set properly.

    But in Netfilter, skb->transport_header for ipv6 is not guaranteed
    to be right value for sctphdr. It would cause to fail to check the
    checksum for sctp packets.

    So fix it by using offset, which is always right in all places.

    v1->v2:
    - Fix the changelog.

    Fixes: e6d8b64b34aa ("net: sctp: fix and consolidate SCTP checksumming code")
    Reported-by: Li Shuang
    Signed-off-by: Xin Long
    Signed-off-by: David S. Miller

    Xin Long
     
  • I am using "protocol ip" filters in TC to manipulate TC flower
    classifiers, which are only available with "protocol ip". However,
    I faced an issue that packets sent via raw sockets with ETH_P_ALL
    did not match the ip filters even if they did satisfy the condition
    (e.g., DHCP offer from dhcpd).

    I have determined that the behavior was caused by an unexpected
    value stored in skb->protocol, namely, ETH_P_ALL instead of ETH_P_IP,
    when packets were sent via raw sockets with ETH_P_ALL set.

    IMHO, storing ETH_P_ALL in skb->protocol is not appropriate for
    packets sent via raw sockets because ETH_P_ALL is not a real ether
    type used on wire, but a virtual one.

    This patch fixes the tx protocol selection in cases of transmission
    via raw sockets created with ETH_P_ALL so that it asks the driver to
    extract protocol from the Ethernet header.

    Fixes: 75c65772c3 ("net/packet: Ask driver for protocol if not provided by user")
    Signed-off-by: Yoshiki Komachi
    Acked-by: Willem de Bruijn
    Signed-off-by: David S. Miller

    Yoshiki Komachi
     
  • When using fanouts with AF_PACKET, the demux functions such as
    fanout_demux_cpu will return an index in the fanout socket array, which
    corresponds to the selected socket.

    The ordering of this array depends on the order the sockets were added
    to a given fanout group, so for FANOUT_CPU this means sockets are bound
    to cpus in the order they are configured, which is OK.

    However, when stopping then restarting the interface these sockets are
    bound to, the sockets are reassigned to the fanout group in the reverse
    order, due to the fact that they were inserted at the head of the
    interface's AF_PACKET socket list.

    This means that traffic that was directed to the first socket in the
    fanout group is now directed to the last one after an interface restart.

    In the case of FANOUT_CPU, traffic from CPU0 will be directed to the
    socket that used to receive traffic from the last CPU after an interface
    restart.

    This commit introduces a helper to add a socket at the tail of a list,
    then uses it to register AF_PACKET sockets.

    Note that this changes the order in which sockets are listed in /proc and
    with sock_diag.

    Fixes: dc99f600698d ("packet: Add fanout support")
    Signed-off-by: Maxime Chevallier
    Acked-by: Willem de Bruijn
    Signed-off-by: David S. Miller

    Maxime Chevallier
     
  • Commit ad6c9986bcb62 ("vxlan: Fix GRO cells race condition between
    receive and link delete") fixed a race condition for the typical case a vxlan
    device is dismantled from the current netns. But if a netns is dismantled,
    vxlan_destroy_tunnels() is called to schedule a unregister_netdevice_queue()
    of all the vxlan tunnels that are related to this netns.

    In vxlan_destroy_tunnels(), gro_cells_destroy() is called and finished before
    unregister_netdevice_queue(). This means that the gro_cells_destroy() call is
    done too soon, for the same reasons explained in above commit.

    So we need to fully respect the RCU rules, and thus must remove the
    gro_cells_destroy() call or risk use after-free.

    Fixes: 58ce31cca1ff ("vxlan: GRO support at tunnel layer")
    Signed-off-by: Suanming.Mou
    Suggested-by: Eric Dumazet
    Reviewed-by: Stefano Brivio
    Reviewed-by: Zhiqiang Liu
    Signed-off-by: David S. Miller

    Zhiqiang Liu
     
  • TCP/UDP checksum validity was propagated to skb
    only if IP checksum is valid.
    But for IPv6 there is no validity as there is no checksum in IPv6.
    This patch propagates TCP/UDP checksum validity regardless of IP checksum.

    Fixes: 018423e90bee ("net: ethernet: aquantia: Add ring support code")
    Signed-off-by: Igor Russkikh
    Signed-off-by: Nikita Danilov
    Signed-off-by: Dmitry Bogdanov
    Signed-off-by: David S. Miller

    Dmitry Bogdanov
     
  • The bug that Stan reported is as follows. After a restart, a 16-bit NIC
    may be incorrectly identified as a 32-bit NIC and stop working.

    mac8390 slot.E: Memory length resource not found, probing
    mac8390 slot.E: Farallon EtherMac II-C (type farallon)
    mac8390 slot.E: MAC 00:00:c5:30:c2:99, IRQ 61, 32 KB shared memory at 0xfeed0000, 32-bit access.

    The bug never arises after a cold start and only intermittently after a
    warm start. (I didn't investigate why the bug is intermittent.)

    It turns out that memcpy_toio() is deprecated and memcmp_withio() also
    has issues. Replacing these calls with mmio accessors fixes the problem.

    Reported-and-tested-by: Stan Johnson
    Fixes: 2964db0f5904 ("m68k: Mac DP8390 update")
    Signed-off-by: Finn Thain
    Signed-off-by: David S. Miller

    Finn Thain
     
  • Similarly to commit a7603ac1fc8c ("geneve: change NET_UDP_TUNNEL
    dependency to select"), GTP has a dependency on NET_UDP_TUNNEL which
    makes impossible to compile it if no other protocol depending on
    NET_UDP_TUNNEL is selected.

    Fix this by changing the depends to a select, and drop NET_IP_TUNNEL from
    the select list, as it already depends on NET_UDP_TUNNEL.

    Signed-off-by: Matteo Croce
    Signed-off-by: David S. Miller

    Matteo Croce
     
  • rose_write_internal() uses a temp buffer of 100 bytes, but a manual
    inspection showed that given arbitrary input, rose_create_facilities()
    can fill up to 110 bytes.

    Lets use a tailroom of 256 bytes for peace of mind, and remove
    the bounce buffer : we can simply allocate a big enough skb
    and adjust its length as needed.

    syzbot report :

    BUG: KASAN: stack-out-of-bounds in memcpy include/linux/string.h:352 [inline]
    BUG: KASAN: stack-out-of-bounds in rose_create_facilities net/rose/rose_subr.c:521 [inline]
    BUG: KASAN: stack-out-of-bounds in rose_write_internal+0x597/0x15d0 net/rose/rose_subr.c:116
    Write of size 7 at addr ffff88808b1ffbef by task syz-executor.0/24854

    CPU: 0 PID: 24854 Comm: syz-executor.0 Not tainted 5.0.0+ #97
    Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
    Call Trace:
    __dump_stack lib/dump_stack.c:77 [inline]
    dump_stack+0x172/0x1f0 lib/dump_stack.c:113
    print_address_description.cold+0x7c/0x20d mm/kasan/report.c:187
    kasan_report.cold+0x1b/0x40 mm/kasan/report.c:317
    check_memory_region_inline mm/kasan/generic.c:185 [inline]
    check_memory_region+0x123/0x190 mm/kasan/generic.c:191
    memcpy+0x38/0x50 mm/kasan/common.c:131
    memcpy include/linux/string.h:352 [inline]
    rose_create_facilities net/rose/rose_subr.c:521 [inline]
    rose_write_internal+0x597/0x15d0 net/rose/rose_subr.c:116
    rose_connect+0x7cb/0x1510 net/rose/af_rose.c:826
    __sys_connect+0x266/0x330 net/socket.c:1685
    __do_sys_connect net/socket.c:1696 [inline]
    __se_sys_connect net/socket.c:1693 [inline]
    __x64_sys_connect+0x73/0xb0 net/socket.c:1693
    do_syscall_64+0x103/0x610 arch/x86/entry/common.c:290
    entry_SYSCALL_64_after_hwframe+0x49/0xbe
    RIP: 0033:0x458079
    Code: ad b8 fb ff c3 66 2e 0f 1f 84 00 00 00 00 00 66 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 3d 01 f0 ff ff 0f 83 7b b8 fb ff c3 66 2e 0f 1f 84 00 00 00 00
    RSP: 002b:00007f47b8d9dc78 EFLAGS: 00000246 ORIG_RAX: 000000000000002a
    RAX: ffffffffffffffda RBX: 0000000000000003 RCX: 0000000000458079
    RDX: 000000000000001c RSI: 0000000020000040 RDI: 0000000000000004
    RBP: 000000000073bf00 R08: 0000000000000000 R09: 0000000000000000
    R10: 0000000000000000 R11: 0000000000000246 R12: 00007f47b8d9e6d4
    R13: 00000000004be4a4 R14: 00000000004ceca8 R15: 00000000ffffffff

    The buggy address belongs to the page:
    page:ffffea00022c7fc0 count:0 mapcount:0 mapping:0000000000000000 index:0x0
    flags: 0x1fffc0000000000()
    raw: 01fffc0000000000 0000000000000000 ffffffff022c0101 0000000000000000
    raw: 0000000000000000 0000000000000000 00000000ffffffff 0000000000000000
    page dumped because: kasan: bad access detected

    Memory state around the buggy address:
    ffff88808b1ffa80: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
    ffff88808b1ffb00: 00 00 00 00 00 00 00 00 f1 f1 f1 f1 00 00 00 03
    >ffff88808b1ffb80: f2 f2 00 00 00 00 00 00 00 00 00 00 00 00 04 f3
    ^
    ffff88808b1ffc00: f3 f3 f3 f3 00 00 00 00 00 00 00 00 00 00 00 00
    ffff88808b1ffc80: 00 00 00 00 00 00 00 f1 f1 f1 f1 f1 f1 01 f2 01

    Signed-off-by: Eric Dumazet
    Reported-by: syzbot
    Signed-off-by: David S. Miller

    Eric Dumazet
     
  • Use https and link to the patch directly.

    Signed-off-by: Tobias Klauser
    Acked-by: Willem de Bruijn
    Signed-off-by: David S. Miller

    Tobias Klauser
     

18 Mar, 2019

2 commits

  • We move the check that prevents connecting service ranges to after
    the RDM/DGRAM check, and move address sanity control to a separate
    function that also validates the service range.

    Fixes: 23998835be98 ("tipc: improve address sanity check in tipc_connect()")
    Signed-off-by: Erik Hugne
    Signed-off-by: Jon Maloy
    Signed-off-by: David S. Miller

    Erik Hugne
     
  • Fix documentation markup warnings in snmp_counter.rst:

    Documentation/networking/snmp_counter.rst:416: WARNING: Title underline too short.
    Documentation/networking/snmp_counter.rst:684: WARNING: Bullet list ends without a blank line; unexpected unindent.
    Documentation/networking/snmp_counter.rst:693: WARNING: Title underline too short.
    Documentation/networking/snmp_counter.rst:707: WARNING: Bullet list ends without a blank line; unexpected unindent.
    Documentation/networking/snmp_counter.rst:712: WARNING: Bullet list ends without a blank line; unexpected unindent.
    Documentation/networking/snmp_counter.rst:722: WARNING: Title underline too short.
    Documentation/networking/snmp_counter.rst:733: WARNING: Bullet list ends without a blank line; unexpected unindent.
    Documentation/networking/snmp_counter.rst:736: WARNING: Bullet list ends without a blank line; unexpected unindent.
    Documentation/networking/snmp_counter.rst:739: WARNING: Bullet list ends without a blank line; unexpected unindent.

    Fixes: 80cc49507ba48 ("net: Add part of TCP counts explanations in snmp_counters.rst")
    Fixes: 8e2ea53a83dfb ("add snmp counters document")
    Fixes: a6c7c7aac2de6 ("net: add document for several snmp counters")

    Signed-off-by: Randy Dunlap
    Cc: yupeng

    Randy Dunlap
     

17 Mar, 2019

5 commits

  • nla_nest_start may fail. The fix check its status and returns
    -EMSGSIZE in case it fails.

    Signed-off-by: Kangjie Lu
    Signed-off-by: David S. Miller

    Kangjie Lu
     
  • In my latest patch I missed one rcu_read_unlock(), in case
    device is down.

    Fixes: 4477138fa0ae ("tun: properly test for IFF_UP")
    Signed-off-by: Eric Dumazet
    Reported-by: syzbot
    Signed-off-by: David S. Miller

    Eric Dumazet
     
  • Daniel Borkmann says:

    ====================
    pull-request: bpf 2019-03-16

    The following pull-request contains BPF updates for your *net* tree.

    The main changes are:

    1) Fix a umem memory leak on cleanup in AF_XDP, from Björn.

    2) Fix BTF to properly resolve forward-declared enums into their corresponding
    full enum definition types during deduplication, from Andrii.

    3) Fix libbpf to reject invalid flags in xsk_socket__create(), from Magnus.

    4) Fix accessing invalid pointer returned from bpf_tcp_sock() and
    bpf_sk_fullsock() after bpf_sk_release() was called, from Martin.

    5) Fix generation of load/store DW instructions in PPC JIT, from Naveen.

    6) Various fixes in BPF helper function documentation in bpf.h UAPI header
    used to bpf-helpers(7) man page, from Quentin.

    7) Fix segfault in BPF test_progs when prog loading failed, from Yonghong.
    ====================

    Signed-off-by: David S. Miller

    David S. Miller
     
  • nla_nest_start could fail and requires a check. The fix returns
    -EMSGSIZE if it fails.

    Signed-off-by: Kangjie Lu
    Signed-off-by: David S. Miller

    Kangjie Lu
     
  • nla_nest_start may fail and thus deserves a check.

    The fix returns -EMSGSIZE in case it fails.

    Signed-off-by: Kangjie Lu
    Signed-off-by: David S. Miller

    Kangjie Lu