Eric Lee / smarc-fsl-linux-kernel

27 Dec, 2013

1 commit

  • 4c55a4623   atm: slight optimization of addr compare ... Browse Code »

    Use possibly more efficient ether_addr_equal
    instead of memcmp.

    Cc: Chas Williams
    Cc: linux-atm-general@lists.sourceforge.net
    Cc: netdev@vger.kernel.org
    Cc: linux-kernel@vger.kernel.org
    Signed-off-by: Yang Yingliang
    Signed-off-by: Ding Tianhong
    Signed-off-by: David S. Miller

    dingtianhong
     

11 Dec, 2013

2 commits

20 Nov, 2013

1 commit

22 Oct, 2013

1 commit

16 Sep, 2013

1 commit

14 Sep, 2013

1 commit

05 Sep, 2013

2 commits

18 Jun, 2013

1 commit

  • b32369f11   net, atm/ambassader: convert skb->tail into skb_tail_pointer(skb) ... Browse Code »

    The change set of 27a884dc, "[SK_BUFF]: Convert skb->tail to sk_buff_data_t"
    converted skb->tail from pointer into sk_buff_data_t. It missed skb->tail
    in drivers/atm/ambassador.c.
    This patch converts skb->tail into skb_tail_pointer(skb).

    Found by inspection. Compile tested only.

    Cc: Simon Horman
    Cc: Chas Williams
    Signed-off-by: Isaku Yamahata
    Reviewed-by: Simon Horman
    Signed-off-by: David S. Miller

    Isaku Yamahata
     

30 Apr, 2013

1 commit

28 Feb, 2013

3 commits

  • b67bfe0d4   hlist: drop the node parameter from iterators ... Browse Code »

    I'm not sure why, but the hlist for each entry iterators were conceived

    list_for_each_entry(pos, head, member)

    The hlist ones were greedy and wanted an extra parameter:

    hlist_for_each_entry(tpos, pos, head, member)

    Why did they need an extra pos parameter? I'm not quite sure. Not only
    they don't really need it, it also prevents the iterator from looking
    exactly like the list iterator, which is unfortunate.

    Besides the semantic patch, there was some manual work required:

    - Fix up the actual hlist iterators in linux/list.h
    - Fix up the declaration of other iterators based on the hlist ones.
    - A very small amount of places were using the 'node' parameter, this
    was modified to use 'obj->member' instead.
    - Coccinelle didn't handle the hlist_for_each_entry_safe iterator
    properly, so those had to be fixed up manually.

    The semantic patch which is mostly the work of Peter Senna Tschudin is here:

    @@
    iterator name hlist_for_each_entry, hlist_for_each_entry_continue, hlist_for_each_entry_from, hlist_for_each_entry_rcu, hlist_for_each_entry_rcu_bh, hlist_for_each_entry_continue_rcu_bh, for_each_busy_worker, ax25_uid_for_each, ax25_for_each, inet_bind_bucket_for_each, sctp_for_each_hentry, sk_for_each, sk_for_each_rcu, sk_for_each_from, sk_for_each_safe, sk_for_each_bound, hlist_for_each_entry_safe, hlist_for_each_entry_continue_rcu, nr_neigh_for_each, nr_neigh_for_each_safe, nr_node_for_each, nr_node_for_each_safe, for_each_gfn_indirect_valid_sp, for_each_gfn_sp, for_each_host;

    type T;
    expression a,c,d,e;
    identifier b;
    statement S;
    @@

    -T b;

    [akpm@linux-foundation.org: drop bogus change from net/ipv4/raw.c]
    [akpm@linux-foundation.org: drop bogus hunk from net/ipv6/raw.c]
    [akpm@linux-foundation.org: checkpatch fixes]
    [akpm@linux-foundation.org: fix warnings]
    [akpm@linux-foudnation.org: redo intrusive kvm changes]
    Tested-by: Peter Senna Tschudin
    Acked-by: Paul E. McKenney
    Signed-off-by: Sasha Levin
    Cc: Wu Fengguang
    Cc: Marcelo Tosatti
    Cc: Gleb Natapov
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Sasha Levin
     
  • b051f6edc   atm/nicstar: convert to idr_alloc() ... Browse Code »

    Convert to the much saner new idr interface. The existing code looks
    buggy to me - ID 0 is treated as no-ID but allocation specifies 0 as
    lower limit and there's no error handling after partial success. This
    conversion keeps the bugs unchanged.

    Signed-off-by: Tejun Heo
    Acked-by: Chas Williams
    Reported-by: kbuild test robot
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Tejun Heo
     
  • c767bf2ed   atm/nicstar: don't use idr_remove_all() ... Browse Code »

    idr_destroy() can destroy idr by itself and idr_remove_all() is being
    deprecated. Drop its usage.

    Signed-off-by: Tejun Heo
    Cc: Chas Williams
    Cc: David Miller
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Tejun Heo
     

09 Feb, 2013

1 commit

  • ab54ee80a   atm/iphase: rename fregt_t -> ffreg_t ... Browse Code »

    We have conflicting type qualifiers for "freg_t" in s390's ptrace.h and the
    iphase atm device driver, which causes the compile error below.
    Unfortunately the s390 typedef can't be renamed, since it's a user visible api,
    nor can I change the include order in s390 code to avoid the conflict.

    So simply rename the iphase typedef to a new name. Fixes this compile error:

    In file included from drivers/atm/iphase.c:66:0:
    drivers/atm/iphase.h:639:25: error: conflicting type qualifiers for 'freg_t'
    In file included from next/arch/s390/include/asm/ptrace.h:9:0,
    from next/arch/s390/include/asm/lowcore.h:12,
    from next/arch/s390/include/asm/thread_info.h:30,
    from include/linux/thread_info.h:54,
    from include/linux/preempt.h:9,
    from include/linux/spinlock.h:50,
    from include/linux/seqlock.h:29,
    from include/linux/time.h:5,
    from include/linux/stat.h:18,
    from include/linux/module.h:10,
    from drivers/atm/iphase.c:43:
    next/arch/s390/include/uapi/asm/ptrace.h:197:3: note: previous declaration of 'freg_t' was here

    Signed-off-by: Heiko Carstens
    Acked-by: chas williams - CONTRACTOR
    Signed-off-by: David S. Miller

    Heiko Carstens
     

04 Jan, 2013

1 commit

  • 6c44512d0   Drivers: atm: remove __dev* attributes. ... Browse Code »

    CONFIG_HOTPLUG is going away as an option. As a result, the __dev*
    markings need to be removed.

    This change removes the use of __devinit, __devexit_p, __devinitdata,
    __devinitconst, and __devexit from these drivers.

    Based on patches originally written by Bill Pemberton, but redone by me
    in order to handle some of the coding style issues better, by hand.

    Cc: Bill Pemberton
    Cc: Chas Williams
    Signed-off-by: Greg Kroah-Hartman

    Greg Kroah-Hartman
     

22 Dec, 2012

1 commit

20 Dec, 2012

4 commits

12 Dec, 2012

1 commit

  • cae49ede0   solos-pci: fix double-free of TX skb in DMA mode ... Browse Code »

    We weren't clearing card->tx_skb[port] when processing the TX done interrupt.
    If there wasn't another skb ready to transmit immediately, this led to a
    double-free because we'd free it *again* next time we did have a packet to
    send.

    Signed-off-by: David Woodhouse
    Cc: stable@kernel.org
    Signed-off-by: David S. Miller

    David Woodhouse
     

02 Dec, 2012

6 commits

29 Nov, 2012

1 commit

06 Oct, 2012

1 commit

07 Aug, 2012

1 commit

  • f716168b8   drivers/atm/iphase.c: fix error return code ... Browse Code »

    Convert a 0 error return code to a negative one, as returned elsewhere in the
    function.

    A simplified version of the semantic match that finds this problem is as
    follows: (http://coccinelle.lip6.fr/)

    //
    @@
    identifier ret;
    expression e,e1,e2,e3,e4,x;
    @@

    (
    if (\(ret != 0\|ret < 0\) || ...) { ... return ...; }
    |
    ret = 0
    )
    ... when != ret = e1
    *x = \(kmalloc\|kzalloc\|kcalloc\|devm_kzalloc\|ioremap\|ioremap_nocache\|devm_ioremap\|devm_ioremap_nocache\)(...);
    ... when != x = e2
    when != ret = e3
    *if (x == NULL || ...)
    {
    ... when != ret = e4
    * return ret;
    }
    //

    Signed-off-by: Julia Lawall
    Signed-off-by: David S. Miller

    Julia Lawall
     

25 May, 2012

1 commit

  • b4bd8ad9b   solos-pci: Fix DMA support ... Browse Code »
    1

    DMA support has finally made its way to the top of the TODO list, having
    realised that a Geode using MMIO can't keep up with two ADSL2+ lines
    each running at 21Mb/s.

    This patch fixes a couple of bugs in the DMA support in the driver, so
    once the corresponding FPGA update is complete and tested everything
    should work properly.

    We weren't storing the currently-transmitting skb, so we were never
    unmapping it and never freeing/popping it when the TX was done.
    And the addition of pci_set_master() is fairly self-explanatory.

    Signed-off-by: David Woodhouse
    Cc: stable@kernel.org
    Signed-off-by: David S. Miller

    David Woodhouse
     

07 May, 2012

1 commit

  • ec47ea824   skb: Add inline helper for getting the skb end offset from head ... Browse Code »

    With the recent changes for how we compute the skb truesize it occurs to me
    we are probably going to have a lot of calls to skb_end_pointer -
    skb->head. Instead of running all over the place doing that it would make
    more sense to just make it a separate inline skb_end_offset(skb) that way
    we can return the correct value without having gcc having to do all the
    optimization to cancel out skb->head - skb->head.

    Signed-off-by: Alexander Duyck
    Acked-by: Eric Dumazet
    Signed-off-by: David S. Miller

    Alexander Duyck
     

11 Apr, 2012

1 commit

05 Apr, 2012

1 commit

29 Mar, 2012

1 commit

17 Mar, 2012

1 commit

12 Mar, 2012

1 commit

27 Feb, 2012

1 commit

20 Feb, 2012

1 commit

  • 8ae0cfee2   drivers/atm/solos-pci.c: exchange pci_iounmaps ... Browse Code »

    The calls to pci_iounmap are in the wrong order, as compared to the
    associated calls to pci_iomap.

    A simplified version of the semantic match that finds this problem is as
    follows: (http://coccinelle.lip6.fr/)

    //
    @@
    expression e,x;
    statement S,S1;
    int ret;
    @@
    e = pci_iomap(x,...)
    ... when != pci_iounmap(x,e)
    if () S
    ... when any
    when != pci_iounmap(x,e)
    *if (...)
    { ... when != pci_iounmap(x,e)
    return ...; }
    ... when any
    pci_iounmap(x,e);
    //

    Signed-off-by: Julia Lawall
    Signed-off-by: David S. Miller

    Julia Lawall